-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Ensure that the event subscription success is dispatched … #17842
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_EventSubscriptionDispatch
Apr 29, 2022
Merged
[chip-tool] Ensure that the event subscription success is dispatched … #17842
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:ChipTool_EventSubscriptionDispatch
Apr 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to SubscribeEvent
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple and
gjc13
April 28, 2022 11:25
pullapprove
bot
requested review from
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
April 28, 2022 11:25
PR #17842: Size comparison from 8c836f1 to 5cdf53d Decreases (1 build for linux)
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
yunhanw-google
approved these changes
Apr 28, 2022
bzbarsky-apple
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to SubscribeEvent
Problem
Looking at #17764 I realised that in
chip-tool
when subscribing to an event the event subscription is not dispatched properly.Change overview
Testing
Running the command
./out/debug/standalone/chip-tool basic subscribe-event start-up 4 5 0x12344321 0
waits until the timeout without this patch and does not with it.