Add cluster commands to tv-casting-app #17830

chrisdecenzo · 2022-04-27T23:30:01Z

Problem

Linux tv-casting-app does not support all cluster commands

Change overview

Support casting commands from shell using "cast cluster [command]", for example:
"cast cluster keypadinput send-key 1 18446744004990074879 1"
Support casting commands from command line (using first fabric in saved list), for example:
"chip-tv-casting-app onoff read on-off 18446744004990074879 2"

Testing

Tested running tv-casting-app against tv-app on macOS

github-actions · 2022-04-27T23:55:44Z

PR #17830: Size comparison from 11c49af to db4bd45

Full report (2 builds for mbed, nrfconnect)

platform	target	config	section	`11c49af`	`db4bd45`
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	`2411100`	`2411100`
			.bss	205708	205708
			.data	5848	5848
			.text	1373700	1373700
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	`1179039`	`1179039`
			bss	141840	141840
			rodata	150064	150064
			text	808428	808428

…n command

github-actions · 2022-05-01T14:54:51Z

PR #17830: Size comparison from 5488e57 to a677ee0

Full report (10 builds for cyw30739, k32w, mbed, nrfconnect, p6)

platform	target	config	section	`5488e57`	`a677ee0`
cyw30739	light	cyw930739m2evb_01	(read/write)	626354	626354
			.app_xip_area	528888	528888
			.bss	80116	80116
			.data	696	696
			.rodata	0	0
			.text	0	0
	lock	cyw930739m2evb_01	(read/write)	625066	625066
			.app_xip_area	529064	529064
			.bss	78692	78692
			.data	660	660
			.rodata	0	0
			.text	0	0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	574194	574194
			.app_xip_area	468572	468572
			.bss	88016	88016
			.data	572	572
			.rodata	0	0
			.text	112	112
k32w	light	k32w061+release	(read/write)	684236	684236
			.bss	81320	81320
			.data	2008	2008
			.text	599204	599204
	lock	k32w061+release	(read/write)	729132	729132
			.bss	81744	81744
			.data	1968	1968
			.text	643716	643716
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2418060	2418060
			.bss	205884	205884
			.data	5856	5856
			.text	`1380660`	`1380660`
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1180107	1180107
			bss	142000	142000
			rodata	150804	150804
			text	808620	808620
p6	all-clusters-app	default	(read/write)	2528576	2528576
			.bss	139256	139256
			.data	2792	2792
			.text	1486840	1486840
	light-app	default	(read/write)	`2419176`	`2419176`
			.bss	132720	132720
			.data	2592	2592
			.text	1377440	1377440
	lock-app	default	(read/write)	`2428448`	`2428448`
			.bss	132544	132544
			.data	2552	2552
			.text	1386712	1386712

github-actions · 2022-05-01T15:28:43Z

PR #17830: Size comparison from 5488e57 to f024aa0

Full report (6 builds for cyw30739, mbed, nrfconnect, telink)

platform	target	config	section	`5488e57`	`f024aa0`
cyw30739	light	cyw930739m2evb_01	(read/write)	626354	626354
			.app_xip_area	528888	528888
			.bss	80116	80116
			.data	696	696
			.rodata	0	0
			.text	0	0
	lock	cyw930739m2evb_01	(read/write)	625066	625066
			.app_xip_area	529064	529064
			.bss	78692	78692
			.data	660	660
			.rodata	0	0
			.text	0	0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	574194	574194
			.app_xip_area	468572	468572
			.bss	88016	88016
			.data	572	572
			.rodata	0	0
			.text	112	112
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2418060	2418060
			.bss	205884	205884
			.data	5856	5856
			.text	`1380660`	`1380660`
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1180107	1180107
			bss	142000	142000
			rodata	150804	150804
			text	808620	808620
telink	lighting-app	tlsr9518adk80d	(read/write)	807348	807348
			bss	75432	75432
			noinit	40416	40416
			text	571142	571142

github-actions · 2022-05-01T15:51:31Z

PR #17830: Size comparison from 5488e57 to fa3ed6b

Full report (16 builds for cc13x2_26x2, cyw30739, efr32, mbed, nrfconnect, telink)

platform	target	config	section	`5488e57`	`fa3ed6b`
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read only)	688903	688903
			(read/write)	163352	163352
			.bss	75236	75236
			.data	3400	3400
			.rodata	102303	102303
			.text	586116	586116
	lock-ftd	LP_CC2652R7	(read only)	676767	676767
			(read/write)	166744	166744
			.bss	73548	73548
			.data	3224	3224
			.rodata	94359	94359
			.text	581928	581928
	lock-mtd	LP_CC2652R7	(read only)	625527	625527
			(read/write)	146352	146352
			.bss	69268	69268
			.data	3224	3224
			.rodata	94247	94247
			.text	530792	530792
	pump-app	LP_CC2652R7	(read only)	661267	661267
			(read/write)	183484	183484
			.bss	73764	73764
			.data	3256	3256
			.rodata	80387	80387
			.text	580396	580396
	pump-controller-app	LP_CC2652R7	(read only)	654155	654155
			(read/write)	190396	190396
			.bss	73820	73820
			.data	3220	3220
			.rodata	83323	83323
			.text	570348	570348
cyw30739	light	cyw930739m2evb_01	(read/write)	626354	626354
			.app_xip_area	528888	528888
			.bss	80116	80116
			.data	696	696
			.rodata	0	0
			.text	0	0
	lock	cyw930739m2evb_01	(read/write)	625066	625066
			.app_xip_area	529064	529064
			.bss	78692	78692
			.data	660	660
			.rodata	0	0
			.text	0	0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	574194	574194
			.app_xip_area	468572	468572
			.bss	88016	88016
			.data	572	572
			.rodata	0	0
			.text	112	112
efr32	lighting-app	BRD4161A	(read only)	908216	908216
			(read/write)	135128	135128
			.bss	133072	133072
			.data	2052	2052
			.text	908208	908208
		BRD4161A+rpc	(read only)	942560	942560
			(read/write)	151808	151808
			.bss	149552	149552
			.data	2256	2256
			.text	942552	942552
		BRD4161A+rs911x	(read only)	746516	746516
			(read/write)	129352	129352
			.bss	127372	127372
			.data	1980	1980
			.text	746508	746508
	lock-app	BRD4161A+wf200	(read only)	916512	916512
			(read/write)	127540	127540
			.bss	125604	125604
			.data	1936	1936
			.text	916504	916504
	window-app	BRD4161A	(read only)	845464	845464
			(read/write)	133216	133216
			.bss	131248	131248
			.data	1964	1964
			.text	845456	845456
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2418060	2418060
			.bss	205884	205884
			.data	5856	5856
			.text	`1380660`	`1380660`
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1180107	1180107
			bss	142000	142000
			rodata	150804	150804
			text	808620	808620
telink	lighting-app	tlsr9518adk80d	(read/write)	807348	807348
			bss	75432	75432
			noinit	40416	40416
			text	571142	571142

github-actions · 2022-05-02T14:12:29Z

PR #17830: Size comparison from 5488e57 to 13b4a70

Decreases (1 build for telink)

platform	target	config	section	`5488e57`	`13b4a70`	change	% change
telink	lighting-app	tlsr9518adk80d	text	571142	571140	-2	-0.0

Full report (16 builds for cc13x2_26x2, efr32, mbed, nrfconnect, p6, telink)

platform	target	config	section	`5488e57`	`13b4a70`	change	% change
cc13x2_26x2	all-clusters-app	LP_CC2652R7	(read only)	688903	688903	0	0.0
			(read/write)	163352	163352	0	0.0
			.bss	75236	75236	0	0.0
			.data	3400	3400	0	0.0
			.rodata	102303	102303	0	0.0
			.text	586116	586116	0	0.0
	lock-ftd	LP_CC2652R7	(read only)	676767	676767	0	0.0
			(read/write)	166744	166744	0	0.0
			.bss	73548	73548	0	0.0
			.data	3224	3224	0	0.0
			.rodata	94359	94359	0	0.0
			.text	581928	581928	0	0.0
	lock-mtd	LP_CC2652R7	(read only)	625527	625527	0	0.0
			(read/write)	146352	146352	0	0.0
			.bss	69268	69268	0	0.0
			.data	3224	3224	0	0.0
			.rodata	94247	94247	0	0.0
			.text	530792	530792	0	0.0
	pump-app	LP_CC2652R7	(read only)	661267	661267	0	0.0
			(read/write)	183484	183484	0	0.0
			.bss	73764	73764	0	0.0
			.data	3256	3256	0	0.0
			.rodata	80387	80387	0	0.0
			.text	580396	580396	0	0.0
	pump-controller-app	LP_CC2652R7	(read only)	654155	654155	0	0.0
			(read/write)	190396	190396	0	0.0
			.bss	73820	73820	0	0.0
			.data	3220	3220	0	0.0
			.rodata	83323	83323	0	0.0
			.text	570348	570348	0	0.0
efr32	lighting-app	BRD4161A	(read only)	908216	908216	0	0.0
			(read/write)	135128	135128	0	0.0
			.bss	133072	133072	0	0.0
			.data	2052	2052	0	0.0
			.text	908208	908208	0	0.0
		BRD4161A+rpc	(read only)	942560	942560	0	0.0
			(read/write)	151808	151808	0	0.0
			.bss	149552	149552	0	0.0
			.data	2256	2256	0	0.0
			.text	942552	942552	0	0.0
		BRD4161A+rs911x	(read only)	746516	746516	0	0.0
			(read/write)	129352	129352	0	0.0
			.bss	127372	127372	0	0.0
			.data	1980	1980	0	0.0
			.text	746508	746508	0	0.0
	lock-app	BRD4161A+wf200	(read only)	916512	916512	0	0.0
			(read/write)	127540	127540	0	0.0
			.bss	125604	125604	0	0.0
			.data	1936	1936	0	0.0
			.text	916504	916504	0	0.0
	window-app	BRD4161A	(read only)	845464	845464	0	0.0
			(read/write)	133216	133216	0	0.0
			.bss	131248	131248	0	0.0
			.data	1964	1964	0	0.0
			.text	845456	845456	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2418060	2418060	0	0.0
			.bss	205884	205884	0	0.0
			.data	5856	5856	0	0.0
			.text	`1380660`	`1380660`	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1180107	1180107	0	0.0
			bss	142000	142000	0	0.0
			rodata	150804	150804	0	0.0
			text	808620	808620	0	0.0
p6	all-clusters-app	default	(read/write)	2528576	2528576	0	0.0
			.bss	139256	139256	0	0.0
			.data	2792	2792	0	0.0
			.text	1486840	1486840	0	0.0
	light-app	default	(read/write)	`2419176`	`2419176`	0	0.0
			.bss	132720	132720	0	0.0
			.data	2592	2592	0	0.0
			.text	1377440	1377440	0	0.0
	lock-app	default	(read/write)	`2428448`	`2428448`	0	0.0
			.bss	132544	132544	0	0.0
			.data	2552	2552	0	0.0
			.text	1386712	1386712	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	807348	807348	0	0.0
			bss	75432	75432	0	0.0
			noinit	40416	40416	0	0.0
			text	571142	571140	-2	-0.0

Add cluster commands to tv-casting-app

db4bd45

boring-cyborg bot added the examples label Apr 27, 2022

pullapprove bot requested review from wbschiller, woody-apple, xylophone21 and yufengwangca April 27, 2022 23:30

pullapprove bot added the review - pending label Apr 27, 2022

restyled-io bot mentioned this pull request Apr 27, 2022

Restyle Add cluster commands to tv-casting-app #17831

Closed

Support looking up video player node id from bindings when nodeId=0 i…

435df33

…n command

woody-apple approved these changes Apr 29, 2022

View reviewed changes

merge with TOT

a677ee0

chrisdecenzo added 2 commits May 1, 2022 08:05

refactor shell commands into tv-casting-common

f55218f

refactor cleanup

f024aa0

chrisdecenzo added 2 commits May 1, 2022 08:32

add shell commands for print/delete fabrics

851befa

shell help

fa3ed6b

lint and restyled

13b4a70

lint and readme

d63f4a5

restyled-io bot mentioned this pull request May 2, 2022

Restyle Add cluster commands to tv-casting-app #17955

Closed

chrisdecenzo added 2 commits May 2, 2022 07:46

restyled

d686996

spelling

1f93ecd

boring-cyborg bot added the github label May 2, 2022

sharadb-amazon approved these changes May 2, 2022

View reviewed changes

hawk248 approved these changes May 2, 2022

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels May 2, 2022

chrisdecenzo merged commit 3c5b7ab into master May 2, 2022

chrisdecenzo deleted the tv-apps-android2 branch May 2, 2022 19:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add cluster commands to tv-casting-app #17830

Add cluster commands to tv-casting-app #17830

chrisdecenzo commented Apr 27, 2022

github-actions bot commented Apr 27, 2022

github-actions bot commented May 1, 2022 •

edited

Loading

github-actions bot commented May 1, 2022 •

edited

Loading

github-actions bot commented May 1, 2022 •

edited

Loading

github-actions bot commented May 2, 2022 •

edited

Loading

Add cluster commands to tv-casting-app #17830

Add cluster commands to tv-casting-app #17830

Conversation

chrisdecenzo commented Apr 27, 2022

Problem

Change overview

Testing

github-actions bot commented Apr 27, 2022

github-actions bot commented May 1, 2022 • edited Loading

github-actions bot commented May 1, 2022 • edited Loading

github-actions bot commented May 1, 2022 • edited Loading

github-actions bot commented May 2, 2022 • edited Loading

github-actions bot commented May 1, 2022 •

edited

Loading

github-actions bot commented May 1, 2022 •

edited

Loading

github-actions bot commented May 1, 2022 •

edited

Loading

github-actions bot commented May 2, 2022 •

edited

Loading