Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored tv-casting-app/linux/main.cpp #17826

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Refactored tv-casting-app/linux/main.cpp #17826

merged 1 commit into from
Apr 28, 2022

Conversation

sharadb-amazon
Copy link
Contributor

Problem

tv-casting-app/linux/main.cpp had implementation of several functions and logic that are required across non-Linux platforms like Android and iOS. It had also grown to 700+ loc, was dealing with many distinct concerns, making it harder to read/edit.

Change overview

This PR does not intend to make any functional changes. It sets up the tv-casting-app code structure to be leveraged across all 3 platforms of interest: Linux, android and iOS. Following are the changes made:

  • Pulled out the classes TargetEndpointInfo and TargetVideoPlayerInfo into .hs and .cpps of their own and moved them into tv-casting-common (instead of the linux dir).
  • Pulled out several functions with non-linux specific logic to form the top level facade "CastingServer." Created CastingServer.h and .cpp under tv-casting-common. In a future PR, this CastingServer.h will be bound to Android through JNI and to iOS as well, simplifying the implementations of the tv-casting-app ports for those platforms.
  • Renamed Casting.h to CastingUtils.h and removed some of the common functions from there that had been added to tv-casting-common/CastingServer.

Testing

Tested by building and running tv-casting-app/linux.

@restyled-io restyled-io bot mentioned this pull request Apr 27, 2022
Closed
@github-actions
Copy link

PR #17826: Size comparison from 11c49af to 8291d7c

Full report (8 builds for cyw30739, linux, mbed, nrfconnect, telink)
platform target config section 11c49af 8291d7c change % change
cyw30739 light cyw930739m2evb_01 (read/write) 626374 626374 0 0.0
.app_xip_area 529204 529204 0 0.0
.bss 79828 79828 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 620974 620974 0 0.0
.app_xip_area 525276 525276 0 0.0
.bss 78388 78388 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574074 574074 0 0.0
.app_xip_area 468732 468732 0 0.0
.bss 87736 87736 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8237604 8237604 0 0.0
(read/write) 538593 538593 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 478600 478600 0 0.0
.dynamic 560 560 0 0.0
.got 14080 14080 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 421492 421492 0 0.0
.text 6600196 6600196 0 0.0
thermostat-no-ble arm64 (read only) 2365468 2365468 0 0.0
(read/write) 174305 174305 0 0.0
.bss 86129 86129 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 78928 78928 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145612 145612 0 0.0
.text 1991024 1991024 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411100 2411100 0 0.0
.bss 205708 205708 0 0.0
.data 5848 5848 0 0.0
.text 1373700 1373700 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179039 1179039 0 0.0
bss 141840 141840 0 0.0
rodata 150064 150064 0 0.0
text 808428 808428 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807312 807312 0 0.0
bss 75272 75272 0 0.0
noinit 40416 40416 0 0.0
text 571242 571242 0 0.0

@restyled-io restyled-io bot mentioned this pull request Apr 27, 2022
Closed
chrisdecenzo
chrisdecenzo approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@chrisdecenzo chrisdecenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but wondering why not make CastingUtils common?

@github-actions
Copy link

github-actions bot commented Apr 27, 2022 •
edited
Loading

PR #17826: Size comparison from 11c49af to 7fc227c

Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 11c49af 7fc227c change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 687787 687787 0 0.0
(read/write) 164308 164308 0 0.0
.bss 75076 75076 0 0.0
.data 3396 3396 0 0.0
.rodata 101467 101467 0 0.0
.text 585840 585840 0 0.0
lock-ftd LP_CC2652R7 (read only) 688571 688571 0 0.0
(read/write) 154828 154828 0 0.0
.bss 73436 73436 0 0.0
.data 3220 3220 0 0.0
.rodata 103123 103123 0 0.0
.text 584964 584964 0 0.0
lock-mtd LP_CC2652R7 (read only) 637315 637315 0 0.0
(read/write) 146236 146236 0 0.0
.bss 69156 69156 0 0.0
.data 3220 3220 0 0.0
.rodata 103003 103003 0 0.0
.text 533820 533820 0 0.0
pump-app LP_CC2652R7 (read only) 661359 661359 0 0.0
(read/write) 183240 183240 0 0.0
.bss 73612 73612 0 0.0
.data 3252 3252 0 0.0
.rodata 80319 80319 0 0.0
.text 580560 580560 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654303 654303 0 0.0
(read/write) 190088 190088 0 0.0
.bss 73660 73660 0 0.0
.data 3216 3216 0 0.0
.rodata 83343 83343 0 0.0
.text 570480 570480 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626374 626374 0 0.0
.app_xip_area 529204 529204 0 0.0
.bss 79828 79828 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 620974 620974 0 0.0
.app_xip_area 525276 525276 0 0.0
.bss 78388 78388 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574074 574074 0 0.0
.app_xip_area 468732 468732 0 0.0
.bss 87736 87736 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907432 907432 0 0.0
(read/write) 134960 134960 0 0.0
.bss 132912 132912 0 0.0
.data 2044 2044 0 0.0
.text 907424 907424 0 0.0
BRD4161A+rpc (read only) 941816 941816 0 0.0
(read/write) 151640 151640 0 0.0
.bss 149392 149392 0 0.0
.data 2248 2248 0 0.0
.text 941808 941808 0 0.0
window-app BRD4161A (read only) 844640 844640 0 0.0
(read/write) 133048 133048 0 0.0
.bss 131088 131088 0 0.0
.data 1956 1956 0 0.0
.text 844632 844632 0 0.0
esp32 all-clusters-app c3devkit (read only) 998842 998842 0 0.0
(read/write) 1473570 1473570 0 0.0
.dram0.bss 68208 68208 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 206488 206488 0 0.0
.flash.text 998842 998842 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1053087 1053087 0 0.0
(read/write) 475568 475568 0 0.0
.dram0.bss 73728 73728 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 235836 235836 0 0.0
.flash.text 1047703 1047703 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 688388 688388 0 0.0
.bss 81160 81160 0 0.0
.data 2000 2000 0 0.0
.text 599428 599428 0 0.0
lock k32w061+release (read/write) 729248 729248 0 0.0
.bss 81568 81568 0 0.0
.data 1960 1960 0 0.0
.text 639920 639920 0 0.0
linux all-clusters-app debug (read only) 2730993 2730993 0 0.0
(read/write) 172752 172752 0 0.0
.bss 83168 83168 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 81496 81496 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1000 1000 0 0.0
.rodata 234085 234085 0 0.0
.text 2322546 2322546 0 0.0
bridge-app debug+rpc (read only) 1888049 1888049 0 0.0
(read/write) 120112 120112 0 0.0
.bss 71168 71168 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40184 40184 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 159489 159489 0 0.0
.text 1606402 1606402 0 0.0
chip-tool debug (read only) 8379277 8379277 0 0.0
(read/write) 473424 473424 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 443448 443448 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 455029 455029 0 0.0
.text 6840933 6840933 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8237604 8237604 0 0.0
(read/write) 538593 538593 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 478600 478600 0 0.0
.dynamic 560 560 0 0.0
.got 14080 14080 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 421492 421492 0 0.0
.text 6600196 6600196 0 0.0
lighting-app debug+rpc (read only) 2322417 2322417 0 0.0
(read/write) 151096 151096 0 0.0
.bss 73248 73248 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70120 70120 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 183601 183601 0 0.0
.text 1972802 1972802 0 0.0
lock-app debug (read only) 2203521 2203521 0 0.0
(read/write) 145416 145416 0 0.0
.bss 71808 71808 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66456 66456 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 192097 192097 0 0.0
.text 1852050 1852050 0 0.0
ota-provider-app debug (read only) 2057001 2057001 0 0.0
(read/write) 138696 138696 0 0.0
.bss 71232 71232 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60008 60008 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 174147 174147 0 0.0
.text 1725970 1725970 0 0.0
ota-requestor-app debug (read only) 2088081 2088081 0 0.0
(read/write) 141472 141472 0 0.0
.bss 71872 71872 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62056 62056 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 170380 170380 0 0.0
.text 1759330 1759330 0 0.0
shell debug (read only) 2555977 2555977 0 0.0
(read/write) 196648 196648 0 0.0
.bss 113768 113768 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 75784 75784 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 215794 215794 0 0.0
.text 2178898 2178898 0 0.0
thermostat-no-ble arm64 (read only) 2365468 2365468 0 0.0
(read/write) 174305 174305 0 0.0
.bss 86129 86129 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 78928 78928 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145612 145612 0 0.0
.text 1991024 1991024 0 0.0
tv-app debug (read only) 2841065 2841065 0 0.0
(read/write) 276344 276344 0 0.0
.bss 189112 189112 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76360 76360 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 216203 216203 0 0.0
.text 2443026 2443026 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411100 2411100 0 0.0
.bss 205708 205708 0 0.0
.data 5848 5848 0 0.0
.text 1373700 1373700 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179039 1179039 0 0.0
bss 141840 141840 0 0.0
rodata 150064 150064 0 0.0
text 808428 808428 0 0.0
p6 all-clusters-app default (read/write) 2526408 2526408 0 0.0
.bss 139096 139096 0 0.0
.data 2784 2784 0 0.0
.text 1484672 1484672 0 0.0
light-app default (read/write) 2418352 2418352 0 0.0
.bss 132568 132568 0 0.0
.data 2584 2584 0 0.0
.text 1376616 1376616 0 0.0
lock-app default (read/write) 2422432 2422432 0 0.0
.bss 132368 132368 0 0.0
.data 2544 2544 0 0.0
.text 1380696 1380696 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807312 807312 0 0.0
bss 75272 75272 0 0.0
noinit 40416 40416 0 0.0
text 571242 571242 0 0.0

@github-actions
Copy link

github-actions bot commented Apr 27, 2022 •
edited
Loading

PR #17826: Size comparison from 11c49af to 2fc0f3f

Full report (13 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 11c49af 2fc0f3f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 626374 626374 0 0.0
.app_xip_area 529204 529204 0 0.0
.bss 79828 79828 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 620974 620974 0 0.0
.app_xip_area 525276 525276 0 0.0
.bss 78388 78388 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574074 574074 0 0.0
.app_xip_area 468732 468732 0 0.0
.bss 87736 87736 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 688388 688388 0 0.0
.bss 81160 81160 0 0.0
.data 2000 2000 0 0.0
.text 599428 599428 0 0.0
lock k32w061+release (read/write) 729248 729248 0 0.0
.bss 81568 81568 0 0.0
.data 1960 1960 0 0.0
.text 639920 639920 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 8237604 8237604 0 0.0
(read/write) 538593 538593 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 478600 478600 0 0.0
.dynamic 560 560 0 0.0
.got 14080 14080 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 421492 421492 0 0.0
.text 6600196 6600196 0 0.0
thermostat-no-ble arm64 (read only) 2365468 2365468 0 0.0
(read/write) 174305 174305 0 0.0
.bss 86129 86129 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 78928 78928 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145612 145612 0 0.0
.text 1991024 1991024 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411100 2411100 0 0.0
.bss 205708 205708 0 0.0
.data 5848 5848 0 0.0
.text 1373700 1373700 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179039 1179039 0 0.0
bss 141840 141840 0 0.0
rodata 150064 150064 0 0.0
text 808428 808428 0 0.0
p6 all-clusters-app default (read/write) 2526408 2526408 0 0.0
.bss 139096 139096 0 0.0
.data 2784 2784 0 0.0
.text 1484672 1484672 0 0.0
light-app default (read/write) 2418352 2418352 0 0.0
.bss 132568 132568 0 0.0
.data 2584 2584 0 0.0
.text 1376616 1376616 0 0.0
lock-app default (read/write) 2422432 2422432 0 0.0
.bss 132368 132368 0 0.0
.data 2544 2544 0 0.0
.text 1380696 1380696 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807312 807312 0 0.0
bss 75272 75272 0 0.0
noinit 40416 40416 0 0.0
text 571242 571242 0 0.0

@sharadb-amazon
Moved TargetEndpointInfo and TargetVideoPlayerInfo out of tv-casting-…
fe860b3 
…app/linux/main.cpp

Refactored tv-casting-app/linux/main.cpp: Created CastingServer, renamed Casting->CastingUtils
@github-actions
Copy link

github-actions bot commented Apr 28, 2022 •
edited
Loading

PR #17826: Size comparison from 11c49af to fe860b3

Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 11c49af fe860b3 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 687787 687787 0 0.0
(read/write) 164308 164308 0 0.0
.bss 75076 75076 0 0.0
.data 3396 3396 0 0.0
.rodata 101467 101467 0 0.0
.text 585840 585840 0 0.0
lock-ftd LP_CC2652R7 (read only) 688571 688571 0 0.0
(read/write) 154828 154828 0 0.0
.bss 73436 73436 0 0.0
.data 3220 3220 0 0.0
.rodata 103123 103123 0 0.0
.text 584964 584964 0 0.0
lock-mtd LP_CC2652R7 (read only) 637315 637315 0 0.0
(read/write) 146236 146236 0 0.0
.bss 69156 69156 0 0.0
.data 3220 3220 0 0.0
.rodata 103003 103003 0 0.0
.text 533820 533820 0 0.0
pump-app LP_CC2652R7 (read only) 661359 661359 0 0.0
(read/write) 183240 183240 0 0.0
.bss 73612 73612 0 0.0
.data 3252 3252 0 0.0
.rodata 80319 80319 0 0.0
.text 580560 580560 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654303 654303 0 0.0
(read/write) 190088 190088 0 0.0
.bss 73660 73660 0 0.0
.data 3216 3216 0 0.0
.rodata 83343 83343 0 0.0
.text 570480 570480 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626374 626374 0 0.0
.app_xip_area 529204 529204 0 0.0
.bss 79828 79828 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 620974 620974 0 0.0
.app_xip_area 525276 525276 0 0.0
.bss 78388 78388 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574074 574074 0 0.0
.app_xip_area 468732 468732 0 0.0
.bss 87736 87736 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907432 907432 0 0.0
(read/write) 134960 134960 0 0.0
.bss 132912 132912 0 0.0
.data 2044 2044 0 0.0
.text 907424 907424 0 0.0
BRD4161A+rpc (read only) 941816 941816 0 0.0
(read/write) 151640 151640 0 0.0
.bss 149392 149392 0 0.0
.data 2248 2248 0 0.0
.text 941808 941808 0 0.0
window-app BRD4161A (read only) 844640 844640 0 0.0
(read/write) 133048 133048 0 0.0
.bss 131088 131088 0 0.0
.data 1956 1956 0 0.0
.text 844632 844632 0 0.0
esp32 all-clusters-app c3devkit (read only) 998842 998842 0 0.0
(read/write) 1473570 1473570 0 0.0
.dram0.bss 68208 68208 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 206488 206488 0 0.0
.flash.text 998842 998842 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1053087 1053087 0 0.0
(read/write) 475568 475568 0 0.0
.dram0.bss 73728 73728 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 235836 235836 0 0.0
.flash.text 1047703 1047703 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 688388 688388 0 0.0
.bss 81160 81160 0 0.0
.data 2000 2000 0 0.0
.text 599428 599428 0 0.0
lock k32w061+release (read/write) 729248 729248 0 0.0
.bss 81568 81568 0 0.0
.data 1960 1960 0 0.0
.text 639920 639920 0 0.0
linux all-clusters-app debug (read only) 2730993 2730993 0 0.0
(read/write) 172752 172752 0 0.0
.bss 83168 83168 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 81496 81496 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 1000 1000 0 0.0
.rodata 234085 234085 0 0.0
.text 2322546 2322546 0 0.0
bridge-app debug+rpc (read only) 1888049 1888049 0 0.0
(read/write) 120112 120112 0 0.0
.bss 71168 71168 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40184 40184 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 159489 159489 0 0.0
.text 1606402 1606402 0 0.0
chip-tool debug (read only) 8379277 8379277 0 0.0
(read/write) 473424 473424 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 443448 443448 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 455029 455029 0 0.0
.text 6840933 6840933 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8237604 8237604 0 0.0
(read/write) 538593 538593 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 478600 478600 0 0.0
.dynamic 560 560 0 0.0
.got 14080 14080 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 421492 421492 0 0.0
.text 6600196 6600196 0 0.0
lighting-app debug+rpc (read only) 2322417 2322417 0 0.0
(read/write) 151096 151096 0 0.0
.bss 73248 73248 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70120 70120 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 183601 183601 0 0.0
.text 1972802 1972802 0 0.0
lock-app debug (read only) 2203521 2203521 0 0.0
(read/write) 145416 145416 0 0.0
.bss 71808 71808 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66456 66456 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 192097 192097 0 0.0
.text 1852050 1852050 0 0.0
ota-provider-app debug (read only) 2057001 2057001 0 0.0
(read/write) 138696 138696 0 0.0
.bss 71232 71232 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60008 60008 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 174147 174147 0 0.0
.text 1725970 1725970 0 0.0
ota-requestor-app debug (read only) 2088081 2088081 0 0.0
(read/write) 141472 141472 0 0.0
.bss 71872 71872 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62056 62056 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 170380 170380 0 0.0
.text 1759330 1759330 0 0.0
shell debug (read only) 2555977 2555977 0 0.0
(read/write) 196648 196648 0 0.0
.bss 113768 113768 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 75784 75784 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 215794 215794 0 0.0
.text 2178898 2178898 0 0.0
thermostat-no-ble arm64 (read only) 2365468 2365468 0 0.0
(read/write) 174305 174305 0 0.0
.bss 86129 86129 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 78928 78928 0 0.0
.dynamic 560 560 0 0.0
.got 4736 4736 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145612 145612 0 0.0
.text 1991024 1991024 0 0.0
tv-app debug (read only) 2841065 2841065 0 0.0
(read/write) 276344 276344 0 0.0
.bss 189112 189112 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76360 76360 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 216203 216203 0 0.0
.text 2443026 2443026 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411100 2411100 0 0.0
.bss 205708 205708 0 0.0
.data 5848 5848 0 0.0
.text 1373700 1373700 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179039 1179039 0 0.0
bss 141840 141840 0 0.0
rodata 150064 150064 0 0.0
text 808428 808428 0 0.0
p6 all-clusters-app default (read/write) 2526408 2526408 0 0.0
.bss 139096 139096 0 0.0
.data 2784 2784 0 0.0
.text 1484672 1484672 0 0.0
light-app default (read/write) 2418352 2418352 0 0.0
.bss 132568 132568 0 0.0
.data 2584 2584 0 0.0
.text 1376616 1376616 0 0.0
lock-app default (read/write) 2422432 2422432 0 0.0
.bss 132368 132368 0 0.0
.data 2544 2544 0 0.0
.text 1380696 1380696 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807312 807312 0 0.0
bss 75272 75272 0 0.0
noinit 40416 40416 0 0.0
text 571242 571242 0 0.0

@chrisdecenzo chrisdecenzo merged commit d2e6b99 into project-chip:master Apr 28, 2022
@sharadb-amazon sharadb-amazon deleted the droid-20220425 branch June 19, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@lazarkov lazarkov Awaiting requested review from lazarkov

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@hawk248 hawk248 Awaiting requested review from hawk248

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples linux review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharadb-amazon @hawk248 @chrisdecenzo