Remove the concept of client attributes from EmberAfAttributeSearchRecord. #17825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cord. All attributes in Matter are server attributes.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google and
mrjerryjohns
pullapprove
bot
requested review from
msandstedt,
mspang,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #17825: Size comparison from 11c49af to 8897fdc Increases (5 builds for cc13x2_26x2, linux)
Decreases (28 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Damian-Nordic
approved these changes
Apr 28, 2022
tcarmelveilleux
approved these changes
Apr 28, 2022
chrisbeach59
pushed a commit
to chrisbeach59/connectedhomeip
that referenced
this pull request
May 31, 2022
* [IM] Crash when trying to subscribe to an event * [YAML] Update TestEvents.yaml to use subscribeEvent * Fix ClusterTestGeneration.js to make it possible to wait for an event report * Update generated test code Test Modified Apr 17 (project-chip#17513) * Modified scripts TC-MC-1.1 TC-MC-1.2 TC-MC-1.3 TC-MC-1.4 TC-MC-1.5 TC-MC-1.6 TC-MC-1.7 TC-MC-1.8 TC-MC-1.9 TC-MC-1.10 TC-MC-1.11 TC-MC-1.12 TC-MC-3.1 TC-MC-3.2 TC-MC-3.3 TC-MC-3.4 TC-MC-3.5 TC-OO-1.1 TC-RH-1.1 TC-RH-2.1 TC-TM-1.1 TC-TSUIC-1.1 * Added auto generated files * Restyled by whitespace * Modified JS file * Auto generated files Co-authored-by: Restyled.io <[email protected]> Test added apr7 (project-chip#17165) * Added manual scripts * Added auto generatedfiles * Restyled by whitespace * Restyled by prettier-yaml * updated additional comments Co-authored-by: Restyled.io <[email protected]> [Tests] Increase the tests timeout from 30 minutes to 40 minutes (project-chip#17838) [chip-tool] Do not try to reset an element that does not exists in the case of a group command (project-chip#17844) Remove the concept of client attributes from EmberAfAttributeSearchRecord. (project-chip#17825) All attributes in Matter are server attributes. Change erase size for OTA Reduce CHIP_CONFIG_MAX_FABRICS from 16 to 5 DCT modules used for ACL reduced from 48 to 15 SetRequestorCanConsent to true [Tempfix] Store new target software version in persistent storage Current method adds 1 to the old software version TODO: change to the exact software version downloaded TODO: use ConfigurationMgr() instead of Impl after rebasing to newer version SetRequestorCanConsent to true for lighting and ota-requestor apps rebasing Pull in Changes from Te7 Stat Tested against the PC simulator for thermostat. Thermostat Ameba Files Add examples/thermostat/ameba/main files Update .gitignore to exclude examples/thermostat/ameba/build Pull in Changes from Te7 Stat Tested against the PC simulator for thermostat. Realtek update update Zap update for SW Diags and Wi-Fi Diags Update thermostat.zap file Thermostat .zap config update Used for TE 7.5 Updated config Change VID and PID to work with example DAA credentials zap file update for thermostat Remove deprecated api for OTA Updated device manger and interface files for TE9 Works with new device attestation verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All attributes in Matter are server attributes.
Problem
Unnecessary sides for attributes being passed around.
Change overview
Remove some of them. There are more to remove, but those will be separate PRs.
Testing
No behavior changes, just code removal.