Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Thread Synchronized Sleepy End Devices #17803

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Added support for Thread Synchronized Sleepy End Devices #17803

merged 1 commit into from
Apr 28, 2022

Conversation

kkasperczyk-no
Copy link
Contributor

Problem

Thread 1.2 allows to use Synchronized Sleepy End Devices that doesn't need to poll parent for data like traditional SED,
but wakes up in scheduled time slots to listen for messages without transmitting requests to parent. There is no support for such devices in Matter Thread platform.

Change overview

  • Refactored naming for sleepy end devices, as everywhere the polling mechanism is assumed. Basically renamed polling
    intervals to intervals and fast/slow polling mode to active/idle mode.
  • Added CHIP_DEVICE_CONFIG_THREAD_SSED that allows to enable Thread SSED support.
  • Added new Thread kThreadDeviceType_SynchronizedSleepyEndDevice device type
  • Added calculating communication intervals for Thread SSED based on CSL period instead of poll period.

Testing

PR adds only initial support, as no example is using SSED yet. Communication was tested manually with the nrfconnect lock-app, chip-tool and ota-provider.

@kkasperczyk-no
Added support for Thread Synchronized Sleepy End Devices
d6b94d2 
Thread 1.2 allows to use Synchronized Sleepy End Devices
that doesn't need to poll parent for data like traditional SED,
but wakes up in scheduled time slots to listen for messages
without transmitting requests to parent.

* Refactored naming for sleepy end devices, as everywhere
the polling mechanism is assumed. Basically renamed polling
intervals to intervals and fast/slow polling mode to
active/idle mode.
* Added CHIP_DEVICE_CONFIG_THREAD_SSED that allows to enable
Thread SSED support.
* Added new Thread kThreadDeviceType_SynchronizedSleepyEndDevice
device type
* Added calculating communication intervals for Thread SSED based
on CSL period instead of poll period.
@kkasperczyk-no kkasperczyk-no force-pushed the ssed_thread_initial_support branch from 3a884e1 to d6b94d2 Compare April 27, 2022 09:27
LuDuda
LuDuda approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@github-actions
Copy link

github-actions bot commented Apr 27, 2022 •
edited
Loading

PR #17803: Size comparison from aa566b0 to d6b94d2

Increases (8 builds for cc13x2_26x2, cyw30739, efr32, nrfconnect)
platform target config section aa566b0 d6b94d2 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 689047 689055 8 0.0
.text 585316 585324 8 0.0
pump-controller-app LP_CC2652R7 (read only) 654787 654795 8 0.0
.text 570840 570848 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626890 626898 8 0.0
.app_xip_area 529768 529776 8 0.0
efr32 window-app BRD4161A (read only) 845276 845292 16 0.0
.text 845268 845284 16 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1156159 1156175 16 0.0
text 810084 810088 4 0.0
nrf52840dk_nrf52840+rpc text 782568 782572 4 0.0
nrf52840dongle_nrf52840 (read/write) 1064219 1064235 16 0.0
text 738660 738664 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1058614 1058630 16 0.0
text 720192 720196 4 0.0
Decreases (3 builds for cc13x2_26x2, k32w)
platform target config section aa566b0 d6b94d2 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 154304 154296 -8 -0.0
pump-controller-app LP_CC2652R7 (read/write) 189556 189548 -8 -0.0
k32w lock k32w061+release (read/write) 729684 729676 -8 -0.0
.text 640404 640396 -8 -0.0
Full report (40 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section aa566b0 d6b94d2 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 688423 688423 0 0.0
(read/write) 163624 163624 0 0.0
.bss 75028 75028 0 0.0
.data 3396 3396 0 0.0
.rodata 101583 101583 0 0.0
.text 586360 586360 0 0.0
lock-ftd LP_CC2652R7 (read only) 689047 689055 8 0.0
(read/write) 154304 154296 -8 -0.0
.bss 73388 73388 0 0.0
.data 3220 3220 0 0.0
.rodata 103247 103247 0 0.0
.text 585316 585324 8 0.0
lock-mtd LP_CC2652R7 (read only) 637791 637791 0 0.0
(read/write) 146188 146188 0 0.0
.bss 69108 69108 0 0.0
.data 3220 3220 0 0.0
.rodata 103127 103127 0 0.0
.text 534172 534172 0 0.0
pump-app LP_CC2652R7 (read only) 661891 661891 0 0.0
(read/write) 182660 182660 0 0.0
.bss 73564 73564 0 0.0
.data 3252 3252 0 0.0
.rodata 80443 80443 0 0.0
.text 580968 580968 0 0.0
pump-controller-app LP_CC2652R7 (read only) 654787 654795 8 0.0
(read/write) 189556 189548 -8 -0.0
.bss 73612 73612 0 0.0
.data 3216 3216 0 0.0
.rodata 83467 83467 0 0.0
.text 570840 570848 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626890 626898 8 0.0
.app_xip_area 529768 529776 8 0.0
.bss 79780 79780 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 621434 621434 0 0.0
.app_xip_area 525784 525784 0 0.0
.bss 78340 78340 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574262 574262 0 0.0
.app_xip_area 468968 468968 0 0.0
.bss 87688 87688 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907908 907908 0 0.0
(read/write) 134908 134908 0 0.0
.bss 132864 132864 0 0.0
.data 2044 2044 0 0.0
.text 907900 907900 0 0.0
BRD4161A+rpc (read only) 942308 942308 0 0.0
(read/write) 151592 151592 0 0.0
.bss 149344 149344 0 0.0
.data 2248 2248 0 0.0
.text 942300 942300 0 0.0
window-app BRD4161A (read only) 845276 845292 16 0.0
(read/write) 132996 132996 0 0.0
.bss 131040 131040 0 0.0
.data 1956 1956 0 0.0
.text 845268 845284 16 0.0
esp32 all-clusters-app c3devkit (read only) 999664 999664 0 0.0
(read/write) 1473706 1473706 0 0.0
.dram0.bss 68184 68184 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 206640 206640 0 0.0
.flash.text 999664 999664 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1053895 1053895 0 0.0
(read/write) 475696 475696 0 0.0
.dram0.bss 73704 73704 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 235988 235988 0 0.0
.flash.text 1048511 1048511 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 688824 688824 0 0.0
.bss 81112 81112 0 0.0
.data 2000 2000 0 0.0
.text 599912 599912 0 0.0
lock k32w061+release (read/write) 729684 729676 -8 -0.0
.bss 81520 81520 0 0.0
.data 1960 1960 0 0.0
.text 640404 640396 -8 -0.0
linux all-clusters-app debug (read only) 2736265 2736265 0 0.0
(read/write) 172808 172808 0 0.0
.bss 83168 83168 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 81576 81576 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 992 992 0 0.0
.rodata 234213 234213 0 0.0
.text 2327426 2327426 0 0.0
bridge-app debug+rpc (read only) 1891369 1891369 0 0.0
(read/write) 120240 120240 0 0.0
.bss 71168 71168 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40328 40328 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 159601 159601 0 0.0
.text 1609202 1609202 0 0.0
chip-tool debug (read only) 8360565 8360565 0 0.0
(read/write) 472624 472624 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 442648 442648 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 453013 453013 0 0.0
.text 6825989 6825989 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8222460 8222460 0 0.0
(read/write) 537745 537745 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 477752 477752 0 0.0
.dynamic 560 560 0 0.0
.got 14080 14080 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 419452 419452 0 0.0
.text 6589060 6589060 0 0.0
lighting-app debug+rpc (read only) 2326841 2326841 0 0.0
(read/write) 151192 151192 0 0.0
.bss 73216 73216 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70248 70248 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 183729 183729 0 0.0
.text 1976690 1976690 0 0.0
lock-app debug (read only) 2207225 2207225 0 0.0
(read/write) 145576 145576 0 0.0
.bss 71808 71808 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66600 66600 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 192225 192225 0 0.0
.text 1855218 1855218 0 0.0
ota-provider-app debug (read only) 2059929 2059929 0 0.0
(read/write) 138824 138824 0 0.0
.bss 71232 71232 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60152 60152 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 174235 174235 0 0.0
.text 1728402 1728402 0 0.0
ota-requestor-app debug (read only) 2091145 2091145 0 0.0
(read/write) 141600 141600 0 0.0
.bss 71872 71872 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62184 62184 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 170556 170556 0 0.0
.text 1761810 1761810 0 0.0
shell debug (read only) 2561937 2561937 0 0.0
(read/write) 196776 196776 0 0.0
.bss 113768 113768 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 75912 75912 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 215922 215922 0 0.0
.text 2184322 2184322 0 0.0
thermostat-no-ble arm64 (read only) 2369116 2369116 0 0.0
(read/write) 174353 174353 0 0.0
.bss 86113 86113 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 78984 78984 0 0.0
.dynamic 560 560 0 0.0
.got 4744 4744 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145660 145660 0 0.0
.text 1994432 1994432 0 0.0
tv-app debug (read only) 2846113 2846113 0 0.0
(read/write) 276472 276472 0 0.0
.bss 189112 189112 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76488 76488 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 216363 216363 0 0.0
.text 2447506 2447506 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411772 2411772 0 0.0
.bss 205660 205660 0 0.0
.data 5848 5848 0 0.0
.text 1374372 1374372 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179599 1179599 0 0.0
bss 141792 141792 0 0.0
rodata 150272 150272 0 0.0
text 808904 808904 0 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1156159 1156175 16 0.0
bss 145508 145508 0 0.0
rodata 121984 121984 0 0.0
text 810084 810088 4 0.0
nrf52840dk_nrf52840+rpc (read/write) 1120463 1120463 0 0.0
bss 145744 145744 0 0.0
rodata 113096 113096 0 0.0
text 782568 782572 4 0.0
nrf52840dongle_nrf52840 (read/write) 1064219 1064235 16 0.0
bss 152700 152700 0 0.0
rodata 92060 92060 0 0.0
text 738660 738664 4 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1058614 1058630 16 0.0
bss 141712 141712 0 0.0
rodata 114740 114740 0 0.0
text 720192 720196 4 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1093771 1093771 0 0.0
bss 135424 135424 0 0.0
rodata 133780 133780 0 0.0
text 746096 746096 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 996554 996554 0 0.0
bss 131660 131660 0 0.0
rodata 126584 126584 0 0.0
text 656344 656344 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1076567 1076567 0 0.0
bss 135512 135512 0 0.0
rodata 117496 117496 0 0.0
text 744964 744964 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1058103 1058103 0 0.0
bss 135232 135232 0 0.0
rodata 113448 113448 0 0.0
text 730848 730848 0 0.0
p6 all-clusters-app default (read/write) 2527344 2527344 0 0.0
.bss 139048 139048 0 0.0
.data 2784 2784 0 0.0
.text 1485608 1485608 0 0.0
light-app default (read/write) 2418960 2418960 0 0.0
.bss 132520 132520 0 0.0
.data 2584 2584 0 0.0
.text 1377224 1377224 0 0.0
lock-app default (read/write) 2423136 2423136 0 0.0
.bss 132320 132320 0 0.0
.data 2544 2544 0 0.0
.text 1381400 1381400 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 808256 808256 0 0.0
bss 75224 75224 0 0.0
noinit 40416 40416 0 0.0
text 571996 571996 0 0.0

@pullapprove pullapprove bot requested a review from arkq April 27, 2022 18:45
@andy31415 andy31415 merged commit 10bb2fd into project-chip:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@LuDuda LuDuda LuDuda approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@arkq arkq Awaiting requested review from arkq

Assignees
No one assigned
Labels
app config examples linux nrf connect openthread platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kkasperczyk-no @LuDuda @bzbarsky-apple @andy31415