-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CHIPAttestationTrustStoreBridge when we know we have PAA certs. #17783
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:create-attestation-bridge-later
Apr 27, 2022
Merged
Create CHIPAttestationTrustStoreBridge when we know we have PAA certs. #17783
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:create-attestation-bridge-later
Apr 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt,
mspang and
robszewczyk
April 26, 2022 21:13
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
April 26, 2022 21:13
PR #17783: Size comparison from 6c54ab8 to 9a44d99 Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
pullapprove
bot
requested review from
erjiaqing
and removed request for
lzgrablic02
April 26, 2022 21:40
carol-apple
approved these changes
Apr 26, 2022
carol-apple
reviewed
Apr 26, 2022
tcarmelveilleux
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17746
Problem
We end up with a field marked nullable that should never be nil.
Change overview
Initialize it in the constructor so it's never nil. This requires creating the containing object somewhat later.
Testing
Should compile and pass clang-tidy.