-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error reporting in chip-tool. #17760
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-chip-tool-error-reporting
Apr 27, 2022
Merged
Fix error reporting in chip-tool. #17760
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:fix-chip-tool-error-reporting
Apr 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google,
mrjerryjohns,
msandstedt and
robszewczyk
April 26, 2022 16:18
pullapprove
bot
requested review from
msandstedt,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs and
vivien-apple
April 26, 2022 16:18
pullapprove
bot
requested review from
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
April 26, 2022 16:18
vivien-apple
approved these changes
Apr 26, 2022
PR #17760: Size comparison from 8246236 to 59e6a7a Decreases (1 build for linux)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
force-pushed
the
fix-chip-tool-error-reporting
branch
from
April 26, 2022 18:59
59e6a7a
to
1375b98
Compare
PR #17760: Size comparison from 6c54ab8 to 1375b98 Decreases (1 build for linux)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
/rebase |
bzbarsky-apple
force-pushed
the
fix-chip-tool-error-reporting
branch
from
April 26, 2022 21:56
1375b98
to
03ec142
Compare
PR #17760: Size comparison from 6c54ab8 to 03ec142 Full report (10 builds for cc13x2_26x2, efr32, mbed, nrfconnect)
|
The actual error message got lost in project-chip#17628.
bzbarsky-apple
force-pushed
the
fix-chip-tool-error-reporting
branch
from
April 27, 2022 00:52
03ec142
to
8d0f150
Compare
PR #17760: Size comparison from 13ef4a3 to 8d0f150 Decreases (1 build for linux)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmeg-sfy
approved these changes
Apr 27, 2022
tcarmelveilleux
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual error message got lost in #17628.
Problem
Get error messages like:
Change overview
Make it be more like:
Testing
Ran a failing test, looked at the error message.