-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[linux] Use BLE notification instead of indication #17692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux BLE peripherals use GATT indications instead of notifications as defined in the spec.
PR #17692: Size comparison from cb6843f to 2bed76f Decreases (1 build for linux)
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
Apr 25, 2022
AntonGrey
pushed a commit
to AntonGrey/connectedhomeip
that referenced
this pull request
Apr 26, 2022
Linux BLE peripherals use GATT indications instead of notifications as defined in the spec.
Damian-Nordic
added a commit
to Damian-Nordic/connectedhomeip
that referenced
this pull request
Apr 28, 2022
…hip#17692)" This reverts commit 6160935.
andy31415
pushed a commit
that referenced
this pull request
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Linux BLE peripherals use GATT indications instead of notifications as defined in the spec.
Change overview
Switch to using GATT notifications (without confirmation).
Fixes #17353.
Testing
Verified using chip-tool for Linux that commissioning of a Linux peripheral still works.