Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable several more clang-tidy checks. Fix a set of 'loop variable too small' errors. #17690

Merged
merged 25 commits into from
Apr 26, 2022
Merged

Enable several more clang-tidy checks. Fix a set of 'loop variable too small' errors. #17690

merged 25 commits into from
Apr 26, 2022

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Apr 25, 2022 •
edited
Loading

Problem

The more clang-tidy checks we have, the more likely to have well behaving code.

Change overview

Enables a bunch of clang-tidy checks.
Out of the checks, the check for loop variable size generated some errors so I fixed them.
Non-null check triggered a lot of darwin errors. Marked the corresponding class members as _Nullable

Testing

Manually ran check on linux. CI will run check on darwin too.

@github-actions
Copy link

github-actions bot commented Apr 25, 2022 •
edited
Loading

PR #17690: Size comparison from e4df559 to ba84eb6

Increases (21 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, p6)
platform target config section e4df559 ba84eb6 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 678635 678643 8 0.0
.text 579300 579308 8 0.0
lock-mtd LP_CC2652R7 (read only) 627379 627387 8 0.0
.text 528156 528164 8 0.0
pump-app LP_CC2652R7 (read only) 651071 651079 8 0.0
.text 574880 574888 8 0.0
pump-controller-app LP_CC2652R7 (read only) 644139 644147 8 0.0
.text 564816 564824 8 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 618498 618506 8 0.0
.app_xip_area 522792 522800 8 0.0
esp32 all-clusters-app c3devkit (read only) 999220 999282 62 0.0
.dram0.bss 68216 68224 8 0.0
.flash.text 999220 999282 62 0.0
m5stack (read only) 1053467 1053503 36 0.0
(read/write) 475720 475728 8 0.0
.dram0.bss 73736 73744 8 0.0
.flash.text 1048083 1048119 36 0.0
k32w light k32w061+release (read/write) 688808 688824 16 0.0
.text 599840 599856 16 0.0
linux all-clusters-app debug (read only) 2734185 2734553 368 0.0
.rodata 233381 233669 288 0.1
.text 2325890 2325970 80 0.0
bridge-app debug+rpc (read only) 1847941 1848309 368 0.0
.rodata 149089 149345 256 0.2
.text 1579669 1579781 112 0.0
chip-tool debug (read only) 10944317 10944717 400 0.0
.rodata 547349 547605 256 0.0
.text 9557061 9557205 144 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10555708 10556028 320 0.0
.rodata 521212 521340 128 0.0
.text 8916692 8916884 192 0.0
lighting-app debug+rpc (read only) 2325465 2326041 576 0.0
.rodata 183281 183537 256 0.1
.text 1975474 1975794 320 0.0
lock-app debug (read only) 2151977 2152345 368 0.0
.rodata 189601 189857 256 0.1
.text 1805186 1805298 112 0.0
ota-provider-app debug (read only) 2058537 2058857 320 0.0
.rodata 173723 174011 288 0.2
.text 1727378 1727410 32 0.0
ota-requestor-app debug (read only) 2089785 2090073 288 0.0
.rodata 170076 170332 256 0.2
.text 1760786 1760818 32 0.0
shell debug (read only) 2560649 2561065 416 0.0
.rodata 215570 215858 288 0.1
.text 2183074 2183202 128 0.0
thermostat-no-ble arm64 (read only) 2367532 2367804 272 0.0
.rodata 145308 145420 112 0.1
.text 1993024 1993184 160 0.0
tv-app debug (read only) 2843681 2844049 368 0.0
.rodata 215531 215787 256 0.1
.text 2445618 2445730 112 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2411396 2411460 64 0.0
.text 1373996 1374060 64 0.0
p6 light-app default (read/write) 2418640 2418656 16 0.0
.text 1376904 1376920 16 0.0
Decreases (4 builds for cc13x2_26x2, efr32, nrfconnect, telink)
platform target config section e4df559 ba84eb6 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 164756 164748 -8 -0.0
efr32 lighting-app BRD4161A+rpc (read only) 941936 941920 -16 -0.0
.text 941928 941912 -16 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177531 1177515 -16 -0.0
text 806852 806840 -12 -0.0
telink lighting-app tlsr9518adk80d (read/write) 807984 807976 -8 -0.0
text 571680 571676 -4 -0.0
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e4df559 ba84eb6 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 692119 692119 0 0.0
(read/write) 159968 159968 0 0.0
.bss 75072 75072 0 0.0
.data 3396 3396 0 0.0
.rodata 106015 106015 0 0.0
.text 585624 585624 0 0.0
lock-ftd LP_CC2652R7 (read only) 678635 678643 8 0.0
(read/write) 164756 164748 -8 -0.0
.bss 73432 73432 0 0.0
.data 3220 3220 0 0.0
.rodata 98851 98851 0 0.0
.text 579300 579308 8 0.0
lock-mtd LP_CC2652R7 (read only) 627379 627387 8 0.0
(read/write) 146228 146228 0 0.0
.bss 69152 69152 0 0.0
.data 3220 3220 0 0.0
.rodata 98731 98731 0 0.0
.text 528156 528164 8 0.0
pump-app LP_CC2652R7 (read only) 651071 651079 8 0.0
(read/write) 151692 151692 0 0.0
.bss 73560 73560 0 0.0
.data 3252 3252 0 0.0
.rodata 75703 75703 0 0.0
.text 574880 574888 8 0.0
pump-controller-app LP_CC2652R7 (read only) 644139 644147 8 0.0
(read/write) 151440 151440 0 0.0
.bss 73600 73600 0 0.0
.data 3216 3216 0 0.0
.rodata 78835 78835 0 0.0
.text 564816 564824 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 623542 623542 0 0.0
.app_xip_area 526356 526356 0 0.0
.bss 79844 79844 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 618498 618506 8 0.0
.app_xip_area 522792 522800 8 0.0
.bss 78396 78396 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571134 571134 0 0.0
.app_xip_area 465840 465840 0 0.0
.bss 87688 87688 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907520 907520 0 0.0
(read/write) 134968 134968 0 0.0
.bss 132920 132920 0 0.0
.data 2044 2044 0 0.0
.text 907512 907512 0 0.0
BRD4161A+rpc (read only) 941936 941920 -16 -0.0
(read/write) 151648 151648 0 0.0
.bss 149400 149400 0 0.0
.data 2248 2248 0 0.0
.text 941928 941912 -16 -0.0
window-app BRD4161A (read only) 845008 845008 0 0.0
(read/write) 133056 133056 0 0.0
.bss 131096 131096 0 0.0
.data 1956 1956 0 0.0
.text 845000 845000 0 0.0
esp32 all-clusters-app c3devkit (read only) 999220 999282 62 0.0
(read/write) 1473730 1473730 0 0.0
.dram0.bss 68216 68224 8 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 206632 206632 0 0.0
.flash.text 999220 999282 62 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1053467 1053503 36 0.0
(read/write) 475720 475728 8 0.0
.dram0.bss 73736 73744 8 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 235980 235980 0 0.0
.flash.text 1048083 1048119 36 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 688808 688824 16 0.0
.bss 81168 81168 0 0.0
.data 2000 2000 0 0.0
.text 599840 599856 16 0.0
lock k32w061+release (read/write) 729676 729676 0 0.0
.bss 81576 81576 0 0.0
.data 1960 1960 0 0.0
.text 640340 640340 0 0.0
linux all-clusters-app debug (read only) 2734185 2734553 368 0.0
(read/write) 172864 172864 0 0.0
.bss 83168 83168 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 81624 81624 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 984 984 0 0.0
.rodata 233381 233669 288 0.1
.text 2325890 2325970 80 0.0
bridge-app debug+rpc (read only) 1847941 1848309 368 0.0
(read/write) 115248 115248 0 0.0
.bss 67368 67368 0 0.0
.data 3072 3072 0 0.0
.data.rel.ro 39704 39704 0 0.0
.dynamic 592 592 0 0.0
.got 3936 3936 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 149089 149345 256 0.2
.text 1579669 1579781 112 0.0
chip-tool debug (read only) 10944317 10944717 400 0.0
(read/write) 375760 375760 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 345768 345768 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 547349 547605 256 0.0
.text 9557061 9557205 144 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10555708 10556028 320 0.0
(read/write) 497681 497681 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 393088 393088 0 0.0
.dynamic 560 560 0 0.0
.got 58680 58680 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 521212 521340 128 0.0
.text 8916692 8916884 192 0.0
lighting-app debug+rpc (read only) 2325465 2326041 576 0.0
(read/write) 151280 151280 0 0.0
.bss 73248 73248 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70328 70328 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 183281 183537 256 0.1
.text 1975474 1975794 320 0.0
lock-app debug (read only) 2151977 2152345 368 0.0
(read/write) 143512 143512 0 0.0
.bss 71040 71040 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 65368 65368 0 0.0
.dynamic 592 592 0 0.0
.got 4280 4280 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 189601 189857 256 0.1
.text 1805186 1805298 112 0.0
ota-provider-app debug (read only) 2058537 2058857 320 0.0
(read/write) 138880 138880 0 0.0
.bss 71232 71232 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60216 60216 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 173723 174011 288 0.2
.text 1727378 1727410 32 0.0
ota-requestor-app debug (read only) 2089785 2090073 288 0.0
(read/write) 141688 141688 0 0.0
.bss 71904 71904 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62248 62248 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 170076 170332 256 0.2
.text 1760786 1760818 32 0.0
shell debug (read only) 2560649 2561065 416 0.0
(read/write) 196840 196840 0 0.0
.bss 113800 113800 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 75952 75952 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 215570 215858 288 0.1
.text 2183074 2183202 128 0.0
thermostat-no-ble arm64 (read only) 2367532 2367804 272 0.0
(read/write) 174401 174401 0 0.0
.bss 86145 86145 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 78992 78992 0 0.0
.dynamic 560 560 0 0.0
.got 4744 4744 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145308 145420 112 0.1
.text 1993024 1993184 160 0.0
tv-app debug (read only) 2843681 2844049 368 0.0
(read/write) 276592 276592 0 0.0
.bss 189176 189176 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76560 76560 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 215531 215787 256 0.1
.text 2445618 2445730 112 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411396 2411460 64 0.0
.bss 205716 205716 0 0.0
.data 5848 5848 0 0.0
.text 1373996 1374060 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177531 1177515 -16 -0.0
bss 141840 141840 0 0.0
rodata 150124 150124 0 0.0
text 806852 806840 -12 -0.0
p6 all-clusters-app default (read/write) 2526888 2526888 0 0.0
.bss 139096 139096 0 0.0
.data 2784 2784 0 0.0
.text 1485152 1485152 0 0.0
light-app default (read/write) 2418640 2418656 16 0.0
.bss 132576 132576 0 0.0
.data 2584 2584 0 0.0
.text 1376904 1376920 16 0.0
lock-app default (read/write) 2422832 2422832 0 0.0
.bss 132376 132376 0 0.0
.data 2544 2544 0 0.0
.text 1381096 1381096 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 807984 807976 -8 -0.0
bss 75272 75272 0 0.0
noinit 40416 40416 0 0.0
text 571680 571676 -4 -0.0

@github-actions
Copy link

github-actions bot commented Apr 25, 2022 •
edited
Loading

PR #17690: Size comparison from e4df559 to 448a637

Increases (3 builds for cyw30739, k32w, mbed)
platform target config section e4df559 448a637 change % change
cyw30739 lock cyw930739m2evb_01 (read/write) 618498 618506 8 0.0
.app_xip_area 522792 522800 8 0.0
k32w light k32w061+release (read/write) 688808 688824 16 0.0
.text 599840 599856 16 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2411396 2411460 64 0.0
.text 1373996 1374060 64 0.0
Decreases (2 builds for nrfconnect, telink)
platform target config section e4df559 448a637 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177531 1177515 -16 -0.0
text 806852 806840 -12 -0.0
telink lighting-app tlsr9518adk80d (read/write) 807984 807976 -8 -0.0
text 571680 571676 -4 -0.0
Full report (8 builds for cyw30739, k32w, mbed, nrfconnect, telink)
platform target config section e4df559 448a637 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 623542 623542 0 0.0
.app_xip_area 526356 526356 0 0.0
.bss 79844 79844 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 618498 618506 8 0.0
.app_xip_area 522792 522800 8 0.0
.bss 78396 78396 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571134 571134 0 0.0
.app_xip_area 465840 465840 0 0.0
.bss 87688 87688 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w light k32w061+release (read/write) 688808 688824 16 0.0
.bss 81168 81168 0 0.0
.data 2000 2000 0 0.0
.text 599840 599856 16 0.0
lock k32w061+release (read/write) 729676 729676 0 0.0
.bss 81576 81576 0 0.0
.data 1960 1960 0 0.0
.text 640340 640340 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411396 2411460 64 0.0
.bss 205716 205716 0 0.0
.data 5848 5848 0 0.0
.text 1373996 1374060 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177531 1177515 -16 -0.0
bss 141840 141840 0 0.0
rodata 150124 150124 0 0.0
text 806852 806840 -12 -0.0
telink lighting-app tlsr9518adk80d (read/write) 807984 807976 -8 -0.0
bss 75272 75272 0 0.0
noinit 40416 40416 0 0.0
text 571680 571676 -4 -0.0

bzbarsky-apple
bzbarsky-apple requested changes Apr 25, 2022
View reviewed changes
examples/shell/shell_common/cmd_server.cpp Outdated Show resolved Hide resolved
src/app/AttributePathExpandIterator.cpp Outdated Show resolved Hide resolved
src/app/clusters/descriptor/descriptor.cpp Outdated Show resolved Hide resolved
src/app/util/attribute-storage.cpp Show resolved Hide resolved
src/app/util/mock/attribute-storage.cpp Outdated Show resolved Hide resolved
src/lib/shell/streamer.cpp Outdated Show resolved Hide resolved
bzbarsky-apple
bzbarsky-apple approved these changes Apr 25, 2022
View reviewed changes
src/app/AttributePathExpandIterator.cpp Outdated Show resolved Hide resolved
@boring-cyborg boring-cyborg bot added the darwin label Apr 26, 2022
@andy31415 andy31415 mentioned this pull request Apr 26, 2022
Closed
@github-actions
Copy link

github-actions bot commented Apr 26, 2022 •
edited
Loading

PR #17690: Size comparison from 2057972 to 1a65e87

Increases (4 builds for cc13x2_26x2, cyw30739)
platform target config section 2057972 1a65e87 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 163676 163700 24 0.0
pump-app LP_CC2652R7 (read only) 661767 661775 8 0.0
.text 580872 580880 8 0.0
pump-controller-app LP_CC2652R7 (read/write) 189680 189696 16 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 621446 621454 8 0.0
.app_xip_area 525796 525804 8 0.0
Decreases (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 2057972 1a65e87 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 688363 688339 -24 -0.0
.text 586256 586232 -24 -0.0
pump-app LP_CC2652R7 (read/write) 182784 182776 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 654663 654647 -16 -0.0
.text 570744 570728 -16 -0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574234 574226 -8 -0.0
.app_xip_area 468940 468932 -8 -0.0
efr32 lighting-app BRD4161A+rpc (read only) 942192 942176 -16 -0.0
.text 942184 942168 -16 -0.0
window-app BRD4161A (read only) 845160 845144 -16 -0.0
.text 845152 845136 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 999482 999422 -60 -0.0
.flash.text 999482 999422 -60 -0.0
m5stack (read only) 1053791 1053711 -80 -0.0
.flash.text 1048407 1048327 -80 -0.0
k32w light k32w061+release (read/write) 688820 688804 -16 -0.0
.text 599908 599892 -16 -0.0
lock k32w061+release (read/write) 729712 729696 -16 -0.0
.text 640432 640416 -16 -0.0
linux all-clusters-app debug (read only) 2735249 2735185 -64 -0.0
.text 2326578 2326514 -64 -0.0
bridge-app debug+rpc (read only) 1891201 1891169 -32 -0.0
.text 1608850 1608818 -32 -0.0
chip-tool debug (read only) 8360045 8360029 -16 -0.0
.text 6825317 6825301 -16 -0.0
lighting-app debug+rpc (read only) 2326673 2326625 -48 -0.0
.text 1976370 1976322 -48 -0.0
lock-app debug (read only) 2207041 2207009 -32 -0.0
.text 1854882 1854850 -32 -0.0
ota-provider-app debug (read only) 2059761 2059729 -32 -0.0
.text 1728050 1728018 -32 -0.0
ota-requestor-app debug (read only) 2090993 2090961 -32 -0.0
.text 1761474 1761442 -32 -0.0
shell debug (read only) 2561081 2561001 -80 -0.0
.text 2183602 2183522 -80 -0.0
tv-app debug (read only) 2845177 2845145 -32 -0.0
.text 2446738 2446706 -32 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177475 1177459 -16 -0.0
text 806956 806936 -20 -0.0
p6 all-clusters-app default (read/write) 2527096 2527080 -16 -0.0
.text 1485360 1485344 -16 -0.0
lock-app default (read/write) 2423040 2423024 -16 -0.0
.text 1381304 1381288 -16 -0.0
telink lighting-app tlsr9518adk80d (read/write) 808020 808004 -16 -0.0
text 571792 571780 -12 -0.0
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 2057972 1a65e87 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 688363 688339 -24 -0.0
(read/write) 163676 163700 24 0.0
.bss 75020 75020 0 0.0
.data 3396 3396 0 0.0
.rodata 101627 101627 0 0.0
.text 586256 586232 -24 -0.0
lock-ftd LP_CC2652R7 (read only) 688923 688923 0 0.0
(read/write) 154428 154428 0 0.0
.bss 73388 73388 0 0.0
.data 3220 3220 0 0.0
.rodata 103219 103219 0 0.0
.text 585220 585220 0 0.0
lock-mtd LP_CC2652R7 (read only) 637675 637675 0 0.0
(read/write) 146188 146188 0 0.0
.bss 69108 69108 0 0.0
.data 3220 3220 0 0.0
.rodata 103099 103099 0 0.0
.text 534084 534084 0 0.0
pump-app LP_CC2652R7 (read only) 661767 661775 8 0.0
(read/write) 182784 182776 -8 -0.0
.bss 73564 73564 0 0.0
.data 3252 3252 0 0.0
.rodata 80415 80415 0 0.0
.text 580872 580880 8 0.0
pump-controller-app LP_CC2652R7 (read only) 654663 654647 -16 -0.0
(read/write) 189680 189696 16 0.0
.bss 73612 73612 0 0.0
.data 3216 3216 0 0.0
.rodata 83439 83439 0 0.0
.text 570744 570728 -16 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 626910 626910 0 0.0
.app_xip_area 529788 529788 0 0.0
.bss 79780 79780 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 621446 621454 8 0.0
.app_xip_area 525796 525804 8 0.0
.bss 78340 78340 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574234 574226 -8 -0.0
.app_xip_area 468940 468932 -8 -0.0
.bss 87688 87688 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907776 907776 0 0.0
(read/write) 134912 134912 0 0.0
.bss 132864 132864 0 0.0
.data 2044 2044 0 0.0
.text 907768 907768 0 0.0
BRD4161A+rpc (read only) 942192 942176 -16 -0.0
(read/write) 151592 151592 0 0.0
.bss 149344 149344 0 0.0
.data 2248 2248 0 0.0
.text 942184 942168 -16 -0.0
window-app BRD4161A (read only) 845160 845144 -16 -0.0
(read/write) 133000 133000 0 0.0
.bss 131040 131040 0 0.0
.data 1956 1956 0 0.0
.text 845152 845136 -16 -0.0
esp32 all-clusters-app c3devkit (read only) 999482 999422 -60 -0.0
(read/write) 1473666 1473666 0 0.0
.dram0.bss 68176 68176 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 206616 206616 0 0.0
.flash.text 999482 999422 -60 -0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1053791 1053711 -80 -0.0
(read/write) 475656 475656 0 0.0
.dram0.bss 73696 73696 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 235956 235956 0 0.0
.flash.text 1048407 1048327 -80 -0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 688820 688804 -16 -0.0
.bss 81112 81112 0 0.0
.data 2000 2000 0 0.0
.text 599908 599892 -16 -0.0
lock k32w061+release (read/write) 729712 729696 -16 -0.0
.bss 81520 81520 0 0.0
.data 1960 1960 0 0.0
.text 640432 640416 -16 -0.0
linux all-clusters-app debug (read only) 2735249 2735185 -64 -0.0
(read/write) 172872 172872 0 0.0
.bss 83168 83168 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 81640 81640 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 992 992 0 0.0
.rodata 233829 233829 0 0.0
.text 2326578 2326514 -64 -0.0
bridge-app debug+rpc (read only) 1891201 1891169 -32 -0.0
(read/write) 120304 120304 0 0.0
.bss 71168 71168 0 0.0
.data 3424 3424 0 0.0
.data.rel.ro 40392 40392 0 0.0
.dynamic 592 592 0 0.0
.got 4032 4032 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 159569 159569 0 0.0
.text 1608850 1608818 -32 -0.0
chip-tool debug (read only) 8360045 8360029 -16 -0.0
(read/write) 472720 472720 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 442728 442728 0 0.0
.dynamic 624 624 0 0.0
.got 4952 4952 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 452949 452949 0 0.0
.text 6825317 6825301 -16 -0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 8221852 8221852 0 0.0
(read/write) 537761 537761 0 0.0
.bss 40897 40897 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 477776 477776 0 0.0
.dynamic 560 560 0 0.0
.got 14080 14080 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 419388 419388 0 0.0
.text 6588436 6588436 0 0.0
lighting-app debug+rpc (read only) 2326673 2326625 -48 -0.0
(read/write) 151256 151256 0 0.0
.bss 73216 73216 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70328 70328 0 0.0
.dynamic 608 608 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 183665 183665 0 0.0
.text 1976370 1976322 -48 -0.0
lock-app debug (read only) 2207041 2207009 -32 -0.0
(read/write) 145640 145640 0 0.0
.bss 71808 71808 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 66664 66664 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 192161 192161 0 0.0
.text 1854882 1854850 -32 -0.0
ota-provider-app debug (read only) 2059761 2059729 -32 -0.0
(read/write) 138888 138888 0 0.0
.bss 71232 71232 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60216 60216 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 174203 174203 0 0.0
.text 1728050 1728018 -32 -0.0
ota-requestor-app debug (read only) 2090993 2090961 -32 -0.0
(read/write) 141696 141696 0 0.0
.bss 71872 71872 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62264 62264 0 0.0
.dynamic 592 592 0 0.0
.got 4320 4320 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 170524 170524 0 0.0
.text 1761474 1761442 -32 -0.0
shell debug (read only) 2561081 2561001 -80 -0.0
(read/write) 196840 196840 0 0.0
.bss 113768 113768 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 75992 75992 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 215570 215570 0 0.0
.text 2183602 2183522 -80 -0.0
thermostat-no-ble arm64 (read only) 2368284 2368284 0 0.0
(read/write) 174369 174369 0 0.0
.bss 86097 86097 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 79008 79008 0 0.0
.dynamic 560 560 0 0.0
.got 4744 4744 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145500 145500 0 0.0
.text 1993680 1993680 0 0.0
tv-app debug (read only) 2845177 2845145 -32 -0.0
(read/write) 276536 276536 0 0.0
.bss 189112 189112 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76568 76568 0 0.0
.dynamic 592 592 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 215979 215979 0 0.0
.text 2446738 2446706 -32 -0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2411676 2411676 0 0.0
.bss 205660 205660 0 0.0
.data 5848 5848 0 0.0
.text 1374276 1374276 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1177475 1177459 -16 -0.0
bss 141784 141784 0 0.0
rodata 150100 150100 0 0.0
text 806956 806936 -20 -0.0
p6 all-clusters-app default (read/write) 2527096 2527080 -16 -0.0
.bss 139040 139040 0 0.0
.data 2784 2784 0 0.0
.text 1485360 1485344 -16 -0.0
light-app default (read/write) 2418848 2418848 0 0.0
.bss 132520 132520 0 0.0
.data 2584 2584 0 0.0
.text 1377112 1377112 0 0.0
lock-app default (read/write) 2423040 2423024 -16 -0.0
.bss 132320 132320 0 0.0
.data 2544 2544 0 0.0
.text 1381304 1381288 -16 -0.0
telink lighting-app tlsr9518adk80d (read/write) 808020 808004 -16 -0.0
bss 75216 75216 0 0.0
noinit 40416 40416 0 0.0
text 571792 571780 -12 -0.0

@andy31415 andy31415 merged commit 6c54ab8 into project-chip:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@emargolis emargolis emargolis approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app darwin examples lib review - approved setup payload transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andy31415 @emargolis @bzbarsky-apple @Damian-Nordic