-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that read attribute paths are valid paths. #17664
Ensure that read attribute paths are valid paths. #17664
Conversation
PR #17664: Size comparison from c6a0447 to e84b275 Increases (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (2 builds for cc13x2_26x2)
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
e84b275
to
e140ff7
Compare
PR #17664: Size comparison from c6a0447 to e140ff7 Increases (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (2 builds for cc13x2_26x2)
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
e140ff7
to
0f37b78
Compare
PR #17664: Size comparison from 0cbfaec to 0f37b78 Increases (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (2 builds for cc13x2_26x2)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
0f37b78
to
990a0b7
Compare
PR #17664: Size comparison from 0cbfaec to 990a0b7 Increases (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
Decreases (2 builds for cc13x2_26x2)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
|
990a0b7
to
a9812a3
Compare
PR #17664: Size comparison from 077e44e to a9812a3 Increases (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
Decreases (2 builds for cc13x2_26x2)
Full report (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
|
a9812a3
to
c697312
Compare
PR #17664: Size comparison from 252314f to c697312 Increases (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (2 builds for cc13x2_26x2)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
c697312
to
cb8ad0a
Compare
PR #17664: Size comparison from 8f45a9e to cb8ad0a Increases (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
Decreases (2 builds for cc13x2_26x2)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
|
/rebase |
Disallow out-of-range attribute ids and wildcard cluster with non-wildcard non-global attribute. Fixes project-chip#14026
cb8ad0a
to
76e44cc
Compare
PR #17664: Size comparison from 923b996 to 76e44cc Increases (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (2 builds for cc13x2_26x2)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Disallow out-of-range attribute ids and wildcard cluster with
non-wildcard non-global attribute.
Fixes #14026
Spec changes that clarify the behavior are at https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/5127
Problem
Not following the spec in terms of handling invalid paths during a read.
Change overview
Implement the spec behavior.
Testing
Manually tested the error cases with chip-tool and verified that we now return the right errors (i.e. an overall INVALID_ACTION, instead of per-path UNSUPPORTED_ATTRIBUTE/CLUSTER).