-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up a network commissioning cluster in linux lock-app. #17663
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:lock-app-linux-network-commissioning
Apr 25, 2022
Merged
Set up a network commissioning cluster in linux lock-app. #17663
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:lock-app-linux-network-commissioning
Apr 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt and
mspang
April 23, 2022 03:51
pullapprove
bot
requested review from
mlepage-google,
msandstedt,
mspang,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
April 23, 2022 03:51
If we have thread or wifi, use them to set up a network commissioning cluster.
bzbarsky-apple
force-pushed
the
lock-app-linux-network-commissioning
branch
from
April 23, 2022 04:07
08c3310
to
7b85639
Compare
PR #17663: Size comparison from c6a0447 to 7b85639 Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
reviewed
Apr 25, 2022
andy31415
approved these changes
Apr 25, 2022
lazarkov
approved these changes
Apr 25, 2022
LuDuda
approved these changes
Apr 25, 2022
jmartinez-silabs
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have thread or wifi, use them to set up a network commissioning
cluster.
Problem
Linux lock-app does not support any sort of commissioning other than onnetwork.
Change overview
Use Thread if compiled with that. If not, use Wi-Fi if compiled with that.
Testing
Going to find someone who can test this on a Raspberry Pi.