Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SimpleSessionResumptionStorage Save/Load index #17581

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Apr 21, 2022

Problem

Fixes #17438

Change overview

  • Fix SimpleSessionResumptionStorage::SaveIndex and LoadIndex
  • Added unit tests for it

Testing

Added unit-tests for the error case

@github-actions
Copy link

github-actions bot commented Apr 21, 2022

PR #17581: Size comparison from 4b4e035 to 3e4e54b

Increases (17 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, telink)
platform target config section 4b4e035 3e4e54b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691027 691163 136 0.0
.text 584504 584640 136 0.0
lock-ftd LP_CC2652R7 (read only) 677383 677519 136 0.0
.text 578092 578228 136 0.0
lock-mtd LP_CC2652R7 (read only) 626127 626263 136 0.0
.text 526948 527084 136 0.0
pump-app LP_CC2652R7 (read only) 649187 649323 136 0.0
.text 573320 573456 136 0.0
pump-controller-app LP_CC2652R7 (read only) 642191 642327 136 0.0
.text 563192 563328 136 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618170 618306 136 0.0
.app_xip_area 525176 525312 136 0.0
lock cyw930739m2evb_01 (read/write) 613118 613254 136 0.0
.app_xip_area 521604 521740 136 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565746 565882 136 0.0
.app_xip_area 464644 464780 136 0.0
esp32 all-clusters-app c3devkit (read only) 985210 985338 128 0.0
.flash.text 985210 985338 128 0.0
m5stack (read only) 1040491 1040587 96 0.0
.flash.text 1035107 1035203 96 0.0
k32w light k32w061+release (read/write) 684172 684300 128 0.0
.text 598716 598844 128 0.0
lock k32w061+release (read/write) 725256 725384 128 0.0
.text 639208 639336 128 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10530812 10530860 48 0.0
.text 8894788 8894836 48 0.0
thermostat-no-ble arm64 (read only) 2362060 2362108 48 0.0
.text 1987712 1987760 48 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2410132 2410260 128 0.0
.text 1372732 1372860 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1170635 1170779 144 0.0
text 805648 805784 136 0.0
telink lighting-app tlsr9518adk80d (read/write) 801096 801232 136 0.0
text 570414 570550 136 0.0
Decreases (2 builds for cc13x2_26x2)
platform target config section 4b4e035 3e4e54b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161900 161764 -136 -0.1
lock-ftd LP_CC2652R7 (read/write) 166512 166376 -136 -0.1
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4b4e035 3e4e54b change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691027 691163 136 0.0
(read/write) 161900 161764 -136 -0.1
.bss 75912 75912 0 0.0
.data 3396 3396 0 0.0
.rodata 106043 106043 0 0.0
.text 584504 584640 136 0.0
lock-ftd LP_CC2652R7 (read only) 677383 677519 136 0.0
(read/write) 166512 166376 -136 -0.1
.bss 73936 73936 0 0.0
.data 3220 3220 0 0.0
.rodata 98807 98807 0 0.0
.text 578092 578228 136 0.0
lock-mtd LP_CC2652R7 (read only) 626127 626263 136 0.0
(read/write) 146732 146732 0 0.0
.bss 69656 69656 0 0.0
.data 3220 3220 0 0.0
.rodata 98687 98687 0 0.0
.text 526948 527084 136 0.0
pump-app LP_CC2652R7 (read only) 649187 649323 136 0.0
(read/write) 152500 152500 0 0.0
.bss 74368 74368 0 0.0
.data 3252 3252 0 0.0
.rodata 75379 75379 0 0.0
.text 573320 573456 136 0.0
pump-controller-app LP_CC2652R7 (read only) 642191 642327 136 0.0
(read/write) 151912 151912 0 0.0
.bss 74072 74072 0 0.0
.data 3216 3216 0 0.0
.rodata 78511 78511 0 0.0
.text 563192 563328 136 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618170 618306 136 0.0
.app_xip_area 525176 525312 136 0.0
.bss 75652 75652 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 613118 613254 136 0.0
.app_xip_area 521604 521740 136 0.0
.bss 74204 74204 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565746 565882 136 0.0
.app_xip_area 464644 464780 136 0.0
.bss 83496 83496 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 905944 905944 0 0.0
(read/write) 129384 129384 0 0.0
.bss 127336 127336 0 0.0
.data 2044 2044 0 0.0
.text 905936 905936 0 0.0
BRD4161A+rpc (read only) 940344 940344 0 0.0
(read/write) 146064 146064 0 0.0
.bss 143816 143816 0 0.0
.data 2248 2248 0 0.0
.text 940336 940336 0 0.0
window-app BRD4161A (read only) 843432 843432 0 0.0
(read/write) 127472 127472 0 0.0
.bss 125512 125512 0 0.0
.data 1956 1956 0 0.0
.text 843424 843424 0 0.0
esp32 all-clusters-app c3devkit (read only) 985210 985338 128 0.0
(read/write) 1465954 1465954 0 0.0
.dram0.bss 62376 62376 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 204696 204696 0 0.0
.flash.text 985210 985338 128 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1040491 1040587 96 0.0
(read/write) 468112 468112 0 0.0
.dram0.bss 67896 67896 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 234212 234212 0 0.0
.flash.text 1035107 1035203 96 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684172 684300 128 0.0
.bss 77656 77656 0 0.0
.data 2000 2000 0 0.0
.text 598716 598844 128 0.0
lock k32w061+release (read/write) 725256 725384 128 0.0
.bss 78288 78288 0 0.0
.data 1960 1960 0 0.0
.text 639208 639336 128 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10530812 10530860 48 0.0
(read/write) 496897 496897 0 0.0
.bss 40865 40865 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 392424 392424 0 0.0
.dynamic 560 560 0 0.0
.got 58608 58608 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 519948 519948 0 0.0
.text 8894788 8894836 48 0.0
thermostat-no-ble arm64 (read only) 2362060 2362108 48 0.0
(read/write) 151185 151185 0 0.0
.bss 62897 62897 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 79040 79040 0 0.0
.dynamic 560 560 0 0.0
.got 4744 4744 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145164 145164 0 0.0
.text 1987712 1987760 48 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2410132 2410260 128 0.0
.bss 184996 184996 0 0.0
.data 5848 5848 0 0.0
.text 1372732 1372860 128 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1170635 1170779 144 0.0
bss 136264 136264 0 0.0
rodata 150076 150076 0 0.0
text 805648 805784 136 0.0
p6 all-clusters-app default (read/write) 2524680 2524680 0 0.0
.bss 118368 118368 0 0.0
.data 2784 2784 0 0.0
.text 1482944 1482944 0 0.0
light-app default (read/write) 2416416 2416416 0 0.0
.bss 111848 111848 0 0.0
.data 2584 2584 0 0.0
.text 1374680 1374680 0 0.0
lock-app default (read/write) 2420616 2420616 0 0.0
.bss 111648 111648 0 0.0
.data 2544 2544 0 0.0
.text 1378880 1378880 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 801096 801232 136 0.0
bss 69696 69696 0 0.0
noinit 40416 40416 0 0.0
text 570414 570550 136 0.0

@andy31415 andy31415 merged commit 1e3dd0e into project-chip:master Apr 21, 2022
@kghost kghost deleted the pairing-4 branch April 22, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CASE: SimpleSessionResumptionStorage cannot save and cannot load
3 participants