Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code in matter IDL for responses #17561

Merged
merged 3 commits into from
Apr 21, 2022

Conversation

andy31415
Copy link
Contributor

Problem

Based on the spec, response structures are technically command invocations and they have an associated code (that is part of the response encoding)

Change overview

Add support for having response structs contain a 'code' associated with them.

Testing

Unit tests updated.

@github-actions
Copy link

github-actions bot commented Apr 20, 2022

PR #17561: Size comparison from 20dc31f to 470c330

Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 20dc31f 470c330 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 691147 691147 0 0.0
(read/write) 161780 161780 0 0.0
.bss 75912 75912 0 0.0
.data 3396 3396 0 0.0
.rodata 106163 106163 0 0.0
.text 584504 584504 0 0.0
lock-ftd LP_CC2652R7 (read only) 677587 677587 0 0.0
(read/write) 166308 166308 0 0.0
.bss 73936 73936 0 0.0
.data 3220 3220 0 0.0
.rodata 99011 99011 0 0.0
.text 578092 578092 0 0.0
lock-mtd LP_CC2652R7 (read only) 626331 626331 0 0.0
(read/write) 146732 146732 0 0.0
.bss 69656 69656 0 0.0
.data 3220 3220 0 0.0
.rodata 98891 98891 0 0.0
.text 526948 526948 0 0.0
pump-app LP_CC2652R7 (read only) 649339 649339 0 0.0
(read/write) 152500 152500 0 0.0
.bss 74368 74368 0 0.0
.data 3252 3252 0 0.0
.rodata 75531 75531 0 0.0
.text 573320 573320 0 0.0
pump-controller-app LP_CC2652R7 (read only) 642395 642395 0 0.0
(read/write) 151912 151912 0 0.0
.bss 74072 74072 0 0.0
.data 3216 3216 0 0.0
.rodata 78715 78715 0 0.0
.text 563192 563192 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618266 618266 0 0.0
.app_xip_area 525272 525272 0 0.0
.bss 75652 75652 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 613230 613230 0 0.0
.app_xip_area 521716 521716 0 0.0
.bss 74204 74204 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565770 565770 0 0.0
.app_xip_area 464668 464668 0 0.0
.bss 83496 83496 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 906156 906156 0 0.0
(read/write) 128660 128660 0 0.0
.bss 126616 126616 0 0.0
.data 2044 2044 0 0.0
.text 906148 906148 0 0.0
BRD4161A+rpc (read only) 940548 940548 0 0.0
(read/write) 145344 145344 0 0.0
.bss 143096 143096 0 0.0
.data 2248 2248 0 0.0
.text 940540 940540 0 0.0
window-app BRD4161A (read only) 843612 843612 0 0.0
(read/write) 126748 126748 0 0.0
.bss 124792 124792 0 0.0
.data 1956 1956 0 0.0
.text 843604 843604 0 0.0
esp32 all-clusters-app c3devkit (read only) 985210 985210 0 0.0
(read/write) 1466170 1466170 0 0.0
.dram0.bss 62376 62376 0 0.0
.dram0.data 14428 14428 0 0.0
.flash.rodata 204912 204912 0 0.0
.flash.text 985210 985210 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1040491 1040491 0 0.0
(read/write) 468336 468336 0 0.0
.dram0.bss 67896 67896 0 0.0
.dram0.data 34168 34168 0 0.0
.flash.rodata 234436 234436 0 0.0
.flash.text 1035107 1035107 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684184 684184 0 0.0
.bss 77656 77656 0 0.0
.data 2000 2000 0 0.0
.text 598728 598728 0 0.0
lock k32w061+release (read/write) 725360 725360 0 0.0
.bss 78288 78288 0 0.0
.data 1960 1960 0 0.0
.text 639312 639312 0 0.0
linux all-clusters-app debug (read only) 2728713 2728713 0 0.0
(read/write) 149664 149664 0 0.0
.bss 59936 59936 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 81672 81672 0 0.0
.dynamic 608 608 0 0.0
.got 4448 4448 0 0.0
.init 27 27 0 0.0
.init_array 984 984 0 0.0
.rodata 233221 233221 0 0.0
.text 2320626 2320626 0 0.0
bridge-app debug+rpc (read only) 1842637 1842637 0 0.0
(read/write) 92016 92016 0 0.0
.bss 44136 44136 0 0.0
.data 3072 3072 0 0.0
.data.rel.ro 39744 39744 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 148961 148961 0 0.0
.text 1574533 1574533 0 0.0
chip-tool debug (read only) 10916205 10916205 0 0.0
(read/write) 375120 375120 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 345152 345152 0 0.0
.dynamic 624 624 0 0.0
.got 4936 4936 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 546005 546005 0 0.0
.text 9531797 9531797 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10530764 10530764 0 0.0
(read/write) 496897 496897 0 0.0
.bss 40865 40865 0 0.0
.data 1192 1192 0 0.0
.data.rel.ro 392424 392424 0 0.0
.dynamic 560 560 0 0.0
.got 58608 58608 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 519948 519948 0 0.0
.text 8894740 8894740 0 0.0
lighting-app debug+rpc (read only) 2320089 2320089 0 0.0
(read/write) 128080 128080 0 0.0
.bss 50016 50016 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 70360 70360 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 183121 183121 0 0.0
.text 1970306 1970306 0 0.0
lock-app debug (read only) 2146585 2146585 0 0.0
(read/write) 120312 120312 0 0.0
.bss 47808 47808 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 65416 65416 0 0.0
.dynamic 592 592 0 0.0
.got 4264 4264 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 189473 189473 0 0.0
.text 1799970 1799970 0 0.0
ota-provider-app debug (read only) 2053241 2053241 0 0.0
(read/write) 115680 115680 0 0.0
.bss 48000 48000 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 608 608 0 0.0
.got 4464 4464 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 173627 173627 0 0.0
.text 1722226 1722226 0 0.0
ota-requestor-app debug (read only) 2084425 2084425 0 0.0
(read/write) 118488 118488 0 0.0
.bss 48672 48672 0 0.0
.data 1928 1928 0 0.0
.data.rel.ro 62296 62296 0 0.0
.dynamic 592 592 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 169916 169916 0 0.0
.text 1755634 1755634 0 0.0
shell debug (read only) 2555289 2555289 0 0.0
(read/write) 150408 150408 0 0.0
.bss 67336 67336 0 0.0
.data 1360 1360 0 0.0
.data.rel.ro 76000 76000 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 215442 215442 0 0.0
.text 2177890 2177890 0 0.0
thermostat-no-ble arm64 (read only) 2362044 2362044 0 0.0
(read/write) 151185 151185 0 0.0
.bss 62897 62897 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 79040 79040 0 0.0
.dynamic 560 560 0 0.0
.got 4744 4744 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145180 145180 0 0.0
.text 1987680 1987680 0 0.0
tv-app debug (read only) 2839073 2839073 0 0.0
(read/write) 253392 253392 0 0.0
.bss 165944 165944 0 0.0
.data 4640 4640 0 0.0
.data.rel.ro 76600 76600 0 0.0
.dynamic 592 592 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 215371 215371 0 0.0
.text 2441170 2441170 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2410308 2410308 0 0.0
.bss 184996 184996 0 0.0
.data 5848 5848 0 0.0
.text 1372908 1372908 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1170879 1170879 0 0.0
bss 136264 136264 0 0.0
rodata 150320 150320 0 0.0
text 805648 805648 0 0.0
p6 all-clusters-app default (read/write) 2524888 2524888 0 0.0
.bss 118368 118368 0 0.0
.data 2784 2784 0 0.0
.text 1483152 1483152 0 0.0
light-app default (read/write) 2416608 2416608 0 0.0
.bss 111848 111848 0 0.0
.data 2584 2584 0 0.0
.text 1374872 1374872 0 0.0
lock-app default (read/write) 2420792 2420792 0 0.0
.bss 111648 111648 0 0.0
.data 2544 2544 0 0.0
.text 1379056 1379056 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 801272 801272 0 0.0
bss 69696 69696 0 0.0
noinit 40416 40416 0 0.0
text 570414 570414 0 0.0

@bzbarsky-apple bzbarsky-apple changed the title Add code in matter ID for responses Add code in matter IDL for responses Apr 20, 2022
@Damian-Nordic Damian-Nordic merged commit 99becaa into project-chip:master Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants