Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[System] Rename SystemLayer to Make abstraction of IP Lib #17554

Merged

Conversation

jepenven-silabs
Copy link
Contributor

Problem

The event loop for FreeRTOS LwIP/OpenThread implementation bear the name LwIP while having only a single line of code specific to the LwIP stack. This is misleading.

Change overview

Rename src/system/SystemLayerImplLwIP.cpp -> src/system/SystemLayerImplFreeRTOS.cpp

Testing

Simple renaming operation. Validated with Unit Test.

@github-actions
Copy link

github-actions bot commented Apr 20, 2022

PR #17554: Size comparison from 66333a9 to 5048b84

Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 66333a9 5048b84 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 684595 684595 0 0.0
(read/write) 168308 168308 0 0.0
.bss 75888 75888 0 0.0
.data 3380 3380 0 0.0
.rodata 103323 103323 0 0.0
.text 580792 580792 0 0.0
lock-ftd LP_CC2652R7 (read only) 676947 676947 0 0.0
(read/write) 166924 166924 0 0.0
.bss 73912 73912 0 0.0
.data 3212 3212 0 0.0
.rodata 99027 99027 0 0.0
.text 577436 577436 0 0.0
lock-mtd LP_CC2652R7 (read only) 625691 625691 0 0.0
(read/write) 146700 146700 0 0.0
.bss 69632 69632 0 0.0
.data 3212 3212 0 0.0
.rodata 98907 98907 0 0.0
.text 526292 526292 0 0.0
pump-app LP_CC2652R7 (read only) 648715 648715 0 0.0
(read/write) 152212 152212 0 0.0
.bss 74344 74344 0 0.0
.data 3244 3244 0 0.0
.rodata 75491 75491 0 0.0
.text 572736 572736 0 0.0
pump-controller-app LP_CC2652R7 (read only) 642019 642019 0 0.0
(read/write) 151880 151880 0 0.0
.bss 74048 74048 0 0.0
.data 3208 3208 0 0.0
.rodata 78771 78771 0 0.0
.text 562760 562760 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 617842 617842 0 0.0
.app_xip_area 524880 524880 0 0.0
.bss 75628 75628 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 612534 612534 0 0.0
.app_xip_area 521052 521052 0 0.0
.bss 74180 74180 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565322 565322 0 0.0
.app_xip_area 464252 464252 0 0.0
.bss 83472 83472 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 905540 905540 0 0.0
(read/write) 128628 128628 0 0.0
.bss 126592 126592 0 0.0
.data 2036 2036 0 0.0
.text 905532 905532 0 0.0
BRD4161A+rpc (read only) 939900 939900 0 0.0
(read/write) 145312 145312 0 0.0
.bss 143072 143072 0 0.0
.data 2240 2240 0 0.0
.text 939892 939892 0 0.0
window-app BRD4161A (read only) 842996 842996 0 0.0
(read/write) 126712 126712 0 0.0
.bss 124768 124768 0 0.0
.data 1944 1944 0 0.0
.text 842988 842988 0 0.0
esp32 all-clusters-app c3devkit (read only) 980922 980922 0 0.0
(read/write) 1397714 1397714 0 0.0
.dram0.bss 62352 62352 0 0.0
.dram0.data 14412 14412 0 0.0
.flash.rodata 202040 202040 0 0.0
.flash.text 980922 980922 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1036355 1036355 0 0.0
(read/write) 465456 465456 0 0.0
.dram0.bss 67872 67872 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 231596 231596 0 0.0
.flash.text 1030971 1030971 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 683720 683720 0 0.0
.bss 77632 77632 0 0.0
.data 1992 1992 0 0.0
.text 598296 598296 0 0.0
lock k32w061+release (read/write) 724704 724704 0 0.0
.bss 78264 78264 0 0.0
.data 1952 1952 0 0.0
.text 638688 638688 0 0.0
linux all-clusters-app debug (read only) 2706137 2706137 0 0.0
(read/write) 149536 149536 0 0.0
.bss 59872 59872 0 0.0
.data 1920 1920 0 0.0
.data.rel.ro 81672 81672 0 0.0
.dynamic 608 608 0 0.0
.got 4448 4448 0 0.0
.init 27 27 0 0.0
.init_array 984 984 0 0.0
.rodata 233349 233349 0 0.0
.text 2297922 2297922 0 0.0
bridge-app debug+rpc (read only) 1839053 1839053 0 0.0
(read/write) 91856 91856 0 0.0
.bss 44136 44136 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 39744 39744 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 149089 149089 0 0.0
.text 1570821 1570821 0 0.0
chip-tool debug (read only) 10878005 10878005 0 0.0
(read/write) 374192 374192 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 344232 344232 0 0.0
.dynamic 624 624 0 0.0
.got 4936 4936 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 545933 545933 0 0.0
.text 9496357 9496357 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10495100 10495100 0 0.0
(read/write) 495713 495713 0 0.0
.bss 40865 40865 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 391400 391400 0 0.0
.dynamic 560 560 0 0.0
.got 58464 58464 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 519596 519596 0 0.0
.text 8862644 8862644 0 0.0
lighting-app debug+rpc (read only) 2316233 2316233 0 0.0
(read/write) 127952 127952 0 0.0
.bss 49920 49920 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 70360 70360 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 183249 183249 0 0.0
.text 1966322 1966322 0 0.0
lock-app debug (read only) 2139897 2139897 0 0.0
(read/write) 120216 120216 0 0.0
.bss 47744 47744 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 65416 65416 0 0.0
.dynamic 592 592 0 0.0
.got 4248 4248 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 189633 189633 0 0.0
.text 1793298 1793298 0 0.0
ota-provider-app debug (read only) 2049145 2049145 0 0.0
(read/write) 115584 115584 0 0.0
.bss 47936 47936 0 0.0
.data 1640 1640 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 608 608 0 0.0
.got 4448 4448 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 173595 173595 0 0.0
.text 1718338 1718338 0 0.0
ota-requestor-app debug (read only) 2080025 2080025 0 0.0
(read/write) 118392 118392 0 0.0
.bss 48608 48608 0 0.0
.data 1896 1896 0 0.0
.data.rel.ro 62296 62296 0 0.0
.dynamic 592 592 0 0.0
.got 4288 4288 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 169980 169980 0 0.0
.text 1751346 1751346 0 0.0
shell debug (read only) 2533065 2533065 0 0.0
(read/write) 150280 150280 0 0.0
.bss 67272 67272 0 0.0
.data 1296 1296 0 0.0
.data.rel.ro 76000 76000 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 215442 215442 0 0.0
.text 2155666 2155666 0 0.0
thermostat-no-ble arm64 (read only) 2358260 2358260 0 0.0
(read/write) 151073 151073 0 0.0
.bss 62849 62849 0 0.0
.data 1440 1440 0 0.0
.data.rel.ro 79040 79040 0 0.0
.dynamic 560 560 0 0.0
.got 4728 4728 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145156 145156 0 0.0
.text 1983968 1983968 0 0.0
tv-app debug (read only) 2833705 2833705 0 0.0
(read/write) 253104 253104 0 0.0
.bss 165880 165880 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 76568 76568 0 0.0
.dynamic 592 592 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 215371 215371 0 0.0
.text 2435922 2435922 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2409748 2409748 0 0.0
.bss 184972 184972 0 0.0
.data 5840 5840 0 0.0
.text 1372348 1372348 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1164331 1164331 0 0.0
bss 136240 136240 0 0.0
rodata 147484 147484 0 0.0
text 801948 801948 0 0.0
p6 all-clusters-app default (read/write) 2517448 2517448 0 0.0
.bss 118344 118344 0 0.0
.data 2768 2768 0 0.0
.text 1475712 1475712 0 0.0
light-app default (read/write) 2416120 2416120 0 0.0
.bss 111824 111824 0 0.0
.data 2576 2576 0 0.0
.text 1374384 1374384 0 0.0
lock-app default (read/write) 2420024 2420024 0 0.0
.bss 111624 111624 0 0.0
.data 2536 2536 0 0.0
.text 1378288 1378288 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800756 800756 0 0.0
bss 69672 69672 0 0.0
noinit 40416 40416 0 0.0
text 569896 569896 0 0.0

@mspang mspang merged commit b686463 into project-chip:master Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants