-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[System] Rename SystemLayer to Make abstraction of IP Lib #17554
Merged
mspang
merged 1 commit into
project-chip:master
from
jepenven-silabs:rename_event_loop_freertos
Apr 20, 2022
Merged
[System] Rename SystemLayer to Make abstraction of IP Lib #17554
mspang
merged 1 commit into
project-chip:master
from
jepenven-silabs:rename_event_loop_freertos
Apr 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing and
franck-apple
April 20, 2022 13:34
pullapprove
bot
requested review from
mrjerryjohns,
selissia,
msandstedt,
tecimovic,
mspang,
vijs,
vivien-apple,
sagar-apple,
wbschiller,
saurabhst,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
April 20, 2022 13:34
PR #17554: Size comparison from 66333a9 to 5048b84 Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Apr 20, 2022
jmartinez-silabs
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The event loop for FreeRTOS LwIP/OpenThread implementation bear the name LwIP while having only a single line of code specific to the LwIP stack. This is misleading.
Change overview
Rename src/system/SystemLayerImplLwIP.cpp -> src/system/SystemLayerImplFreeRTOS.cpp
Testing
Simple renaming operation. Validated with Unit Test.