Stop using PRI*16 and %zu format specifiers #17502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
andy31415
reviewed
Apr 19, 2022
andy31415
reviewed
Apr 19, 2022
|
PR #17502: Size comparison from 8793870 to 5d0b953 Increases (6 builds for cc13x2_26x2, efr32, linux)
Decreases (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Apr 19, 2022
|
It seems that I still have some issues from my last commit, I'll fix them |
andrei-menzopol
force-pushed
the
format-specifiers
branch
from
27122f1 to
c6cecc2
Compare
Some libcs don't support them, use %u/%d/%x instead * Commit generated by running the following git-extras commands: git sed -f g '" PRIu16 "' 'u' git sed -f g '" PRIu16' 'u"' git sed -f g '" PRIx16 "' 'x' git sed -f g '" PRIx16' 'x"' git sed -f g '" PRIX16 "' 'X' git sed -f g '" PRIX16' 'X"' git sed -f g '" PRId16 "' 'd' git sed -f g '" PRId16' 'd"' git sed -f g '%zu' '%u' * Cast some %zu parameters due to warnings * Add lint rules * Run restyle Signed-off-by: Andrei Menzopol <[email protected]>
Signed-off-by: Andrei Menzopol <[email protected]>
Signed-off-by: Andrei Menzopol <[email protected]>
andrei-menzopol
force-pushed
the
format-specifiers
branch
from
c6cecc2 to
6b6455b
Compare
Signed-off-by: Andrei Menzopol <[email protected]>
|
PR #17502: Size comparison from 03ea72d to 095801d Increases (10 builds for cc13x2_26x2, efr32, linux)
Decreases (40 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (43 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
I think eveything is ok now |
tcarmelveilleux
approved these changes
Apr 20, 2022
bzbarsky-apple
approved these changes
Apr 20, 2022
| VerifyOrDieWithMsg(mPendingWork == 0, DataManagement, "CommandHandler::Close() called with %zu unfinished async work items", | ||
| mPendingWork); | ||
| VerifyOrDieWithMsg(mPendingWork == 0, DataManagement, "CommandHandler::Close() called with %u unfinished async work items", | ||
| static_cast<unsigned int>(mPendingWork)); |
There was a problem hiding this comment.
mPendingWork should just be an unsigned instead of size_t. It's a simple counter... Followup for making that change is fine. If that happens, the other logs that involve it in this file should be fixed too.
There was a problem hiding this comment.
Got it, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit generated by running the following git-extras commands:
git sed -f g '" PRIu16 "' 'u'
git sed -f g '" PRIu16' 'u"'
git sed -f g '" PRIx16 "' 'x'
git sed -f g '" PRIx16' 'x"'
git sed -f g '" PRIX16 "' 'X'
git sed -f g '" PRIX16' 'X"'
git sed -f g '" PRId16 "' 'd'
git sed -f g '" PRId16' 'd"'
git sed -f g '%zu' '%u'
Cast some %zu parameters due to warnings
Add lint rules
Run restyle
This PR is similar with #15099
Problem
Some libcs such as newlib-nano don't support new format specifiers (> C89/C++11). This causes problems in logs and may also cause crashes due to promotion rules.
Change overview
Replace these format specifiers with simpler ones (%u/%d/%x) and cast where necessary.
Testing
Passed all CI/CD on my fork