Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty channel #17489

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Fix empty channel #17489

merged 3 commits into from
Apr 20, 2022

Conversation

xylophone21
Copy link
Collaborator

Problem

  • Fix build error by 3fa7de8
  • Fix crash error when lineup and channel is null in channel cluster

Change overview

  • Fix app path
  • Added null check

Testing

  • chip-tool channel

@restyled-io restyled-io bot mentioned this pull request Apr 19, 2022
Closed
@github-actions
Copy link

github-actions bot commented Apr 19, 2022 •
edited
Loading

PR #17489: Size comparison from 8793870 to 4fc9d58

Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 8793870 4fc9d58 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 684759 684759 0 0.0
(read/write) 168424 168424 0 0.0
.bss 76168 76168 0 0.0
.data 3380 3380 0 0.0
.rodata 103415 103415 0 0.0
.text 580864 580864 0 0.0
lock-ftd LP_CC2652R7 (read only) 677679 677679 0 0.0
(read/write) 166448 166448 0 0.0
.bss 74168 74168 0 0.0
.data 3212 3212 0 0.0
.rodata 98903 98903 0 0.0
.text 578292 578292 0 0.0
lock-mtd LP_CC2652R7 (read only) 626423 626423 0 0.0
(read/write) 146956 146956 0 0.0
.bss 69888 69888 0 0.0
.data 3212 3212 0 0.0
.rodata 98783 98783 0 0.0
.text 527148 527148 0 0.0
pump-app LP_CC2652R7 (read only) 649807 649807 0 0.0
(read/write) 152492 152492 0 0.0
.bss 74624 74624 0 0.0
.data 3244 3244 0 0.0
.rodata 75719 75719 0 0.0
.text 573600 573600 0 0.0
pump-controller-app LP_CC2652R7 (read only) 643151 643151 0 0.0
(read/write) 152160 152160 0 0.0
.bss 74328 74328 0 0.0
.data 3208 3208 0 0.0
.rodata 79055 79055 0 0.0
.text 563608 563608 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 619310 619310 0 0.0
.app_xip_area 526068 526068 0 0.0
.bss 75908 75908 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 613562 613562 0 0.0
.app_xip_area 521824 521824 0 0.0
.bss 74436 74436 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 566406 566406 0 0.0
.app_xip_area 465056 465056 0 0.0
.bss 83752 83752 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 909172 909172 0 0.0
(read/write) 133128 133128 0 0.0
.bss 131088 131088 0 0.0
.data 2040 2040 0 0.0
.text 909164 909164 0 0.0
BRD4161A+rpc (read only) 943548 943548 0 0.0
(read/write) 149812 149812 0 0.0
.bss 147568 147568 0 0.0
.data 2244 2244 0 0.0
.text 943540 943540 0 0.0
window-app BRD4161A (read only) 845540 845540 0 0.0
(read/write) 131116 131116 0 0.0
.bss 129168 129168 0 0.0
.data 1948 1948 0 0.0
.text 845532 845532 0 0.0
esp32 all-clusters-app c3devkit (read only) 980742 980742 0 0.0
(read/write) 1397866 1397866 0 0.0
.dram0.bss 62600 62600 0 0.0
.dram0.data 14412 14412 0 0.0
.flash.rodata 201936 201936 0 0.0
.flash.text 980742 980742 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1036127 1036127 0 0.0
(read/write) 465608 465608 0 0.0
.dram0.bss 68112 68112 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 231508 231508 0 0.0
.flash.text 1030743 1030743 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684868 684868 0 0.0
.bss 77912 77912 0 0.0
.data 1992 1992 0 0.0
.text 599164 599164 0 0.0
lock k32w061+release (read/write) 725716 725716 0 0.0
.bss 78520 78520 0 0.0
.data 1952 1952 0 0.0
.text 639444 639444 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10430092 10430092 0 0.0
(read/write) 494193 494193 0 0.0
.bss 40865 40865 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 390440 390440 0 0.0
.dynamic 560 560 0 0.0
.got 57904 57904 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 516652 516652 0 0.0
.text 8804420 8804420 0 0.0
thermostat-no-ble arm64 (read only) 2359996 2359996 0 0.0
(read/write) 151137 151137 0 0.0
.bss 62945 62945 0 0.0
.data 1440 1440 0 0.0
.data.rel.ro 78984 78984 0 0.0
.dynamic 560 560 0 0.0
.got 4752 4752 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145356 145356 0 0.0
.text 1985648 1985648 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2410300 2410300 0 0.0
.bss 185228 185228 0 0.0
.data 5840 5840 0 0.0
.text 1372900 1372900 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1164691 1164691 0 0.0
bss 136520 136520 0 0.0
rodata 147572 147572 0 0.0
text 801960 801960 0 0.0
p6 all-clusters-app default (read/write) 2517224 2517224 0 0.0
.bss 118624 118624 0 0.0
.data 2768 2768 0 0.0
.text 1475488 1475488 0 0.0
light-app default (read/write) 2417144 2417144 0 0.0
.bss 112104 112104 0 0.0
.data 2576 2576 0 0.0
.text 1375408 1375408 0 0.0
lock-app default (read/write) 2420608 2420608 0 0.0
.bss 111880 111880 0 0.0
.data 2536 2536 0 0.0
.text 1378872 1378872 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 802236 802236 0 0.0
bss 69952 69952 0 0.0
noinit 40416 40416 0 0.0
text 570790 570790 0 0.0

@andy31415 andy31415 merged commit 18338b9 into project-chip:master Apr 20, 2022
andy31415 added a commit to andy31415/connectedhomeip that referenced this pull request Apr 21, 2022
@andy31415
Revert "Fix empty channel (project-chip#17489)"
64f0c48 
This reverts commit 18338b9.

Commit broke android compilation using build_examples.py:

```
./scripts/build/build_examples.py --target android-arm-chip-tvserver
```
andy31415 added a commit that referenced this pull request Apr 21, 2022
@andy31415
Revert "Fix empty channel (#17489)" (#17607)
489217c 
This reverts commit 18338b9.

Commit broke android compilation using build_examples.py:

```
./scripts/build/build_examples.py --target android-arm-chip-tvserver
```
@xylophone21 xylophone21 mentioned this pull request Apr 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples fast track review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xylophone21 @andy31415