Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature map to media clusters & TV linux app #17473

Merged

Conversation

lazarkov
Copy link
Contributor

@lazarkov lazarkov commented Apr 18, 2022

Problem

  • media clusters do not have feature map logic
  • tv app does not have feature map for clusters

Change overview

see above

Issue(s) fixed:

15566

Testing

Run ./scripts/run_in_build_env.sh \ "./scripts/tests/run_test_suite.py \ --chip-tool ./out/debug/standalone/chip-tool \ run \ --iterations 1 \ --all-clusters-app ./out/debug/standalone/chip-all-clusters-app \ --tv-app ./out/debug/standalone/chip-tv-app \ "

@github-actions
Copy link

github-actions bot commented Apr 18, 2022

PR #17473: Size comparison from 375fff3 to cf25f18

Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 375fff3 cf25f18 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 684775 684775 0 0.0
(read/write) 168408 168408 0 0.0
.bss 76168 76168 0 0.0
.data 3380 3380 0 0.0
.rodata 103415 103415 0 0.0
.text 580880 580880 0 0.0
lock-ftd LP_CC2652R7 (read only) 677695 677695 0 0.0
(read/write) 166432 166432 0 0.0
.bss 74168 74168 0 0.0
.data 3212 3212 0 0.0
.rodata 98903 98903 0 0.0
.text 578308 578308 0 0.0
lock-mtd LP_CC2652R7 (read only) 626439 626439 0 0.0
(read/write) 146956 146956 0 0.0
.bss 69888 69888 0 0.0
.data 3212 3212 0 0.0
.rodata 98783 98783 0 0.0
.text 527164 527164 0 0.0
pump-app LP_CC2652R7 (read only) 649831 649831 0 0.0
(read/write) 152492 152492 0 0.0
.bss 74624 74624 0 0.0
.data 3244 3244 0 0.0
.rodata 75719 75719 0 0.0
.text 573624 573624 0 0.0
pump-controller-app LP_CC2652R7 (read only) 643167 643167 0 0.0
(read/write) 152160 152160 0 0.0
.bss 74328 74328 0 0.0
.data 3208 3208 0 0.0
.rodata 79055 79055 0 0.0
.text 563624 563624 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 619302 619302 0 0.0
.app_xip_area 526060 526060 0 0.0
.bss 75908 75908 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 613562 613562 0 0.0
.app_xip_area 521824 521824 0 0.0
.bss 74436 74436 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 566398 566398 0 0.0
.app_xip_area 465048 465048 0 0.0
.bss 83752 83752 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 909172 909172 0 0.0
(read/write) 133128 133128 0 0.0
.bss 131088 131088 0 0.0
.data 2040 2040 0 0.0
.text 909164 909164 0 0.0
BRD4161A+rpc (read only) 943548 943548 0 0.0
(read/write) 149812 149812 0 0.0
.bss 147568 147568 0 0.0
.data 2244 2244 0 0.0
.text 943540 943540 0 0.0
window-app BRD4161A (read only) 845540 845540 0 0.0
(read/write) 131116 131116 0 0.0
.bss 129168 129168 0 0.0
.data 1948 1948 0 0.0
.text 845532 845532 0 0.0
esp32 all-clusters-app c3devkit (read only) 980666 980666 0 0.0
(read/write) 1397866 1397866 0 0.0
.dram0.bss 62600 62600 0 0.0
.dram0.data 14412 14412 0 0.0
.flash.rodata 201936 201936 0 0.0
.flash.text 980666 980666 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1036119 1036119 0 0.0
(read/write) 465608 465608 0 0.0
.dram0.bss 68112 68112 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 231508 231508 0 0.0
.flash.text 1030735 1030735 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 684884 684884 0 0.0
.bss 77912 77912 0 0.0
.data 1992 1992 0 0.0
.text 599180 599180 0 0.0
lock k32w061+release (read/write) 725732 725732 0 0.0
.bss 78520 78520 0 0.0
.data 1952 1952 0 0.0
.text 639460 639460 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10430092 10430092 0 0.0
(read/write) 494193 494193 0 0.0
.bss 40865 40865 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 390440 390440 0 0.0
.dynamic 560 560 0 0.0
.got 57904 57904 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 516652 516652 0 0.0
.text 8804420 8804420 0 0.0
thermostat-no-ble arm64 (read only) 2359996 2359996 0 0.0
(read/write) 151137 151137 0 0.0
.bss 62945 62945 0 0.0
.data 1440 1440 0 0.0
.data.rel.ro 78984 78984 0 0.0
.dynamic 560 560 0 0.0
.got 4752 4752 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145356 145356 0 0.0
.text 1985648 1985648 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2410364 2410364 0 0.0
.bss 185228 185228 0 0.0
.data 5840 5840 0 0.0
.text 1372964 1372964 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1164707 1164707 0 0.0
bss 136520 136520 0 0.0
rodata 147572 147572 0 0.0
text 801976 801976 0 0.0
p6 all-clusters-app default (read/write) 2517224 2517224 0 0.0
.bss 118624 118624 0 0.0
.data 2768 2768 0 0.0
.text 1475488 1475488 0 0.0
light-app default (read/write) 2417144 2417144 0 0.0
.bss 112104 112104 0 0.0
.data 2576 2576 0 0.0
.text 1375408 1375408 0 0.0
lock-app default (read/write) 2420608 2420608 0 0.0
.bss 111880 111880 0 0.0
.data 2536 2536 0 0.0
.text 1378872 1378872 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 802172 802172 0 0.0
bss 69952 69952 0 0.0
noinit 40416 40416 0 0.0
text 570732 570732 0 0.0

@lazarkov lazarkov merged commit b36e4a2 into project-chip:master Apr 19, 2022
@lazarkov lazarkov deleted the feature/add-feature-flag-tv-linux branch April 19, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants