Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-Enable Certificate Validity Time Checks #17225

Conversation

emargolis
Copy link
Contributor

@emargolis emargolis commented Apr 9, 2022

Problem

Certificate validity time checks are currently commented out.

Ticket: #12554

Change overview

Re-enabled checks

Testing

existing tests

@github-actions
Copy link

github-actions bot commented Apr 9, 2022

PR #17225: Size comparison from da7eb85 to 3fd2e9d

Increases (1 build for linux)
platform target config section da7eb85 3fd2e9d change % change
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10278348 10279036 688 0.0
.text 8662740 8663428 688 0.0
Full report (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section da7eb85 3fd2e9d change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 639379 639379 0 0.0
(read/write) 151052 151052 0 0.0
.bss 73984 73984 0 0.0
.data 3212 3212 0 0.0
.rodata 79955 79955 0 0.0
.text 558932 558932 0 0.0
lock-mtd LP_CC2652R7 (read only) 588115 588115 0 0.0
(read/write) 146772 146772 0 0.0
.bss 69704 69704 0 0.0
.data 3212 3212 0 0.0
.rodata 79835 79835 0 0.0
.text 507788 507788 0 0.0
pump-app LP_CC2652R7 (read only) 646759 646759 0 0.0
(read/write) 152260 152260 0 0.0
.bss 74392 74392 0 0.0
.data 3244 3244 0 0.0
.rodata 74663 74663 0 0.0
.text 571608 571608 0 0.0
pump-controller-app LP_CC2652R7 (read only) 641099 641099 0 0.0
(read/write) 151952 151952 0 0.0
.bss 74120 74120 0 0.0
.data 3208 3208 0 0.0
.rodata 78443 78443 0 0.0
.text 562168 562168 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 617822 617822 0 0.0
.app_xip_area 524948 524948 0 0.0
.bss 75540 75540 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 575426 575426 0 0.0
.app_xip_area 484088 484088 0 0.0
.bss 74036 74036 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 563918 563918 0 0.0
.app_xip_area 462952 462952 0 0.0
.bss 83368 83368 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 906400 906400 0 0.0
(read/write) 132920 132920 0 0.0
.bss 130880 130880 0 0.0
.data 2040 2040 0 0.0
.text 906392 906392 0 0.0
BRD4161A+rpc (read only) 934272 934272 0 0.0
(read/write) 148872 148872 0 0.0
.bss 146648 146648 0 0.0
.data 2220 2220 0 0.0
.text 934264 934264 0 0.0
window-app BRD4161A (read only) 843688 843688 0 0.0
(read/write) 130992 130992 0 0.0
.bss 129040 129040 0 0.0
.data 1948 1948 0 0.0
.text 843680 843680 0 0.0
esp32 all-clusters-app c3devkit (read only) 992918 992918 0 0.0
(read/write) 1462514 1462514 0 0.0
.dram0.bss 62960 62960 0 0.0
.dram0.data 14364 14364 0 0.0
.flash.rodata 199720 199720 0 0.0
.flash.text 992918 992918 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1045591 1045591 0 0.0
(read/write) 463576 463576 0 0.0
.dram0.bss 68480 68480 0 0.0
.dram0.data 34160 34160 0 0.0
.flash.rodata 228792 228792 0 0.0
.flash.text 1040207 1040207 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 686348 686348 0 0.0
.bss 77968 77968 0 0.0
.data 2036 2036 0 0.0
.text 600544 600544 0 0.0
lock k32w061+release (read/write) 690948 690948 0 0.0
.bss 78544 78544 0 0.0
.data 1996 1996 0 0.0
.text 604608 604608 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10278348 10279036 688 0.0
(read/write) 492193 492193 0 0.0
.bss 41009 41009 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388824 388824 0 0.0
.dynamic 560 560 0 0.0
.got 57392 57392 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512428 512428 0 0.0
.text 8662740 8663428 688 0.0
thermostat-no-ble arm64 (read only) 2351724 2351724 0 0.0
(read/write) 150833 150833 0 0.0
.bss 63025 63025 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78600 78600 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144652 144652 0 0.0
.text 1978592 1978592 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2367996 2367996 0 0.0
.bss 185076 185076 0 0.0
.data 5840 5840 0 0.0
.text 1330596 1330596 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154967 1154967 0 0.0
bss 135304 135304 0 0.0
rodata 146544 146544 0 0.0
text 794408 794408 0 0.0
p6 all-clusters-app default (read/write) 2514152 2514152 0 0.0
.bss 118480 118480 0 0.0
.data 2768 2768 0 0.0
.text 1472416 1472416 0 0.0
light-app default (read/write) 2414840 2414840 0 0.0
.bss 111976 111976 0 0.0
.data 2576 2576 0 0.0
.text 1373104 1373104 0 0.0
lock-app default (read/write) 2378408 2378408 0 0.0
.bss 111720 111720 0 0.0
.data 2536 2536 0 0.0
.text 1336672 1336672 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800600 800600 0 0.0
bss 69828 69828 0 0.0
noinit 40416 40416 0 0.0
text 569474 569474 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit 25cfd8d into project-chip:master Apr 9, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants