-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-Enable Certificate Validity Time Checks #17225
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
emargolis:emargolis/feature/re-enable-certificate-validity-time-check
Apr 9, 2022
Merged
Re-Enable Certificate Validity Time Checks #17225
bzbarsky-apple
merged 1 commit into
project-chip:master
from
emargolis:emargolis/feature/re-enable-certificate-validity-time-check
Apr 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran and
isiu-apple
April 9, 2022 00:09
pullapprove
bot
requested review from
LuDuda,
lzgrablic02,
tecimovic,
vijs,
mlepage-google,
mrjerryjohns,
vivien-apple,
msandstedt,
wbschiller,
mspang,
robszewczyk,
woody-apple,
sagar-apple,
saurabhst,
xylophone21 and
selissia
April 9, 2022 00:09
yunhanw-google
approved these changes
Apr 9, 2022
PR #17225: Size comparison from da7eb85 to 3fd2e9d Increases (1 build for linux)
Full report (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Apr 9, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Certificate validity time checks are currently commented out.
Ticket: #12554
Change overview
Re-enabled checks
Testing
existing tests