Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove global keyword from matter IDL files #17139

Merged
merged 4 commits into from
Apr 7, 2022
Merged

Remove global keyword from matter IDL files #17139

merged 4 commits into from
Apr 7, 2022

Conversation

andy31415
Copy link
Contributor

Problem

global does not have any real meaning for matter - it is a spec term saying attribute ID is reused across multiple clusters. Code generation and matching to spec only needs to use and check id.

Change overview

Remove global from both generated files and parser itself.

Testing

Compiled android (since JNI uses codegen), ran unit tests. CI will validate more builds.

@github-actions
Copy link

github-actions bot commented Apr 6, 2022 •
edited
Loading

PR #17139: Size comparison from 716ffda to 26c61ef

Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 716ffda 26c61ef change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 674403 674403 0 0.0
(read/write) 177108 177108 0 0.0
.bss 81552 81552 0 0.0
.data 3168 3168 0 0.0
.rodata 80579 80579 0 0.0
.text 593344 593344 0 0.0
lock-mtd LP_CC2652R7 (read only) 623539 623539 0 0.0
(read/write) 154304 154304 0 0.0
.bss 77280 77280 0 0.0
.data 3168 3168 0 0.0
.rodata 80467 80467 0 0.0
.text 542584 542584 0 0.0
pump-app LP_CC2652R7 (read only) 691719 691719 0 0.0
(read/write) 160952 160952 0 0.0
.bss 81944 81944 0 0.0
.data 3200 3200 0 0.0
.rodata 82511 82511 0 0.0
.text 608724 608724 0 0.0
pump-controller-app LP_CC2652R7 (read only) 676091 676091 0 0.0
(read/write) 176324 176324 0 0.0
.bss 81688 81688 0 0.0
.data 3164 3164 0 0.0
.rodata 79011 79011 0 0.0
.text 596596 596596 0 0.0
efr32 lighting-app BRD4161A (read only) 904628 904628 0 0.0
(read/write) 133144 133144 0 0.0
.bss 131152 131152 0 0.0
.data 1992 1992 0 0.0
.text 904620 904620 0 0.0
BRD4161A+rpc (read only) 932516 932516 0 0.0
(read/write) 149092 149092 0 0.0
.bss 146920 146920 0 0.0
.data 2172 2172 0 0.0
.text 932508 932508 0 0.0
window-app BRD4161A (read only) 841964 841964 0 0.0
(read/write) 131204 131204 0 0.0
.bss 129328 129328 0 0.0
.data 1876 1876 0 0.0
.text 841956 841956 0 0.0
esp32 all-clusters-app c3devkit (read only) 991802 991802 0 0.0
(read/write) 1461530 1461530 0 0.0
.dram0.bss 63000 63000 0 0.0
.dram0.data 14260 14260 0 0.0
.flash.rodata 198784 198784 0 0.0
.flash.text 991802 991802 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1044443 1044443 0 0.0
(read/write) 462584 462584 0 0.0
.dram0.bss 68528 68528 0 0.0
.dram0.data 34064 34064 0 0.0
.flash.rodata 227848 227848 0 0.0
.flash.text 1039059 1039059 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 684940 684940 0 0.0
.bss 78240 78240 0 0.0
.data 1988 1988 0 0.0
.text 598912 598912 0 0.0
lock k32w061+release (read/write) 689780 689780 0 0.0
.bss 78816 78816 0 0.0
.data 1948 1948 0 0.0
.text 603216 603216 0 0.0
linux all-clusters-app debug (read only) 2618105 2618105 0 0.0
(read/write) 145384 145384 0 0.0
.bss 57856 57856 0 0.0
.data 1408 1408 0 0.0
.data.rel.ro 80232 80232 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 222277 222277 0 0.0
.text 2227138 2227138 0 0.0
bridge-app debug+rpc (read only) 1826845 1826845 0 0.0
(read/write) 90824 90824 0 0.0
.bss 44792 44792 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38904 38904 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 148409 148409 0 0.0
.text 1561157 1561157 0 0.0
chip-tool debug (read only) 10675813 10675813 0 0.0
(read/write) 371640 371640 0 0.0
.bss 22784 22784 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 341584 341584 0 0.0
.dynamic 624 624 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 538005 538005 0 0.0
.text 9309013 9309013 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10278220 10278220 0 0.0
(read/write) 492033 492033 0 0.0
.bss 41041 41041 0 0.0
.data 1120 1120 0 0.0
.data.rel.ro 388704 388704 0 0.0
.dynamic 560 560 0 0.0
.got 57360 57360 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512396 512396 0 0.0
.text 8663044 8663044 0 0.0
door-lock-app debug (read only) 2098057 2098057 0 0.0
(read/write) 118864 118864 0 0.0
.bss 48128 48128 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 64024 64024 0 0.0
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 186441 186441 0 0.0
.text 1757154 1757154 0 0.0
lighting-app debug+rpc (read only) 2277977 2277977 0 0.0
(read/write) 125920 125920 0 0.0
.bss 49472 49472 0 0.0
.data 1600 1600 0 0.0
.data.rel.ro 69160 69160 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 180649 180649 0 0.0
.text 1933378 1933378 0 0.0
ota-provider-app debug (read only) 2036033 2036033 0 0.0
(read/write) 114432 114432 0 0.0
.bss 47968 47968 0 0.0
.data 1384 1384 0 0.0
.data.rel.ro 59352 59352 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 172291 172291 0 0.0
.text 1708370 1708370 0 0.0
ota-requestor-app debug (read only) 2065617 2065617 0 0.0
(read/write) 117720 117720 0 0.0
.bss 48928 48928 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 61592 61592 0 0.0
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 168820 168820 0 0.0
.text 1739650 1739650 0 0.0
shell debug (read only) 2513177 2513177 0 0.0
(read/write) 148912 148912 0 0.0
.bss 67560 67560 0 0.0
.data 848 848 0 0.0
.data.rel.ro 74776 74776 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 213874 213874 0 0.0
.text 2140098 2140098 0 0.0
thermostat-no-ble arm64 (read only) 2344460 2344460 0 0.0
(read/write) 150257 150257 0 0.0
.bss 63169 63169 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 78184 78184 0 0.0
.dynamic 560 560 0 0.0
.got 4752 4752 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144364 144364 0 0.0
.text 1972944 1972944 0 0.0
tv-app debug (read only) 2787361 2787361 0 0.0
(read/write) 250488 250488 0 0.0
.bss 165576 165576 0 0.0
.data 3360 3360 0 0.0
.data.rel.ro 75360 75360 0 0.0
.dynamic 592 592 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 212523 212523 0 0.0
.text 2395362 2395362 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2366708 2366708 0 0.0
.bss 185092 185092 0 0.0
.data 5792 5792 0 0.0
.text 1329308 1329308 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1153063 1153063 0 0.0
bss 135604 135604 0 0.0
rodata 145632 145632 0 0.0
text 793256 793256 0 0.0
p6 all-clusters-app default (read/write) 2512088 2512088 0 0.0
.bss 118528 118528 0 0.0
.data 2672 2672 0 0.0
.text 1470352 1470352 0 0.0
light-app default (read/write) 2413264 2413264 0 0.0
.bss 111992 111992 0 0.0
.data 2528 2528 0 0.0
.text 1371528 1371528 0 0.0
lock-app default (read/write) 2376944 2376944 0 0.0
.bss 111736 111736 0 0.0
.data 2488 2488 0 0.0
.text 1335208 1335208 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 798988 798988 0 0.0
bss 70096 70096 0 0.0
noinit 40416 40416 0 0.0
text 568076 568076 0 0.0

@andy31415 andy31415 merged commit 306e8a4 into project-chip:master Apr 7, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@andy31415 @andrei-menzopol
Remove global keyword from matter IDL files (project-chip#17139)
5b0c2cb 
* Remove global IDL configuration from IDL parser - it has no meaning

* Remove global from IDL autogeneration

* Remove one more global attribute from IDL parsing

* Regenerated zap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app controller examples review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andy31415 @tcarmelveilleux @bzbarsky-apple