-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] Implement DeviceInfoProviderImpl with persistent storage #17136
Merged
yufengwangca
merged 8 commits into
project-chip:master
from
yufengwangca:pr/darwin/devinfo
Apr 12, 2022
Merged
[Darwin] Implement DeviceInfoProviderImpl with persistent storage #17136
yufengwangca
merged 8 commits into
project-chip:master
from
yufengwangca:pr/darwin/devinfo
Apr 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost and
kpschoedel
April 6, 2022 18:53
pullapprove
bot
requested review from
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
April 6, 2022 18:53
PR #17136: Size comparison from ceefa88 to d1c08cd Full report (19 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #17136: Size comparison from 16606a4 to 755e23e Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #17136: Size comparison from 97b144a to 3957a81 Full report (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Apr 12, 2022
PR #17136: Size comparison from f4e1799 to cf70145 Increases (29 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
yunhanw-google
approved these changes
Apr 12, 2022
PR #17136: Size comparison from f4e1799 to ba8fafe Increases (29 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
Decreases (1 build for esp32)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #17136: Size comparison from 2c15978 to 23ec26c Increases (29 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #17136: Size comparison from 2e33dec to 8a27abd Increases (29 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…oject-chip#17136) * [Darwin] Implement DeviceInfoProviderImpl with persistent storage * Use storage delegate instead of PersistedStorage * Update src/platform/Darwin/DeviceInfoProviderImpl.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/platform/Darwin/DeviceInfoProviderImpl.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/platform/Darwin/DeviceInfoProviderImpl.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/platform/Darwin/DeviceInfoProviderImpl.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/include/platform/DeviceInfoProvider.h Co-authored-by: Boris Zbarsky <[email protected]> * Address review comments Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Implement DeviceInfoProviderImpl with persistent storage for Darwin
Testing
How was this tested? (at least one bullet point required)