Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ameba] Restructure PersistentStorage #17047

Merged
merged 3 commits into from
Apr 20, 2022
Merged

[Ameba] Restructure PersistentStorage #17047

merged 3 commits into from
Apr 20, 2022

Conversation

pankore
Copy link
Contributor

@pankore pankore commented Apr 5, 2022

Problem

  • Ameba's current implementation of persistent storage is storing key-values in wrong places, causing commissioning issues
  • Data stored outside of chip-factory, chip-config and chip-counters are not stored in proper domains
  • Wrong error code in AmebaWiFiDriver::Init
  • Wrong integer type used in AmebaConfig::ReadConfigValue, causing read value to be wrong
  • InitOTARequestor is called after Server::Init, causing runtime hardfault

Change overview

  • Add more kConfigNamespace to organize key-value data into proper domains
  • Fix wrong error code in AmebaWiFiDriver::Init
  • Fix integer type in AmebaConfig::ReadConfigValue
  • Fix initialization order in chipinterface

Testing

  • Tested ble-wifi commissioning with chip-tool

@restyled-io restyled-io bot mentioned this pull request Apr 5, 2022
Closed
@github-actions
Copy link

github-actions bot commented Apr 5, 2022 •
edited
Loading

PR #17047: Size comparison from e92157a to 8427f0c

Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e92157a 8427f0c change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 670727 670727 0 0.0
(read/write) 180992 180992 0 0.0
.bss 81760 81760 0 0.0
.data 3164 3164 0 0.0
.rodata 80039 80039 0 0.0
.text 590208 590208 0 0.0
lock-mtd LP_CC2652R7 (read only) 619855 619855 0 0.0
(read/write) 154508 154508 0 0.0
.bss 77488 77488 0 0.0
.data 3164 3164 0 0.0
.rodata 79927 79927 0 0.0
.text 539440 539440 0 0.0
pump-app LP_CC2652R7 (read only) 690191 690191 0 0.0
(read/write) 162704 162704 0 0.0
.bss 82168 82168 0 0.0
.data 3196 3196 0 0.0
.rodata 82119 82119 0 0.0
.text 607588 607588 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672431 672431 0 0.0
(read/write) 180192 180192 0 0.0
.bss 81896 81896 0 0.0
.data 3160 3160 0 0.0
.rodata 78455 78455 0 0.0
.text 593492 593492 0 0.0
efr32 lighting-app BRD4161A (read only) 919500 919500 0 0.0
(read/write) 129792 129792 0 0.0
.bss 127800 127800 0 0.0
.data 1992 1992 0 0.0
.text 919492 919492 0 0.0
BRD4161A+rpc (read only) 947396 947396 0 0.0
(read/write) 145740 145740 0 0.0
.bss 143568 143568 0 0.0
.data 2172 2172 0 0.0
.text 947388 947388 0 0.0
window-app BRD4161A (read only) 854716 854716 0 0.0
(read/write) 127816 127816 0 0.0
.bss 125944 125944 0 0.0
.data 1872 1872 0 0.0
.text 854708 854708 0 0.0
esp32 all-clusters-app c3devkit (read only) 988250 988250 0 0.0
(read/write) 1460922 1460922 0 0.0
.dram0.bss 62952 62952 0 0.0
.dram0.data 14196 14196 0 0.0
.flash.rodata 198288 198288 0 0.0
.flash.text 988250 988250 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1040599 1040599 0 0.0
(read/write) 461912 461912 0 0.0
.dram0.bss 68480 68480 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 227232 227232 0 0.0
.flash.text 1035215 1035215 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 710620 710620 0 0.0
.bss 77968 77968 0 0.0
.data 1904 1904 0 0.0
.text 624948 624948 0 0.0
lock k32w061+release (read/write) 710024 710024 0 0.0
.bss 77960 77960 0 0.0
.data 1944 1944 0 0.0
.text 624320 624320 0 0.0
linux all-clusters-app debug (read only) 2593737 2593737 0 0.0
(read/write) 144872 144872 0 0.0
.bss 57664 57664 0 0.0
.data 1440 1440 0 0.0
.data.rel.ro 79880 79880 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 221285 221285 0 0.0
.text 2204434 2204434 0 0.0
bridge-app debug+rpc (read only) 1803701 1803701 0 0.0
(read/write) 90296 90296 0 0.0
.bss 44584 44584 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38584 38584 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 147513 147513 0 0.0
.text 1539557 1539557 0 0.0
chip-tool debug (read only) 10484645 10484645 0 0.0
(read/write) 367128 367128 0 0.0
.bss 22016 22016 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 337848 337848 0 0.0
.dynamic 624 624 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 534349 534349 0 0.0
.text 9131957 9131957 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10083572 10083572 0 0.0
(read/write) 486977 486977 0 0.0
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 384712 384712 0 0.0
.dynamic 560 560 0 0.0
.got 57008 57008 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 508404 508404 0 0.0
.text 8484324 8484324 0 0.0
door-lock-app debug (read only) 2074673 2074673 0 0.0
(read/write) 118320 118320 0 0.0
.bss 47904 47904 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 63704 63704 0 0.0
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 185513 185513 0 0.0
.text 1735346 1735346 0 0.0
lighting-app debug+rpc (read only) 2253193 2253193 0 0.0
(read/write) 125312 125312 0 0.0
.bss 49216 49216 0 0.0
.data 1600 1600 0 0.0
.data.rel.ro 68808 68808 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 179625 179625 0 0.0
.text 1910290 1910290 0 0.0
ota-provider-app debug (read only) 2012593 2012593 0 0.0
(read/write) 113888 113888 0 0.0
.bss 47744 47744 0 0.0
.data 1384 1384 0 0.0
.data.rel.ro 59032 59032 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 171403 171403 0 0.0
.text 1686466 1686466 0 0.0
ota-requestor-app debug (read only) 2041977 2041977 0 0.0
(read/write) 117176 117176 0 0.0
.bss 48736 48736 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 61240 61240 0 0.0
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 167892 167892 0 0.0
.text 1717682 1717682 0 0.0
shell debug (read only) 2490745 2490745 0 0.0
(read/write) 148336 148336 0 0.0
.bss 67336 67336 0 0.0
.data 848 848 0 0.0
.data.rel.ro 74424 74424 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212978 212978 0 0.0
.text 2119234 2119234 0 0.0
thermostat-no-ble arm64 (read only) 2325020 2325020 0 0.0
(read/write) 149521 149521 0 0.0
.bss 62977 62977 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 77760 77760 0 0.0
.dynamic 560 560 0 0.0
.got 4632 4632 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 143340 143340 0 0.0
.text 1955840 1955840 0 0.0
tv-app debug (read only) 2762281 2762281 0 0.0
(read/write) 249984 249984 0 0.0
.bss 165360 165360 0 0.0
.data 3392 3392 0 0.0
.data.rel.ro 75040 75040 0 0.0
.dynamic 592 592 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 211467 211467 0 0.0
.text 2371986 2371986 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2362956 2362956 0 0.0
.bss 185052 185052 0 0.0
.data 5784 5784 0 0.0
.text 1325556 1325556 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151471 1151471 0 0.0
bss 143072 143072 0 0.0
rodata 143656 143656 0 0.0
text 789876 789876 0 0.0
p6 all-clusters-app default (read/write) 2507784 2507784 0 0.0
.bss 118480 118480 0 0.0
.data 2672 2672 0 0.0
.text 1466048 1466048 0 0.0
light-app default (read/write) 2408960 2408960 0 0.0
.bss 111944 111944 0 0.0
.data 2528 2528 0 0.0
.text 1367224 1367224 0 0.0
lock-app default (read/write) 2372608 2372608 0 0.0
.bss 111688 111688 0 0.0
.data 2488 2488 0 0.0
.text 1330872 1330872 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 795088 795088 0 0.0
bss 70300 70300 0 0.0
noinit 40416 40416 0 0.0
text 564554 564554 0 0.0

@pankore
Copy link
Contributor Author

pankore commented Apr 5, 2022

#17051 is the prerequisite for this PR

woody-apple
woody-apple approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking platform changes.

@github-actions
Copy link

github-actions bot commented Apr 7, 2022 •
edited
Loading

PR #17047: Size comparison from ebcb002 to d16f764

Full report (19 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ebcb002 d16f764 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 674539 674539 0 0.0
(read/write) 176940 176940 0 0.0
.bss 81520 81520 0 0.0
.data 3216 3216 0 0.0
.rodata 80563 80563 0 0.0
.text 593496 593496 0 0.0
lock-mtd LP_CC2652R7 (read only) 623675 623675 0 0.0
(read/write) 154320 154320 0 0.0
.bss 77248 77248 0 0.0
.data 3216 3216 0 0.0
.rodata 80451 80451 0 0.0
.text 542736 542736 0 0.0
pump-app LP_CC2652R7 (read only) 691919 691919 0 0.0
(read/write) 160720 160720 0 0.0
.bss 81912 81912 0 0.0
.data 3248 3248 0 0.0
.rodata 82575 82575 0 0.0
.text 608860 608860 0 0.0
pump-controller-app LP_CC2652R7 (read only) 676243 676243 0 0.0
(read/write) 176140 176140 0 0.0
.bss 81656 81656 0 0.0
.data 3212 3212 0 0.0
.rodata 79027 79027 0 0.0
.text 596732 596732 0 0.0
efr32 lighting-app BRD4161A (read only) 904924 904924 0 0.0
(read/write) 133160 133160 0 0.0
.bss 131120 131120 0 0.0
.data 2040 2040 0 0.0
.text 904916 904916 0 0.0
BRD4161A+rpc (read only) 932812 932812 0 0.0
(read/write) 149108 149108 0 0.0
.bss 146888 146888 0 0.0
.data 2220 2220 0 0.0
.text 932804 932804 0 0.0
window-app BRD4161A (read only) 842212 842212 0 0.0
(read/write) 131228 131228 0 0.0
.bss 129280 129280 0 0.0
.data 1948 1948 0 0.0
.text 842204 842204 0 0.0
esp32 all-clusters-app c3devkit (read only) 991922 991922 0 0.0
(read/write) 1461762 1461762 0 0.0
.dram0.bss 62936 62936 0 0.0
.dram0.data 14356 14356 0 0.0
.flash.rodata 198984 198984 0 0.0
.flash.text 991922 991922 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1044611 1044611 0 0.0
(read/write) 462816 462816 0 0.0
.dram0.bss 68464 68464 0 0.0
.dram0.data 34160 34160 0 0.0
.flash.rodata 228048 228048 0 0.0
.flash.text 1039227 1039227 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 685180 685180 0 0.0
.bss 78208 78208 0 0.0
.data 2036 2036 0 0.0
.text 599136 599136 0 0.0
lock k32w061+release (read/write) 689964 689964 0 0.0
.bss 78784 78784 0 0.0
.data 1996 1996 0 0.0
.text 603384 603384 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10279596 10279596 0 0.0
(read/write) 492081 492081 0 0.0
.bss 41009 41009 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388720 388720 0 0.0
.dynamic 560 560 0 0.0
.got 57376 57376 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512700 512700 0 0.0
.text 8664020 8664020 0 0.0
thermostat-no-ble arm64 (read only) 2345388 2345388 0 0.0
(read/write) 150401 150401 0 0.0
.bss 63025 63025 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78184 78184 0 0.0
.dynamic 560 560 0 0.0
.got 4752 4752 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144428 144428 0 0.0
.text 1973808 1973808 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2366844 2366844 0 0.0
.bss 185060 185060 0 0.0
.data 5840 5840 0 0.0
.text 1329444 1329444 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1153391 1153391 0 0.0
bss 135540 135540 0 0.0
rodata 145832 145832 0 0.0
text 793412 793412 0 0.0
p6 all-clusters-app default (read/write) 2512552 2512552 0 0.0
.bss 118464 118464 0 0.0
.data 2768 2768 0 0.0
.text 1470816 1470816 0 0.0
light-app default (read/write) 2413576 2413576 0 0.0
.bss 111960 111960 0 0.0
.data 2576 2576 0 0.0
.text 1371840 1371840 0 0.0
lock-app default (read/write) 2377208 2377208 0 0.0
.bss 111704 111704 0 0.0
.data 2536 2536 0 0.0
.text 1335472 1335472 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 799264 799264 0 0.0
bss 70064 70064 0 0.0
noinit 40416 40416 0 0.0
text 568296 568296 0 0.0

@github-actions
Copy link

github-actions bot commented Apr 11, 2022 •
edited
Loading

PR #17047: Size comparison from 25cfd8d to a476bde

Full report (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 25cfd8d a476bde change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 639379 639379 0 0.0
(read/write) 151052 151052 0 0.0
.bss 73984 73984 0 0.0
.data 3212 3212 0 0.0
.rodata 79955 79955 0 0.0
.text 558932 558932 0 0.0
lock-mtd LP_CC2652R7 (read only) 588115 588115 0 0.0
(read/write) 146772 146772 0 0.0
.bss 69704 69704 0 0.0
.data 3212 3212 0 0.0
.rodata 79835 79835 0 0.0
.text 507788 507788 0 0.0
pump-app LP_CC2652R7 (read only) 647199 647199 0 0.0
(read/write) 152348 152348 0 0.0
.bss 74480 74480 0 0.0
.data 3244 3244 0 0.0
.rodata 75103 75103 0 0.0
.text 571608 571608 0 0.0
pump-controller-app LP_CC2652R7 (read only) 641419 641419 0 0.0
(read/write) 152016 152016 0 0.0
.bss 74184 74184 0 0.0
.data 3208 3208 0 0.0
.rodata 78763 78763 0 0.0
.text 562168 562168 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 617822 617822 0 0.0
.app_xip_area 524948 524948 0 0.0
.bss 75540 75540 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 575426 575426 0 0.0
.app_xip_area 484088 484088 0 0.0
.bss 74036 74036 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 563918 563918 0 0.0
.app_xip_area 462952 462952 0 0.0
.bss 83368 83368 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 906400 906400 0 0.0
(read/write) 132920 132920 0 0.0
.bss 130880 130880 0 0.0
.data 2040 2040 0 0.0
.text 906392 906392 0 0.0
BRD4161A+rpc (read only) 934272 934272 0 0.0
(read/write) 148872 148872 0 0.0
.bss 146648 146648 0 0.0
.data 2220 2220 0 0.0
.text 934264 934264 0 0.0
window-app BRD4161A (read only) 843688 843688 0 0.0
(read/write) 130992 130992 0 0.0
.bss 129040 129040 0 0.0
.data 1948 1948 0 0.0
.text 843680 843680 0 0.0
esp32 all-clusters-app c3devkit (read only) 992918 992918 0 0.0
(read/write) 1462514 1462514 0 0.0
.dram0.bss 62960 62960 0 0.0
.dram0.data 14364 14364 0 0.0
.flash.rodata 199720 199720 0 0.0
.flash.text 992918 992918 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1045591 1045591 0 0.0
(read/write) 463576 463576 0 0.0
.dram0.bss 68480 68480 0 0.0
.dram0.data 34160 34160 0 0.0
.flash.rodata 228792 228792 0 0.0
.flash.text 1040207 1040207 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 686348 686348 0 0.0
.bss 77968 77968 0 0.0
.data 2036 2036 0 0.0
.text 600544 600544 0 0.0
lock k32w061+release (read/write) 690948 690948 0 0.0
.bss 78544 78544 0 0.0
.data 1996 1996 0 0.0
.text 604608 604608 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10279036 10279036 0 0.0
(read/write) 492193 492193 0 0.0
.bss 41009 41009 0 0.0
.data 1168 1168 0 0.0
.data.rel.ro 388824 388824 0 0.0
.dynamic 560 560 0 0.0
.got 57392 57392 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 512428 512428 0 0.0
.text 8663428 8663428 0 0.0
thermostat-no-ble arm64 (read only) 2351724 2351724 0 0.0
(read/write) 150833 150833 0 0.0
.bss 63025 63025 0 0.0
.data 1424 1424 0 0.0
.data.rel.ro 78600 78600 0 0.0
.dynamic 560 560 0 0.0
.got 4768 4768 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 144652 144652 0 0.0
.text 1978592 1978592 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2367996 2367996 0 0.0
.bss 185076 185076 0 0.0
.data 5840 5840 0 0.0
.text 1330596 1330596 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1154967 1154967 0 0.0
bss 135304 135304 0 0.0
rodata 146544 146544 0 0.0
text 794408 794408 0 0.0
p6 all-clusters-app default (read/write) 2514152 2514152 0 0.0
.bss 118480 118480 0 0.0
.data 2768 2768 0 0.0
.text 1472416 1472416 0 0.0
light-app default (read/write) 2414840 2414840 0 0.0
.bss 111976 111976 0 0.0
.data 2576 2576 0 0.0
.text 1373104 1373104 0 0.0
lock-app default (read/write) 2378408 2378408 0 0.0
.bss 111720 111720 0 0.0
.data 2536 2536 0 0.0
.text 1336672 1336672 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800600 800600 0 0.0
bss 69828 69828 0 0.0
noinit 40416 40416 0 0.0
text 569474 569474 0 0.0

@github-actions
Copy link

github-actions bot commented Apr 13, 2022 •
edited
Loading

PR #17047: Size comparison from 3af5410 to 7727f79

Full report (20 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
platform target config section 3af5410 7727f79 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 640211 640211 0 0.0
(read/write) 151212 151212 0 0.0
.bss 74144 74144 0 0.0
.data 3212 3212 0 0.0
.rodata 80163 80163 0 0.0
.text 559556 559556 0 0.0
lock-mtd LP_CC2652R7 (read only) 588947 588947 0 0.0
(read/write) 146932 146932 0 0.0
.bss 69864 69864 0 0.0
.data 3212 3212 0 0.0
.rodata 80043 80043 0 0.0
.text 508412 508412 0 0.0
pump-app LP_CC2652R7 (read only) 648287 648287 0 0.0
(read/write) 152508 152508 0 0.0
.bss 74640 74640 0 0.0
.data 3244 3244 0 0.0
.rodata 75351 75351 0 0.0
.text 572448 572448 0 0.0
pump-controller-app LP_CC2652R7 (read only) 642267 642267 0 0.0
(read/write) 152176 152176 0 0.0
.bss 74344 74344 0 0.0
.data 3208 3208 0 0.0
.rodata 78987 78987 0 0.0
.text 562792 562792 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 618818 618818 0 0.0
.app_xip_area 525528 525528 0 0.0
.bss 75956 75956 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 576414 576414 0 0.0
.app_xip_area 484660 484660 0 0.0
.bss 74452 74452 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 564938 564938 0 0.0
.app_xip_area 463556 463556 0 0.0
.bss 83784 83784 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 907300 907300 0 0.0
(read/write) 133080 133080 0 0.0
.bss 131040 131040 0 0.0
.data 2040 2040 0 0.0
.text 907292 907292 0 0.0
BRD4161A+rpc (read only) 941668 941668 0 0.0
(read/write) 149764 149764 0 0.0
.bss 147520 147520 0 0.0
.data 2244 2244 0 0.0
.text 941660 941660 0 0.0
window-app BRD4161A (read only) 844292 844292 0 0.0
(read/write) 131148 131148 0 0.0
.bss 129200 129200 0 0.0
.data 1948 1948 0 0.0
.text 844284 844284 0 0.0
esp32 all-clusters-app c3devkit (read only) 979702 979702 0 0.0
(read/write) 1397514 1397514 0 0.0
.dram0.bss 62624 62624 0 0.0
.dram0.data 14420 14420 0 0.0
.flash.rodata 201552 201552 0 0.0
.flash.text 979702 979702 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1035283 1035283 0 0.0
(read/write) 465252 465252 0 0.0
.dram0.bss 68144 68144 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 231120 231120 0 0.0
.flash.text 1029899 1029899 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 687036 687036 0 0.0
.bss 78128 78128 0 0.0
.data 2036 2036 0 0.0
.text 601072 601072 0 0.0
lock k32w061+release (read/write) 691652 691652 0 0.0
.bss 78704 78704 0 0.0
.data 1996 1996 0 0.0
.text 605152 605152 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2368260 2368260 0 0.0
.bss 185236 185236 0 0.0
.data 5840 5840 0 0.0
.text 1330860 1330860 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156151 1156151 0 0.0
bss 135464 135464 0 0.0
rodata 146768 146768 0 0.0
text 795236 795236 0 0.0
p6 all-clusters-app default (read/write) 2514704 2514704 0 0.0
.bss 118640 118640 0 0.0
.data 2768 2768 0 0.0
.text 1472968 1472968 0 0.0
light-app default (read/write) 2415176 2415176 0 0.0
.bss 112136 112136 0 0.0
.data 2576 2576 0 0.0
.text 1373440 1373440 0 0.0
lock-app default (read/write) 2378744 2378744 0 0.0
.bss 111880 111880 0 0.0
.data 2536 2536 0 0.0
.text 1337008 1337008 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 801264 801264 0 0.0
bss 69988 69988 0 0.0
noinit 40416 40416 0 0.0
text 569958 569958 0 0.0

@pankore
Copy link
Contributor Author

pankore commented Apr 13, 2022

#17320 is the prerequisite for this PR.

@pankore pankore mentioned this pull request Apr 14, 2022
Merged
@pankore
Copy link
Contributor Author

pankore commented Apr 19, 2022

/rebase

1 similar comment
@pankore
Copy link
Contributor Author

pankore commented Apr 19, 2022

/rebase

pankore and others added 3 commits April 20, 2022 09:59
@pankore
[PersistentStorage] [Commissioning] Restructure PersistentStorage con…
5d461df 
…figuration to fix commissioning issue

- Key-values outside of below domains are not stored in proper domains
    "chip-factory"
    "chip-config"
    "chip-counters"
- Add more domains to be registered into DCT
- Add AmebaConfig::EnsureNamespace2 to register some domains into DCT2
- Change wrong error code in AmebaWiFiDriver::Init
@pankore
[chipinterface] Revise initialization order
a30aa4d 
- Current init order faces hardfault
- Move InitOTARequestor after Server is initialized
@restyled-commits @pankore
Restyled by clang-format
d83a2f9
@github-actions
Copy link

github-actions bot commented Apr 20, 2022 •
edited
Loading

PR #17047: Size comparison from 66333a9 to d83a2f9

Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 66333a9 d83a2f9 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 684595 684595 0 0.0
(read/write) 168308 168308 0 0.0
.bss 75888 75888 0 0.0
.data 3380 3380 0 0.0
.rodata 103323 103323 0 0.0
.text 580792 580792 0 0.0
lock-ftd LP_CC2652R7 (read only) 676947 676947 0 0.0
(read/write) 166924 166924 0 0.0
.bss 73912 73912 0 0.0
.data 3212 3212 0 0.0
.rodata 99027 99027 0 0.0
.text 577436 577436 0 0.0
lock-mtd LP_CC2652R7 (read only) 625691 625691 0 0.0
(read/write) 146700 146700 0 0.0
.bss 69632 69632 0 0.0
.data 3212 3212 0 0.0
.rodata 98907 98907 0 0.0
.text 526292 526292 0 0.0
pump-app LP_CC2652R7 (read only) 648715 648715 0 0.0
(read/write) 152212 152212 0 0.0
.bss 74344 74344 0 0.0
.data 3244 3244 0 0.0
.rodata 75491 75491 0 0.0
.text 572736 572736 0 0.0
pump-controller-app LP_CC2652R7 (read only) 642019 642019 0 0.0
(read/write) 151880 151880 0 0.0
.bss 74048 74048 0 0.0
.data 3208 3208 0 0.0
.rodata 78771 78771 0 0.0
.text 562760 562760 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 617842 617842 0 0.0
.app_xip_area 524880 524880 0 0.0
.bss 75628 75628 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 612534 612534 0 0.0
.app_xip_area 521052 521052 0 0.0
.bss 74180 74180 0 0.0
.data 648 648 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 565322 565322 0 0.0
.app_xip_area 464252 464252 0 0.0
.bss 83472 83472 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 905540 905540 0 0.0
(read/write) 128628 128628 0 0.0
.bss 126592 126592 0 0.0
.data 2036 2036 0 0.0
.text 905532 905532 0 0.0
BRD4161A+rpc (read only) 939900 939900 0 0.0
(read/write) 145312 145312 0 0.0
.bss 143072 143072 0 0.0
.data 2240 2240 0 0.0
.text 939892 939892 0 0.0
window-app BRD4161A (read only) 842996 842996 0 0.0
(read/write) 126712 126712 0 0.0
.bss 124768 124768 0 0.0
.data 1944 1944 0 0.0
.text 842988 842988 0 0.0
esp32 all-clusters-app c3devkit (read only) 980922 980922 0 0.0
(read/write) 1397714 1397714 0 0.0
.dram0.bss 62352 62352 0 0.0
.dram0.data 14412 14412 0 0.0
.flash.rodata 202040 202040 0 0.0
.flash.text 980922 980922 0 0.0
.iram0.text 62020 62020 0 0.0
m5stack (read only) 1036355 1036355 0 0.0
(read/write) 465456 465456 0 0.0
.dram0.bss 67872 67872 0 0.0
.dram0.data 34152 34152 0 0.0
.flash.rodata 231596 231596 0 0.0
.flash.text 1030971 1030971 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 683720 683720 0 0.0
.bss 77632 77632 0 0.0
.data 1992 1992 0 0.0
.text 598296 598296 0 0.0
lock k32w061+release (read/write) 724704 724704 0 0.0
.bss 78264 78264 0 0.0
.data 1952 1952 0 0.0
.text 638688 638688 0 0.0
linux all-clusters-app debug (read only) 2706137 2706137 0 0.0
(read/write) 149536 149536 0 0.0
.bss 59872 59872 0 0.0
.data 1920 1920 0 0.0
.data.rel.ro 81672 81672 0 0.0
.dynamic 608 608 0 0.0
.got 4448 4448 0 0.0
.init 27 27 0 0.0
.init_array 984 984 0 0.0
.rodata 233349 233349 0 0.0
.text 2297922 2297922 0 0.0
bridge-app debug+rpc (read only) 1839053 1839053 0 0.0
(read/write) 91856 91856 0 0.0
.bss 44136 44136 0 0.0
.data 2912 2912 0 0.0
.data.rel.ro 39744 39744 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 149089 149089 0 0.0
.text 1570821 1570821 0 0.0
chip-tool debug (read only) 10878005 10878005 0 0.0
(read/write) 374192 374192 0 0.0
.bss 22592 22592 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 344232 344232 0 0.0
.dynamic 624 624 0 0.0
.got 4936 4936 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 545933 545933 0 0.0
.text 9496357 9496357 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10495100 10495100 0 0.0
(read/write) 495713 495713 0 0.0
.bss 40865 40865 0 0.0
.data 1184 1184 0 0.0
.data.rel.ro 391400 391400 0 0.0
.dynamic 560 560 0 0.0
.got 58464 58464 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 519596 519596 0 0.0
.text 8862644 8862644 0 0.0
lighting-app debug+rpc (read only) 2316233 2316233 0 0.0
(read/write) 127952 127952 0 0.0
.bss 49920 49920 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 70360 70360 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 183249 183249 0 0.0
.text 1966322 1966322 0 0.0
lock-app debug (read only) 2139897 2139897 0 0.0
(read/write) 120216 120216 0 0.0
.bss 47744 47744 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 65416 65416 0 0.0
.dynamic 592 592 0 0.0
.got 4248 4248 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 189633 189633 0 0.0
.text 1793298 1793298 0 0.0
ota-provider-app debug (read only) 2049145 2049145 0 0.0
(read/write) 115584 115584 0 0.0
.bss 47936 47936 0 0.0
.data 1640 1640 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 608 608 0 0.0
.got 4448 4448 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 173595 173595 0 0.0
.text 1718338 1718338 0 0.0
ota-requestor-app debug (read only) 2080025 2080025 0 0.0
(read/write) 118392 118392 0 0.0
.bss 48608 48608 0 0.0
.data 1896 1896 0 0.0
.data.rel.ro 62296 62296 0 0.0
.dynamic 592 592 0 0.0
.got 4288 4288 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 169980 169980 0 0.0
.text 1751346 1751346 0 0.0
shell debug (read only) 2533065 2533065 0 0.0
(read/write) 150280 150280 0 0.0
.bss 67272 67272 0 0.0
.data 1296 1296 0 0.0
.data.rel.ro 76000 76000 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 215442 215442 0 0.0
.text 2155666 2155666 0 0.0
thermostat-no-ble arm64 (read only) 2358260 2358260 0 0.0
(read/write) 151073 151073 0 0.0
.bss 62849 62849 0 0.0
.data 1440 1440 0 0.0
.data.rel.ro 79040 79040 0 0.0
.dynamic 560 560 0 0.0
.got 4728 4728 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 145156 145156 0 0.0
.text 1983968 1983968 0 0.0
tv-app debug (read only) 2833705 2833705 0 0.0
(read/write) 253104 253104 0 0.0
.bss 165880 165880 0 0.0
.data 4448 4448 0 0.0
.data.rel.ro 76568 76568 0 0.0
.dynamic 592 592 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 215371 215371 0 0.0
.text 2435922 2435922 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2409748 2409748 0 0.0
.bss 184972 184972 0 0.0
.data 5840 5840 0 0.0
.text 1372348 1372348 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1164331 1164331 0 0.0
bss 136240 136240 0 0.0
rodata 147484 147484 0 0.0
text 801948 801948 0 0.0
p6 all-clusters-app default (read/write) 2517448 2517448 0 0.0
.bss 118344 118344 0 0.0
.data 2768 2768 0 0.0
.text 1475712 1475712 0 0.0
light-app default (read/write) 2416120 2416120 0 0.0
.bss 111824 111824 0 0.0
.data 2576 2576 0 0.0
.text 1374384 1374384 0 0.0
lock-app default (read/write) 2420024 2420024 0 0.0
.bss 111624 111624 0 0.0
.data 2536 2536 0 0.0
.text 1378288 1378288 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 800756 800756 0 0.0
bss 69672 69672 0 0.0
noinit 40416 40416 0 0.0
text 569896 569896 0 0.0

@bzbarsky-apple bzbarsky-apple merged commit bd2c21a into project-chip:master Apr 20, 2022
@pankore pankore deleted the fix_config branch April 22, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@woody-apple woody-apple woody-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pankore @woody-apple @Damian-Nordic @bzbarsky-apple @restyled-commits