Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support remove fabric for access control extension #17032

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Support remove fabric for access control extension #17032

merged 1 commit into from
Apr 5, 2022

Conversation

mlepage-google
Copy link
Contributor

Problem

Extension attribute needs its fabric scoped data removed
when the fabric is removed.

Part of issue #10252

Change overview

Add fabric table delegate to listen for fabric removal notifications.

Use them to remove the fabric-scoped extension data.

Testing

  • Ran chip-all-clusters-app with chip-tool on Linux
  • Added extension, verified data present in /tmp/chip_kvs
  • Removed fabric, verified data absent in /tmp/chip_kvs

@boring-cyborg boring-cyborg bot added the app label Apr 5, 2022
@mlepage-google
Copy link
Contributor Author

Needs to be rebased/built off PR #17008

@woody-apple
Copy link
Contributor

/rebase

@mlepage-google @woody-apple
Support remove fabric for access control extension
7c64305 
Extension attribute needs its fabric scoped data removed
when the fabric is removed.

Part of issue project-chip#10252
@woody-apple woody-apple force-pushed the extension-remove-fabric branch from bd79939 to 7c64305 Compare April 5, 2022 01:12
@github-actions
Copy link

github-actions bot commented Apr 5, 2022 •
edited
Loading

PR #17032: Size comparison from 913aca0 to 7c64305

Increases (18 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 913aca0 7c64305 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 670511 670735 224 0.0
.bss 81752 81760 8 0.0
.rodata 79975 80039 64 0.1
.text 590056 590216 160 0.0
lock-mtd LP_CC2652R7 (read only) 619639 619863 224 0.0
(read/write) 154500 154508 8 0.0
.bss 77480 77488 8 0.0
.rodata 79863 79927 64 0.1
.text 539288 539448 160 0.0
pump-app LP_CC2652R7 (read only) 689983 690199 216 0.0
.bss 82152 82168 16 0.0
.rodata 82063 82119 56 0.1
.text 607436 607596 160 0.0
pump-controller-app LP_CC2652R7 (read only) 672207 672439 232 0.0
.bss 81888 81896 8 0.0
.rodata 78399 78455 56 0.1
.text 593324 593500 176 0.0
efr32 lighting-app BRD4161A (read only) 919164 919420 256 0.0
(read/write) 129784 129792 8 0.0
.bss 127792 127800 8 0.0
.text 919156 919412 256 0.0
BRD4161A+rpc (read only) 947060 947316 256 0.0
(read/write) 145732 145740 8 0.0
.bss 143560 143568 8 0.0
.text 947052 947308 256 0.0
window-app BRD4161A (read only) 854380 854636 256 0.0
(read/write) 127808 127816 8 0.0
.bss 125936 125944 8 0.0
.text 854372 854628 256 0.0
esp32 all-clusters-app c3devkit (read only) 988094 988250 156 0.0
(read/write) 1460842 1460922 80 0.0
.dram0.bss 62944 62952 8 0.0
.flash.rodata 198224 198288 64 0.0
.flash.text 988094 988250 156 0.0
m5stack (read only) 1040455 1040599 144 0.0
(read/write) 461840 461912 72 0.0
.dram0.bss 68472 68480 8 0.0
.flash.rodata 227168 227232 64 0.0
.flash.text 1035071 1035215 144 0.0
k32w light k32w061+release (read/write) 710388 710620 232 0.0
.bss 77952 77968 16 0.0
.text 624732 624948 216 0.0
lock k32w061+release (read/write) 709784 710024 240 0.0
.bss 77952 77960 8 0.0
.text 624088 624320 232 0.0
linux thermostat-no-ble arm64 (read only) 2324428 2325020 592 0.0
(read/write) 149441 149521 80 0.1
.bss 62945 62977 32 0.1
.data.rel.ro 77704 77760 56 0.1
.rodata 143308 143340 32 0.0
.text 1955408 1955840 432 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2362700 2362956 256 0.0
.bss 185036 185052 16 0.0
.text 1325300 1325556 256 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151231 1151471 240 0.0
bss 143060 143072 12 0.0
rodata 143592 143656 64 0.0
text 789708 789880 172 0.0
p6 all-clusters-app default (read/write) 2507528 2507784 256 0.0
.bss 118472 118480 8 0.0
.text 1465792 1466048 256 0.0
light-app default (read/write) 2408704 2408960 256 0.0
.bss 111928 111944 16 0.0
.text 1366968 1367224 256 0.0
lock-app default (read/write) 2372352 2372608 256 0.0
.bss 111672 111688 16 0.0
.text 1330616 1330872 256 0.0
telink lighting-app tlsr9518adk80d (read/write) 794808 795080 272 0.0
bss 70288 70300 12 0.0
text 564354 564544 190 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section 913aca0 7c64305 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 181200 180984 -216 -0.1
pump-app LP_CC2652R7 (read/write) 162896 162696 -200 -0.1
pump-controller-app LP_CC2652R7 (read/write) 180408 180184 -224 -0.1
Full report (19 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 913aca0 7c64305 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 670511 670735 224 0.0
(read/write) 181200 180984 -216 -0.1
.bss 81752 81760 8 0.0
.data 3164 3164 0 0.0
.rodata 79975 80039 64 0.1
.text 590056 590216 160 0.0
lock-mtd LP_CC2652R7 (read only) 619639 619863 224 0.0
(read/write) 154500 154508 8 0.0
.bss 77480 77488 8 0.0
.data 3164 3164 0 0.0
.rodata 79863 79927 64 0.1
.text 539288 539448 160 0.0
pump-app LP_CC2652R7 (read only) 689983 690199 216 0.0
(read/write) 162896 162696 -200 -0.1
.bss 82152 82168 16 0.0
.data 3196 3196 0 0.0
.rodata 82063 82119 56 0.1
.text 607436 607596 160 0.0
pump-controller-app LP_CC2652R7 (read only) 672207 672439 232 0.0
(read/write) 180408 180184 -224 -0.1
.bss 81888 81896 8 0.0
.data 3160 3160 0 0.0
.rodata 78399 78455 56 0.1
.text 593324 593500 176 0.0
efr32 lighting-app BRD4161A (read only) 919164 919420 256 0.0
(read/write) 129784 129792 8 0.0
.bss 127792 127800 8 0.0
.data 1992 1992 0 0.0
.text 919156 919412 256 0.0
BRD4161A+rpc (read only) 947060 947316 256 0.0
(read/write) 145732 145740 8 0.0
.bss 143560 143568 8 0.0
.data 2172 2172 0 0.0
.text 947052 947308 256 0.0
window-app BRD4161A (read only) 854380 854636 256 0.0
(read/write) 127808 127816 8 0.0
.bss 125936 125944 8 0.0
.data 1872 1872 0 0.0
.text 854372 854628 256 0.0
esp32 all-clusters-app c3devkit (read only) 988094 988250 156 0.0
(read/write) 1460842 1460922 80 0.0
.dram0.bss 62944 62952 8 0.0
.dram0.data 14196 14196 0 0.0
.flash.rodata 198224 198288 64 0.0
.flash.text 988094 988250 156 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1040455 1040599 144 0.0
(read/write) 461840 461912 72 0.0
.dram0.bss 68472 68480 8 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 227168 227232 64 0.0
.flash.text 1035071 1035215 144 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 710388 710620 232 0.0
.bss 77952 77968 16 0.0
.data 1904 1904 0 0.0
.text 624732 624948 216 0.0
lock k32w061+release (read/write) 709784 710024 240 0.0
.bss 77952 77960 8 0.0
.data 1944 1944 0 0.0
.text 624088 624320 232 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10083572 10083572 0 0.0
(read/write) 486977 486977 0 0.0
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 384712 384712 0 0.0
.dynamic 560 560 0 0.0
.got 57008 57008 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 508404 508404 0 0.0
.text 8484324 8484324 0 0.0
thermostat-no-ble arm64 (read only) 2324428 2325020 592 0.0
(read/write) 149441 149521 80 0.1
.bss 62945 62977 32 0.1
.data 1136 1136 0 0.0
.data.rel.ro 77704 77760 56 0.1
.dynamic 560 560 0 0.0
.got 4632 4632 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 143308 143340 32 0.0
.text 1955408 1955840 432 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2362700 2362956 256 0.0
.bss 185036 185052 16 0.0
.data 5784 5784 0 0.0
.text 1325300 1325556 256 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151231 1151471 240 0.0
bss 143060 143072 12 0.0
rodata 143592 143656 64 0.0
text 789708 789880 172 0.0
p6 all-clusters-app default (read/write) 2507528 2507784 256 0.0
.bss 118472 118480 8 0.0
.data 2672 2672 0 0.0
.text 1465792 1466048 256 0.0
light-app default (read/write) 2408704 2408960 256 0.0
.bss 111928 111944 16 0.0
.data 2528 2528 0 0.0
.text 1366968 1367224 256 0.0
lock-app default (read/write) 2372352 2372608 256 0.0
.bss 111672 111688 16 0.0
.data 2488 2488 0 0.0
.text 1330616 1330872 256 0.0
telink lighting-app tlsr9518adk80d (read/write) 794808 795080 272 0.0
bss 70288 70300 12 0.0
noinit 40416 40416 0 0.0
text 564354 564544 190 0.0

@mlepage-google mlepage-google merged commit 2ff1d72 into project-chip:master Apr 5, 2022
@mlepage-google mlepage-google deleted the extension-remove-fabric branch April 5, 2022 04:44
@mlepage-google mlepage-google mentioned this pull request Apr 5, 2022
Closed
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@mlepage-google @chencheung
Support remove fabric for access control extension (project-chip#17032)
784f01f 
Extension attribute needs its fabric scoped data removed
when the fabric is removed.

Part of issue project-chip#10252
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@mlepage-google @chencheung
Support remove fabric for access control extension (project-chip#17032)
a96adaa 
Extension attribute needs its fabric scoped data removed
when the fabric is removed.

Part of issue project-chip#10252
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@mlepage-google @andrei-menzopol
Support remove fabric for access control extension (project-chip#17032)
8f5b80c 
Extension attribute needs its fabric scoped data removed
when the fabric is removed.

Part of issue project-chip#10252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@cecille cecille cecille approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@msandstedt msandstedt Awaiting requested review from msandstedt

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mlepage-google @woody-apple @tcarmelveilleux @msandstedt @cecille