WindowCovering: Cleanup enum xml #16992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov and
LuDuda
|
PR #16992: Size comparison from 3666138 to 6478181 Increases above 0.2%:
Increases (2 builds for linux)
Decreases (1 build for linux)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmartinez-silabs
approved these changes
Apr 4, 2022
woody-apple
approved these changes
Apr 4, 2022
jmeg-sfy
changed the title
invalid operands to binary expression ('chip::app::Clusters::WindowCovering::EndProductType' and 'int')
CheckConstraintNotValue("endProductType", endProductType, 250)
+ Update LCDPainter
jmeg-sfy
force-pushed
the
jmeg-sfy/window-covering-enum-xml
branch
from
a1c9283 to
f10d38f
Compare
|
PR #16992: Size comparison from e92157a to f10d38f Increases above 0.2%:
Increases (2 builds for linux)
Decreases (1 build for linux)
Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Apr 5, 2022
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
* DEV: Update XML enum declaration and ZAP
* DEV: Update attribute access for Window-covering-server
* DEV: Update CycleType in WindowApp
* DEV: Update LCD painter to new enun + use uint16_t instead of uint8_t
* DEV: LCD Painter move namespace
* Test config disable test on WNCV 2.1
invalid operands to binary expression ('chip::app::Clusters::WindowCovering::EndProductType' and 'int')
CheckConstraintNotValue("endProductType", endProductType, 250)
* DEV: Fix missing update
* FIX: UpdateLCD must not be called outside the app Task
+ Update LCDPainter
* Restyled by clang-format
* DEV: remove comment useless
* fix: Includes: keep order in the right position from clang-format
* FIX: Remove leftover enum declaration from helper.js
Co-authored-by: Restyled.io <[email protected]>
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
* DEV: Update XML enum declaration and ZAP
* DEV: Update attribute access for Window-covering-server
* DEV: Update CycleType in WindowApp
* DEV: Update LCD painter to new enun + use uint16_t instead of uint8_t
* DEV: LCD Painter move namespace
* Test config disable test on WNCV 2.1
invalid operands to binary expression ('chip::app::Clusters::WindowCovering::EndProductType' and 'int')
CheckConstraintNotValue("endProductType", endProductType, 250)
* DEV: Fix missing update
* FIX: UpdateLCD must not be called outside the app Task
+ Update LCDPainter
* Restyled by clang-format
* DEV: remove comment useless
* fix: Includes: keep order in the right position from clang-format
* FIX: Remove leftover enum declaration from helper.js
Co-authored-by: Restyled.io <[email protected]>
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
* DEV: Update XML enum declaration and ZAP
* DEV: Update attribute access for Window-covering-server
* DEV: Update CycleType in WindowApp
* DEV: Update LCD painter to new enun + use uint16_t instead of uint8_t
* DEV: LCD Painter move namespace
* Test config disable test on WNCV 2.1
invalid operands to binary expression ('chip::app::Clusters::WindowCovering::EndProductType' and 'int')
CheckConstraintNotValue("endProductType", endProductType, 250)
* DEV: Fix missing update
* FIX: UpdateLCD must not be called outside the app Task
+ Update LCDPainter
* Restyled by clang-format
* DEV: remove comment useless
* fix: Includes: keep order in the right position from clang-format
* FIX: Remove leftover enum declaration from helper.js
Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
This PR cleanup the code base from #define constant value to use kConstant enum
Also we update the LCD code to use uint16_t instead of uint8_t
DISABLE some minor test on WNCV 2.1 due to ZAP giving issues comparing enum with CheckConstraintNotValue
invalid operands to binary expression ('chip::app::Clusters::WindowCovering::EndProductType' and 'int')
CheckConstraintNotValue("endProductType", endProductType, 250)
Testing
How was this tested? (at least one bullet point required)