Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nrfconnect] Refactored configuration for the nrfconnect examples #16991

Merged
merged 1 commit into from
Apr 5, 2022
Merged

[nrfconnect] Refactored configuration for the nrfconnect examples #16991

merged 1 commit into from
Apr 5, 2022

Conversation

kkasperczyk-no
Copy link
Contributor

Problem

nrfconnect platform uses Kconfig overlays and defaults in a way that is not consistent with the nRF Connect SDK recommendations

Change overview

  • Created Kconfig.defaults that set default configs common for all examples (replaced sample-defaults.conf)
  • Created Kconfig.features that allows to configure set of options within single feature using single option
  • Replaced approach of adding overlays in example cmake file with the pattern of placing prj.conf files in a configuration/build-target/ location that allows adding config files to the build automatically by the toolchain.
  • Created debug and release configuration variants for several examples.

Testing

Tested manually builds and basic functionalities, however change should not introduce functional changes, as it's only structural refactor.

@github-actions
Copy link

github-actions bot commented Apr 4, 2022 •
edited
Loading

PR #16991: Size comparison from a208c3d to cb2698c

Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section a208c3d cb2698c change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668091 668091 0 0.0
(read/write) 183604 183604 0 0.0
.bss 81736 81736 0 0.0
.data 3128 3128 0 0.0
.rodata 79683 79683 0 0.0
.text 587928 587928 0 0.0
lock-mtd LP_CC2652R7 (read only) 617211 617211 0 0.0
(read/write) 154448 154448 0 0.0
.bss 77464 77464 0 0.0
.data 3128 3128 0 0.0
.rodata 79563 79563 0 0.0
.text 537160 537160 0 0.0
pump-app LP_CC2652R7 (read only) 687543 687543 0 0.0
(read/write) 165312 165312 0 0.0
.bss 82128 82128 0 0.0
.data 3160 3160 0 0.0
.rodata 81759 81759 0 0.0
.text 605300 605300 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669775 669775 0 0.0
(read/write) 182824 182824 0 0.0
.bss 81872 81872 0 0.0
.data 3124 3124 0 0.0
.rodata 78095 78095 0 0.0
.text 591196 591196 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610682 610682 0 0.0
.app_xip_area 517456 517456 0 0.0
.bss 75980 75980 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 568202 568202 0 0.0
.app_xip_area 476504 476504 0 0.0
.bss 74484 74484 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 579790 579790 0 0.0
.app_xip_area 478460 478460 0 0.0
.bss 83796 83796 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916168 916168 0 0.0
(read/write) 129728 129728 0 0.0
.bss 127768 127768 0 0.0
.data 1956 1956 0 0.0
.text 916160 916160 0 0.0
BRD4161A+rpc (read only) 944048 944048 0 0.0
(read/write) 145680 145680 0 0.0
.bss 143544 143544 0 0.0
.data 2136 2136 0 0.0
.text 944040 944040 0 0.0
window-app BRD4161A (read only) 851480 851480 0 0.0
(read/write) 127752 127752 0 0.0
.bss 125912 125912 0 0.0
.data 1836 1836 0 0.0
.text 851472 851472 0 0.0
esp32 all-clusters-app c3devkit (read only) 985940 985940 0 0.0
(read/write) 1460530 1460530 0 0.0
.dram0.bss 62920 62920 0 0.0
.dram0.data 14164 14164 0 0.0
.flash.rodata 197960 197960 0 0.0
.flash.text 985940 985940 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1038339 1038339 0 0.0
(read/write) 461544 461544 0 0.0
.dram0.bss 68448 68448 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 226928 226928 0 0.0
.flash.text 1032955 1032955 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 707908 707908 0 0.0
.bss 77944 77944 0 0.0
.data 1868 1868 0 0.0
.text 622296 622296 0 0.0
lock k32w061+release (read/write) 707316 707316 0 0.0
.bss 77928 77928 0 0.0
.data 1908 1908 0 0.0
.text 621680 621680 0 0.0
linux all-clusters-app debug (read only) 2576609 2576609 0 0.0
(read/write) 144360 144360 0 0.0
.bss 57536 57536 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 79608 79608 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 220549 220549 0 0.0
.text 2188642 2188642 0 0.0
bridge-app debug+rpc (read only) 1787181 1787181 0 0.0
(read/write) 89912 89912 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 38320 38320 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 146937 146937 0 0.0
.text 1524213 1524213 0 0.0
chip-tool debug (read only) 10436029 10436029 0 0.0
(read/write) 358552 358552 0 0.0
.bss 22016 22016 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 329272 329272 0 0.0
.dynamic 624 624 0 0.0
.got 4896 4896 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 532205 532205 0 0.0
.text 9111349 9111349 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10036540 10036540 0 0.0
(read/write) 478177 478177 0 0.0
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 376144 376144 0 0.0
.dynamic 560 560 0 0.0
.got 56768 56768 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 506524 506524 0 0.0
.text 8465492 8465492 0 0.0
door-lock-app debug (read only) 2057977 2057977 0 0.0
(read/write) 117808 117808 0 0.0
.bss 47776 47776 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 63416 63416 0 0.0
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 184873 184873 0 0.0
.text 1719890 1719890 0 0.0
lighting-app debug+rpc (read only) 2236209 2236209 0 0.0
(read/write) 124800 124800 0 0.0
.bss 49120 49120 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 68488 68488 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 179017 179017 0 0.0
.text 1894514 1894514 0 0.0
ota-provider-app debug (read only) 1995985 1995985 0 0.0
(read/write) 113408 113408 0 0.0
.bss 47616 47616 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 58728 58728 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 170707 170707 0 0.0
.text 1671154 1671154 0 0.0
ota-requestor-app debug (read only) 2024785 2024785 0 0.0
(read/write) 116632 116632 0 0.0
.bss 48608 48608 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 60936 60936 0 0.0
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 166908 166908 0 0.0
.text 1702098 1702098 0 0.0
shell debug (read only) 2473937 2473937 0 0.0
(read/write) 147888 147888 0 0.0
.bss 67240 67240 0 0.0
.data 784 784 0 0.0
.data.rel.ro 74136 74136 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212338 212338 0 0.0
.text 2103666 2103666 0 0.0
thermostat-no-ble arm64 (read only) 2311068 2311068 0 0.0
(read/write) 149057 149057 0 0.0
.bss 62913 62913 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 77488 77488 0 0.0
.dynamic 560 560 0 0.0
.got 4568 4568 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 142908 142908 0 0.0
.text 1943040 1943040 0 0.0
tv-app debug (read only) 2741337 2741337 0 0.0
(read/write) 249312 249312 0 0.0
.bss 165200 165200 0 0.0
.data 3296 3296 0 0.0
.data.rel.ro 74648 74648 0 0.0
.dynamic 592 592 0 0.0
.got 4656 4656 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 210635 210635 0 0.0
.text 2352882 2352882 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360020 2360020 0 0.0
.bss 185020 185020 0 0.0
.data 5752 5752 0 0.0
.text 1322620 1322620 0 0.0
p6 all-clusters-app default (read/write) 2504592 2504592 0 0.0
.bss 118456 118456 0 0.0
.data 2632 2632 0 0.0
.text 1462856 1462856 0 0.0
light-app default (read/write) 2405752 2405752 0 0.0
.bss 111912 111912 0 0.0
.data 2488 2488 0 0.0
.text 1364016 1364016 0 0.0
lock-app default (read/write) 2369384 2369384 0 0.0
.bss 111656 111656 0 0.0
.data 2448 2448 0 0.0
.text 1327648 1327648 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 792340 792340 0 0.0
bss 70264 70264 0 0.0
noinit 40416 40416 0 0.0
text 562250 562250 0 0.0

@github-actions
Copy link

github-actions bot commented Apr 4, 2022 •
edited
Loading

PR #16991: Size comparison from 3666138 to 619f684

Increases above 0.2%:

platform target config section 3666138 619f684 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 143292 144720 1428 1.0
pigweed-app nrf52840dk_nrf52840 (read/write) 557047 561943 4896 0.9
rodata 45368 46024 656 1.4
text 382568 386672 4104 1.1
shell nrf52840dk_nrf52840 (read/write) 802171 807083 4912 0.6
rodata 73756 74444 688 0.9
text 537412 541360 3948 0.7
Increases (3 builds for nrfconnect)
platform target config section 3666138 619f684 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 143292 144720 1428 1.0
text 787612 787940 328 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 557047 561943 4896 0.9
bss 69672 69724 52 0.1
rodata 45368 46024 656 1.4
text 382568 386672 4104 1.1
shell nrf52840dk_nrf52840 (read/write) 802171 807083 4912 0.6
bss 117376 117432 56 0.0
rodata 73756 74444 688 0.9
text 537412 541360 3948 0.7
Decreases (1 build for nrfconnect)
platform target config section 3666138 619f684 change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148795 1146927 -1868 -0.2
bss 143048 135788 -7260 -5.1
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 3666138 619f684 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668091 668091 0 0.0
(read/write) 183604 183604 0 0.0
.bss 81736 81736 0 0.0
.data 3128 3128 0 0.0
.rodata 79683 79683 0 0.0
.text 587928 587928 0 0.0
lock-mtd LP_CC2652R7 (read only) 617211 617211 0 0.0
(read/write) 154448 154448 0 0.0
.bss 77464 77464 0 0.0
.data 3128 3128 0 0.0
.rodata 79563 79563 0 0.0
.text 537160 537160 0 0.0
pump-app LP_CC2652R7 (read only) 687543 687543 0 0.0
(read/write) 165312 165312 0 0.0
.bss 82128 82128 0 0.0
.data 3160 3160 0 0.0
.rodata 81759 81759 0 0.0
.text 605300 605300 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669775 669775 0 0.0
(read/write) 182824 182824 0 0.0
.bss 81872 81872 0 0.0
.data 3124 3124 0 0.0
.rodata 78095 78095 0 0.0
.text 591196 591196 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610682 610682 0 0.0
.app_xip_area 517456 517456 0 0.0
.bss 75980 75980 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 568202 568202 0 0.0
.app_xip_area 476504 476504 0 0.0
.bss 74484 74484 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 579790 579790 0 0.0
.app_xip_area 478460 478460 0 0.0
.bss 83796 83796 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916168 916168 0 0.0
(read/write) 129728 129728 0 0.0
.bss 127768 127768 0 0.0
.data 1956 1956 0 0.0
.text 916160 916160 0 0.0
BRD4161A+rpc (read only) 944048 944048 0 0.0
(read/write) 145680 145680 0 0.0
.bss 143544 143544 0 0.0
.data 2136 2136 0 0.0
.text 944040 944040 0 0.0
window-app BRD4161A (read only) 851480 851480 0 0.0
(read/write) 127752 127752 0 0.0
.bss 125912 125912 0 0.0
.data 1836 1836 0 0.0
.text 851472 851472 0 0.0
esp32 all-clusters-app c3devkit (read only) 985940 985940 0 0.0
(read/write) 1460530 1460530 0 0.0
.dram0.bss 62920 62920 0 0.0
.dram0.data 14164 14164 0 0.0
.flash.rodata 197960 197960 0 0.0
.flash.text 985940 985940 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1038339 1038339 0 0.0
(read/write) 461544 461544 0 0.0
.dram0.bss 68448 68448 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 226928 226928 0 0.0
.flash.text 1032955 1032955 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 707908 707908 0 0.0
.bss 77944 77944 0 0.0
.data 1868 1868 0 0.0
.text 622296 622296 0 0.0
lock k32w061+release (read/write) 707316 707316 0 0.0
.bss 77928 77928 0 0.0
.data 1908 1908 0 0.0
.text 621680 621680 0 0.0
linux all-clusters-app debug (read only) 2576609 2576609 0 0.0
(read/write) 144360 144360 0 0.0
.bss 57536 57536 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 79608 79608 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 220549 220549 0 0.0
.text 2188642 2188642 0 0.0
bridge-app debug+rpc (read only) 1787181 1787181 0 0.0
(read/write) 89912 89912 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 38320 38320 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 146937 146937 0 0.0
.text 1524213 1524213 0 0.0
chip-tool debug (read only) 10436029 10436029 0 0.0
(read/write) 358552 358552 0 0.0
.bss 22016 22016 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 329272 329272 0 0.0
.dynamic 624 624 0 0.0
.got 4896 4896 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 532205 532205 0 0.0
.text 9111349 9111349 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10036540 10036540 0 0.0
(read/write) 478177 478177 0 0.0
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 376144 376144 0 0.0
.dynamic 560 560 0 0.0
.got 56768 56768 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 506524 506524 0 0.0
.text 8465492 8465492 0 0.0
door-lock-app debug (read only) 2057977 2057977 0 0.0
(read/write) 117808 117808 0 0.0
.bss 47776 47776 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 63416 63416 0 0.0
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 184873 184873 0 0.0
.text 1719890 1719890 0 0.0
lighting-app debug+rpc (read only) 2236209 2236209 0 0.0
(read/write) 124800 124800 0 0.0
.bss 49120 49120 0 0.0
.data 1504 1504 0 0.0
.data.rel.ro 68488 68488 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 179017 179017 0 0.0
.text 1894514 1894514 0 0.0
ota-provider-app debug (read only) 1995985 1995985 0 0.0
(read/write) 113408 113408 0 0.0
.bss 47616 47616 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 58728 58728 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 170707 170707 0 0.0
.text 1671154 1671154 0 0.0
ota-requestor-app debug (read only) 2024785 2024785 0 0.0
(read/write) 116632 116632 0 0.0
.bss 48608 48608 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 60936 60936 0 0.0
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 166908 166908 0 0.0
.text 1702098 1702098 0 0.0
shell debug (read only) 2473937 2473937 0 0.0
(read/write) 147888 147888 0 0.0
.bss 67240 67240 0 0.0
.data 784 784 0 0.0
.data.rel.ro 74136 74136 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212338 212338 0 0.0
.text 2103666 2103666 0 0.0
thermostat-no-ble arm64 (read only) 2311068 2311068 0 0.0
(read/write) 149057 149057 0 0.0
.bss 62913 62913 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 77488 77488 0 0.0
.dynamic 560 560 0 0.0
.got 4568 4568 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 142908 142908 0 0.0
.text 1943040 1943040 0 0.0
tv-app debug (read only) 2741337 2741337 0 0.0
(read/write) 249312 249312 0 0.0
.bss 165200 165200 0 0.0
.data 3296 3296 0 0.0
.data.rel.ro 74648 74648 0 0.0
.dynamic 592 592 0 0.0
.got 4656 4656 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 210635 210635 0 0.0
.text 2352882 2352882 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360020 2360020 0 0.0
.bss 185020 185020 0 0.0
.data 5752 5752 0 0.0
.text 1322620 1322620 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148795 1146927 -1868 -0.2
bss 143048 135788 -7260 -5.1
rodata 143292 144720 1428 1.0
text 787612 787940 328 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1133875 1133875 0 0.0
bss 139492 139492 0 0.0
rodata 120268 120268 0 0.0
text 795604 795604 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1098083 1098083 0 0.0
bss 139728 139728 0 0.0
rodata 111412 111412 0 0.0
text 767972 767972 0 0.0
nrf52840dongle_nrf52840 (read/write) 1148307 1148307 0 0.0
bss 140492 140492 0 0.0
rodata 119864 119864 0 0.0
text 798492 798492 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1042654 1042654 0 0.0
bss 136556 136556 0 0.0
rodata 113460 113460 0 0.0
text 710768 710768 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1034319 1034319 0 0.0
bss 129440 129440 0 0.0
rodata 113192 113192 0 0.0
text 713272 713272 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 943358 943358 0 0.0
bss 126536 126536 0 0.0
rodata 106436 106436 0 0.0
text 628588 628588 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 557047 561943 4896 0.9
bss 69672 69724 52 0.1
rodata 45368 46024 656 1.4
text 382568 386672 4104 1.1
pump-app nrf52840dk_nrf52840 (read/write) 1053247 1053247 0 0.0
bss 129356 129356 0 0.0
rodata 115272 115272 0 0.0
text 730096 730096 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1035415 1035415 0 0.0
bss 129100 129100 0 0.0
rodata 111488 111488 0 0.0
text 716336 716336 0 0.0
shell nrf52840dk_nrf52840 (read/write) 802171 807083 4912 0.6
bss 117376 117432 56 0.0
rodata 73756 74444 688 0.9
text 537412 541360 3948 0.7
p6 all-clusters-app default (read/write) 2504592 2504592 0 0.0
.bss 118456 118456 0 0.0
.data 2632 2632 0 0.0
.text 1462856 1462856 0 0.0
light-app default (read/write) 2405752 2405752 0 0.0
.bss 111912 111912 0 0.0
.data 2488 2488 0 0.0
.text 1364016 1364016 0 0.0
lock-app default (read/write) 2369384 2369384 0 0.0
.bss 111656 111656 0 0.0
.data 2448 2448 0 0.0
.text 1327648 1327648 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 792340 792340 0 0.0
bss 70264 70264 0 0.0
noinit 40416 40416 0 0.0
text 562250 562250 0 0.0

woody-apple
woody-apple approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking platform changes

@github-actions
Copy link

github-actions bot commented Apr 5, 2022 •
edited
Loading

PR #16991: Size comparison from 2ff1d72 to 7f7f921

Full report (25 builds for cc13x2_26x2, efr32, k32w, linux, mbed, p6, telink)
platform target config section 2ff1d72 7f7f921 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 670735 670735 0 0.0
(read/write) 180984 180984 0 0.0
.bss 81760 81760 0 0.0
.data 3164 3164 0 0.0
.rodata 80039 80039 0 0.0
.text 590216 590216 0 0.0
lock-mtd LP_CC2652R7 (read only) 619863 619863 0 0.0
(read/write) 154508 154508 0 0.0
.bss 77488 77488 0 0.0
.data 3164 3164 0 0.0
.rodata 79927 79927 0 0.0
.text 539448 539448 0 0.0
pump-app LP_CC2652R7 (read only) 690199 690199 0 0.0
(read/write) 162696 162696 0 0.0
.bss 82168 82168 0 0.0
.data 3196 3196 0 0.0
.rodata 82119 82119 0 0.0
.text 607596 607596 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672439 672439 0 0.0
(read/write) 180184 180184 0 0.0
.bss 81896 81896 0 0.0
.data 3160 3160 0 0.0
.rodata 78455 78455 0 0.0
.text 593500 593500 0 0.0
efr32 lighting-app BRD4161A (read only) 919420 919420 0 0.0
(read/write) 129792 129792 0 0.0
.bss 127800 127800 0 0.0
.data 1992 1992 0 0.0
.text 919412 919412 0 0.0
BRD4161A+rpc (read only) 947316 947316 0 0.0
(read/write) 145740 145740 0 0.0
.bss 143568 143568 0 0.0
.data 2172 2172 0 0.0
.text 947308 947308 0 0.0
window-app BRD4161A (read only) 854636 854636 0 0.0
(read/write) 127816 127816 0 0.0
.bss 125944 125944 0 0.0
.data 1872 1872 0 0.0
.text 854628 854628 0 0.0
k32w light k32w061+release (read/write) 710620 710620 0 0.0
.bss 77968 77968 0 0.0
.data 1904 1904 0 0.0
.text 624948 624948 0 0.0
lock k32w061+release (read/write) 710024 710024 0 0.0
.bss 77960 77960 0 0.0
.data 1944 1944 0 0.0
.text 624320 624320 0 0.0
linux all-clusters-app debug (read only) 2593737 2593737 0 0.0
(read/write) 144872 144872 0 0.0
.bss 57664 57664 0 0.0
.data 1440 1440 0 0.0
.data.rel.ro 79880 79880 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 221285 221285 0 0.0
.text 2204434 2204434 0 0.0
bridge-app debug+rpc (read only) 1803701 1803701 0 0.0
(read/write) 90296 90296 0 0.0
.bss 44584 44584 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38584 38584 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 147513 147513 0 0.0
.text 1539557 1539557 0 0.0
chip-tool debug (read only) 10484645 10484645 0 0.0
(read/write) 367128 367128 0 0.0
.bss 22016 22016 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 337848 337848 0 0.0
.dynamic 624 624 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 534349 534349 0 0.0
.text 9131957 9131957 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10083572 10083572 0 0.0
(read/write) 486977 486977 0 0.0
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 384712 384712 0 0.0
.dynamic 560 560 0 0.0
.got 57008 57008 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 508404 508404 0 0.0
.text 8484324 8484324 0 0.0
door-lock-app debug (read only) 2074673 2074673 0 0.0
(read/write) 118320 118320 0 0.0
.bss 47904 47904 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 63704 63704 0 0.0
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 185513 185513 0 0.0
.text 1735346 1735346 0 0.0
lighting-app debug+rpc (read only) 2253193 2253193 0 0.0
(read/write) 125312 125312 0 0.0
.bss 49216 49216 0 0.0
.data 1600 1600 0 0.0
.data.rel.ro 68808 68808 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 179625 179625 0 0.0
.text 1910290 1910290 0 0.0
ota-provider-app debug (read only) 2012593 2012593 0 0.0
(read/write) 113888 113888 0 0.0
.bss 47744 47744 0 0.0
.data 1384 1384 0 0.0
.data.rel.ro 59032 59032 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 171403 171403 0 0.0
.text 1686466 1686466 0 0.0
ota-requestor-app debug (read only) 2041977 2041977 0 0.0
(read/write) 117176 117176 0 0.0
.bss 48736 48736 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 61240 61240 0 0.0
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 167892 167892 0 0.0
.text 1717682 1717682 0 0.0
shell debug (read only) 2490745 2490745 0 0.0
(read/write) 148336 148336 0 0.0
.bss 67336 67336 0 0.0
.data 848 848 0 0.0
.data.rel.ro 74424 74424 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212978 212978 0 0.0
.text 2119234 2119234 0 0.0
thermostat-no-ble arm64 (read only) 2325020 2325020 0 0.0
(read/write) 149521 149521 0 0.0
.bss 62977 62977 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 77760 77760 0 0.0
.dynamic 560 560 0 0.0
.got 4632 4632 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 143340 143340 0 0.0
.text 1955840 1955840 0 0.0
tv-app debug (read only) 2762281 2762281 0 0.0
(read/write) 249984 249984 0 0.0
.bss 165360 165360 0 0.0
.data 3392 3392 0 0.0
.data.rel.ro 75040 75040 0 0.0
.dynamic 592 592 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 211467 211467 0 0.0
.text 2371986 2371986 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2362956 2362956 0 0.0
.bss 185052 185052 0 0.0
.data 5784 5784 0 0.0
.text 1325556 1325556 0 0.0
p6 all-clusters-app default (read/write) 2507784 2507784 0 0.0
.bss 118480 118480 0 0.0
.data 2672 2672 0 0.0
.text 1466048 1466048 0 0.0
light-app default (read/write) 2408960 2408960 0 0.0
.bss 111944 111944 0 0.0
.data 2528 2528 0 0.0
.text 1367224 1367224 0 0.0
lock-app default (read/write) 2372608 2372608 0 0.0
.bss 111688 111688 0 0.0
.data 2488 2488 0 0.0
.text 1330872 1330872 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 795080 795080 0 0.0
bss 70300 70300 0 0.0
noinit 40416 40416 0 0.0
text 564544 564544 0 0.0

@github-actions
Copy link

github-actions bot commented Apr 5, 2022 •
edited
Loading

PR #16991: Size comparison from e92157a to cc7acde

Full report (27 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, p6, telink)
platform target config section e92157a cc7acde change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 670727 670727 0 0.0
(read/write) 180992 180992 0 0.0
.bss 81760 81760 0 0.0
.data 3164 3164 0 0.0
.rodata 80039 80039 0 0.0
.text 590208 590208 0 0.0
lock-mtd LP_CC2652R7 (read only) 619855 619855 0 0.0
(read/write) 154508 154508 0 0.0
.bss 77488 77488 0 0.0
.data 3164 3164 0 0.0
.rodata 79927 79927 0 0.0
.text 539440 539440 0 0.0
pump-app LP_CC2652R7 (read only) 690191 690191 0 0.0
(read/write) 162704 162704 0 0.0
.bss 82168 82168 0 0.0
.data 3196 3196 0 0.0
.rodata 82119 82119 0 0.0
.text 607588 607588 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672431 672431 0 0.0
(read/write) 180192 180192 0 0.0
.bss 81896 81896 0 0.0
.data 3160 3160 0 0.0
.rodata 78455 78455 0 0.0
.text 593492 593492 0 0.0
efr32 lighting-app BRD4161A (read only) 919500 919500 0 0.0
(read/write) 129792 129792 0 0.0
.bss 127800 127800 0 0.0
.data 1992 1992 0 0.0
.text 919492 919492 0 0.0
BRD4161A+rpc (read only) 947396 947396 0 0.0
(read/write) 145740 145740 0 0.0
.bss 143568 143568 0 0.0
.data 2172 2172 0 0.0
.text 947388 947388 0 0.0
window-app BRD4161A (read only) 854716 854716 0 0.0
(read/write) 127816 127816 0 0.0
.bss 125944 125944 0 0.0
.data 1872 1872 0 0.0
.text 854708 854708 0 0.0
esp32 all-clusters-app c3devkit (read only) 988250 988250 0 0.0
(read/write) 1460922 1460922 0 0.0
.dram0.bss 62952 62952 0 0.0
.dram0.data 14196 14196 0 0.0
.flash.rodata 198288 198288 0 0.0
.flash.text 988250 988250 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1040599 1040599 0 0.0
(read/write) 461912 461912 0 0.0
.dram0.bss 68480 68480 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 227232 227232 0 0.0
.flash.text 1035215 1035215 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 710620 710620 0 0.0
.bss 77968 77968 0 0.0
.data 1904 1904 0 0.0
.text 624948 624948 0 0.0
lock k32w061+release (read/write) 710024 710024 0 0.0
.bss 77960 77960 0 0.0
.data 1944 1944 0 0.0
.text 624320 624320 0 0.0
linux all-clusters-app debug (read only) 2593737 2593737 0 0.0
(read/write) 144872 144872 0 0.0
.bss 57664 57664 0 0.0
.data 1440 1440 0 0.0
.data.rel.ro 79880 79880 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 221285 221285 0 0.0
.text 2204434 2204434 0 0.0
bridge-app debug+rpc (read only) 1803701 1803701 0 0.0
(read/write) 90296 90296 0 0.0
.bss 44584 44584 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38584 38584 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 147513 147513 0 0.0
.text 1539557 1539557 0 0.0
chip-tool debug (read only) 10484645 10484645 0 0.0
(read/write) 367128 367128 0 0.0
.bss 22016 22016 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 337848 337848 0 0.0
.dynamic 624 624 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 534349 534349 0 0.0
.text 9131957 9131957 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10083572 10083572 0 0.0
(read/write) 486977 486977 0 0.0
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 384712 384712 0 0.0
.dynamic 560 560 0 0.0
.got 57008 57008 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 508404 508404 0 0.0
.text 8484324 8484324 0 0.0
door-lock-app debug (read only) 2074673 2074673 0 0.0
(read/write) 118320 118320 0 0.0
.bss 47904 47904 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 63704 63704 0 0.0
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 185513 185513 0 0.0
.text 1735346 1735346 0 0.0
lighting-app debug+rpc (read only) 2253193 2253193 0 0.0
(read/write) 125312 125312 0 0.0
.bss 49216 49216 0 0.0
.data 1600 1600 0 0.0
.data.rel.ro 68808 68808 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 179625 179625 0 0.0
.text 1910290 1910290 0 0.0
ota-provider-app debug (read only) 2012593 2012593 0 0.0
(read/write) 113888 113888 0 0.0
.bss 47744 47744 0 0.0
.data 1384 1384 0 0.0
.data.rel.ro 59032 59032 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 171403 171403 0 0.0
.text 1686466 1686466 0 0.0
ota-requestor-app debug (read only) 2041977 2041977 0 0.0
(read/write) 117176 117176 0 0.0
.bss 48736 48736 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 61240 61240 0 0.0
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 167892 167892 0 0.0
.text 1717682 1717682 0 0.0
shell debug (read only) 2490745 2490745 0 0.0
(read/write) 148336 148336 0 0.0
.bss 67336 67336 0 0.0
.data 848 848 0 0.0
.data.rel.ro 74424 74424 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212978 212978 0 0.0
.text 2119234 2119234 0 0.0
thermostat-no-ble arm64 (read only) 2325020 2325020 0 0.0
(read/write) 149521 149521 0 0.0
.bss 62977 62977 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 77760 77760 0 0.0
.dynamic 560 560 0 0.0
.got 4632 4632 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 143340 143340 0 0.0
.text 1955840 1955840 0 0.0
tv-app debug (read only) 2762281 2762281 0 0.0
(read/write) 249984 249984 0 0.0
.bss 165360 165360 0 0.0
.data 3392 3392 0 0.0
.data.rel.ro 75040 75040 0 0.0
.dynamic 592 592 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 211467 211467 0 0.0
.text 2371986 2371986 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2362956 2362956 0 0.0
.bss 185052 185052 0 0.0
.data 5784 5784 0 0.0
.text 1325556 1325556 0 0.0
p6 all-clusters-app default (read/write) 2507784 2507784 0 0.0
.bss 118480 118480 0 0.0
.data 2672 2672 0 0.0
.text 1466048 1466048 0 0.0
light-app default (read/write) 2408960 2408960 0 0.0
.bss 111944 111944 0 0.0
.data 2528 2528 0 0.0
.text 1367224 1367224 0 0.0
lock-app default (read/write) 2372608 2372608 0 0.0
.bss 111688 111688 0 0.0
.data 2488 2488 0 0.0
.text 1330872 1330872 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 795088 795088 0 0.0
bss 70300 70300 0 0.0
noinit 40416 40416 0 0.0
text 564554 564554 0 0.0

@kkasperczyk-no
[nrfconnect] Refactored configuration for the nrfconnect examples
8dee62f 
nrfconnect platform uses Kconfig overlays and defaults in a way
that is not consistent with the nRF Connect SDK recommendations

* Created Kconfig.defaults that set default configs common
for all examples (replaced sample-defaults.conf)
* Created Kconfig.features that allows to configure set
of options within single feature using single option
* Replaced approach of adding overlays in example cmake file
with the pattern of placing prj.conf files in a
configuration/build-target/ location that allows adding config
files to the build automatically by the toolchain.
* Created debug and release configuration variants for several
examples.
@github-actions
Copy link

github-actions bot commented Apr 5, 2022 •
edited
Loading

PR #16991: Size comparison from 04f1acd to 8dee62f

Increases above 0.2%:

platform target config section 04f1acd 8dee62f change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 143656 145084 1428 1.0
Increases (1 build for nrfconnect)
platform target config section 04f1acd 8dee62f change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 rodata 143656 145084 1428 1.0
text 789876 790204 328 0.0
Decreases (1 build for nrfconnect)
platform target config section 04f1acd 8dee62f change % change
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151471 1149731 -1740 -0.2
bss 143072 135812 -7260 -5.1
Full report (38 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 04f1acd 8dee62f change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 670727 670727 0 0.0
(read/write) 180992 180992 0 0.0
.bss 81760 81760 0 0.0
.data 3164 3164 0 0.0
.rodata 80039 80039 0 0.0
.text 590208 590208 0 0.0
lock-mtd LP_CC2652R7 (read only) 619855 619855 0 0.0
(read/write) 154508 154508 0 0.0
.bss 77488 77488 0 0.0
.data 3164 3164 0 0.0
.rodata 79927 79927 0 0.0
.text 539440 539440 0 0.0
pump-app LP_CC2652R7 (read only) 690191 690191 0 0.0
(read/write) 162704 162704 0 0.0
.bss 82168 82168 0 0.0
.data 3196 3196 0 0.0
.rodata 82119 82119 0 0.0
.text 607588 607588 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672431 672431 0 0.0
(read/write) 180192 180192 0 0.0
.bss 81896 81896 0 0.0
.data 3160 3160 0 0.0
.rodata 78455 78455 0 0.0
.text 593492 593492 0 0.0
efr32 lighting-app BRD4161A (read only) 919516 919516 0 0.0
(read/write) 129792 129792 0 0.0
.bss 127800 127800 0 0.0
.data 1992 1992 0 0.0
.text 919508 919508 0 0.0
BRD4161A+rpc (read only) 947428 947428 0 0.0
(read/write) 145740 145740 0 0.0
.bss 143568 143568 0 0.0
.data 2172 2172 0 0.0
.text 947420 947420 0 0.0
window-app BRD4161A (read only) 854716 854716 0 0.0
(read/write) 127816 127816 0 0.0
.bss 125944 125944 0 0.0
.data 1872 1872 0 0.0
.text 854708 854708 0 0.0
esp32 all-clusters-app c3devkit (read only) 988250 988250 0 0.0
(read/write) 1460922 1460922 0 0.0
.dram0.bss 62952 62952 0 0.0
.dram0.data 14196 14196 0 0.0
.flash.rodata 198288 198288 0 0.0
.flash.text 988250 988250 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1040599 1040599 0 0.0
(read/write) 461912 461912 0 0.0
.dram0.bss 68480 68480 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 227232 227232 0 0.0
.flash.text 1035215 1035215 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 710620 710620 0 0.0
.bss 77968 77968 0 0.0
.data 1904 1904 0 0.0
.text 624948 624948 0 0.0
lock k32w061+release (read/write) 710024 710024 0 0.0
.bss 77960 77960 0 0.0
.data 1944 1944 0 0.0
.text 624320 624320 0 0.0
linux all-clusters-app debug (read only) 2593737 2593737 0 0.0
(read/write) 144872 144872 0 0.0
.bss 57664 57664 0 0.0
.data 1440 1440 0 0.0
.data.rel.ro 79880 79880 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 221285 221285 0 0.0
.text 2204434 2204434 0 0.0
bridge-app debug+rpc (read only) 1803701 1803701 0 0.0
(read/write) 90296 90296 0 0.0
.bss 44584 44584 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 38584 38584 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 147513 147513 0 0.0
.text 1539557 1539557 0 0.0
chip-tool debug (read only) 10484645 10484645 0 0.0
(read/write) 367128 367128 0 0.0
.bss 22016 22016 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 337848 337848 0 0.0
.dynamic 624 624 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 534349 534349 0 0.0
.text 9131957 9131957 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10083572 10083572 0 0.0
(read/write) 486977 486977 0 0.0
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 384712 384712 0 0.0
.dynamic 560 560 0 0.0
.got 57008 57008 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 508404 508404 0 0.0
.text 8484324 8484324 0 0.0
door-lock-app debug (read only) 2074673 2074673 0 0.0
(read/write) 118320 118320 0 0.0
.bss 47904 47904 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 63704 63704 0 0.0
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 185513 185513 0 0.0
.text 1735346 1735346 0 0.0
lighting-app debug+rpc (read only) 2253193 2253193 0 0.0
(read/write) 125312 125312 0 0.0
.bss 49216 49216 0 0.0
.data 1600 1600 0 0.0
.data.rel.ro 68808 68808 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 179625 179625 0 0.0
.text 1910290 1910290 0 0.0
ota-provider-app debug (read only) 2012593 2012593 0 0.0
(read/write) 113888 113888 0 0.0
.bss 47744 47744 0 0.0
.data 1384 1384 0 0.0
.data.rel.ro 59032 59032 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 171403 171403 0 0.0
.text 1686466 1686466 0 0.0
ota-requestor-app debug (read only) 2042041 2042041 0 0.0
(read/write) 117176 117176 0 0.0
.bss 48736 48736 0 0.0
.data 1608 1608 0 0.0
.data.rel.ro 61240 61240 0 0.0
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 167892 167892 0 0.0
.text 1717746 1717746 0 0.0
shell debug (read only) 2490745 2490745 0 0.0
(read/write) 148336 148336 0 0.0
.bss 67336 67336 0 0.0
.data 848 848 0 0.0
.data.rel.ro 74424 74424 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212978 212978 0 0.0
.text 2119234 2119234 0 0.0
thermostat-no-ble arm64 (read only) 2325020 2325020 0 0.0
(read/write) 149521 149521 0 0.0
.bss 62977 62977 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 77760 77760 0 0.0
.dynamic 560 560 0 0.0
.got 4632 4632 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 143340 143340 0 0.0
.text 1955840 1955840 0 0.0
tv-app debug (read only) 2762281 2762281 0 0.0
(read/write) 249984 249984 0 0.0
.bss 165360 165360 0 0.0
.data 3392 3392 0 0.0
.data.rel.ro 75040 75040 0 0.0
.dynamic 592 592 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 211467 211467 0 0.0
.text 2371986 2371986 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2362956 2362956 0 0.0
.bss 185052 185052 0 0.0
.data 5784 5784 0 0.0
.text 1325556 1325556 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1151471 1149731 -1740 -0.2
bss 143072 135812 -7260 -5.1
rodata 143656 145084 1428 1.0
text 789876 790204 328 0.0
lighting-app nrf52840dk_nrf52840 (read/write) 1136515 1136515 0 0.0
bss 139516 139516 0 0.0
rodata 120628 120628 0 0.0
text 797844 797844 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 1100711 1100711 0 0.0
bss 139752 139752 0 0.0
rodata 111768 111768 0 0.0
text 770204 770204 0 0.0
nrf52840dongle_nrf52840 (read/write) 1150919 1150919 0 0.0
bss 140516 140516 0 0.0
rodata 120204 120204 0 0.0
text 800724 800724 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 1045322 1045322 0 0.0
bss 136580 136580 0 0.0
rodata 113816 113816 0 0.0
text 713000 713000 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 1036951 1036951 0 0.0
bss 129464 129464 0 0.0
rodata 113552 113552 0 0.0
text 715520 715520 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 945990 945990 0 0.0
bss 126560 126560 0 0.0
rodata 106796 106796 0 0.0
text 630832 630832 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 557047 557047 0 0.0
bss 69672 69672 0 0.0
rodata 45368 45368 0 0.0
text 382568 382568 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 1055879 1055879 0 0.0
bss 129380 129380 0 0.0
rodata 115632 115632 0 0.0
text 732344 732344 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 1038047 1038047 0 0.0
bss 129124 129124 0 0.0
rodata 111848 111848 0 0.0
text 718584 718584 0 0.0
shell nrf52840dk_nrf52840 (read/write) 802191 802191 0 0.0
bss 117376 117376 0 0.0
rodata 73760 73760 0 0.0
text 537428 537428 0 0.0
p6 all-clusters-app default (read/write) 2507784 2507784 0 0.0
.bss 118480 118480 0 0.0
.data 2672 2672 0 0.0
.text 1466048 1466048 0 0.0
light-app default (read/write) 2408960 2408960 0 0.0
.bss 111944 111944 0 0.0
.data 2528 2528 0 0.0
.text 1367224 1367224 0 0.0
lock-app default (read/write) 2372608 2372608 0 0.0
.bss 111688 111688 0 0.0
.data 2488 2488 0 0.0
.text 1330872 1330872 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 795088 795088 0 0.0
bss 70300 70300 0 0.0
noinit 40416 40416 0 0.0
text 564554 564554 0 0.0

@Damian-Nordic Damian-Nordic merged commit dcca243 into project-chip:master Apr 5, 2022
@andy31415 andy31415 mentioned this pull request Apr 5, 2022
Merged
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@kkasperczyk-no @chencheung
[nrfconnect] Refactored configuration for the nrfconnect examples (pr…
8a7a711 
…oject-chip#16991)

nrfconnect platform uses Kconfig overlays and defaults in a way
that is not consistent with the nRF Connect SDK recommendations

* Created Kconfig.defaults that set default configs common
for all examples (replaced sample-defaults.conf)
* Created Kconfig.features that allows to configure set
of options within single feature using single option
* Replaced approach of adding overlays in example cmake file
with the pattern of placing prj.conf files in a
configuration/build-target/ location that allows adding config
files to the build automatically by the toolchain.
* Created debug and release configuration variants for several
examples.
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@kkasperczyk-no @chencheung
[nrfconnect] Refactored configuration for the nrfconnect examples (pr…
0eb4dc1 
…oject-chip#16991)

nrfconnect platform uses Kconfig overlays and defaults in a way
that is not consistent with the nRF Connect SDK recommendations

* Created Kconfig.defaults that set default configs common
for all examples (replaced sample-defaults.conf)
* Created Kconfig.features that allows to configure set
of options within single feature using single option
* Replaced approach of adding overlays in example cmake file
with the pattern of placing prj.conf files in a
configuration/build-target/ location that allows adding config
files to the build automatically by the toolchain.
* Created debug and release configuration variants for several
examples.
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@kkasperczyk-no @andrei-menzopol
[nrfconnect] Refactored configuration for the nrfconnect examples (pr…
f4c2838 
…oject-chip#16991)

nrfconnect platform uses Kconfig overlays and defaults in a way
that is not consistent with the nRF Connect SDK recommendations

* Created Kconfig.defaults that set default configs common
for all examples (replaced sample-defaults.conf)
* Created Kconfig.features that allows to configure set
of options within single feature using single option
* Replaced approach of adding overlays in example cmake file
with the pattern of placing prj.conf files in a
configuration/build-target/ location that allows adding config
files to the build automatically by the toolchain.
* Created debug and release configuration variants for several
examples.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

Assignees
No one assigned
Labels
config examples fast track github review - approved workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkasperczyk-no @woody-apple @Damian-Nordic