Failsafe fixes #16973
Merged
Failsafe fixes #16973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google and
mrjerryjohns
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
|
PR #16973: Size comparison from 6e49d41 to eca44cb Increases (29 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (3 builds for cc13x2_26x2)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Do not allow CASE connections to arm the failsafe the first time if there is a commissioning window open.
|
PR #16973: Size comparison from 6e49d41 to c037a5a Increases (29 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (3 builds for cc13x2_26x2)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Apr 4, 2022
src/app/clusters/general-commissioning-server/general-commissioning-server.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/general-commissioning-server/general-commissioning-server.cpp
Outdated
Show resolved
Hide resolved
|
PR #16973: Size comparison from c3b1810 to 1955b29 Increases (29 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (3 builds for cc13x2_26x2)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
Apr 4, 2022
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
* Failsafe checks Do not allow CASE connections to arm the failsafe the first time if there is a commissioning window open. * Disarm failsafe immediately if we get 0 timeout. * Do not allow commissioning window to be opened if failsafe is held * Force expire failsafe on Commissioning window close * Run test in cirque * Arm failsafe on PASE session establishment complete * Failsafe fixes from other PR * Restyled by autopep8 * Remove newly removed argument * manually cancel timer. * Fixes from review. Co-authored-by: Restyled.io <[email protected]>
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
* Failsafe checks Do not allow CASE connections to arm the failsafe the first time if there is a commissioning window open. * Disarm failsafe immediately if we get 0 timeout. * Do not allow commissioning window to be opened if failsafe is held * Force expire failsafe on Commissioning window close * Run test in cirque * Arm failsafe on PASE session establishment complete * Failsafe fixes from other PR * Restyled by autopep8 * Remove newly removed argument * manually cancel timer. * Fixes from review. Co-authored-by: Restyled.io <[email protected]>
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
* Failsafe checks Do not allow CASE connections to arm the failsafe the first time if there is a commissioning window open. * Disarm failsafe immediately if we get 0 timeout. * Do not allow commissioning window to be opened if failsafe is held * Force expire failsafe on Commissioning window close * Run test in cirque * Arm failsafe on PASE session establishment complete * Failsafe fixes from other PR * Restyled by autopep8 * Remove newly removed argument * manually cancel timer. * Fixes from review. Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Add changes proposed in https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/5083
Change overview
Testing
Please see new cirque tests. Tests for arming failsafe on PASE session establishment completion are more complicated because we have no direct access to the failsafe value. This can be tested by attempting to send a command that requires the failsafe to be armed. Network commands, unfortunately, do not yet check this. I have added such a check in https://github.com/cecille/connectedhomeip/tree/failsafe_fixes_with_tests along with the tests, but failsafe checking on network commands needs to be handled in another PR as it may affect platform devs.