Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTA] Make watchdog timeout value configurable #16955

Merged
merged 1 commit into from
Apr 4, 2022
Merged

[OTA] Make watchdog timeout value configurable #16955

merged 1 commit into from
Apr 4, 2022

Conversation

carol-apple
Copy link
Contributor

Problem

Specifically for Raspi, the images are quite large (~29MB). When downloading at 1024 bytes per block, this easily exceeds the default 6 hour watchdog timer.

Change overview

  • Add a command line option to make the watchdog timeout value configurable
  • If none or zero is supplied, the default of 6 hours set in the driver is used
  • Update the README accordingly

Testing

  • Verified that when supplied, the --watchdogTimeout value is used by the driver

@github-actions
Copy link

github-actions bot commented Apr 1, 2022 •
edited
Loading

PR #16955: Size comparison from bd56c52 to a0a1494

Increases above 0.2%:

platform target config section bd56c52 a0a1494 change % change
linux ota-requestor-app debug .data 1512 1544 32 2.1
Increases (1 build for linux)
platform target config section bd56c52 a0a1494 change % change
linux ota-requestor-app debug (read only) 2022481 2022889 408 0.0
(read/write) 116728 116760 32 0.0
.data 1512 1544 32 2.1
.rodata 167020 167308 288 0.2
.text 1699538 1699634 96 0.0
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section bd56c52 a0a1494 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 667283 667283 0 0.0
(read/write) 184444 184444 0 0.0
.bss 81768 81768 0 0.0
.data 3132 3132 0 0.0
.rodata 79595 79595 0 0.0
.text 587208 587208 0 0.0
lock-mtd LP_CC2652R7 (read only) 616411 616411 0 0.0
(read/write) 154484 154484 0 0.0
.bss 77496 77496 0 0.0
.data 3132 3132 0 0.0
.rodata 79475 79475 0 0.0
.text 536448 536448 0 0.0
pump-app LP_CC2652R7 (read only) 686743 686743 0 0.0
(read/write) 166144 166144 0 0.0
.bss 82160 82160 0 0.0
.data 3164 3164 0 0.0
.rodata 81671 81671 0 0.0
.text 604588 604588 0 0.0
pump-controller-app LP_CC2652R7 (read only) 668967 668967 0 0.0
(read/write) 183664 183664 0 0.0
.bss 81904 81904 0 0.0
.data 3128 3128 0 0.0
.rodata 78007 78007 0 0.0
.text 590476 590476 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 609666 609666 0 0.0
.app_xip_area 516408 516408 0 0.0
.bss 76004 76004 0 0.0
.data 600 600 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 567178 567178 0 0.0
.app_xip_area 475456 475456 0 0.0
.bss 74508 74508 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 578798 578798 0 0.0
.app_xip_area 477436 477436 0 0.0
.bss 83820 83820 0 0.0
.data 504 504 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914584 914584 0 0.0
(read/write) 129760 129760 0 0.0
.bss 127800 127800 0 0.0
.data 1960 1960 0 0.0
.text 914576 914576 0 0.0
BRD4161A+rpc (read only) 942464 942464 0 0.0
(read/write) 145720 145720 0 0.0
.bss 143576 143576 0 0.0
.data 2140 2140 0 0.0
.text 942456 942456 0 0.0
window-app BRD4161A (read only) 849944 849944 0 0.0
(read/write) 127784 127784 0 0.0
.bss 125944 125944 0 0.0
.data 1840 1840 0 0.0
.text 849936 849936 0 0.0
esp32 all-clusters-app c3devkit (read only) 985074 985074 0 0.0
(read/write) 1460498 1460498 0 0.0
.dram0.bss 62952 62952 0 0.0
.dram0.data 14172 14172 0 0.0
.flash.rodata 197896 197896 0 0.0
.flash.text 985074 985074 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1037635 1037635 0 0.0
(read/write) 461520 461520 0 0.0
.dram0.bss 68480 68480 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 226872 226872 0 0.0
.flash.text 1032251 1032251 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 707112 707112 0 0.0
.bss 77976 77976 0 0.0
.data 1872 1872 0 0.0
.text 621464 621464 0 0.0
lock k32w061+release (read/write) 706520 706520 0 0.0
.bss 77960 77960 0 0.0
.data 1912 1912 0 0.0
.text 620848 620848 0 0.0
linux all-clusters-app debug (read only) 2573873 2573873 0 0.0
(read/write) 144456 144456 0 0.0
.bss 57600 57600 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 79640 79640 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 220453 220453 0 0.0
.text 2185954 2185954 0 0.0
bridge-app debug+rpc (read only) 1784949 1784949 0 0.0
(read/write) 90040 90040 0 0.0
.bss 44584 44584 0 0.0
.data 2000 2000 0 0.0
.data.rel.ro 38352 38352 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 147121 147121 0 0.0
.text 1521653 1521653 0 0.0
chip-tool debug (read only) 10422733 10422733 0 0.0
(read/write) 358040 358040 0 0.0
.bss 22016 22016 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 328728 328728 0 0.0
.dynamic 624 624 0 0.0
.got 4896 4896 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 531469 531469 0 0.0
.text 9099989 9099989 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10024396 10024396 0 0.0
(read/write) 477505 477505 0 0.0
.bss 40337 40337 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 375576 375576 0 0.0
.dynamic 560 560 0 0.0
.got 56664 56664 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 505948 505948 0 0.0
.text 8455460 8455460 0 0.0
door-lock-app debug (read only) 2055649 2055649 0 0.0
(read/write) 117936 117936 0 0.0
.bss 47840 47840 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 63448 63448 0 0.0
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 184961 184961 0 0.0
.text 1717330 1717330 0 0.0
lighting-app debug+rpc (read only) 2233545 2233545 0 0.0
(read/write) 124896 124896 0 0.0
.bss 49152 49152 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 68520 68520 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 179009 179009 0 0.0
.text 1891810 1891810 0 0.0
ota-provider-app debug (read only) 1993649 1993649 0 0.0
(read/write) 113504 113504 0 0.0
.bss 47680 47680 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 58760 58760 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 170787 170787 0 0.0
.text 1668594 1668594 0 0.0
ota-requestor-app debug (read only) 2022481 2022889 408 0.0
(read/write) 116728 116760 32 0.0
.bss 48672 48672 0 0.0
.data 1512 1544 32 2.1
.data.rel.ro 60968 60968 0 0.0
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 167020 167308 288 0.2
.text 1699538 1699634 96 0.0
shell debug (read only) 2471025 2471025 0 0.0
(read/write) 147952 147952 0 0.0
.bss 67304 67304 0 0.0
.data 784 784 0 0.0
.data.rel.ro 74136 74136 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212338 212338 0 0.0
.text 2100754 2100754 0 0.0
thermostat-no-ble arm64 (read only) 2308516 2308516 0 0.0
(read/write) 149137 149137 0 0.0
.bss 62961 62961 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 77496 77496 0 0.0
.dynamic 560 560 0 0.0
.got 4576 4576 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 142948 142948 0 0.0
.text 1940384 1940384 0 0.0
tv-app debug (read only) 2738185 2738185 0 0.0
(read/write) 249440 249440 0 0.0
.bss 165264 165264 0 0.0
.data 3328 3328 0 0.0
.data.rel.ro 74680 74680 0 0.0
.dynamic 592 592 0 0.0
.got 4656 4656 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 210667 210667 0 0.0
.text 2349554 2349554 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2358540 2358540 0 0.0
.bss 185052 185052 0 0.0
.data 5760 5760 0 0.0
.text 1321140 1321140 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1147967 1147967 0 0.0
bss 143076 143076 0 0.0
rodata 143232 143232 0 0.0
text 786840 786840 0 0.0
p6 all-clusters-app default (read/write) 2503128 2503128 0 0.0
.bss 118488 118488 0 0.0
.data 2640 2640 0 0.0
.text 1461392 1461392 0 0.0
light-app default (read/write) 2404312 2404312 0 0.0
.bss 111944 111944 0 0.0
.data 2496 2496 0 0.0
.text 1362576 1362576 0 0.0
lock-app default (read/write) 2367920 2367920 0 0.0
.bss 111688 111688 0 0.0
.data 2456 2456 0 0.0
.text 1326184 1326184 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 791300 791300 0 0.0
bss 70296 70296 0 0.0
noinit 40416 40416 0 0.0
text 561262 561262 0 0.0

@carol-apple carol-apple force-pushed the ota_requestor_configurable_watchdog_timer branch from a0a1494 to 3e4d477 Compare April 2, 2022 04:01
@boring-cyborg boring-cyborg bot added the github label Apr 2, 2022
@github-actions
Copy link

github-actions bot commented Apr 2, 2022 •
edited
Loading

PR #16955: Size comparison from 5f8c83e to 3e4d477

Increases above 0.2%:

platform target config section 5f8c83e 3e4d477 change % change
linux ota-requestor-app debug .data 1512 1544 32 2.1
Increases (1 build for linux)
platform target config section 5f8c83e 3e4d477 change % change
linux ota-requestor-app debug (read only) 2023857 2024313 456 0.0
(read/write) 116760 116792 32 0.0
.data 1512 1544 32 2.1
.rodata 167084 167404 320 0.2
.text 1700850 1700962 112 0.0
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5f8c83e 3e4d477 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 667715 667715 0 0.0
(read/write) 184012 184012 0 0.0
.bss 81768 81768 0 0.0
.data 3132 3132 0 0.0
.rodata 79747 79747 0 0.0
.text 587488 587488 0 0.0
lock-mtd LP_CC2652R7 (read only) 616843 616843 0 0.0
(read/write) 154484 154484 0 0.0
.bss 77496 77496 0 0.0
.data 3132 3132 0 0.0
.rodata 79627 79627 0 0.0
.text 536728 536728 0 0.0
pump-app LP_CC2652R7 (read only) 687175 687175 0 0.0
(read/write) 165712 165712 0 0.0
.bss 82160 82160 0 0.0
.data 3164 3164 0 0.0
.rodata 81823 81823 0 0.0
.text 604868 604868 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669399 669399 0 0.0
(read/write) 183232 183232 0 0.0
.bss 81904 81904 0 0.0
.data 3128 3128 0 0.0
.rodata 78159 78159 0 0.0
.text 590756 590756 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610098 610098 0 0.0
.app_xip_area 516840 516840 0 0.0
.bss 76004 76004 0 0.0
.data 600 600 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 567602 567602 0 0.0
.app_xip_area 475880 475880 0 0.0
.bss 74508 74508 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 579214 579214 0 0.0
.app_xip_area 477852 477852 0 0.0
.bss 83820 83820 0 0.0
.data 504 504 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915192 915192 0 0.0
(read/write) 129760 129760 0 0.0
.bss 127800 127800 0 0.0
.data 1960 1960 0 0.0
.text 915184 915184 0 0.0
BRD4161A+rpc (read only) 943072 943072 0 0.0
(read/write) 145720 145720 0 0.0
.bss 143576 143576 0 0.0
.data 2140 2140 0 0.0
.text 943064 943064 0 0.0
window-app BRD4161A (read only) 850536 850536 0 0.0
(read/write) 127784 127784 0 0.0
.bss 125944 125944 0 0.0
.data 1840 1840 0 0.0
.text 850528 850528 0 0.0
esp32 all-clusters-app c3devkit (read only) 985358 985358 0 0.0
(read/write) 1460626 1460626 0 0.0
.dram0.bss 62952 62952 0 0.0
.dram0.data 14172 14172 0 0.0
.flash.rodata 198024 198024 0 0.0
.flash.text 985358 985358 0 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1037895 1037895 0 0.0
(read/write) 461640 461640 0 0.0
.dram0.bss 68480 68480 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 226992 226992 0 0.0
.flash.text 1032511 1032511 0 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 707528 707528 0 0.0
.bss 77976 77976 0 0.0
.data 1872 1872 0 0.0
.text 621880 621880 0 0.0
lock k32w061+release (read/write) 706952 706952 0 0.0
.bss 77960 77960 0 0.0
.data 1912 1912 0 0.0
.text 621280 621280 0 0.0
linux all-clusters-app debug (read only) 2575665 2575665 0 0.0
(read/write) 144488 144488 0 0.0
.bss 57600 57600 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 79672 79672 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 220709 220709 0 0.0
.text 2187394 2187394 0 0.0
bridge-app debug+rpc (read only) 1786341 1786341 0 0.0
(read/write) 90072 90072 0 0.0
.bss 44584 44584 0 0.0
.data 2000 2000 0 0.0
.data.rel.ro 38384 38384 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 147217 147217 0 0.0
.text 1522949 1522949 0 0.0
chip-tool debug (read only) 10433101 10433101 0 0.0
(read/write) 358584 358584 0 0.0
.bss 22016 22016 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 329272 329272 0 0.0
.dynamic 624 624 0 0.0
.got 4896 4896 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 532141 532141 0 0.0
.text 9108485 9108485 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10033756 10033756 0 0.0
(read/write) 478177 478177 0 0.0
.bss 40337 40337 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 376144 376144 0 0.0
.dynamic 560 560 0 0.0
.got 56768 56768 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 506572 506572 0 0.0
.text 8462660 8462660 0 0.0
door-lock-app debug (read only) 2057057 2057057 0 0.0
(read/write) 117968 117968 0 0.0
.bss 47840 47840 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 63480 63480 0 0.0
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 185057 185057 0 0.0
.text 1718642 1718642 0 0.0
lighting-app debug+rpc (read only) 2235241 2235241 0 0.0
(read/write) 124928 124928 0 0.0
.bss 49152 49152 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 68552 68552 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 179169 179169 0 0.0
.text 1893250 1893250 0 0.0
ota-provider-app debug (read only) 1995025 1995025 0 0.0
(read/write) 113536 113536 0 0.0
.bss 47680 47680 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 58792 58792 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 170851 170851 0 0.0
.text 1669906 1669906 0 0.0
ota-requestor-app debug (read only) 2023857 2024313 456 0.0
(read/write) 116760 116792 32 0.0
.bss 48672 48672 0 0.0
.data 1512 1544 32 2.1
.data.rel.ro 61000 61000 0 0.0
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 167084 167404 320 0.2
.text 1700850 1700962 112 0.0
shell debug (read only) 2472481 2472481 0 0.0
(read/write) 147952 147952 0 0.0
.bss 67304 67304 0 0.0
.data 784 784 0 0.0
.data.rel.ro 74136 74136 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212498 212498 0 0.0
.text 2102050 2102050 0 0.0
thermostat-no-ble arm64 (read only) 2309868 2309868 0 0.0
(read/write) 149185 149185 0 0.0
.bss 62961 62961 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 77552 77552 0 0.0
.dynamic 560 560 0 0.0
.got 4576 4576 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 143052 143052 0 0.0
.text 1941536 1941536 0 0.0
tv-app debug (read only) 2739289 2739289 0 0.0
(read/write) 249472 249472 0 0.0
.bss 165264 165264 0 0.0
.data 3328 3328 0 0.0
.data.rel.ro 74712 74712 0 0.0
.dynamic 592 592 0 0.0
.got 4656 4656 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 210731 210731 0 0.0
.text 2350594 2350594 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2359004 2359004 0 0.0
.bss 185052 185052 0 0.0
.data 5760 5760 0 0.0
.text 1321604 1321604 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148347 1148347 0 0.0
bss 143076 143076 0 0.0
rodata 143356 143356 0 0.0
text 787092 787092 0 0.0
p6 all-clusters-app default (read/write) 2503728 2503728 0 0.0
.bss 118488 118488 0 0.0
.data 2640 2640 0 0.0
.text 1461992 1461992 0 0.0
light-app default (read/write) 2404904 2404904 0 0.0
.bss 111944 111944 0 0.0
.data 2496 2496 0 0.0
.text 1363168 1363168 0 0.0
lock-app default (read/write) 2368536 2368536 0 0.0
.bss 111688 111688 0 0.0
.data 2456 2456 0 0.0
.text 1326800 1326800 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 791780 791780 0 0.0
bss 70296 70296 0 0.0
noinit 40416 40416 0 0.0
text 561594 561594 0 0.0

@carol-apple carol-apple merged commit 7ab6653 into project-chip:master Apr 4, 2022
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@carol-apple @chencheung
[OTA] Make watchdog timeout value configurable (project-chip#16955)
e97f4ba
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@carol-apple @chencheung
[OTA] Make watchdog timeout value configurable (project-chip#16955)
0efafa6
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@carol-apple @andrei-menzopol
[OTA] Make watchdog timeout value configurable (project-chip#16955)
872a449
@somu1710 somu1710 mentioned this pull request Apr 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isiu-apple isiu-apple isiu-apple approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app examples github review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carol-apple @Damian-Nordic @isiu-apple