Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTA] Make OTARequestor responsible for responding to AnnounceOTAProvider command #16952

Merged
merged 1 commit into from
Apr 4, 2022
Merged

[OTA] Make OTARequestor responsible for responding to AnnounceOTAProvider command #16952

merged 1 commit into from
Apr 4, 2022

Conversation

carol-apple
Copy link
Contributor

Problem

The responsibility of whether the requestor cluster or the default OTARequestor class is sending the status was not well defined.

Fixes: #15895

Change overview

  • Make the OTARequestor responsible for sending the status
  • Clearly spell this out in the header file

Testing

  • Verify that chip-tool gets a status when issuing an announce-ota-provider command

@boring-cyborg boring-cyborg bot added the app label Apr 1, 2022
@github-actions
Copy link

github-actions bot commented Apr 1, 2022 •
edited
Loading

PR #16952: Size comparison from 37094b5 to 3839898

Increases (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 37094b5 3839898 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 667283 667539 256 0.0
.rodata 79595 79739 144 0.2
.text 587208 587320 112 0.0
lock-mtd LP_CC2652R7 (read only) 616411 616667 256 0.0
.rodata 79475 79619 144 0.2
.text 536448 536560 112 0.0
pump-app LP_CC2652R7 (read only) 686743 686999 256 0.0
.rodata 81671 81815 144 0.2
.text 604588 604700 112 0.0
pump-controller-app LP_CC2652R7 (read only) 668967 669223 256 0.0
.rodata 78007 78151 144 0.2
.text 590476 590588 112 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 609666 609834 168 0.0
.app_xip_area 516408 516576 168 0.0
lock cyw930739m2evb_01 (read/write) 567178 567338 160 0.0
.app_xip_area 475456 475616 160 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 578798 579046 248 0.0
.app_xip_area 477436 477684 248 0.1
efr32 lighting-app BRD4161A (read only) 914584 914840 256 0.0
.text 914576 914832 256 0.0
BRD4161A+rpc (read only) 942464 942720 256 0.0
.text 942456 942712 256 0.0
esp32 all-clusters-app c3devkit (read only) 985074 985162 88 0.0
(read/write) 1460498 1460586 88 0.0
.flash.rodata 197896 197984 88 0.0
.flash.text 985074 985162 88 0.0
m5stack (read only) 1037635 1037711 76 0.0
(read/write) 461520 461608 88 0.0
.flash.rodata 226872 226960 88 0.0
.flash.text 1032251 1032327 76 0.0
k32w light k32w061+release (read/write) 707112 707368 256 0.0
.text 621464 621720 256 0.0
lock k32w061+release (read/write) 706520 706688 168 0.0
.text 620848 621016 168 0.0
linux all-clusters-app debug (read only) 2554825 2555225 400 0.0
.rodata 219205 219365 160 0.1
.text 2170882 2171122 240 0.0
lighting-app debug+rpc (read only) 2214537 2214921 384 0.0
.rodata 177761 177889 128 0.1
.text 1876786 1877042 256 0.0
ota-requestor-app debug (read only) 2003841 2004321 480 0.0
.rodata 165772 165932 160 0.1
.text 1684450 1684770 320 0.0
shell debug (read only) 2470065 2470481 416 0.0
.rodata 212338 212498 160 0.1
.text 2099794 2100050 256 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2358540 2358692 152 0.0
.text 1321140 1321292 152 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1147967 1148223 256 0.0
rodata 143232 143376 144 0.1
text 786840 786956 116 0.0
p6 all-clusters-app default (read/write) 2503128 2503296 168 0.0
.text 1461392 1461560 168 0.0
light-app default (read/write) 2404312 2404480 168 0.0
.text 1362576 1362744 168 0.0
lock-app default (read/write) 2367920 2368096 176 0.0
.text 1326184 1326360 176 0.0
telink lighting-app tlsr9518adk80d (read/write) 791300 791480 180 0.0
text 561262 561352 90 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section 37094b5 3839898 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 184444 184188 -256 -0.1
pump-app LP_CC2652R7 (read/write) 166144 165888 -256 -0.2
pump-controller-app LP_CC2652R7 (read/write) 183664 183408 -256 -0.1
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 37094b5 3839898 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 667283 667539 256 0.0
(read/write) 184444 184188 -256 -0.1
.bss 81768 81768 0 0.0
.data 3132 3132 0 0.0
.rodata 79595 79739 144 0.2
.text 587208 587320 112 0.0
lock-mtd LP_CC2652R7 (read only) 616411 616667 256 0.0
(read/write) 154484 154484 0 0.0
.bss 77496 77496 0 0.0
.data 3132 3132 0 0.0
.rodata 79475 79619 144 0.2
.text 536448 536560 112 0.0
pump-app LP_CC2652R7 (read only) 686743 686999 256 0.0
(read/write) 166144 165888 -256 -0.2
.bss 82160 82160 0 0.0
.data 3164 3164 0 0.0
.rodata 81671 81815 144 0.2
.text 604588 604700 112 0.0
pump-controller-app LP_CC2652R7 (read only) 668967 669223 256 0.0
(read/write) 183664 183408 -256 -0.1
.bss 81904 81904 0 0.0
.data 3128 3128 0 0.0
.rodata 78007 78151 144 0.2
.text 590476 590588 112 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 609666 609834 168 0.0
.app_xip_area 516408 516576 168 0.0
.bss 76004 76004 0 0.0
.data 600 600 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 567178 567338 160 0.0
.app_xip_area 475456 475616 160 0.0
.bss 74508 74508 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 578798 579046 248 0.0
.app_xip_area 477436 477684 248 0.1
.bss 83820 83820 0 0.0
.data 504 504 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 914584 914840 256 0.0
(read/write) 129760 129760 0 0.0
.bss 127800 127800 0 0.0
.data 1960 1960 0 0.0
.text 914576 914832 256 0.0
BRD4161A+rpc (read only) 942464 942720 256 0.0
(read/write) 145720 145720 0 0.0
.bss 143576 143576 0 0.0
.data 2140 2140 0 0.0
.text 942456 942712 256 0.0
window-app BRD4161A (read only) 849944 849944 0 0.0
(read/write) 127784 127784 0 0.0
.bss 125944 125944 0 0.0
.data 1840 1840 0 0.0
.text 849936 849936 0 0.0
esp32 all-clusters-app c3devkit (read only) 985074 985162 88 0.0
(read/write) 1460498 1460586 88 0.0
.dram0.bss 62952 62952 0 0.0
.dram0.data 14172 14172 0 0.0
.flash.rodata 197896 197984 88 0.0
.flash.text 985074 985162 88 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1037635 1037711 76 0.0
(read/write) 461520 461608 88 0.0
.dram0.bss 68480 68480 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 226872 226960 88 0.0
.flash.text 1032251 1032327 76 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 707112 707368 256 0.0
.bss 77976 77976 0 0.0
.data 1872 1872 0 0.0
.text 621464 621720 256 0.0
lock k32w061+release (read/write) 706520 706688 168 0.0
.bss 77960 77960 0 0.0
.data 1912 1912 0 0.0
.text 620848 621016 168 0.0
linux all-clusters-app debug (read only) 2554825 2555225 400 0.0
(read/write) 144000 144000 0 0.0
.bss 57472 57472 0 0.0
.data 1296 1296 0 0.0
.data.rel.ro 79464 79464 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 219205 219365 160 0.1
.text 2170882 2171122 240 0.0
bridge-app debug+rpc (read only) 1783989 1783989 0 0.0
(read/write) 90008 90008 0 0.0
.bss 44552 44552 0 0.0
.data 2000 2000 0 0.0
.data.rel.ro 38352 38352 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 147121 147121 0 0.0
.text 1520693 1520693 0 0.0
chip-tool debug (read only) 10426485 10426485 0 0.0
(read/write) 358112 358112 0 0.0
.bss 22080 22080 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 328728 328728 0 0.0
.dynamic 624 624 0 0.0
.got 4896 4896 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 531981 531981 0 0.0
.text 9103205 9103205 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10032244 10032244 0 0.0
(read/write) 477585 477585 0 0.0
.bss 40401 40401 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 375576 375576 0 0.0
.dynamic 560 560 0 0.0
.got 56672 56672 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 505932 505932 0 0.0
.text 8463204 8463204 0 0.0
door-lock-app debug (read only) 2036633 2036633 0 0.0
(read/write) 117416 117416 0 0.0
.bss 47680 47680 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 63288 63288 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 183745 183745 0 0.0
.text 1702258 1702258 0 0.0
lighting-app debug+rpc (read only) 2214537 2214921 384 0.0
(read/write) 124376 124376 0 0.0
.bss 48960 48960 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 68360 68360 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 177761 177889 128 0.1
.text 1876786 1877042 256 0.0
ota-provider-app debug (read only) 1976177 1976177 0 0.0
(read/write) 113112 113112 0 0.0
.bss 47552 47552 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58600 58600 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 169571 169571 0 0.0
.text 1653794 1653794 0 0.0
ota-requestor-app debug (read only) 2003841 2004321 480 0.0
(read/write) 116304 116304 0 0.0
.bss 48544 48544 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60792 60792 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 165772 165932 160 0.1
.text 1684450 1684770 320 0.0
shell debug (read only) 2470065 2470481 416 0.0
(read/write) 147952 147952 0 0.0
.bss 67304 67304 0 0.0
.data 784 784 0 0.0
.data.rel.ro 74136 74136 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212338 212498 160 0.1
.text 2099794 2100050 256 0.0
thermostat-no-ble arm64 (read only) 2294132 2294132 0 0.0
(read/write) 148785 148785 0 0.0
.bss 62849 62849 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77328 77328 0 0.0
.dynamic 560 560 0 0.0
.got 4552 4552 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 142164 142164 0 0.0
.text 1927744 1927744 0 0.0
tv-app debug (read only) 2719793 2719793 0 0.0
(read/write) 248984 248984 0 0.0
.bss 165104 165104 0 0.0
.data 3296 3296 0 0.0
.data.rel.ro 74520 74520 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 209483 209483 0 0.0
.text 2334626 2334626 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2358540 2358692 152 0.0
.bss 185052 185052 0 0.0
.data 5760 5760 0 0.0
.text 1321140 1321292 152 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1147967 1148223 256 0.0
bss 143076 143076 0 0.0
rodata 143232 143376 144 0.1
text 786840 786956 116 0.0
p6 all-clusters-app default (read/write) 2503128 2503296 168 0.0
.bss 118488 118488 0 0.0
.data 2640 2640 0 0.0
.text 1461392 1461560 168 0.0
light-app default (read/write) 2404312 2404480 168 0.0
.bss 111944 111944 0 0.0
.data 2496 2496 0 0.0
.text 1362576 1362744 168 0.0
lock-app default (read/write) 2367920 2368096 176 0.0
.bss 111688 111688 0 0.0
.data 2456 2456 0 0.0
.text 1326184 1326360 176 0.0
telink lighting-app tlsr9518adk80d (read/write) 791300 791480 180 0.0
bss 70296 70296 0 0.0
noinit 40416 40416 0 0.0
text 561262 561352 90 0.0

@carol-apple carol-apple force-pushed the ota_requestor_delegate_responses branch from 3839898 to 3028a81 Compare April 2, 2022 04:08
@carol-apple carol-apple changed the title [OTA} Make OTARequestor responsible for responding to AnnounceOTAProvider command [OTA] Make OTARequestor responsible for responding to AnnounceOTAProvider command Apr 2, 2022
@github-actions
Copy link

github-actions bot commented Apr 2, 2022 •
edited
Loading

PR #16952: Size comparison from 5f8c83e to 3028a81

Increases (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5f8c83e 3028a81 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 667715 667947 232 0.0
.rodata 79747 79883 136 0.2
.text 587488 587584 96 0.0
lock-mtd LP_CC2652R7 (read only) 616843 617075 232 0.0
.rodata 79627 79763 136 0.2
.text 536728 536824 96 0.0
pump-app LP_CC2652R7 (read only) 687175 687391 216 0.0
.rodata 81823 81959 136 0.2
.text 604868 604948 80 0.0
pump-controller-app LP_CC2652R7 (read only) 669399 669631 232 0.0
.rodata 78159 78295 136 0.2
.text 590756 590852 96 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610098 610258 160 0.0
.app_xip_area 516840 517000 160 0.0
lock cyw930739m2evb_01 (read/write) 567602 567762 160 0.0
.app_xip_area 475880 476040 160 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 579214 579446 232 0.0
.app_xip_area 477852 478084 232 0.0
efr32 lighting-app BRD4161A (read only) 915192 915432 240 0.0
.text 915184 915424 240 0.0
BRD4161A+rpc (read only) 943072 943312 240 0.0
.text 943064 943304 240 0.0
esp32 all-clusters-app c3devkit (read only) 985358 985446 88 0.0
(read/write) 1460626 1460714 88 0.0
.flash.rodata 198024 198112 88 0.0
.flash.text 985358 985446 88 0.0
m5stack (read only) 1037895 1037959 64 0.0
(read/write) 461640 461728 88 0.0
.flash.rodata 226992 227080 88 0.0
.flash.text 1032511 1032575 64 0.0
k32w light k32w061+release (read/write) 707528 707768 240 0.0
.text 621880 622120 240 0.0
lock k32w061+release (read/write) 706952 707120 168 0.0
.text 621280 621448 168 0.0
linux all-clusters-app debug (read only) 2575665 2576081 416 0.0
.rodata 220709 220869 160 0.1
.text 2187394 2187650 256 0.0
lighting-app debug+rpc (read only) 2235241 2235657 416 0.0
.rodata 179169 179329 160 0.1
.text 1893250 1893506 256 0.0
ota-requestor-app debug (read only) 2023857 2024321 464 0.0
.rodata 167084 167244 160 0.1
.text 1700850 1701154 304 0.0
shell debug (read only) 2472481 2472897 416 0.0
.rodata 212498 212658 160 0.1
.text 2102050 2102306 256 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2359004 2359156 152 0.0
.text 1321604 1321756 152 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148347 1148567 220 0.0
rodata 143356 143496 140 0.1
text 787092 787184 92 0.0
p6 all-clusters-app default (read/write) 2503728 2503896 168 0.0
.text 1461992 1462160 168 0.0
light-app default (read/write) 2404904 2405072 168 0.0
.text 1363168 1363336 168 0.0
lock-app default (read/write) 2368536 2368704 168 0.0
.text 1326800 1326968 168 0.0
telink lighting-app tlsr9518adk80d (read/write) 791780 791956 176 0.0
text 561594 561684 90 0.0
Decreases (3 builds for cc13x2_26x2)
platform target config section 5f8c83e 3028a81 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 184012 183780 -232 -0.1
pump-app LP_CC2652R7 (read/write) 165712 165496 -216 -0.1
pump-controller-app LP_CC2652R7 (read/write) 183232 183000 -232 -0.1
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 5f8c83e 3028a81 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 667715 667947 232 0.0
(read/write) 184012 183780 -232 -0.1
.bss 81768 81768 0 0.0
.data 3132 3132 0 0.0
.rodata 79747 79883 136 0.2
.text 587488 587584 96 0.0
lock-mtd LP_CC2652R7 (read only) 616843 617075 232 0.0
(read/write) 154484 154484 0 0.0
.bss 77496 77496 0 0.0
.data 3132 3132 0 0.0
.rodata 79627 79763 136 0.2
.text 536728 536824 96 0.0
pump-app LP_CC2652R7 (read only) 687175 687391 216 0.0
(read/write) 165712 165496 -216 -0.1
.bss 82160 82160 0 0.0
.data 3164 3164 0 0.0
.rodata 81823 81959 136 0.2
.text 604868 604948 80 0.0
pump-controller-app LP_CC2652R7 (read only) 669399 669631 232 0.0
(read/write) 183232 183000 -232 -0.1
.bss 81904 81904 0 0.0
.data 3128 3128 0 0.0
.rodata 78159 78295 136 0.2
.text 590756 590852 96 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610098 610258 160 0.0
.app_xip_area 516840 517000 160 0.0
.bss 76004 76004 0 0.0
.data 600 600 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 567602 567762 160 0.0
.app_xip_area 475880 476040 160 0.0
.bss 74508 74508 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 579214 579446 232 0.0
.app_xip_area 477852 478084 232 0.0
.bss 83820 83820 0 0.0
.data 504 504 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915192 915432 240 0.0
(read/write) 129760 129760 0 0.0
.bss 127800 127800 0 0.0
.data 1960 1960 0 0.0
.text 915184 915424 240 0.0
BRD4161A+rpc (read only) 943072 943312 240 0.0
(read/write) 145720 145720 0 0.0
.bss 143576 143576 0 0.0
.data 2140 2140 0 0.0
.text 943064 943304 240 0.0
window-app BRD4161A (read only) 850536 850536 0 0.0
(read/write) 127784 127784 0 0.0
.bss 125944 125944 0 0.0
.data 1840 1840 0 0.0
.text 850528 850528 0 0.0
esp32 all-clusters-app c3devkit (read only) 985358 985446 88 0.0
(read/write) 1460626 1460714 88 0.0
.dram0.bss 62952 62952 0 0.0
.dram0.data 14172 14172 0 0.0
.flash.rodata 198024 198112 88 0.0
.flash.text 985358 985446 88 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1037895 1037959 64 0.0
(read/write) 461640 461728 88 0.0
.dram0.bss 68480 68480 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 226992 227080 88 0.0
.flash.text 1032511 1032575 64 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 707528 707768 240 0.0
.bss 77976 77976 0 0.0
.data 1872 1872 0 0.0
.text 621880 622120 240 0.0
lock k32w061+release (read/write) 706952 707120 168 0.0
.bss 77960 77960 0 0.0
.data 1912 1912 0 0.0
.text 621280 621448 168 0.0
linux all-clusters-app debug (read only) 2575665 2576081 416 0.0
(read/write) 144488 144488 0 0.0
.bss 57600 57600 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 79672 79672 0 0.0
.dynamic 592 592 0 0.0
.got 4312 4312 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 220709 220869 160 0.1
.text 2187394 2187650 256 0.0
bridge-app debug+rpc (read only) 1786341 1786341 0 0.0
(read/write) 90072 90072 0 0.0
.bss 44584 44584 0 0.0
.data 2000 2000 0 0.0
.data.rel.ro 38384 38384 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 147217 147217 0 0.0
.text 1522949 1522949 0 0.0
chip-tool debug (read only) 10433101 10433101 0 0.0
(read/write) 358584 358584 0 0.0
.bss 22016 22016 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 329272 329272 0 0.0
.dynamic 624 624 0 0.0
.got 4896 4896 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 532141 532141 0 0.0
.text 9108485 9108485 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 10033756 10033756 0 0.0
(read/write) 478177 478177 0 0.0
.bss 40337 40337 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 376144 376144 0 0.0
.dynamic 560 560 0 0.0
.got 56768 56768 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 506572 506572 0 0.0
.text 8462660 8462660 0 0.0
door-lock-app debug (read only) 2057057 2057057 0 0.0
(read/write) 117968 117968 0 0.0
.bss 47840 47840 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 63480 63480 0 0.0
.dynamic 592 592 0 0.0
.got 4256 4256 0 0.0
.init 27 27 0 0.0
.init_array 680 680 0 0.0
.rodata 185057 185057 0 0.0
.text 1718642 1718642 0 0.0
lighting-app debug+rpc (read only) 2235241 2235657 416 0.0
(read/write) 124928 124928 0 0.0
.bss 49152 49152 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 68552 68552 0 0.0
.dynamic 608 608 0 0.0
.got 4304 4304 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 179169 179329 160 0.1
.text 1893250 1893506 256 0.0
ota-provider-app debug (read only) 1995025 1995025 0 0.0
(read/write) 113536 113536 0 0.0
.bss 47680 47680 0 0.0
.data 1320 1320 0 0.0
.data.rel.ro 58792 58792 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 170851 170851 0 0.0
.text 1669906 1669906 0 0.0
ota-requestor-app debug (read only) 2023857 2024321 464 0.0
(read/write) 116760 116760 0 0.0
.bss 48672 48672 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 61000 61000 0 0.0
.dynamic 592 592 0 0.0
.got 4296 4296 0 0.0
.init 27 27 0 0.0
.init_array 656 656 0 0.0
.rodata 167084 167244 160 0.1
.text 1700850 1701154 304 0.0
shell debug (read only) 2472481 2472897 416 0.0
(read/write) 147952 147952 0 0.0
.bss 67304 67304 0 0.0
.data 784 784 0 0.0
.data.rel.ro 74136 74136 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212498 212658 160 0.1
.text 2102050 2102306 256 0.0
thermostat-no-ble arm64 (read only) 2309868 2309868 0 0.0
(read/write) 149185 149185 0 0.0
.bss 62961 62961 0 0.0
.data 1080 1080 0 0.0
.data.rel.ro 77552 77552 0 0.0
.dynamic 560 560 0 0.0
.got 4576 4576 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 143052 143052 0 0.0
.text 1941536 1941536 0 0.0
tv-app debug (read only) 2739289 2739289 0 0.0
(read/write) 249472 249472 0 0.0
.bss 165264 165264 0 0.0
.data 3328 3328 0 0.0
.data.rel.ro 74712 74712 0 0.0
.dynamic 592 592 0 0.0
.got 4656 4656 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 210731 210731 0 0.0
.text 2350594 2350594 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2359004 2359156 152 0.0
.bss 185052 185052 0 0.0
.data 5760 5760 0 0.0
.text 1321604 1321756 152 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148347 1148567 220 0.0
bss 143076 143076 0 0.0
rodata 143356 143496 140 0.1
text 787092 787184 92 0.0
p6 all-clusters-app default (read/write) 2503728 2503896 168 0.0
.bss 118488 118488 0 0.0
.data 2640 2640 0 0.0
.text 1461992 1462160 168 0.0
light-app default (read/write) 2404904 2405072 168 0.0
.bss 111944 111944 0 0.0
.data 2496 2496 0 0.0
.text 1363168 1363336 168 0.0
lock-app default (read/write) 2368536 2368704 168 0.0
.bss 111688 111688 0 0.0
.data 2456 2456 0 0.0
.text 1326800 1326968 168 0.0
telink lighting-app tlsr9518adk80d (read/write) 791780 791956 176 0.0
bss 70296 70296 0 0.0
noinit 40416 40416 0 0.0
text 561594 561684 90 0.0

@carol-apple carol-apple force-pushed the ota_requestor_delegate_responses branch from 3028a81 to e2782ad Compare April 4, 2022 18:22
@carol-apple carol-apple closed this Apr 4, 2022
@carol-apple carol-apple reopened this Apr 4, 2022
@github-actions
Copy link

github-actions bot commented Apr 4, 2022 •
edited
Loading

PR #16952: Size comparison from 080bb57 to e2782ad

Increases (19 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
platform target config section 080bb57 e2782ad change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668211 668299 88 0.0
.rodata 79683 79723 40 0.1
.text 588048 588096 48 0.0
lock-mtd LP_CC2652R7 (read only) 617339 617427 88 0.0
.rodata 79571 79611 40 0.1
.text 537280 537328 48 0.0
pump-app LP_CC2652R7 (read only) 687679 687767 88 0.0
.rodata 81767 81807 40 0.0
.text 605428 605476 48 0.0
pump-controller-app LP_CC2652R7 (read only) 669903 669991 88 0.0
.rodata 78103 78143 40 0.1
.text 591316 591364 48 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610854 610926 72 0.0
.app_xip_area 517564 517636 72 0.0
lock cyw930739m2evb_01 (read/write) 568362 568434 72 0.0
.app_xip_area 476616 476688 72 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 580014 580102 88 0.0
.app_xip_area 478624 478712 88 0.0
efr32 lighting-app BRD4161A (read only) 916176 916212 36 0.0
.text 916168 916204 36 0.0
BRD4161A+rpc (read only) 944080 944116 36 0.0
.text 944072 944108 36 0.0
esp32 all-clusters-app c3devkit (read only) 985898 985950 52 0.0
(read/write) 1460570 1460602 32 0.0
.flash.rodata 197952 197984 32 0.0
.flash.text 985898 985950 52 0.0
m5stack (read only) 1038407 1038451 44 0.0
(read/write) 461608 461640 32 0.0
.flash.rodata 226936 226968 32 0.0
.flash.text 1033023 1033067 44 0.0
k32w light k32w061+release (read/write) 708068 708156 88 0.0
.text 622412 622500 88 0.0
lock k32w061+release (read/write) 707492 707572 80 0.0
.text 621796 621876 80 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2360332 2360428 96 0.0
.text 1322932 1323028 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148915 1149003 88 0.0
rodata 143292 143332 40 0.0
text 787692 787740 48 0.0
p6 all-clusters-app default (read/write) 2504504 2504584 80 0.0
.text 1462768 1462848 80 0.0
light-app default (read/write) 2405680 2405760 80 0.0
.text 1363944 1364024 80 0.0
lock-app default (read/write) 2369320 2369416 96 0.0
.text 1327584 1327680 96 0.0
telink lighting-app tlsr9518adk80d (read/write) 792316 792396 80 0.0
text 562168 562220 52 0.0
Decreases (5 builds for cc13x2_26x2, efr32)
platform target config section 080bb57 e2782ad change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 183500 183412 -88 -0.0
pump-app LP_CC2652R7 (read/write) 165200 165112 -88 -0.1
pump-controller-app LP_CC2652R7 (read/write) 182712 182624 -88 -0.0
efr32 lighting-app BRD4161A+rpc (read/write) 145736 145732 -4 -0.0
window-app BRD4161A (read only) 851496 851444 -52 -0.0
.text 851488 851436 -52 -0.0
Full report (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 080bb57 e2782ad change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 668211 668299 88 0.0
(read/write) 183500 183412 -88 -0.0
.bss 81752 81752 0 0.0
.data 3164 3164 0 0.0
.rodata 79683 79723 40 0.1
.text 588048 588096 48 0.0
lock-mtd LP_CC2652R7 (read only) 617339 617427 88 0.0
(read/write) 154500 154500 0 0.0
.bss 77480 77480 0 0.0
.data 3164 3164 0 0.0
.rodata 79571 79611 40 0.1
.text 537280 537328 48 0.0
pump-app LP_CC2652R7 (read only) 687679 687767 88 0.0
(read/write) 165200 165112 -88 -0.1
.bss 82152 82152 0 0.0
.data 3196 3196 0 0.0
.rodata 81767 81807 40 0.0
.text 605428 605476 48 0.0
pump-controller-app LP_CC2652R7 (read only) 669903 669991 88 0.0
(read/write) 182712 182624 -88 -0.0
.bss 81888 81888 0 0.0
.data 3160 3160 0 0.0
.rodata 78103 78143 40 0.1
.text 591316 591364 48 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610854 610926 72 0.0
.app_xip_area 517564 517636 72 0.0
.bss 76004 76004 0 0.0
.data 632 632 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 568362 568434 72 0.0
.app_xip_area 476616 476688 72 0.0
.bss 74500 74500 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 580014 580102 88 0.0
.app_xip_area 478624 478712 88 0.0
.bss 83816 83816 0 0.0
.data 536 536 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 916176 916212 36 0.0
(read/write) 129784 129784 0 0.0
.bss 127792 127792 0 0.0
.data 1992 1992 0 0.0
.text 916168 916204 36 0.0
BRD4161A+rpc (read only) 944080 944116 36 0.0
(read/write) 145736 145732 -4 -0.0
.bss 143560 143560 0 0.0
.data 2172 2172 0 0.0
.text 944072 944108 36 0.0
window-app BRD4161A (read only) 851496 851444 -52 -0.0
(read/write) 127808 127808 0 0.0
.bss 125936 125936 0 0.0
.data 1872 1872 0 0.0
.text 851488 851436 -52 -0.0
esp32 all-clusters-app c3devkit (read only) 985898 985950 52 0.0
(read/write) 1460570 1460602 32 0.0
.dram0.bss 62944 62944 0 0.0
.dram0.data 14196 14196 0 0.0
.flash.rodata 197952 197984 32 0.0
.flash.text 985898 985950 52 0.0
.iram0.text 62572 62572 0 0.0
m5stack (read only) 1038407 1038451 44 0.0
(read/write) 461608 461640 32 0.0
.dram0.bss 68472 68472 0 0.0
.dram0.data 34056 34056 0 0.0
.flash.rodata 226936 226968 32 0.0
.flash.text 1033023 1033067 44 0.0
.iram0.text 123415 123415 0 0.0
k32w light k32w061+release (read/write) 708068 708156 88 0.0
.bss 77952 77952 0 0.0
.data 1904 1904 0 0.0
.text 622412 622500 88 0.0
lock k32w061+release (read/write) 707492 707572 80 0.0
.bss 77952 77952 0 0.0
.data 1944 1944 0 0.0
.text 621796 621876 80 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 10039220 10039220 0 0.0
(read/write) 478305 478305 0 0.0
.bss 40337 40337 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 376264 376264 0 0.0
.dynamic 560 560 0 0.0
.got 56784 56784 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 506628 506628 0 0.0
.text 8467764 8467764 0 0.0
thermostat-no-ble arm64 (read only) 2312940 2312940 0 0.0
(read/write) 149361 149361 0 0.0
.bss 62945 62945 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 77640 77640 0 0.0
.dynamic 560 560 0 0.0
.got 4624 4624 0 0.0
.init 24 24 0 0.0
.init_array 368 368 0 0.0
.rodata 143116 143116 0 0.0
.text 1944224 1944224 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2360332 2360428 96 0.0
.bss 185036 185036 0 0.0
.data 5784 5784 0 0.0
.text 1322932 1323028 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1148915 1149003 88 0.0
bss 143060 143060 0 0.0
rodata 143292 143332 40 0.0
text 787692 787740 48 0.0
p6 all-clusters-app default (read/write) 2504504 2504584 80 0.0
.bss 118472 118472 0 0.0
.data 2672 2672 0 0.0
.text 1462768 1462848 80 0.0
light-app default (read/write) 2405680 2405760 80 0.0
.bss 111928 111928 0 0.0
.data 2528 2528 0 0.0
.text 1363944 1364024 80 0.0
lock-app default (read/write) 2369320 2369416 96 0.0
.bss 111672 111672 0 0.0
.data 2488 2488 0 0.0
.text 1327584 1327680 96 0.0
telink lighting-app tlsr9518adk80d (read/write) 792316 792396 80 0.0
bss 70288 70288 0 0.0
noinit 40416 40416 0 0.0
text 562168 562220 52 0.0

@woody-apple woody-apple merged commit f70fbdb into project-chip:master Apr 4, 2022
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@carol-apple @chencheung
[OTA] Make OTARequestor responsible for responding to AnnounceOTAProv…
4d8f4e8 
…ider command (project-chip#16952)
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@carol-apple @chencheung
[OTA] Make OTARequestor responsible for responding to AnnounceOTAProv…
763ae67 
…ider command (project-chip#16952)
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@carol-apple @andrei-menzopol
[OTA] Make OTARequestor responsible for responding to AnnounceOTAProv…
1d3fdae 
…ider command (project-chip#16952)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@harsha-rajendran harsha-rajendran harsha-rajendran approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OTA Requestor needs to clearly define who is responsible for responding
4 participants
@carol-apple @harsha-rajendran @woody-apple @bzbarsky-apple