Support New VID/PID Encoding in the SubjectDN of Attestation Certs #16900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang and
sagar-apple
emargolis
force-pushed
the
emargolis/feature/vid-and-pid-cn-attribute
branch
2 times, most recently
from
bc536dc to
889ffeb
Compare
|
PR #16900: Size comparison from e8c3452 to 889ffeb Increases above 0.2%:
Increases (11 builds for esp32, linux)
Decreases (5 builds for esp32, linux, mbed, p6, telink)
Full report (24 builds for cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #16900: Size comparison from e8c3452 to c0fcc70 Increases above 0.2%:
Increases (11 builds for efr32, linux)
Decreases (4 builds for linux, mbed, p6, telink)
Full report (25 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
emargolis
force-pushed
the
emargolis/feature/vid-and-pid-cn-attribute
branch
from
c0fcc70 to
e0d44d0
Compare
|
PR #16900: Size comparison from 089d46a to e0d44d0 Increases above 0.2%:
Increases (12 builds for efr32, esp32, linux)
Decreases (5 builds for esp32, linux, mbed, p6, telink)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
src/credentials/attestation_verifier/DefaultDeviceAttestationVerifier.cpp
Outdated
Show resolved
Hide resolved
src/credentials/attestation_verifier/DefaultDeviceAttestationVerifier.cpp
Outdated
Show resolved
Hide resolved
emargolis
force-pushed
the
emargolis/feature/vid-and-pid-cn-attribute
branch
from
c735fef to
696021d
Compare
|
PR #16900: Size comparison from 41a431d to 696021d Increases (3 builds for efr32, linux, mbed)
Decreases (2 builds for linux, telink)
Full report (20 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
* Updated OpenSSL and mbedTLS implementations to support that.
* Updated chip-cert tool to support new format in addition to the old one.
* Added new test verctors:
-- Updated Matter Development DAC (PIDs 0x8010-0x8014) to use
Fallback methods to encode VID and PID in the SubjectDN.
-- Added new Matter Test DAC/PAI vectors that use Fallback methods
to encode VID and PID in the SubjectDN.
emargolis
force-pushed
the
emargolis/feature/vid-and-pid-cn-attribute
branch
from
696021d to
90f2ae5
Compare
|
PR #16900: Size comparison from 41a431d to 90f2ae5 Increases (4 builds for efr32, esp32, linux, mbed)
Decreases (3 builds for esp32, linux, telink)
Full report (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
Looks like comments are resolved, merging. |
woody-apple
approved these changes
Apr 4, 2022
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
…roject-chip#16900) * Updated OpenSSL and mbedTLS implementations to support that. * Updated chip-cert tool to support new format in addition to the old one. * Added new test verctors: -- Updated Matter Development DAC (PIDs 0x8010-0x8014) to use Fallback methods to encode VID and PID in the SubjectDN. -- Added new Matter Test DAC/PAI vectors that use Fallback methods to encode VID and PID in the SubjectDN.
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
…roject-chip#16900) * Updated OpenSSL and mbedTLS implementations to support that. * Updated chip-cert tool to support new format in addition to the old one. * Added new test verctors: -- Updated Matter Development DAC (PIDs 0x8010-0x8014) to use Fallback methods to encode VID and PID in the SubjectDN. -- Added new Matter Test DAC/PAI vectors that use Fallback methods to encode VID and PID in the SubjectDN.
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…roject-chip#16900) * Updated OpenSSL and mbedTLS implementations to support that. * Updated chip-cert tool to support new format in addition to the old one. * Added new test verctors: -- Updated Matter Development DAC (PIDs 0x8010-0x8014) to use Fallback methods to encode VID and PID in the SubjectDN. -- Added new Matter Test DAC/PAI vectors that use Fallback methods to encode VID and PID in the SubjectDN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The spec was updated to support alternative (aka "fallback") method to encode VID and PID fields in the Attestation Certificates.
Ticket: #16747
Change overview
-- Updated Matter Development DAC (PIDs 0x8010-0x8014) to use
Fallback methods to encode VID and PID in the SubjectDN.
-- Added new Matter Test DAC/PAI vectors that use Fallback methods
to encode VID and PID in the SubjectDN.
Testing
Added new test case plus existing tests.