Code

Fix Session ID Allocation#16895

Code

Merged

kghost merged 26 commits intoproject-chip:masterproject-chip/connectedhomeip:masterfrom msandstedt:7835-fix-session-id-allocationmsandstedt/connectedhomeip:7835-fix-session-id-allocationCopy head branch name to clipboardApr 4, 2022

+578-678

Commits

Commits on Mar 31, 2022

• Fix Session ID Allocation

  Show description for 002b1d0
  msandstedt

  committed
  002b1d0

• fix Werror=conversion

  msandstedt

  committed
  188a90b

• fix VerifyOrExit lint error

  msandstedt

  committed
  9bc7d26

• fix Werror=unused-but-set-variable with detail logging disabled

  msandstedt

  committed
  7735c71

Commits on Apr 1, 2022

• fix tv-casting-app build

  msandstedt

  committed
  dfc64b0

• pass SessionHolder by reference to reduce stack size

  msandstedt

  committed
  3225dfa

• bypass -Wstack-usage= in TestPASESession to fix spurious stack warning

  msandstedt

  committed
  82b994d

• Update src/transport/SecureSession.h

  Show description for e6f5d50
  

  msandstedt

  and

  bzbarsky-apple

  authored
  e6f5d50

• Update src/transport/SecureSessionTable.h

  Show description for 3a5890b
  

  msandstedt

  and

  bzbarsky-apple

  authored
  3a5890b

• per bzbarsky-apple, document that allocation of sessions to caller-specified IDs is for testing

  msandstedt

  committed
  41484e0

• Update src/transport/PairingSession.h

  Show description for 06ff5a2
  

  msandstedt

  and

  bzbarsky-apple

  authored
  06ff5a2

• per mrjerryjohns, delegate allocation of secure sessions to base PairingSession object

  msandstedt

  committed
  4d5afbb

• remove use of Optional<uint16_t> session IDs

  Show description for 16c2b80
  msandstedt

  committed
  16c2b80

• init session ID randomly; add more checks for invalid 0 session ID

  msandstedt

  committed
  0f3bb4f

• Update src/transport/PairingSession.h

  Show description for e2b7153
  

  msandstedt

  and

  bzbarsky-apple

  authored
  e2b7153

• per bzbarsky-apple, pass reference type to SessionHolderWithDelegate

  msandstedt

  committed
  b35233d

• restyle

  msandstedt

  committed
  e864a2c

• per kghost, pass SessionHandle, not SessionHolder

  msandstedt

  committed
  13f40b6

• make sure to grab the session in NewPairing

  msandstedt

  committed
  0e71168

• fixup doxy params

  msandstedt

  committed
  90765f1

Commits on Apr 2, 2022

• fix up comments

  msandstedt

  committed
  39bc525

• add a test case to verify the session ID allocator does not have collisions

  msandstedt

  committed
  3c90b7b

• reduce number of session ID allocator collision test iterations to fix CI timeout

  msandstedt

  committed
  11b261b

• fix loop sentinel in TestSessionManager

  msandstedt

  committed
  0328b08

• increase gcc_debug test phase timeout

  msandstedt

  committed
  e955363

Commits on Apr 3, 2022

• increase gcc-debug total timeout to 65 minutes

  msandstedt

  committed
  244b751