-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a typo in src/app/server/Server.cpp that prevents the echo handle… #16878
Merged
tcarmelveilleux
merged 1 commit into
project-chip:master
from
vivien-apple:Server_EchoHandlerInitTypo
Apr 1, 2022
Merged
Fix a typo in src/app/server/Server.cpp that prevents the echo handle… #16878
tcarmelveilleux
merged 1 commit into
project-chip:master
from
vivien-apple:Server_EchoHandlerInitTypo
Apr 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r server to starts
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple and
jelderton
March 31, 2022 14:56
pullapprove
bot
requested review from
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02,
msandstedt,
mspang,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
March 31, 2022 14:56
Damian-Nordic
approved these changes
Mar 31, 2022
PR #16878: Size comparison from a86ad03 to 6850dcd Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jmartinez-silabs
approved these changes
Mar 31, 2022
tcarmelveilleux
approved these changes
Apr 1, 2022
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
…r server to starts (project-chip#16878)
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
…r server to starts (project-chip#16878)
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…r server to starts (project-chip#16878)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r server to starts
Problem
Building the server with
chip_app_use_echo=true
fails because of a typo.Change overview
gExchangeMgr
bymExchangeMgr
Testing
I have tested it by building it with the fix and doing echo requests.