Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using vendor id 0 for controllers in Darwin code. #16807

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Stop using vendor id 0 for controllers in Darwin code. #16807

merged 1 commit into from
Mar 30, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Controllers should use the vendor id of their vendor, or one of the
test vendor ids. Using the "Matter standard" vendor Id there makes no
sense.

Problem

Using vendor id 0 for controllers.

Change overview

Stop doing that.

Testing

CI should cover this.

@github-actions
Copy link

github-actions bot commented Mar 30, 2022 •
edited
Loading

PR #16807: Size comparison from 1456eb1 to 8fd2d86

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 1456eb1 8fd2d86 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606578 606578 0 0.0
.app_xip_area 513348 513348 0 0.0
.bss 75976 75976 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 564134 564134 0 0.0
.app_xip_area 472432 472432 0 0.0
.bss 74480 74480 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576394 576394 0 0.0
.app_xip_area 475044 475044 0 0.0
.bss 83808 83808 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 927680 927680 0 0.0
(read/write) 129112 129112 0 0.0
.bss 127112 127112 0 0.0
.data 1996 1996 0 0.0
.text 927672 927672 0 0.0
BRD4161A+rpc (read only) 956688 956688 0 0.0
(read/write) 145064 145064 0 0.0
.bss 142888 142888 0 0.0
.data 2176 2176 0 0.0
.text 956680 956680 0 0.0
window-app BRD4161A (read only) 857164 857164 0 0.0
(read/write) 127072 127072 0 0.0
.bss 125200 125200 0 0.0
.data 1872 1872 0 0.0
.text 857156 857156 0 0.0
esp32 all-clusters-app c3devkit (read only) 968194 968194 0 0.0
(read/write) 1394706 1394706 0 0.0
.dram0.bss 62416 62416 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 199176 199176 0 0.0
.flash.text 968194 968194 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1023895 1023895 0 0.0
(read/write) 462468 462468 0 0.0
.dram0.bss 67944 67944 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228664 228664 0 0.0
.flash.text 1018511 1018511 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 705168 705168 0 0.0
.bss 77968 77968 0 0.0
.data 1876 1876 0 0.0
.text 619524 619524 0 0.0
lock k32w061+release (read/write) 704284 704284 0 0.0
.bss 77944 77944 0 0.0
.data 1916 1916 0 0.0
.text 618624 618624 0 0.0
linux all-clusters-app debug (read only) 2536025 2536025 0 0.0
(read/write) 143352 143352 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78920 78920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216549 216549 0 0.0
.text 2155650 2155650 0 0.0
bridge-app debug+rpc (read only) 1769757 1769757 0 0.0
(read/write) 89520 89520 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144940 144940 0 0.0
.text 1509461 1509461 0 0.0
chip-tool debug (read only) 10305813 10305813 0 0.0
(read/write) 356424 356424 0 0.0
.bss 22464 22464 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 326792 326792 0 0.0
.dynamic 608 608 0 0.0
.got 4824 4824 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 525429 525429 0 0.0
.text 8994117 8994117 0 0.0
chip-tool-ipv6only arm64 (read only) 9918924 9918924 0 0.0
(read/write) 475361 475361 0 0.0
.bss 40737 40737 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 373512 373512 0 0.0
.dynamic 560 560 0 0.0
.got 56168 56168 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 500628 500628 0 0.0
.text 8360884 8360884 0 0.0
door-lock-app debug (read only) 2022385 2022385 0 0.0
(read/write) 116896 116896 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181532 181532 0 0.0
.text 1691042 1691042 0 0.0
lighting-app debug+rpc (read only) 2198737 2198737 0 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175388 175388 0 0.0
.text 1864178 1864178 0 0.0
ota-provider-app debug (read only) 1962777 1962777 0 0.0
(read/write) 112688 112688 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58184 58184 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167307 167307 0 0.0
.text 1643602 1643602 0 0.0
ota-requestor-app debug (read only) 1990017 1990017 0 0.0
(read/write) 115912 115912 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163492 163492 0 0.0
.text 1673650 1673650 0 0.0
shell debug (read only) 2450793 2450793 0 0.0
(read/write) 147368 147368 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73568 73568 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210002 210002 0 0.0
.text 2083842 2083842 0 0.0
thermostat-no-ble arm64 (read only) 2280564 2280564 0 0.0
(read/write) 148305 148305 0 0.0
.bss 62817 62817 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 76928 76928 0 0.0
.dynamic 560 560 0 0.0
.got 4512 4512 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139972 139972 0 0.0
.text 1917280 1917280 0 0.0
tv-app debug (read only) 2698417 2698417 0 0.0
(read/write) 247520 247520 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74048 74048 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206379 206379 0 0.0
.text 2317410 2317410 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357132 2357132 0 0.0
.bss 185020 185020 0 0.0
.data 5760 5760 0 0.0
.text 1319732 1319732 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1144595 1144595 0 0.0
bss 143052 143052 0 0.0
rodata 142364 142364 0 0.0
text 784336 784336 0 0.0
p6 all-clusters-app default (read/write) 2499728 2499728 0 0.0
.bss 118440 118440 0 0.0
.data 2640 2640 0 0.0
.text 1457992 1457992 0 0.0
light-app default (read/write) 2401896 2401896 0 0.0
.bss 111912 111912 0 0.0
.data 2496 2496 0 0.0
.text 1360160 1360160 0 0.0
lock-app default (read/write) 2365528 2365528 0 0.0
.bss 111656 111656 0 0.0
.data 2456 2456 0 0.0
.text 1323792 1323792 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 788896 788896 0 0.0
bss 70268 70268 0 0.0
noinit 40416 40416 0 0.0
text 559196 559196 0 0.0

@bzbarsky-apple
Stop using vendor id 0 for controllers in Darwin code.
c0ef297 
Controllers should use the vendor id of their vendor, or one of the
test vendor ids.  Using the "Matter standard" vendor Id there makes no
sense.
@github-actions
Copy link

github-actions bot commented Mar 30, 2022 •
edited
Loading

PR #16807: Size comparison from 9d55707 to c0ef297

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 9d55707 c0ef297 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606578 606578 0 0.0
.app_xip_area 513348 513348 0 0.0
.bss 75976 75976 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 564134 564134 0 0.0
.app_xip_area 472432 472432 0 0.0
.bss 74480 74480 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 576394 576394 0 0.0
.app_xip_area 475044 475044 0 0.0
.bss 83808 83808 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 927680 927680 0 0.0
(read/write) 129112 129112 0 0.0
.bss 127112 127112 0 0.0
.data 1996 1996 0 0.0
.text 927672 927672 0 0.0
BRD4161A+rpc (read only) 956688 956688 0 0.0
(read/write) 145064 145064 0 0.0
.bss 142888 142888 0 0.0
.data 2176 2176 0 0.0
.text 956680 956680 0 0.0
window-app BRD4161A (read only) 857164 857164 0 0.0
(read/write) 127072 127072 0 0.0
.bss 125200 125200 0 0.0
.data 1872 1872 0 0.0
.text 857156 857156 0 0.0
esp32 all-clusters-app c3devkit (read only) 968194 968194 0 0.0
(read/write) 1394706 1394706 0 0.0
.dram0.bss 62416 62416 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 199176 199176 0 0.0
.flash.text 968194 968194 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1023895 1023895 0 0.0
(read/write) 462468 462468 0 0.0
.dram0.bss 67944 67944 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228664 228664 0 0.0
.flash.text 1018511 1018511 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 705168 705168 0 0.0
.bss 77968 77968 0 0.0
.data 1876 1876 0 0.0
.text 619524 619524 0 0.0
lock k32w061+release (read/write) 704284 704284 0 0.0
.bss 77944 77944 0 0.0
.data 1916 1916 0 0.0
.text 618624 618624 0 0.0
linux all-clusters-app debug (read only) 2536025 2536025 0 0.0
(read/write) 143352 143352 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78920 78920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216549 216549 0 0.0
.text 2155650 2155650 0 0.0
bridge-app debug+rpc (read only) 1769757 1769757 0 0.0
(read/write) 89520 89520 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144940 144940 0 0.0
.text 1509461 1509461 0 0.0
chip-tool debug (read only) 10308533 10308533 0 0.0
(read/write) 356424 356424 0 0.0
.bss 22464 22464 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 326792 326792 0 0.0
.dynamic 608 608 0 0.0
.got 4824 4824 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 525813 525813 0 0.0
.text 8996453 8996453 0 0.0
chip-tool-ipv6only arm64 (read only) 9921180 9921180 0 0.0
(read/write) 475393 475393 0 0.0
.bss 40737 40737 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 373512 373512 0 0.0
.dynamic 560 560 0 0.0
.got 56200 56200 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 500948 500948 0 0.0
.text 8362724 8362724 0 0.0
door-lock-app debug (read only) 2022385 2022385 0 0.0
(read/write) 116896 116896 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181532 181532 0 0.0
.text 1691042 1691042 0 0.0
lighting-app debug+rpc (read only) 2198737 2198737 0 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175388 175388 0 0.0
.text 1864178 1864178 0 0.0
ota-provider-app debug (read only) 1962777 1962777 0 0.0
(read/write) 112688 112688 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58184 58184 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167307 167307 0 0.0
.text 1643602 1643602 0 0.0
ota-requestor-app debug (read only) 1990017 1990017 0 0.0
(read/write) 115912 115912 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163492 163492 0 0.0
.text 1673650 1673650 0 0.0
shell debug (read only) 2450793 2450793 0 0.0
(read/write) 147368 147368 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73568 73568 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210002 210002 0 0.0
.text 2083842 2083842 0 0.0
thermostat-no-ble arm64 (read only) 2280564 2280564 0 0.0
(read/write) 148305 148305 0 0.0
.bss 62817 62817 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 76928 76928 0 0.0
.dynamic 560 560 0 0.0
.got 4512 4512 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139972 139972 0 0.0
.text 1917280 1917280 0 0.0
tv-app debug (read only) 2698417 2698417 0 0.0
(read/write) 247520 247520 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74048 74048 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206379 206379 0 0.0
.text 2317410 2317410 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2357132 2357132 0 0.0
.bss 185020 185020 0 0.0
.data 5760 5760 0 0.0
.text 1319732 1319732 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1144595 1144595 0 0.0
bss 143052 143052 0 0.0
rodata 142364 142364 0 0.0
text 784336 784336 0 0.0
p6 all-clusters-app default (read/write) 2499728 2499728 0 0.0
.bss 118440 118440 0 0.0
.data 2640 2640 0 0.0
.text 1457992 1457992 0 0.0
light-app default (read/write) 2401896 2401896 0 0.0
.bss 111912 111912 0 0.0
.data 2496 2496 0 0.0
.text 1360160 1360160 0 0.0
lock-app default (read/write) 2365528 2365528 0 0.0
.bss 111656 111656 0 0.0
.data 2456 2456 0 0.0
.text 1323792 1323792 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 788896 788896 0 0.0
bss 70268 70268 0 0.0
noinit 40416 40416 0 0.0
text 559196 559196 0 0.0

@Damian-Nordic Damian-Nordic merged commit 08906fb into project-chip:master Mar 30, 2022
@bzbarsky-apple bzbarsky-apple deleted the apple-vendor-id branch March 30, 2022 08:04
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Mar 31, 2022
@bzbarsky-apple @rochaferraz
Stop using vendor id 0 for controllers in Darwin code. (project-chip#…
4887acd 
…16807)

Controllers should use the vendor id of their vendor, or one of the
test vendor ids.  Using the "Matter standard" vendor Id there makes no
sense.
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@bzbarsky-apple @andrei-menzopol
Stop using vendor id 0 for controllers in Darwin code. (project-chip#…
08a6655 
…16807)

Controllers should use the vendor id of their vendor, or one of the
test vendor ids.  Using the "Matter standard" vendor Id there makes no
sense.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@msandstedt msandstedt Awaiting requested review from msandstedt

Assignees
No one assigned
Labels
darwin examples lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @msandstedt @Damian-Nordic