Try multiple transports in SetUpCodePairer. #16802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
robszewczyk,
sagar-apple and
saurabhst
pullapprove
bot
requested review from
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #16802: Size comparison from 1456eb1 to c328a64 Increases above 0.2%:
Increases (3 builds for linux)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
When a device gets removed from a fabric and then factory reset, we can get into a situation where it's only listening over BLE but there are stale DNS-SD records for it. In that case we should try BLE once we discover that doing PASE over IP does not work.
bzbarsky-apple
force-pushed
the
try-various-addresses
branch
from
c328a64 to
767280b
Compare
|
PR #16802: Size comparison from 9d55707 to 767280b Increases above 0.2%:
Increases (3 builds for linux)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Damian-Nordic
approved these changes
Mar 30, 2022
|
PR #16802: Size comparison from 9d55707 to 4885e87 Increases (2 builds for mbed, nrfconnect)
Full report (2 builds for mbed, nrfconnect)
|
tcarmelveilleux
approved these changes
Mar 31, 2022
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Mar 31, 2022
Followup to project-chip#16802 Instead of making the behavior of CHIPDeviceCommissioner depend on the state of the SetUpCodePairer, just have the latter register as the pairing delegate when it cares about PASE establishment, and restore the logic we used to have in CHIPDeviceCommissioner before PR 16802. The one logic change in CHIPDeviceCommissioner other than that is a fix to ensure that we in fact call OnPairingComplete when PASE is established even if we're going to proceed to auto-commission, so SetUpCodePairer knows to get out of the way at that point.
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Mar 31, 2022
* Try multiple transports in SetUpCodePairer. When a device gets removed from a fabric and then factory reset, we can get into a situation where it's only listening over BLE but there are stale DNS-SD records for it. In that case we should try BLE once we discover that doing PASE over IP does not work. * Address review comments * Address review comments
bzbarsky-apple
added a commit
that referenced
this pull request
Apr 1, 2022
Followup to #16802 Instead of making the behavior of CHIPDeviceCommissioner depend on the state of the SetUpCodePairer, just have the latter register as the pairing delegate when it cares about PASE establishment, and restore the logic we used to have in CHIPDeviceCommissioner before PR 16802. The one logic change in CHIPDeviceCommissioner other than that is a fix to ensure that we in fact call OnPairingComplete when PASE is established even if we're going to proceed to auto-commission, so SetUpCodePairer knows to get out of the way at that point.
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
* Try multiple transports in SetUpCodePairer. When a device gets removed from a fabric and then factory reset, we can get into a situation where it's only listening over BLE but there are stale DNS-SD records for it. In that case we should try BLE once we discover that doing PASE over IP does not work. * Address review comments * Address review comments
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
…chip#16890) Followup to project-chip#16802 Instead of making the behavior of CHIPDeviceCommissioner depend on the state of the SetUpCodePairer, just have the latter register as the pairing delegate when it cares about PASE establishment, and restore the logic we used to have in CHIPDeviceCommissioner before PR 16802. The one logic change in CHIPDeviceCommissioner other than that is a fix to ensure that we in fact call OnPairingComplete when PASE is established even if we're going to proceed to auto-commission, so SetUpCodePairer knows to get out of the way at that point.
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
* Try multiple transports in SetUpCodePairer. When a device gets removed from a fabric and then factory reset, we can get into a situation where it's only listening over BLE but there are stale DNS-SD records for it. In that case we should try BLE once we discover that doing PASE over IP does not work. * Address review comments * Address review comments
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
…chip#16890) Followup to project-chip#16802 Instead of making the behavior of CHIPDeviceCommissioner depend on the state of the SetUpCodePairer, just have the latter register as the pairing delegate when it cares about PASE establishment, and restore the logic we used to have in CHIPDeviceCommissioner before PR 16802. The one logic change in CHIPDeviceCommissioner other than that is a fix to ensure that we in fact call OnPairingComplete when PASE is established even if we're going to proceed to auto-commission, so SetUpCodePairer knows to get out of the way at that point.
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
* Try multiple transports in SetUpCodePairer. When a device gets removed from a fabric and then factory reset, we can get into a situation where it's only listening over BLE but there are stale DNS-SD records for it. In that case we should try BLE once we discover that doing PASE over IP does not work. * Address review comments * Address review comments
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…chip#16890) Followup to project-chip#16802 Instead of making the behavior of CHIPDeviceCommissioner depend on the state of the SetUpCodePairer, just have the latter register as the pairing delegate when it cares about PASE establishment, and restore the logic we used to have in CHIPDeviceCommissioner before PR 16802. The one logic change in CHIPDeviceCommissioner other than that is a fix to ensure that we in fact call OnPairingComplete when PASE is established even if we're going to proceed to auto-commission, so SetUpCodePairer knows to get out of the way at that point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a device gets removed from a fabric and then factory reset, we
can get into a situation where it's only listening over BLE but there
are stale DNS-SD records for it. In that case we should try BLE once
we discover that doing PASE over IP does not work.
Fixes #16728
Problem
See above.
Change overview
See above.
Testing
Followed the steps to reproduce from #16728 and verified that once the IP PASE setup times out we connect to the m5stack over BLE and commission it.