Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Wiseconnect submodule in Matter #16799

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Add Wiseconnect submodule in Matter #16799

merged 3 commits into from
Mar 31, 2022

Conversation

sharad-patil24
Copy link
Contributor

Problem

Wiseconnect SDK is cloned separately in current implementation

Change overview

This PR adds wiseconnect SDK as submodule in Matter

Testing

Tested manually on EFR32MG12 + rs9116 setup

@CLAassistant
Copy link

CLAassistant commented Mar 29, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@restyled-io restyled-io bot mentioned this pull request Mar 29, 2022
Closed
@github-actions
Copy link

github-actions bot commented Mar 31, 2022 •
edited
Loading

PR #16799: Size comparison from a20ba1c to 28393d1

Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a20ba1c 28393d1 change % change
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 667707 667707 0 0.0
(read/write) 184036 184036 0 0.0
.bss 81784 81784 0 0.0
.data 3132 3132 0 0.0
.rodata 79627 79627 0 0.0
.text 587600 587600 0 0.0
lock-mtd LP_CC2652R7 (read only) 616835 616835 0 0.0
(read/write) 154500 154500 0 0.0
.bss 77512 77512 0 0.0
.data 3132 3132 0 0.0
.rodata 79507 79507 0 0.0
.text 536840 536840 0 0.0
pump-app LP_CC2652R7 (read only) 686527 686527 0 0.0
(read/write) 166368 166368 0 0.0
.bss 82168 82168 0 0.0
.data 3128 3128 0 0.0
.rodata 81631 81631 0 0.0
.text 604412 604412 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669415 669415 0 0.0
(read/write) 183232 183232 0 0.0
.bss 81920 81920 0 0.0
.data 3128 3128 0 0.0
.rodata 78039 78039 0 0.0
.text 590892 590892 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 609754 609754 0 0.0
.app_xip_area 516496 516496 0 0.0
.bss 76004 76004 0 0.0
.data 600 600 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 567266 567266 0 0.0
.app_xip_area 475544 475544 0 0.0
.bss 74508 74508 0 0.0
.data 564 564 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 579182 579182 0 0.0
.app_xip_area 477804 477804 0 0.0
.bss 83836 83836 0 0.0
.data 504 504 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 930500 930500 0 0.0
(read/write) 129128 129128 0 0.0
.bss 127136 127136 0 0.0
.data 1992 1992 0 0.0
.text 930492 930492 0 0.0
BRD4161A+rpc (read only) 959508 959508 0 0.0
(read/write) 145084 145084 0 0.0
.bss 142912 142912 0 0.0
.data 2172 2172 0 0.0
.text 959500 959500 0 0.0
window-app BRD4161A (read only) 859960 859960 0 0.0
(read/write) 127096 127096 0 0.0
.bss 125224 125224 0 0.0
.data 1868 1868 0 0.0
.text 859952 859952 0 0.0
esp32 all-clusters-app c3devkit (read only) 970622 970622 0 0.0
(read/write) 1395138 1395138 0 0.0
.dram0.bss 62456 62456 0 0.0
.dram0.data 14220 14220 0 0.0
.flash.rodata 199544 199544 0 0.0
.flash.text 970622 970622 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1026335 1026335 0 0.0
(read/write) 462900 462900 0 0.0
.dram0.bss 67984 67984 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 229056 229056 0 0.0
.flash.text 1020951 1020951 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 707492 707492 0 0.0
.bss 77992 77992 0 0.0
.data 1872 1872 0 0.0
.text 621828 621828 0 0.0
lock k32w061+release (read/write) 706600 706600 0 0.0
.bss 77960 77960 0 0.0
.data 1912 1912 0 0.0
.text 620928 620928 0 0.0
linux all-clusters-app debug (read only) 2553137 2553137 0 0.0
(read/write) 143872 143872 0 0.0
.bss 57472 57472 0 0.0
.data 1296 1296 0 0.0
.data.rel.ro 79352 79352 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 219077 219077 0 0.0
.text 2169634 2169634 0 0.0
bridge-app debug+rpc (read only) 1783037 1783037 0 0.0
(read/write) 89880 89880 0 0.0
.bss 44552 44552 0 0.0
.data 2000 2000 0 0.0
.data.rel.ro 38232 38232 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 552 552 0 0.0
.rodata 147057 147057 0 0.0
.text 1520117 1520117 0 0.0
chip-tool debug (read only) 10333325 10333325 0 0.0
(read/write) 356640 356640 0 0.0
.bss 22080 22080 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 327264 327264 0 0.0
.dynamic 624 624 0 0.0
.got 4896 4896 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 529997 529997 0 0.0
.text 9015269 9015269 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9941780 9941780 0 0.0
(read/write) 475633 475633 0 0.0
.bss 40401 40401 0 0.0
.data 1136 1136 0 0.0
.data.rel.ro 374024 374024 0 0.0
.dynamic 560 560 0 0.0
.got 56264 56264 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 503788 503788 0 0.0
.text 8379380 8379380 0 0.0
door-lock-app debug (read only) 2035761 2035761 0 0.0
(read/write) 117288 117288 0 0.0
.bss 47680 47680 0 0.0
.data 1008 1008 0 0.0
.data.rel.ro 63176 63176 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 183649 183649 0 0.0
.text 1701794 1701794 0 0.0
lighting-app debug+rpc (read only) 2213521 2213521 0 0.0
(read/write) 124280 124280 0 0.0
.bss 48960 48960 0 0.0
.data 1488 1488 0 0.0
.data.rel.ro 68248 68248 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 177665 177665 0 0.0
.text 1876178 1876178 0 0.0
ota-provider-app debug (read only) 1975553 1975553 0 0.0
(read/write) 113016 113016 0 0.0
.bss 47584 47584 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58488 58488 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 169291 169291 0 0.0
.text 1653890 1653890 0 0.0
ota-requestor-app debug (read only) 2003457 2003457 0 0.0
(read/write) 116208 116208 0 0.0
.bss 48544 48544 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60696 60696 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 648 648 0 0.0
.rodata 165652 165652 0 0.0
.text 1684450 1684450 0 0.0
shell debug (read only) 2468473 2468473 0 0.0
(read/write) 147824 147824 0 0.0
.bss 67304 67304 0 0.0
.data 784 784 0 0.0
.data.rel.ro 74016 74016 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 212274 212274 0 0.0
.text 2098578 2098578 0 0.0
thermostat-no-ble arm64 (read only) 2293092 2293092 0 0.0
(read/write) 148657 148657 0 0.0
.bss 62849 62849 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77216 77216 0 0.0
.dynamic 560 560 0 0.0
.got 4544 4544 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 142052 142052 0 0.0
.text 1927072 1927072 0 0.0
tv-app debug (read only) 2714633 2714633 0 0.0
(read/write) 248184 248184 0 0.0
.bss 164624 164624 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74368 74368 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 896 896 0 0.0
.rodata 208811 208811 0 0.0
.text 2330690 2330690 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2358540 2358540 0 0.0
.bss 185052 185052 0 0.0
.data 5760 5760 0 0.0
.text 1321140 1321140 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1147635 1147635 0 0.0
bss 143092 143092 0 0.0
rodata 142884 142884 0 0.0
text 786856 786856 0 0.0
p6 all-clusters-app default (read/write) 2502984 2502984 0 0.0
.bss 118488 118488 0 0.0
.data 2640 2640 0 0.0
.text 1461248 1461248 0 0.0
light-app default (read/write) 2404472 2404472 0 0.0
.bss 111944 111944 0 0.0
.data 2496 2496 0 0.0
.text 1362736 1362736 0 0.0
lock-app default (read/write) 2368080 2368080 0 0.0
.bss 111688 111688 0 0.0
.data 2456 2456 0 0.0
.text 1326344 1326344 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 791428 791428 0 0.0
bss 70296 70296 0 0.0
noinit 40416 40416 0 0.0
text 561392 561392 0 0.0

@jmartinez-silabs jmartinez-silabs merged commit fbcaa81 into project-chip:master Mar 31, 2022
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Mar 31, 2022
@sharad-patil24 @restyled-commits @rochaferraz
Add Wiseconnect submodule in Matter (project-chip#16799)
e20573b 
* Add Wiseconnect submodule in Matter

* Restyled by gn

Co-authored-by: Restyled.io <[email protected]>
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@sharad-patil24 @restyled-commits @chencheung
Add Wiseconnect submodule in Matter (project-chip#16799)
0f9cf86 
* Add Wiseconnect submodule in Matter

* Restyled by gn

Co-authored-by: Restyled.io <[email protected]>
chencheung pushed a commit to chencheung/connectedhomeip that referenced this pull request Apr 6, 2022
@sharad-patil24 @restyled-commits @chencheung
Add Wiseconnect submodule in Matter (project-chip#16799)
d983d44 
* Add Wiseconnect submodule in Matter

* Restyled by gn

Co-authored-by: Restyled.io <[email protected]>
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@sharad-patil24 @restyled-commits @andrei-menzopol
Add Wiseconnect submodule in Matter (project-chip#16799)
eae7f22 
* Add Wiseconnect submodule in Matter

* Restyled by gn

Co-authored-by: Restyled.io <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sharad-patil24 @CLAassistant @bzbarsky-apple @jmartinez-silabs @restyled-commits