-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenThread] Add missing SetThreadProvision implementation on RTOS #1679
Conversation
Size increase report for "gn_nrf-example-build"
Full report output
|
Size increase report for "gn_linux-example-build"
Full report output
|
Size increase report for "nrf-example-build"
Full report output
|
Size increase report for "linux-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
newDataset.mComponents.mIsPendingTimestampPresent = true; | ||
if (netInfo.ThreadNetworkName[0] != 0) | ||
{ | ||
strncpy((char *) newDataset.mNetworkName.m8, netInfo.ThreadNetworkName, sizeof(newDataset.mNetworkName.m8)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strncpy((char *) newDataset.mNetworkName.m8, netInfo.ThreadNetworkName, sizeof(newDataset.mNetworkName.m8)); | |
strncpy((char *) newDataset.mNetworkName.m8, netInfo.ThreadNetworkName, sizeof(newDataset.mNetworkName.m8) - 1); |
newDataset.mComponents.mIsActiveTimestampPresent = true; | ||
newDataset.mComponents.mIsPendingTimestampPresent = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these necessary?
newDataset.mComponents.mIsActiveTimestampPresent = true; | |
newDataset.mComponents.mIsPendingTimestampPresent = true; | |
newDataset.mComponents.mIsActiveTimestampPresent = true; | |
newDataset.mComponents.mIsPendingTimestampPresent = true; |
Problem
SetThreadProvision
is undefined for RTOS devices currently.Summary of Changes
Add the definition of this method.