Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenThread] Add missing SetThreadProvision implementation on RTOS #1679

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

gjc13
Copy link
Contributor

@gjc13 gjc13 commented Jul 22, 2020

Problem

SetThreadProvision is undefined for RTOS devices currently.

Summary of Changes

Add the definition of this method.

@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
.debug_info,0,745
.debug_str,0,441
.debug_line,0,207
.debug_loc,0,161
.debug_abbrev,0,40
.debug_frame,0,40
.debug_ranges,0,40
.debug_macro,0,15
.strtab,0,10
.debug_aranges,0,8
[Unmapped],0,5


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
chip-wifi-echo.elf .flash.rodata -8 -8
chip-wifi-echo.elf .flash.text -72 -72
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize
[Unmapped],0,8
.flash.rodata,-8,-8
.flash.text,-72,-72


@woody-apple woody-apple merged commit c870536 into project-chip:master Jul 22, 2020
newDataset.mComponents.mIsPendingTimestampPresent = true;
if (netInfo.ThreadNetworkName[0] != 0)
{
strncpy((char *) newDataset.mNetworkName.m8, netInfo.ThreadNetworkName, sizeof(newDataset.mNetworkName.m8));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
strncpy((char *) newDataset.mNetworkName.m8, netInfo.ThreadNetworkName, sizeof(newDataset.mNetworkName.m8));
strncpy((char *) newDataset.mNetworkName.m8, netInfo.ThreadNetworkName, sizeof(newDataset.mNetworkName.m8) - 1);

Comment on lines +207 to +208
newDataset.mComponents.mIsActiveTimestampPresent = true;
newDataset.mComponents.mIsPendingTimestampPresent = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these necessary?

Suggested change
newDataset.mComponents.mIsActiveTimestampPresent = true;
newDataset.mComponents.mIsPendingTimestampPresent = true;
newDataset.mComponents.mIsActiveTimestampPresent = true;
newDataset.mComponents.mIsPendingTimestampPresent = true;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants