Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EFR32] Fix light-switch build error #16771

Merged

Conversation

mkardous-silabs
Copy link
Contributor

Problem

  • Typo slipped in causing building with shell to fail

Change overview

  • Fix typo

Testing

  • App can build with shell

@github-actions
Copy link

github-actions bot commented Mar 29, 2022

PR #16771: Size comparison from 8da5d03 to b1361ed

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 8da5d03 b1361ed change % change
cyw30739 light cyw930739m2evb_01 (read/write) 606194 606194 0 0.0
.app_xip_area 512964 512964 0 0.0
.bss 75976 75976 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563734 563734 0 0.0
.app_xip_area 472032 472032 0 0.0
.bss 74480 74480 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575994 575994 0 0.0
.app_xip_area 474644 474644 0 0.0
.bss 83808 83808 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 927264 927264 0 0.0
(read/write) 129112 129112 0 0.0
.bss 127112 127112 0 0.0
.data 1996 1996 0 0.0
.text 927256 927256 0 0.0
BRD4161A+rpc (read only) 956272 956272 0 0.0
(read/write) 145064 145064 0 0.0
.bss 142888 142888 0 0.0
.data 2176 2176 0 0.0
.text 956264 956264 0 0.0
window-app BRD4161A (read only) 856748 856748 0 0.0
(read/write) 127072 127072 0 0.0
.bss 125200 125200 0 0.0
.data 1872 1872 0 0.0
.text 856740 856740 0 0.0
esp32 all-clusters-app c3devkit (read only) 967810 967810 0 0.0
(read/write) 1394642 1394642 0 0.0
.dram0.bss 62416 62416 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 199112 199112 0 0.0
.flash.text 967810 967810 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1023499 1023499 0 0.0
(read/write) 462404 462404 0 0.0
.dram0.bss 67944 67944 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228600 228600 0 0.0
.flash.text 1018115 1018115 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 704784 704784 0 0.0
.bss 77968 77968 0 0.0
.data 1876 1876 0 0.0
.text 619140 619140 0 0.0
lock k32w061+release (read/write) 703900 703900 0 0.0
.bss 77944 77944 0 0.0
.data 1916 1916 0 0.0
.text 618240 618240 0 0.0
linux all-clusters-app debug (read only) 2533833 2533833 0 0.0
(read/write) 143352 143352 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78920 78920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216357 216357 0 0.0
.text 2153650 2153650 0 0.0
bridge-app debug+rpc (read only) 1767533 1767533 0 0.0
(read/write) 89520 89520 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144716 144716 0 0.0
.text 1507461 1507461 0 0.0
chip-tool debug (read only) 10228533 10228533 0 0.0
(read/write) 355656 355656 0 0.0
.bss 22464 22464 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 326008 326008 0 0.0
.dynamic 608 608 0 0.0
.got 4824 4824 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 519157 519157 0 0.0
.text 8924837 8924837 0 0.0
chip-tool-ipv6only arm64 (read only) 9849708 9849708 0 0.0
(read/write) 473713 473713 0 0.0
.bss 40737 40737 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372656 372656 0 0.0
.dynamic 560 560 0 0.0
.got 55368 55368 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 494484 494484 0 0.0
.text 8302004 8302004 0 0.0
door-lock-app debug (read only) 2020193 2020193 0 0.0
(read/write) 116896 116896 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181340 181340 0 0.0
.text 1689042 1689042 0 0.0
lighting-app debug+rpc (read only) 2196545 2196545 0 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175196 175196 0 0.0
.text 1862178 1862178 0 0.0
ota-provider-app debug (read only) 1960825 1960825 0 0.0
(read/write) 112688 112688 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58184 58184 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167147 167147 0 0.0
.text 1641810 1641810 0 0.0
ota-requestor-app debug (read only) 1987793 1987793 0 0.0
(read/write) 115912 115912 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163268 163268 0 0.0
.text 1671650 1671650 0 0.0
shell debug (read only) 2448601 2448601 0 0.0
(read/write) 147368 147368 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73568 73568 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209810 209810 0 0.0
.text 2081842 2081842 0 0.0
thermostat-no-ble arm64 (read only) 2278468 2278468 0 0.0
(read/write) 148305 148305 0 0.0
.bss 62817 62817 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 76928 76928 0 0.0
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139908 139908 0 0.0
.text 1915264 1915264 0 0.0
tv-app debug (read only) 2696209 2696209 0 0.0
(read/write) 247520 247520 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74048 74048 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206187 206187 0 0.0
.text 2315394 2315394 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2356076 2356076 0 0.0
.bss 185020 185020 0 0.0
.data 5760 5760 0 0.0
.text 1318676 1318676 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1144215 1144215 0 0.0
bss 143052 143052 0 0.0
rodata 142304 142304 0 0.0
text 784004 784004 0 0.0
p6 all-clusters-app default (read/write) 2499312 2499312 0 0.0
.bss 118440 118440 0 0.0
.data 2640 2640 0 0.0
.text 1457576 1457576 0 0.0
light-app default (read/write) 2401496 2401496 0 0.0
.bss 111912 111912 0 0.0
.data 2496 2496 0 0.0
.text 1359760 1359760 0 0.0
lock-app default (read/write) 2365112 2365112 0 0.0
.bss 111656 111656 0 0.0
.data 2456 2456 0 0.0
.text 1323376 1323376 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 788424 788424 0 0.0
bss 70268 70268 0 0.0
noinit 40416 40416 0 0.0
text 558792 558792 0 0.0

@bzbarsky-apple
Copy link
Contributor

Fast track: Build fix in platform-specific code.

@bzbarsky-apple bzbarsky-apple merged commit 8144ad9 into project-chip:master Mar 30, 2022
@mkardous-silabs mkardous-silabs deleted the fix/light-switch branch March 30, 2022 12:40
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Mar 31, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants