[examples] Enabled FeatureMap on all clusters for pump-app and pump-controller-app #16764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlykkeberg-grundfos
changed the title
|
PR #16764: Size comparison from d6fcbd9 to 7953fe7 Full report (16 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Damian-Nordic
approved these changes
Mar 29, 2022
bzbarsky-apple
approved these changes
Mar 30, 2022
tcarmelveilleux
approved these changes
Mar 31, 2022
|
/rebase |
pullapprove
bot
requested review from
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
gjc13,
hawk248,
harsha-rajendran,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
msandstedt,
saurabhst,
selissia,
tecimovic,
vijs,
wbschiller and
xylophone21
|
@tlykkeberg-grundfos could you update this? I tried to update this myself however I have no permissions to push to https://github.com/Grundfos/connectedhomeip.git/ apparently |
|
Likely this is the same reason that |
Yes, for sure :-) I was not aware of this. We will do it ASAP. I have just rebased it my self just now. And btw, can you direct us to where to find a list of these maintainers? I'm not that much into Github admin. Never mind, I found it. But how do you want these 4 maintainers to be added to have write access to our fork, without them being active "seat-positions" in our Github plan? Or peraps there is no way to do it without :-) @andy31415 can you please ellaborate a bit on these matters? |
|
PR #16764: Size comparison from 3034129 to 694aa73 Increases above 0.2%:
Increases (19 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (6 builds for cc13x2_26x2, k32w, nrfconnect)
Full report (19 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
Closes #16663 |
|
@andy31415 you have access to the branch now. So you can rebase etc. |
|
/rebase |
|
@tlykkeberg-grundfos @mgarb1 Automatic rebase failed due to merge conflicts, needs manual rebase. I tried doing that, but I can't push to [email protected]:Grundfos/connectedhomeip.git... |
|
PR #16764: Size comparison from 3992a17 to ab40496 Increases above 0.2%:
Increases (2 builds for cc13x2_26x2)
Decreases (2 builds for cc13x2_26x2)
Full report (28 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
/rebase |
bzbarsky-apple
force-pushed
the
bugfix/enabled-featuremap-on-all-clusters
branch
from
ab40496 to
9ad222d
Compare
|
PR #16764: Size comparison from 34f57f3 to 9ad222d Increases above 0.2%:
Increases (2 builds for cc13x2_26x2)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tlykkeberg-grundfos
deleted the
bugfix/enabled-featuremap-on-all-clusters
branch
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…ontroller-app (project-chip#16764) * * Updated the pump-app.zap and pump-controller-app.zap files to inlcude FeatureMap on all clusters * * Re-ran the zap_regen_app.py tool * * Re-ran the zap_regen_all.py tool * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The FeatureMap attribute is not enabled for some clusters in the .zap files for pump-app and pump-controller-app
Change overview
Enabled the FeatureMap attribute for all cluster in the .zap files
Testing
Re-generated all pump-app.zap and pump-controller-app.zap using zap_regen_all.py
Fixes
Fixes this issue: #16663