-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Notify-update-applied command and added ota initialization to common space #16762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248 and
holbrookt
March 29, 2022 12:36
jadhavrohit924
force-pushed
the
init-order
branch
from
April 1, 2022 11:17
3c85606
to
6add1f8
Compare
PR #16762: Size comparison from 2758435 to 6add1f8 Increases (5 builds for cc13x2_26x2, nrfconnect)
Decreases (4 builds for cc13x2_26x2, cyw30739, nrfconnect)
Full report (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
isiu-apple
reviewed
Apr 1, 2022
isiu-apple
reviewed
Apr 1, 2022
jadhavrohit924
force-pushed
the
init-order
branch
from
April 1, 2022 17:27
6add1f8
to
0faa13d
Compare
PR #16762: Size comparison from fe43ca2 to 0faa13d Increases (4 builds for cc13x2_26x2, nrfconnect)
Decreases (2 builds for cyw30739, nrfconnect)
Full report (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
/rebase |
jadhavrohit924
force-pushed
the
init-order
branch
2 times, most recently
from
April 20, 2022 12:24
900f2d0
to
02a478c
Compare
jadhavrohit924
changed the title
[ESP32] Notify-update-applied command and fixed initialization order
[ESP32] Notify-update-applied command and added ota initialization to common space
Apr 20, 2022
PR #16762: Size comparison from 66333a9 to 02a478c Full report (30 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
jadhavrohit924
force-pushed
the
init-order
branch
from
April 20, 2022 14:39
02a478c
to
6aaaeee
Compare
PR #16762: Size comparison from faf9ed4 to 6aaaeee Increases (2 builds for esp32)
Full report (32 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
carol-apple
reviewed
Apr 25, 2022
carol-apple
approved these changes
Apr 25, 2022
dhrishi
approved these changes
Apr 25, 2022
jadhavrohit924
force-pushed
the
init-order
branch
from
April 25, 2022 12:27
7ebb1f2
to
3c15be1
Compare
shubhamdp
approved these changes
Apr 25, 2022
PR #16762: Size comparison from 077e44e to 3c15be1 Increases (2 builds for esp32)
Full report (23 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Schedule notify-update-applied command.
Testing