[Tizen] Add Thread stack manager implementation #16749

ay-agarwal · 2022-03-29T06:09:26Z

Problem
Thread Stack Manager is not implemented for Tizen.

Change overview
Add Thread Stack Manager implementation and thread network commissioning driver for Tizen.

Testing
chip-tool and chip-lighting-app examples

CLAassistant · 2022-03-29T06:12:07Z

All committers have signed the CLA.

wootak-jung

Looks good to me.

github-actions · 2022-03-29T07:41:22Z

PR #16749: Size comparison from a19de20 to 6a48eac

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)

platform	target	config	section	`a19de20`	`6a48eac`
cyw30739	light	cyw930739m2evb_01	(read/write)	605498	605498
			.app_xip_area	512428	512428
			.bss	75816	75816
			.data	604	604
			.rodata	0	0
			.text	0	0
	lock	cyw930739m2evb_01	(read/write)	563286	563286
			.app_xip_area	471744	471744
			.bss	74320	74320
			.data	568	568
			.rodata	0	0
			.text	0	0
	ota-requestor-no-progress-logging	cyw930739m2evb_01	(read/write)	575546	575546
			.app_xip_area	474356	474356
			.bss	83648	83648
			.data	508	508
			.rodata	0	0
			.text	112	112
efr32	lighting-app	BRD4161A	(read only)	926664	926664
			(read/write)	128952	128952
			.bss	126952	126952
			.data	1996	1996
			.text	926656	926656
		BRD4161A+rpc	(read only)	955480	955480
			(read/write)	144904	144904
			.bss	142728	142728
			.data	2176	2176
			.text	955472	955472
	window-app	BRD4161A	(read only)	856052	856052
			(read/write)	126912	126912
			.bss	125040	125040
			.data	1872	1872
			.text	856044	856044
esp32	all-clusters-app	c3devkit	(read only)	966788	966788
			(read/write)	1394810	1394810
			.dram0.bss	62240	62240
			.dram0.data	14204	14204
			.flash.rodata	199456	199456
			.flash.text	966788	966788
			.iram0.text	62016	62016
		m5stack	(read only)	1023211	1023211
			(read/write)	462572	462572
			.dram0.bss	67768	67768
			.dram0.data	34024	34024
			.flash.rodata	228944	228944
			.flash.text	1017827	1017827
			.iram0.text	123107	123107
k32w	light	k32w061+release	(read/write)	704320	704320
			.bss	77808	77808
			.data	1876	1876
			.text	618836	618836
	lock	k32w061+release	(read/write)	703428	703428
			.bss	77784	77784
			.data	1916	1916
			.text	617928	617928
linux	all-clusters-app	debug	(read only)	2526169	2526169
			(read/write)	143352	143352
			.bss	57408	57408
			.data	1280	1280
			.data.rel.ro	78920	78920
			.dynamic	592	592
			.got	4184	4184
			.init	27	27
			.init_array	944	944
			.rodata	216549	216549
			.text	2145794	2145794
	bridge-app	debug+rpc	(read only)	1765389	1765389
			(read/write)	89520	89520
			.bss	44520	44520
			.data	1984	1984
			.data.rel.ro	37936	37936
			.dynamic	592	592
			.got	3928	3928
			.init	27	27
			.init_array	544	544
			.rodata	144684	144684
			.text	1505349	1505349
	chip-tool	debug	(read only)	10228469	10228469
			(read/write)	355656	355656
			.bss	22464	22464
			.data	1072	1072
			.data.rel.ro	326008	326008
			.dynamic	608	608
			.got	4824	4824
			.init	27	27
			.init_array	640	640
			.rodata	519125	519125
			.text	8924805	8924805
	chip-tool-ipv6only	arm64	(read only)	9849660	9849660
			(read/write)	473713	473713
			.bss	40737	40737
			.data	1144	1144
			.data.rel.ro	372656	372656
			.dynamic	560	560
			.got	55368	55368
			.init	24	24
			.init_array	192	192
			.rodata	494468	494468
			.text	8301972	8301972
	door-lock-app	debug	(read only)	`2017217`	`2017217`
			(read/write)	116896	116896
			.bss	47648	47648
			.data	992	992
			.data.rel.ro	62840	62840
			.dynamic	592	592
			.got	4128	4128
			.init	27	27
			.init_array	664	664
			.rodata	181276	181276
			.text	1686130	1686130
	lighting-app	debug+rpc	(read only)	2191665	2191665
			(read/write)	123888	123888
			.bss	48928	48928
			.data	1472	1472
			.data.rel.ro	67928	67928
			.dynamic	608	608
			.got	4176	4176
			.init	27	27
			.init_array	744	744
			.rodata	175356	175356
			.text	1857138	1857138
	ota-provider-app	debug	(read only)	1958057	1958057
			(read/write)	112688	112688
			.bss	47584	47584
			.data	1256	1256
			.data.rel.ro	58184	58184
			.dynamic	608	608
			.got	4384	4384
			.init	27	27
			.init_array	616	616
			.rodata	167115	167115
			.text	1639074	1639074
	ota-requestor-app	debug	(read only)	1985649	1985649
			(read/write)	115912	115912
			.bss	48512	48512
			.data	1480	1480
			.data.rel.ro	60440	60440
			.dynamic	592	592
			.got	4192	4192
			.init	27	27
			.init_array	640	640
			.rodata	163236	163236
			.text	1669538	1669538
	shell	debug	(read only)	2441801	2441801
			(read/write)	147368	147368
			.bss	67304	67304
			.data	800	800
			.data.rel.ro	73568	73568
			.dynamic	592	592
			.got	4160	4160
			.init	27	27
			.init_array	920	920
			.rodata	210034	210034
			.text	2074818	2074818
	thermostat-no-ble	arm64	(read only)	2275348	2275348
			(read/write)	148369	148369
			.bss	62817	62817
			.data	1040	1040
			.data.rel.ro	77000	77000
			.dynamic	560	560
			.got	4504	4504
			.init	24	24
			.init_array	360	360
			.rodata	140036	140036
			.text	`1911952`	`1911952`
	tv-app	debug	(read only)	`2691473`	`2691473`
			(read/write)	247520	247520
			.bss	164288	164288
			.data	3136	3136
			.data.rel.ro	74048	74048
			.dynamic	592	592
			.got	4552	4552
			.init	27	27
			.init_array	888	888
			.rodata	206059	206059
			.text	2310786	2310786
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2355708	2355708
			.bss	184860	184860
			.data	5760	5760
			.text	1318308	1318308
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1143459	1143459
			bss	142892	142892
			rodata	142364	142364
			text	783316	783316
p6	all-clusters-app	default	(read/write)	`2498448`	`2498448`
			.bss	118280	118280
			.data	2640	2640
			.text	`1456712`	`1456712`
	light-app	default	(read/write)	2400896	2400896
			.bss	111752	111752
			.data	2496	2496
			.text	1359160	1359160
	lock-app	default	(read/write)	`2364400`	`2364400`
			.bss	111496	111496
			.data	2456	2456
			.text	1322664	1322664
telink	lighting-app	tlsr9518adk80d	(read/write)	787556	787556
			bss	70092	70092
			noinit	40416	40416
			text	557952	557952

woody-apple

Fast tracking platform changes.

hyunuktak

Looks good to me.

woody-apple · 2022-04-05T00:54:56Z

/rebase

github-actions · 2022-04-05T03:16:02Z

PR #16749: Size comparison from 913aca0 to a7ccdf0

Full report (19 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)

platform	target	config	section	`913aca0`	`a7ccdf0`
cc13x2_26x2	lock-ftd	LP_CC2652R7	(read only)	670511	670511
			(read/write)	181200	181200
			.bss	81752	81752
			.data	3164	3164
			.rodata	79975	79975
			.text	590056	590056
	lock-mtd	LP_CC2652R7	(read only)	619639	619639
			(read/write)	154500	154500
			.bss	77480	77480
			.data	3164	3164
			.rodata	79863	79863
			.text	539288	539288
	pump-app	LP_CC2652R7	(read only)	689983	689983
			(read/write)	162896	162896
			.bss	82152	82152
			.data	3196	3196
			.rodata	82063	82063
			.text	607436	607436
	pump-controller-app	LP_CC2652R7	(read only)	672207	672207
			(read/write)	180408	180408
			.bss	81888	81888
			.data	3160	3160
			.rodata	78399	78399
			.text	593324	593324
efr32	lighting-app	BRD4161A	(read only)	919164	919164
			(read/write)	129784	129784
			.bss	127792	127792
			.data	1992	1992
			.text	919156	919156
		BRD4161A+rpc	(read only)	947060	947060
			(read/write)	145732	145732
			.bss	143560	143560
			.data	2172	2172
			.text	947052	947052
	window-app	BRD4161A	(read only)	854380	854380
			(read/write)	127808	127808
			.bss	125936	125936
			.data	1872	1872
			.text	854372	854372
esp32	all-clusters-app	c3devkit	(read only)	988094	988094
			(read/write)	1460842	1460842
			.dram0.bss	62944	62944
			.dram0.data	14196	14196
			.flash.rodata	198224	198224
			.flash.text	988094	988094
			.iram0.text	62572	62572
		m5stack	(read only)	1040455	1040455
			(read/write)	461840	461840
			.dram0.bss	68472	68472
			.dram0.data	34056	34056
			.flash.rodata	227168	227168
			.flash.text	1035071	1035071
			.iram0.text	123415	123415
k32w	light	k32w061+release	(read/write)	710388	710388
			.bss	77952	77952
			.data	1904	1904
			.text	624732	624732
	lock	k32w061+release	(read/write)	709784	709784
			.bss	77952	77952
			.data	1944	1944
			.text	624088	624088
linux	chip-tool-no-interactive-ipv6only	arm64	(read only)	10083572	10083572
			(read/write)	486977	486977
			.bss	40337	40337
			.data	1128	1128
			.data.rel.ro	384712	384712
			.dynamic	560	560
			.got	57008	57008
			.init	24	24
			.init_array	184	184
			.rodata	508404	508404
			.text	8484324	8484324
	thermostat-no-ble	arm64	(read only)	2324428	2324428
			(read/write)	149441	149441
			.bss	62945	62945
			.data	1136	1136
			.data.rel.ro	77704	77704
			.dynamic	560	560
			.got	4632	4632
			.init	24	24
			.init_array	368	368
			.rodata	143308	143308
			.text	1955408	1955408
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224
			(read/write)	2362700	2362700
			.bss	185036	185036
			.data	5784	5784
			.text	1325300	1325300
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1151231	1151231
			bss	143060	143060
			rodata	143592	143592
			text	789708	789708
p6	all-clusters-app	default	(read/write)	2507528	2507528
			.bss	118472	118472
			.data	2672	2672
			.text	1465792	1465792
	light-app	default	(read/write)	2408704	2408704
			.bss	111928	111928
			.data	2528	2528
			.text	1366968	1366968
	lock-app	default	(read/write)	2372352	2372352
			.bss	111672	111672
			.data	2488	2488
			.text	`1330616`	`1330616`
telink	lighting-app	tlsr9518adk80d	(read/write)	794808	794808
			bss	70288	70288
			noinit	40416	40416
			text	564354	564354

dh79pyun · 2022-04-05T03:19:07Z

We will raise the additional PR to add a command to download Tizen thread stack in Tizen docker file.
After applying Tizen docker's change, the fail issue will be resolved.
https://github.com/project-chip/connectedhomeip/runs/5826718468?check_suite_focus=true

Problem Thread Stack Manager is not implemented for Tizen. Change overview Add Tizen Stack Manager implementation for Tizen. Co-authored-by: Anupam Roy <[email protected]> Co-authored-by: hyunuktak <[email protected]> Signed-off-by: Abhay Agarwal <[email protected]>

Signed-off-by: Abhay Agarwal <[email protected]>

ay-agarwal · 2022-04-05T05:31:03Z

Refer the PR for tizen docker modifications
#17041

stale · 2022-04-12T19:57:47Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

dh79pyun · 2022-04-13T22:26:05Z

@woody-apple
Can we re-trigger the workflows?

MoonkiHong · 2022-04-18T07:01:53Z

@hrajendran-samsung @electrocucaracha Please take a look at the request above

dh79pyun · 2022-04-24T23:21:53Z

When I see the fail log no build fail, the test works with the previous tizen-docker. 0.5.58

https://github.com/project-chip/connectedhomeip/runs/6119450320?check_suite_focus=true

Digest: sha256:a8d0e5007519adf36d5d15b0f46f73a9cc8d7aae865d261ca854088bb9ad3aee
Status: Downloaded newer image for connectedhomeip/chip-build-tizen:0.5.58
docker.io/connectedhomeip/chip-build-tizen:0.5.58
/usr/bin/docker create --name cdbdfe4ef69e43d198e9786302cac2a7_connectedhomeipchipbuildtizen0558_b63be3 --label 294b31 --workdir /__w/connectedhomeip/connectedhomeip --network github_network_615c3f187f6b4ef1b62d451a4cb1c41a --user root -e "HOME=/github/home" -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/tmp/bloat_reports":"/tmp/bloat_reports" -v "/tmp/output_binaries":"/tmp/output_binaries" -v "/home/runner/work":"/__w" -v "/home/runner/runners/2.290.1/externals":"/__e":ro -v "/home/runner/work/_temp":"/__w/_temp" -v "/home/runner/work/_actions":"/__w/_actions" -v "/opt/hostedtoolcache":"/__t" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" --entrypoint "tail" connectedhomeip/chip-build-tizen:0.5.58 "-f" "/dev/null"

We applied Tizen docker change into 0.5.61 version.

https://github.com/project-chip/connectedhomeip/pull/17041/files

So need to run the testing using the latest docker.

dh79pyun · 2022-04-24T23:26:54Z

When I see the fail log no build fail, the test works with the previous tizen-docker. 0.5.58

https://github.com/project-chip/connectedhomeip/runs/6119450320?check_suite_focus=true

Digest: sha256:a8d0e5007519adf36d5d15b0f46f73a9cc8d7aae865d261ca854088bb9ad3aee Status: Downloaded newer image for connectedhomeip/chip-build-tizen:0.5.58 docker.io/connectedhomeip/chip-build-tizen:0.5.58 /usr/bin/docker create --name cdbdfe4ef69e43d198e9786302cac2a7_connectedhomeipchipbuildtizen0558_b63be3 --label 294b31 --workdir /__w/connectedhomeip/connectedhomeip --network github_network_615c3f187f6b4ef1b62d451a4cb1c41a --user root -e "HOME=/github/home" -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/tmp/bloat_reports":"/tmp/bloat_reports" -v "/tmp/output_binaries":"/tmp/output_binaries" -v "/home/runner/work":"/__w" -v "/home/runner/runners/2.290.1/externals":"/__e":ro -v "/home/runner/work/_temp":"/__w/_temp" -v "/home/runner/work/_actions":"/__w/_actions" -v "/opt/hostedtoolcache":"/__t" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" --entrypoint "tail" connectedhomeip/chip-build-tizen:0.5.58 "-f" "/dev/null"

We applied Tizen docker change into 0.5.61 version.

https://github.com/project-chip/connectedhomeip/pull/17041/files

So need to run the testing using the latest docker.

If I see the latest PR, it works on the latest tizen docker.

#17675
https://github.com/project-chip/connectedhomeip/runs/6145754553?check_suite_focus=true

Status: Downloaded newer image for connectedhomeip/chip-build-tizen:0.5.64
docker.io/connectedhomeip/chip-build-tizen:0.5.64

So can you re-trriger the work flow? Then the fail issue will be resolved

dh79pyun · 2022-04-25T23:59:25Z

When I see the fail log no build fail, the test works with the previous tizen-docker. 0.5.58
https://github.com/project-chip/connectedhomeip/runs/6119450320?check_suite_focus=true
Digest: sha256:a8d0e5007519adf36d5d15b0f46f73a9cc8d7aae865d261ca854088bb9ad3aee Status: Downloaded newer image for connectedhomeip/chip-build-tizen:0.5.58 docker.io/connectedhomeip/chip-build-tizen:0.5.58 /usr/bin/docker create --name cdbdfe4ef69e43d198e9786302cac2a7_connectedhomeipchipbuildtizen0558_b63be3 --label 294b31 --workdir /__w/connectedhomeip/connectedhomeip --network github_network_615c3f187f6b4ef1b62d451a4cb1c41a --user root -e "HOME=/github/home" -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/tmp/bloat_reports":"/tmp/bloat_reports" -v "/tmp/output_binaries":"/tmp/output_binaries" -v "/home/runner/work":"/__w" -v "/home/runner/runners/2.290.1/externals":"/__e":ro -v "/home/runner/work/_temp":"/__w/_temp" -v "/home/runner/work/_actions":"/__w/_actions" -v "/opt/hostedtoolcache":"/__t" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" --entrypoint "tail" connectedhomeip/chip-build-tizen:0.5.58 "-f" "/dev/null"
We applied Tizen docker change into 0.5.61 version.
https://github.com/project-chip/connectedhomeip/pull/17041/files
So need to run the testing using the latest docker.

If I see the latest PR, it works on the latest tizen docker.

#17675 https://github.com/project-chip/connectedhomeip/runs/6145754553?check_suite_focus=true

Status: Downloaded newer image for connectedhomeip/chip-build-tizen:0.5.64 docker.io/connectedhomeip/chip-build-tizen:0.5.64

So can you re-trriger the work flow? Then the fail issue will be resolved

The same change is success to build on next PR.
#16749

Maybe some env issue in the current PR.

stale · 2022-05-04T22:35:21Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

ay-agarwal · 2022-05-05T05:44:26Z

Closing this PR since, same changes get merged via
#17677

boring-cyborg bot added config platform labels Mar 29, 2022

wootak-jung approved these changes Mar 29, 2022

View reviewed changes

ay-agarwal force-pushed the abhay-dev branch from 6a48eac to 3f1e01c Compare March 29, 2022 10:42

boring-cyborg bot added the integrations label Mar 29, 2022

woody-apple approved these changes Apr 1, 2022

View reviewed changes

woody-apple added the fast track label Apr 1, 2022

hyunuktak approved these changes Apr 4, 2022

View reviewed changes

woody-apple force-pushed the abhay-dev branch from 3f1e01c to a7ccdf0 Compare April 5, 2022 01:59

msandstedt approved these changes Apr 5, 2022

View reviewed changes

ay-agarwal and others added 3 commits April 5, 2022 10:57

[Tizen] Add thread network commissioning driver

42a0745

Signed-off-by: Abhay Agarwal <[email protected]>

[Tizen] Enable Thread support for tizen

7af277f

Signed-off-by: Abhay Agarwal <[email protected]>

ay-agarwal force-pushed the abhay-dev branch from a7ccdf0 to 7af277f Compare April 5, 2022 05:29

stale bot added the stale Stale issue or PR label Apr 12, 2022

stale bot removed the stale Stale issue or PR label Apr 13, 2022

ay-agarwal mentioned this pull request Apr 25, 2022

[Tizen] Add Thread stack manager implementation #17677

Merged

stale bot added the stale Stale issue or PR label May 4, 2022

ay-agarwal closed this May 5, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tizen] Add Thread stack manager implementation #16749

[Tizen] Add Thread stack manager implementation #16749

ay-agarwal commented Mar 29, 2022

CLAassistant commented Mar 29, 2022 •

edited

Loading

wootak-jung left a comment

github-actions bot commented Mar 29, 2022 •

edited

Loading

woody-apple left a comment

hyunuktak left a comment

woody-apple commented Apr 5, 2022

github-actions bot commented Apr 5, 2022 •

edited

Loading

dh79pyun commented Apr 5, 2022

ay-agarwal commented Apr 5, 2022

stale bot commented Apr 12, 2022

dh79pyun commented Apr 13, 2022 •

edited

Loading

MoonkiHong commented Apr 18, 2022 •

edited

Loading

dh79pyun commented Apr 24, 2022

dh79pyun commented Apr 24, 2022

dh79pyun commented Apr 25, 2022

stale bot commented May 4, 2022

ay-agarwal commented May 5, 2022

[Tizen] Add Thread stack manager implementation #16749

[Tizen] Add Thread stack manager implementation #16749

Conversation

ay-agarwal commented Mar 29, 2022

CLAassistant commented Mar 29, 2022 • edited Loading

wootak-jung left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 29, 2022 • edited Loading

woody-apple left a comment

Choose a reason for hiding this comment

hyunuktak left a comment

Choose a reason for hiding this comment

woody-apple commented Apr 5, 2022

github-actions bot commented Apr 5, 2022 • edited Loading

dh79pyun commented Apr 5, 2022

ay-agarwal commented Apr 5, 2022

stale bot commented Apr 12, 2022

dh79pyun commented Apr 13, 2022 • edited Loading

MoonkiHong commented Apr 18, 2022 • edited Loading

dh79pyun commented Apr 24, 2022

dh79pyun commented Apr 24, 2022

dh79pyun commented Apr 25, 2022

stale bot commented May 4, 2022

ay-agarwal commented May 5, 2022

CLAassistant commented Mar 29, 2022 •

edited

Loading

github-actions bot commented Mar 29, 2022 •

edited

Loading

github-actions bot commented Apr 5, 2022 •

edited

Loading

dh79pyun commented Apr 13, 2022 •

edited

Loading

MoonkiHong commented Apr 18, 2022 •

edited

Loading