-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sanity-checking that CI explicitly defines values for all PICS items #16739
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:add-pics-sanity-check
Mar 29, 2022
Merged
Add sanity-checking that CI explicitly defines values for all PICS items #16739
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:add-pics-sanity-check
Mar 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda and
mlepage-google
March 28, 2022 20:39
pullapprove
bot
requested review from
LuDuda,
yunhanw-google,
mlepage-google,
msandstedt,
mspang,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
March 28, 2022 20:39
krypton36
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you!
…ems. Otherwise we could have items silently defaulting to false. Fixes project-chip#16735
bzbarsky-apple
force-pushed
the
add-pics-sanity-check
branch
from
March 28, 2022 20:45
eaaa54a
to
0e688c6
Compare
PR #16739: Size comparison from 7c69523 to 0e688c6 Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
saurabhst
approved these changes
Mar 29, 2022
jmartinez-silabs
approved these changes
Mar 29, 2022
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Mar 31, 2022
…ems. (project-chip#16739) Otherwise we could have items silently defaulting to false. Fixes project-chip#16735
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…ems. (project-chip#16739) Otherwise we could have items silently defaulting to false. Fixes project-chip#16735
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we could have items silently defaulting to false.
Fixes #16735
Problem
See #16735
Change overview
Add a lint that checks that we are defining values for CI for all the PICS items.
Testing
Tried adding a new PICS item without adding it to the CI file and the lint failed.