-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Allow setting the KeepSubscriptions flag #16706
Merged
vivien-apple
merged 2 commits into
project-chip:master
from
vivien-apple:ChipTool_KeepSubscriptions
Apr 1, 2022
Merged
[chip-tool] Allow setting the KeepSubscriptions flag #16706
vivien-apple
merged 2 commits into
project-chip:master
from
vivien-apple:ChipTool_KeepSubscriptions
Apr 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248 and
holbrookt
March 28, 2022 08:34
pullapprove
bot
requested review from
tecimovic,
wbschiller,
vijs,
woody-apple,
xylophone21 and
yunhanw-google
March 28, 2022 08:34
PR #16706: Size comparison from 58cd5fb to cda3fa9 Full report (16 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
|
arkq
approved these changes
Mar 28, 2022
arkq
requested changes
Mar 28, 2022
vivien-apple
force-pushed
the
ChipTool_KeepSubscriptions
branch
from
March 28, 2022 12:54
cda3fa9
to
1d77655
Compare
arkq
approved these changes
Mar 28, 2022
PR #16706: Size comparison from 125e73c to 1d77655 Increases (2 builds for linux)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Mar 29, 2022
vivien-apple
force-pushed
the
ChipTool_KeepSubscriptions
branch
from
March 30, 2022 15:14
1d77655
to
797ada7
Compare
PR #16706: Size comparison from 11ab5a3 to 797ada7 Increases (1 build for linux)
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fast tracking, given this has had enough time for review (> 3 days)
PR #16706: Size comparison from 5aa8737 to c0ac4d1 Increases (2 builds for linux)
Full report (31 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
chip-tool
can not set theKeepSubscriptions
flag.fix #15845
Change overview
chip-tool
support for setting theKeepSubscriptions
flag.Testing
I have checked the logs to make sure the flag is set appropriately.