-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chip-tool] Add commands to generate/update onboarding payloads #16704
Merged
woody-apple
merged 2 commits into
project-chip:master
from
vivien-apple:ChipTool_GeneratePayload
Mar 30, 2022
Merged
[chip-tool] Add commands to generate/update onboarding payloads #16704
woody-apple
merged 2 commits into
project-chip:master
from
vivien-apple:ChipTool_GeneratePayload
Mar 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost and
kpschoedel
March 28, 2022 08:08
pullapprove
bot
requested review from
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux and
tecimovic
March 28, 2022 08:08
pullapprove
bot
requested review from
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
March 28, 2022 08:08
vivien-apple
changed the title
Chip tool generate payload
[chip-tool] Add commands to generate/update onboarding payloads
Mar 28, 2022
PR #16704: Size comparison from 58cd5fb to 398eea4 Increases (14 builds for cyw30739, efr32, k32w, linux, nrfconnect, p6, telink)
Full report (16 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
/rebase |
woody-apple
force-pushed
the
ChipTool_GeneratePayload
branch
from
March 28, 2022 14:02
398eea4
to
508d49b
Compare
PR #16704: Size comparison from 125e73c to 508d49b Increases above 0.2%:
Increases (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Mar 29, 2022
… QRCodeSetupPayloadGenerator and ManualSetupPayloadGenerator
…o generate/update a manual code
vivien-apple
force-pushed
the
ChipTool_GeneratePayload
branch
from
March 30, 2022 07:56
508d49b
to
d0e4558
Compare
PR #16704: Size comparison from 08906fb to d0e4558 Increases above 0.2%:
Increases (26 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Mar 30, 2022
Fast tracking tooling updates. |
danielsilabs
pushed a commit
to danielsilabs/connectedhomeip
that referenced
this pull request
Mar 31, 2022
…ect-chip#16704) * [Payload] Add SetAllowInvalidPayload and SetForceShortCode methods to QRCodeSetupPayloadGenerator and ManualSetupPayloadGenerator * [chip-tool] Add a command to generate/update a qrcode and a command to generate/update a manual code
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Mar 31, 2022
…ect-chip#16704) * [Payload] Add SetAllowInvalidPayload and SetForceShortCode methods to QRCodeSetupPayloadGenerator and ManualSetupPayloadGenerator * [chip-tool] Add a command to generate/update a qrcode and a command to generate/update a manual code
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…ect-chip#16704) * [Payload] Add SetAllowInvalidPayload and SetForceShortCode methods to QRCodeSetupPayloadGenerator and ManualSetupPayloadGenerator * [chip-tool] Add a command to generate/update a qrcode and a command to generate/update a manual code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
chip-tool
is not able to generate onboarding payloads. Furthermore there is no way to generate invalid payloads using the current APIs.Partially fix #16385
Change overview
Add a command to
chip-tool
to generate/update a qr codeAdd a command to
chip-tool
to generate/update a manual code*Update the APIs provided by
ManualSetupPayloadGenerator
andQRCodeSetupPayloadGenerator
to allow for creating invalid payloads.Testing
It was tested locally and it will be used to generate payloads for TC-DD-3.12/13