Add possibility to build Tizen apps with various options #16701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkq
changed the title
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
|
PR #16701: Size comparison from 58cd5fb to 8b3404f Full report (13 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #16701: Size comparison from 58cd5fb to a718424 Full report (13 builds for cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #16701: Size comparison from 467c696 to ed2e5f9 Full report (16 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #16701: Size comparison from a19de20 to 471a870 Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
How about split this PR for the changes of flake8? I think that is not for only Tizen. |
woody-apple
approved these changes
Apr 1, 2022
|
PR #16701: Size comparison from 41a431d to 2a1e2a2 Full report (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
This change adds a possibility to build Tizen applications with e.g. ASAN sanitizer enabled. Please note, that with current Tizen SDK there is no TSAN library (TSAN for ARMv7) provided, so it's not possible to enable this sanitizer.
|
PR #16701: Size comparison from 41a431d to 72c76f4 Full report (22 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
/rebase |
|
PR #16701: Size comparison from 913aca0 to d37b083 Full report (19 builds for cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
Apr 5, 2022
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
…p#16701) * [build] Fix warnings reported by flake8 checker * [build] Allow to build Tizen apps with variants This change adds a possibility to build Tizen applications with e.g. ASAN sanitizer enabled. Please note, that with current Tizen SDK there is no TSAN library (TSAN for ARMv7) provided, so it's not possible to enable this sanitizer. * Restyled by autopep8 Co-authored-by: Justin Wood <[email protected]> Co-authored-by: Restyled.io <[email protected]>
chencheung
pushed a commit
to chencheung/connectedhomeip
that referenced
this pull request
Apr 6, 2022
…p#16701) * [build] Fix warnings reported by flake8 checker * [build] Allow to build Tizen apps with variants This change adds a possibility to build Tizen applications with e.g. ASAN sanitizer enabled. Please note, that with current Tizen SDK there is no TSAN library (TSAN for ARMv7) provided, so it's not possible to enable this sanitizer. * Restyled by autopep8 Co-authored-by: Justin Wood <[email protected]> Co-authored-by: Restyled.io <[email protected]>
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…p#16701) * [build] Fix warnings reported by flake8 checker * [build] Allow to build Tizen apps with variants This change adds a possibility to build Tizen applications with e.g. ASAN sanitizer enabled. Please note, that with current Tizen SDK there is no TSAN library (TSAN for ARMv7) provided, so it's not possible to enable this sanitizer. * Restyled by autopep8 Co-authored-by: Justin Wood <[email protected]> Co-authored-by: Restyled.io <[email protected]>
andy31415
reviewed
May 10, 2022
| @@ -0,0 +1,2 @@ | |||
| [flake8] | |||
| max-line-length = 132 | |||
There was a problem hiding this comment.
we use autopep8. Are they not conflicting?
I see a lot of changes of style in this PR that are unlikely to be maintained as others just use restyle-diff (i.e. autopep8).
In hindsight, restyle changes should have been separated from code changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Possibility to build Tizen applications with sanitizers like ASAN, UBSAN, etc. Build Tizen apps with no WiFi and/or BT enabled.
Change overview
Testing
Building Tizen app locally with e.g.
./scripts/build/build_examples.py --target tizen-arm-light-asan build.