Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupKeyManagement server: Added validation against groupKeySetID == 0. #16683

Conversation

rcasallas-silabs
Copy link
Contributor

Problem

Change overview

Added missing validation on WriteGroupKeyMap

Testing

  • Project built successfully
  • Group, and GroupKeyManagement tests ran successfully

@github-actions
Copy link

github-actions bot commented Mar 25, 2022

PR #16683: Size comparison from c14faeb to 2602f04

Increases (14 builds for cyw30739, efr32, linux, nrfconnect, p6, telink)
platform target config section c14faeb 2602f04 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604466 604482 16 0.0
.app_xip_area 511636 511652 16 0.0
efr32 lighting-app BRD4161A (read only) 925416 925432 16 0.0
.text 925408 925424 16 0.0
BRD4161A+rpc (read only) 954240 954256 16 0.0
.text 954232 954248 16 0.0
linux all-clusters-app debug (read only) 2487249 2487361 112 0.0
.text 2111442 2111554 112 0.0
chip-tool debug (read only) 1017902 10180261 1232 0.0
.rodata 518517 518613 96 0.0
.text 8876101 8877237 1136 0.0
chip-tool-ipv6only arm64 (read only) 9809852 9810908 1056 0.0
(read/write) 473729 473745 16 0.0
.got 55352 55368 16 0.0
.rodata 493908 494004 96 0.0
.text 8262772 8263684 912 0.0
lighting-app debug+rpc (read only) 2185441 2185537 96 0.0
.text 1851490 1851586 96 0.0
shell debug (read only) 2436057 2436153 96 0.0
.text 2069618 2069714 96 0.0
thermostat-no-ble arm64 (read only) 2268996 2269108 112 0.0
.text 1905984 1906096 112 0.0
tv-app debug (read only) 2682465 2682561 96 0.0
.text 2302258 2302354 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1140887 1140903 16 0.0
text 781500 781520 20 0.0
p6 all-clusters-app default (read/write) 2496624 2496640 16 0.0
.text 1454888 1454904 16 0.0
light-app default (read/write) 2399016 2399048 32 0.0
.text 1357280 1357312 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 897458 897474 16 0.0
text 634878 634894 16 0.0
Full report (25 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c14faeb 2602f04 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604466 604482 16 0.0
.app_xip_area 511636 511652 16 0.0
.bss 75576 75576 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 562270 562270 0 0.0
.app_xip_area 470968 470968 0 0.0
.bss 74080 74080 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574626 574626 0 0.0
.app_xip_area 473676 473676 0 0.0
.bss 83408 83408 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 925416 925432 16 0.0
(read/write) 128688 128688 0 0.0
.bss 126688 126688 0 0.0
.data 1996 1996 0 0.0
.text 925408 925424 16 0.0
BRD4161A+rpc (read only) 954240 954256 16 0.0
(read/write) 144640 144640 0 0.0
.bss 142464 142464 0 0.0
.data 2176 2176 0 0.0
.text 954232 954248 16 0.0
window-app BRD4161A (read only) 854828 854828 0 0.0
(read/write) 126648 126648 0 0.0
.bss 124776 124776 0 0.0
.data 1872 1872 0 0.0
.text 854820 854820 0 0.0
k32w light k32w061+release (read/write) 702984 702984 0 0.0
.bss 77568 77568 0 0.0
.data 1876 1876 0 0.0
.text 617740 617740 0 0.0
lock k32w061+release (read/write) 702084 702084 0 0.0
.bss 77544 77544 0 0.0
.data 1916 1916 0 0.0
.text 616824 616824 0 0.0
linux all-clusters-app debug (read only) 2487249 2487361 112 0.0
(read/write) 143344 143344 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78920 78920 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 212133 212133 0 0.0
.text 2111442 2111554 112 0.0
bridge-app debug+rpc (read only) 1759653 1759653 0 0.0
(read/write) 89552 89552 0 0.0
.bss 44552 44552 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144268 144268 0 0.0
.text 1500149 1500149 0 0.0
chip-tool debug (read only) 1017902 10180261 1232 0.0
(read/write) 355688 355688 0 0.0
.bss 22496 22496 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 326008 326008 0 0.0
.dynamic 608 608 0 0.0
.got 4816 4816 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 518517 518613 96 0.0
.text 8876101 8877237 1136 0.0
chip-tool-ipv6only arm64 (read only) 9809852 9810908 1056 0.0
(read/write) 473729 473745 16 0.0
.bss 40769 40769 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372656 372656 0 0.0
.dynamic 560 560 0 0.0
.got 55352 55368 16 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493908 494004 96 0.0
.text 8262772 8263684 912 0.0
door-lock-app debug (read only) 2011633 2011633 0 0.0
(read/write) 116896 116896 0 0.0
.bss 47680 47680 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 180924 180924 0 0.0
.text 1681026 1681026 0 0.0
lighting-app debug+rpc (read only) 2185441 2185537 96 0.0
(read/write) 123888 123888 0 0.0
.bss 48960 48960 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 174908 174908 0 0.0
.text 1851490 1851586 96 0.0
ota-provider-app debug (read only) 1952841 1952841 0 0.0
(read/write) 112688 112688 0 0.0
.bss 47616 47616 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58184 58184 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166667 166667 0 0.0
.text 1634434 1634434 0 0.0
ota-requestor-app debug (read only) 1980417 1980417 0 0.0
(read/write) 115912 115912 0 0.0
.bss 48544 48544 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162788 162788 0 0.0
.text 1664882 1664882 0 0.0
shell debug (read only) 2436057 2436153 96 0.0
(read/write) 147400 147400 0 0.0
.bss 67336 67336 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73568 73568 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209618 209618 0 0.0
.text 2069618 2069714 96 0.0
thermostat-no-ble arm64 (read only) 2268996 2269108 112 0.0
(read/write) 148385 148385 0 0.0
.bss 62833 62833 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139652 139652 0 0.0
.text 1905984 1906096 112 0.0
tv-app debug (read only) 2682465 2682561 96 0.0
(read/write) 247552 247552 0 0.0
.bss 164320 164320 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74048 74048 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 205579 205579 0 0.0
.text 2302258 2302354 96 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2354708 2354708 0 0.0
.bss 184572 184572 0 0.0
.data 5760 5760 0 0.0
.text 1317308 1317308 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1140887 1140903 16 0.0
bss 142500 142500 0 0.0
rodata 142016 142016 0 0.0
text 781500 781520 20 0.0
p6 all-clusters-app default (read/write) 2496624 2496640 16 0.0
.bss 117992 117992 0 0.0
.data 2640 2640 0 0.0
.text 1454888 1454904 16 0.0
light-app default (read/write) 2399016 2399048 32 0.0
.bss 111464 111464 0 0.0
.data 2496 2496 0 0.0
.text 1357280 1357312 32 0.0
lock-app default (read/write) 2362552 2362552 0 0.0
.bss 111208 111208 0 0.0
.data 2456 2456 0 0.0
.text 1320816 1320816 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 897458 897474 16 0.0
bss 87356 87356 0 0.0
noinit 37160 37160 0 0.0
text 634878 634894 16 0.0

@rcasallas-silabs rcasallas-silabs force-pushed the group_key_management-keysetid_validation branch 2 times, most recently from 027eff3 to 23f04a0 Compare March 25, 2022 19:12
@github-actions
Copy link

github-actions bot commented Mar 25, 2022

PR #16683: Size comparison from c14faeb to 23f04a0

Increases (16 builds for cyw30739, efr32, esp32, linux, nrfconnect, p6, telink)
platform target config section c14faeb 23f04a0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604466 604482 16 0.0
.app_xip_area 511636 511652 16 0.0
efr32 lighting-app BRD4161A (read only) 925416 925432 16 0.0
.text 925408 925424 16 0.0
BRD4161A+rpc (read only) 954240 954256 16 0.0
.text 954232 954248 16 0.0
esp32 all-clusters-app c3devkit (read only) 965550 965572 22 0.0
.flash.text 965550 965572 22 0.0
m5stack (read only) 1022039 1022063 24 0.0
.flash.text 1016655 1016679 24 0.0
linux all-clusters-app debug (read only) 2487249 2487361 112 0.0
.text 2111442 2111554 112 0.0
chip-tool debug (read only) 1017902 10180261 1232 0.0
.rodata 518517 518613 96 0.0
.text 8876101 8877237 1136 0.0
chip-tool-ipv6only arm64 (read only) 9809852 9810908 1056 0.0
(read/write) 473729 473745 16 0.0
.got 55352 55368 16 0.0
.rodata 493908 494004 96 0.0
.text 8262772 8263684 912 0.0
lighting-app debug+rpc (read only) 2185441 2185537 96 0.0
.text 1851490 1851586 96 0.0
shell debug (read only) 2436057 2436153 96 0.0
.text 2069618 2069714 96 0.0
thermostat-no-ble arm64 (read only) 2268996 2269108 112 0.0
.text 1905984 1906096 112 0.0
tv-app debug (read only) 2682465 2682561 96 0.0
.text 2302258 2302354 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1140887 1140903 16 0.0
text 781500 781520 20 0.0
p6 all-clusters-app default (read/write) 2496624 2496640 16 0.0
.text 1454888 1454904 16 0.0
light-app default (read/write) 2399016 2399048 32 0.0
.text 1357280 1357312 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 897458 897474 16 0.0
text 634878 634894 16 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section c14faeb 23f04a0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604466 604482 16 0.0
.app_xip_area 511636 511652 16 0.0
.bss 75576 75576 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 562270 562270 0 0.0
.app_xip_area 470968 470968 0 0.0
.bss 74080 74080 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574626 574626 0 0.0
.app_xip_area 473676 473676 0 0.0
.bss 83408 83408 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 925416 925432 16 0.0
(read/write) 128688 128688 0 0.0
.bss 126688 126688 0 0.0
.data 1996 1996 0 0.0
.text 925408 925424 16 0.0
BRD4161A+rpc (read only) 954240 954256 16 0.0
(read/write) 144640 144640 0 0.0
.bss 142464 142464 0 0.0
.data 2176 2176 0 0.0
.text 954232 954248 16 0.0
window-app BRD4161A (read only) 854828 854828 0 0.0
(read/write) 126648 126648 0 0.0
.bss 124776 124776 0 0.0
.data 1872 1872 0 0.0
.text 854820 854820 0 0.0
esp32 all-clusters-app c3devkit (read only) 965550 965572 22 0.0
(read/write) 1394138 1394138 0 0.0
.dram0.bss 61992 61992 0 0.0
.dram0.data 14212 14212 0 0.0
.flash.rodata 199008 199008 0 0.0
.flash.text 965550 965572 22 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1022039 1022063 24 0.0
(read/write) 461884 461884 0 0.0
.dram0.bss 67520 67520 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228504 228504 0 0.0
.flash.text 1016655 1016679 24 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 702984 702984 0 0.0
.bss 77568 77568 0 0.0
.data 1876 1876 0 0.0
.text 617740 617740 0 0.0
lock k32w061+release (read/write) 702084 702084 0 0.0
.bss 77544 77544 0 0.0
.data 1916 1916 0 0.0
.text 616824 616824 0 0.0
linux all-clusters-app debug (read only) 2487249 2487361 112 0.0
(read/write) 143344 143344 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78920 78920 0 0.0
.dynamic 592 592 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 212133 212133 0 0.0
.text 2111442 2111554 112 0.0
bridge-app debug+rpc (read only) 1759653 1759653 0 0.0
(read/write) 89552 89552 0 0.0
.bss 44552 44552 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144268 144268 0 0.0
.text 1500149 1500149 0 0.0
chip-tool debug (read only) 1017902 10180261 1232 0.0
(read/write) 355688 355688 0 0.0
.bss 22496 22496 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 326008 326008 0 0.0
.dynamic 608 608 0 0.0
.got 4816 4816 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 518517 518613 96 0.0
.text 8876101 8877237 1136 0.0
chip-tool-ipv6only arm64 (read only) 9809852 9810908 1056 0.0
(read/write) 473729 473745 16 0.0
.bss 40769 40769 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372656 372656 0 0.0
.dynamic 560 560 0 0.0
.got 55352 55368 16 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493908 494004 96 0.0
.text 8262772 8263684 912 0.0
door-lock-app debug (read only) 2011633 2011633 0 0.0
(read/write) 116896 116896 0 0.0
.bss 47680 47680 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 180924 180924 0 0.0
.text 1681026 1681026 0 0.0
lighting-app debug+rpc (read only) 2185441 2185537 96 0.0
(read/write) 123888 123888 0 0.0
.bss 48960 48960 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 174908 174908 0 0.0
.text 1851490 1851586 96 0.0
ota-provider-app debug (read only) 1952841 1952841 0 0.0
(read/write) 112688 112688 0 0.0
.bss 47616 47616 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58184 58184 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166667 166667 0 0.0
.text 1634434 1634434 0 0.0
ota-requestor-app debug (read only) 1980417 1980417 0 0.0
(read/write) 115912 115912 0 0.0
.bss 48544 48544 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162788 162788 0 0.0
.text 1664882 1664882 0 0.0
shell debug (read only) 2436057 2436153 96 0.0
(read/write) 147400 147400 0 0.0
.bss 67336 67336 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73568 73568 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209618 209618 0 0.0
.text 2069618 2069714 96 0.0
thermostat-no-ble arm64 (read only) 2268996 2269108 112 0.0
(read/write) 148385 148385 0 0.0
.bss 62833 62833 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139652 139652 0 0.0
.text 1905984 1906096 112 0.0
tv-app debug (read only) 2682465 2682561 96 0.0
(read/write) 247552 247552 0 0.0
.bss 164320 164320 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74048 74048 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 205579 205579 0 0.0
.text 2302258 2302354 96 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2354708 2354708 0 0.0
.bss 184572 184572 0 0.0
.data 5760 5760 0 0.0
.text 1317308 1317308 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1140887 1140903 16 0.0
bss 142500 142500 0 0.0
rodata 142016 142016 0 0.0
text 781500 781520 20 0.0
p6 all-clusters-app default (read/write) 2496624 2496640 16 0.0
.bss 117992 117992 0 0.0
.data 2640 2640 0 0.0
.text 1454888 1454904 16 0.0
light-app default (read/write) 2399016 2399048 32 0.0
.bss 111464 111464 0 0.0
.data 2496 2496 0 0.0
.text 1357280 1357312 32 0.0
lock-app default (read/write) 2362552 2362552 0 0.0
.bss 111208 111208 0 0.0
.data 2456 2456 0 0.0
.text 1320816 1320816 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 897458 897474 16 0.0
bss 87356 87356 0 0.0
noinit 37160 37160 0 0.0
text 634878 634894 16 0.0

@woody-apple
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the group_key_management-keysetid_validation branch from 23f04a0 to ced0bfb Compare March 26, 2022 04:23
@github-actions
Copy link

github-actions bot commented Mar 26, 2022

PR #16683: Size comparison from e5c39d4 to ced0bfb

Increases (16 builds for cyw30739, efr32, esp32, linux, nrfconnect, p6, telink)
platform target config section e5c39d4 ced0bfb change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604722 604738 16 0.0
.app_xip_area 511892 511908 16 0.0
efr32 lighting-app BRD4161A (read only) 925656 925672 16 0.0
.text 925648 925664 16 0.0
BRD4161A+rpc (read only) 954464 954480 16 0.0
.text 954456 954472 16 0.0
esp32 all-clusters-app c3devkit (read only) 966066 966088 22 0.0
.flash.text 966066 966088 22 0.0
m5stack (read only) 1022515 1022539 24 0.0
.flash.text 1017131 1017155 24 0.0
linux all-clusters-app debug (read only) 2524121 2524233 112 0.0
.text 2144066 2144178 112 0.0
chip-tool debug (read only) 10181829 10183045 1216 0.0
.rodata 518485 518581 96 0.0
.text 8878805 8879925 1120 0.0
chip-tool-ipv6only arm64 (read only) 9813772 9814812 1040 0.0
(read/write) 473697 473713 16 0.0
.got 55352 55368 16 0.0
.rodata 493972 494052 80 0.0
.text 8266628 8267540 912 0.0
lighting-app debug+rpc (read only) 2189617 2189729 112 0.0
.text 1855410 1855522 112 0.0
shell debug (read only) 2439769 2439865 96 0.0
.text 2073106 2073202 96 0.0
thermostat-no-ble arm64 (read only) 2273508 2273620 112 0.0
.text 1910400 1910512 112 0.0
tv-app debug (read only) 2686513 2686625 112 0.0
.text 2306178 2306290 112 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1141007 1141023 16 0.0
text 781604 781620 16 0.0
p6 all-clusters-app default (read/write) 2497440 2497456 16 0.0
.text 1455704 1455720 16 0.0
light-app default (read/write) 2399856 2399888 32 0.0
.text 1358120 1358152 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 897562 897578 16 0.0
text 634982 634998 16 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e5c39d4 ced0bfb change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604722 604738 16 0.0
.app_xip_area 511892 511908 16 0.0
.bss 75576 75576 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 562534 562534 0 0.0
.app_xip_area 471232 471232 0 0.0
.bss 74080 74080 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 574858 574858 0 0.0
.app_xip_area 473908 473908 0 0.0
.bss 83408 83408 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 925656 925672 16 0.0
(read/write) 128712 128712 0 0.0
.bss 126712 126712 0 0.0
.data 1996 1996 0 0.0
.text 925648 925664 16 0.0
BRD4161A+rpc (read only) 954464 954480 16 0.0
(read/write) 144664 144664 0 0.0
.bss 142488 142488 0 0.0
.data 2176 2176 0 0.0
.text 954456 954472 16 0.0
window-app BRD4161A (read only) 855060 855060 0 0.0
(read/write) 126672 126672 0 0.0
.bss 124800 124800 0 0.0
.data 1872 1872 0 0.0
.text 855052 855052 0 0.0
esp32 all-clusters-app c3devkit (read only) 966066 966088 22 0.0
(read/write) 1394274 1394274 0 0.0
.dram0.bss 62000 62000 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 199160 199160 0 0.0
.flash.text 966066 966088 22 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1022515 1022539 24 0.0
(read/write) 462044 462044 0 0.0
.dram0.bss 67528 67528 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228656 228656 0 0.0
.flash.text 1017131 1017155 24 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 703224 703224 0 0.0
.bss 77568 77568 0 0.0
.data 1876 1876 0 0.0
.text 617980 617980 0 0.0
lock k32w061+release (read/write) 702340 702340 0 0.0
.bss 77544 77544 0 0.0
.data 1916 1916 0 0.0
.text 617080 617080 0 0.0
linux all-clusters-app debug (read only) 2524121 2524233 112 0.0
(read/write) 143352 143352 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78920 78920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216229 216229 0 0.0
.text 2144066 2144178 112 0.0
bridge-app debug+rpc (read only) 1763485 1763485 0 0.0
(read/write) 89520 89520 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144396 144396 0 0.0
.text 1503733 1503733 0 0.0
chip-tool debug (read only) 10181829 10183045 1216 0.0
(read/write) 355656 355656 0 0.0
.bss 22464 22464 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 326008 326008 0 0.0
.dynamic 608 608 0 0.0
.got 4824 4824 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 518485 518581 96 0.0
.text 8878805 8879925 1120 0.0
chip-tool-ipv6only arm64 (read only) 9813772 9814812 1040 0.0
(read/write) 473697 473713 16 0.0
.bss 40737 40737 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372656 372656 0 0.0
.dynamic 560 560 0 0.0
.got 55352 55368 16 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493972 494052 80 0.0
.text 8266628 8267540 912 0.0
door-lock-app debug (read only) 2015313 2015313 0 0.0
(read/write) 116896 116896 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 180988 180988 0 0.0
.text 1684514 1684514 0 0.0
lighting-app debug+rpc (read only) 2189617 2189729 112 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175036 175036 0 0.0
.text 1855410 1855522 112 0.0
ota-provider-app debug (read only) 1956089 1956089 0 0.0
(read/write) 112688 112688 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58184 58184 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166763 166763 0 0.0
.text 1637458 1637458 0 0.0
ota-requestor-app debug (read only) 1983713 1983713 0 0.0
(read/write) 115912 115912 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162916 162916 0 0.0
.text 1667922 1667922 0 0.0
shell debug (read only) 2439769 2439865 96 0.0
(read/write) 147368 147368 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73568 73568 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209714 209714 0 0.0
.text 2073106 2073202 96 0.0
thermostat-no-ble arm64 (read only) 2273508 2273620 112 0.0
(read/write) 148353 148353 0 0.0
.bss 62801 62801 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139748 139748 0 0.0
.text 1910400 1910512 112 0.0
tv-app debug (read only) 2686513 2686625 112 0.0
(read/write) 247520 247520 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74048 74048 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 205707 205707 0 0.0
.text 2306178 2306290 112 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2354900 2354900 0 0.0
.bss 184620 184620 0 0.0
.data 5760 5760 0 0.0
.text 1317500 1317500 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1141007 1141023 16 0.0
bss 142500 142500 0 0.0
rodata 142024 142024 0 0.0
text 781604 781620 16 0.0
p6 all-clusters-app default (read/write) 2497440 2497456 16 0.0
.bss 118040 118040 0 0.0
.data 2640 2640 0 0.0
.text 1455704 1455720 16 0.0
light-app default (read/write) 2399856 2399888 32 0.0
.bss 111512 111512 0 0.0
.data 2496 2496 0 0.0
.text 1358120 1358152 32 0.0
lock-app default (read/write) 2363392 2363392 0 0.0
.bss 111256 111256 0 0.0
.data 2456 2456 0 0.0
.text 1321656 1321656 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 897562 897578 16 0.0
bss 87356 87356 0 0.0
noinit 37160 37160 0 0.0
text 634982 634998 16 0.0

@rcasallas-silabs rcasallas-silabs force-pushed the group_key_management-keysetid_validation branch from ced0bfb to b9bedb1 Compare March 28, 2022 12:23
@rcasallas-silabs rcasallas-silabs force-pushed the group_key_management-keysetid_validation branch from b9bedb1 to ea3dcb9 Compare March 28, 2022 12:57
@github-actions
Copy link

github-actions bot commented Mar 28, 2022

PR #16683: Size comparison from 125e73c to ea3dcb9

Increases (16 builds for cyw30739, efr32, esp32, linux, nrfconnect, p6, telink)
platform target config section 125e73c ea3dcb9 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 605426 605442 16 0.0
.app_xip_area 512356 512372 16 0.0
efr32 lighting-app BRD4161A (read only) 926600 926632 32 0.0
.text 926592 926624 32 0.0
BRD4161A+rpc (read only) 955416 955432 16 0.0
.text 955408 955424 16 0.0
esp32 all-clusters-app c3devkit (read only) 966714 966736 22 0.0
.flash.text 966714 966736 22 0.0
m5stack (read only) 1023131 1023155 24 0.0
.flash.text 1017747 1017771 24 0.0
linux all-clusters-app debug (read only) 2525993 2526105 112 0.0
.text 2145618 2145730 112 0.0
chip-tool debug (read only) 10183973 10185205 1232 0.0
.rodata 518805 518901 96 0.0
.text 8880629 8881765 1136 0.0
chip-tool-ipv6only arm64 (read only) 9815548 9816588 1040 0.0
(read/write) 473697 473713 16 0.0
.got 55352 55368 16 0.0
.rodata 494212 494292 80 0.0
.text 8268164 8269076 912 0.0
lighting-app debug+rpc (read only) 2191489 2191601 112 0.0
.text 1856962 1857074 112 0.0
shell debug (read only) 2441625 2441737 112 0.0
.text 2074642 2074754 112 0.0
thermostat-no-ble arm64 (read only) 2275156 2275268 112 0.0
.text 1911760 1911872 112 0.0
tv-app debug (read only) 2688417 2688513 96 0.0
.text 2307730 2307826 96 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1143379 1143395 16 0.0
text 783240 783260 20 0.0
p6 all-clusters-app default (read/write) 2498384 2498400 16 0.0
.text 1456648 1456664 16 0.0
light-app default (read/write) 2400816 2400848 32 0.0
.text 1359080 1359112 32 0.0
telink lighting-app tlsr9518adk80d (read/write) 898750 898766 16 0.0
text 635626 635642 16 0.0
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 125e73c ea3dcb9 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 605426 605442 16 0.0
.app_xip_area 512356 512372 16 0.0
.bss 75816 75816 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 563238 563238 0 0.0
.app_xip_area 471696 471696 0 0.0
.bss 74320 74320 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 575498 575498 0 0.0
.app_xip_area 474308 474308 0 0.0
.bss 83648 83648 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 926600 926632 32 0.0
(read/write) 128952 128952 0 0.0
.bss 126952 126952 0 0.0
.data 1996 1996 0 0.0
.text 926592 926624 32 0.0
BRD4161A+rpc (read only) 955416 955432 16 0.0
(read/write) 144904 144904 0 0.0
.bss 142728 142728 0 0.0
.data 2176 2176 0 0.0
.text 955408 955424 16 0.0
window-app BRD4161A (read only) 856004 856004 0 0.0
(read/write) 126912 126912 0 0.0
.bss 125040 125040 0 0.0
.data 1872 1872 0 0.0
.text 855996 855996 0 0.0
esp32 all-clusters-app c3devkit (read only) 966714 966736 22 0.0
(read/write) 1394810 1394810 0 0.0
.dram0.bss 62240 62240 0 0.0
.dram0.data 14204 14204 0 0.0
.flash.rodata 199456 199456 0 0.0
.flash.text 966714 966736 22 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1023131 1023155 24 0.0
(read/write) 462572 462572 0 0.0
.dram0.bss 67768 67768 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228944 228944 0 0.0
.flash.text 1017747 1017771 24 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 704272 704272 0 0.0
.bss 77808 77808 0 0.0
.data 1876 1876 0 0.0
.text 618788 618788 0 0.0
lock k32w061+release (read/write) 703364 703364 0 0.0
.bss 77784 77784 0 0.0
.data 1916 1916 0 0.0
.text 617864 617864 0 0.0
linux all-clusters-app debug (read only) 2525993 2526105 112 0.0
(read/write) 143352 143352 0 0.0
.bss 57408 57408 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78920 78920 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 216549 216549 0 0.0
.text 2145618 2145730 112 0.0
bridge-app debug+rpc (read only) 1765325 1765325 0 0.0
(read/write) 89520 89520 0 0.0
.bss 44520 44520 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37936 37936 0 0.0
.dynamic 592 592 0 0.0
.got 3928 3928 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144684 144684 0 0.0
.text 1505285 1505285 0 0.0
chip-tool debug (read only) 10183973 10185205 1232 0.0
(read/write) 355656 355656 0 0.0
.bss 22464 22464 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 326008 326008 0 0.0
.dynamic 608 608 0 0.0
.got 4824 4824 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 518805 518901 96 0.0
.text 8880629 8881765 1136 0.0
chip-tool-ipv6only arm64 (read only) 9815548 9816588 1040 0.0
(read/write) 473697 473713 16 0.0
.bss 40737 40737 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372656 372656 0 0.0
.dynamic 560 560 0 0.0
.got 55352 55368 16 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 494212 494292 80 0.0
.text 8268164 8269076 912 0.0
door-lock-app debug (read only) 2017153 2017153 0 0.0
(read/write) 116896 116896 0 0.0
.bss 47648 47648 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 592 592 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181276 181276 0 0.0
.text 1686066 1686066 0 0.0
lighting-app debug+rpc (read only) 2191489 2191601 112 0.0
(read/write) 123888 123888 0 0.0
.bss 48928 48928 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175356 175356 0 0.0
.text 1856962 1857074 112 0.0
ota-provider-app debug (read only) 1957977 1957977 0 0.0
(read/write) 112688 112688 0 0.0
.bss 47584 47584 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58184 58184 0 0.0
.dynamic 608 608 0 0.0
.got 4384 4384 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 167115 167115 0 0.0
.text 1638994 1638994 0 0.0
ota-requestor-app debug (read only) 1985569 1985569 0 0.0
(read/write) 115912 115912 0 0.0
.bss 48512 48512 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60440 60440 0 0.0
.dynamic 592 592 0 0.0
.got 4192 4192 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 163236 163236 0 0.0
.text 1669458 1669458 0 0.0
shell debug (read only) 2441625 2441737 112 0.0
(read/write) 147368 147368 0 0.0
.bss 67304 67304 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73568 73568 0 0.0
.dynamic 592 592 0 0.0
.got 4160 4160 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 210034 210034 0 0.0
.text 2074642 2074754 112 0.0
thermostat-no-ble arm64 (read only) 2275156 2275268 112 0.0
(read/write) 148369 148369 0 0.0
.bss 62817 62817 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4504 4504 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 140036 140036 0 0.0
.text 1911760 1911872 112 0.0
tv-app debug (read only) 2688417 2688513 96 0.0
(read/write) 247520 247520 0 0.0
.bss 164288 164288 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74048 74048 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 206059 206059 0 0.0
.text 2307730 2307826 96 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2355644 2355644 0 0.0
.bss 184860 184860 0 0.0
.data 5760 5760 0 0.0
.text 1318244 1318244 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1143379 1143395 16 0.0
bss 142892 142892 0 0.0
rodata 142364 142364 0 0.0
text 783240 783260 20 0.0
p6 all-clusters-app default (read/write) 2498384 2498400 16 0.0
.bss 118280 118280 0 0.0
.data 2640 2640 0 0.0
.text 1456648 1456664 16 0.0
light-app default (read/write) 2400816 2400848 32 0.0
.bss 111752 111752 0 0.0
.data 2496 2496 0 0.0
.text 1359080 1359112 32 0.0
lock-app default (read/write) 2364352 2364352 0 0.0
.bss 111496 111496 0 0.0
.data 2456 2456 0 0.0
.text 1322616 1322616 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 898750 898766 16 0.0
bss 87596 87596 0 0.0
noinit 37160 37160 0 0.0
text 635626 635642 16 0.0

@jepenven-silabs jepenven-silabs merged commit eca10e9 into project-chip:master Mar 29, 2022
rochaferraz pushed a commit to rochaferraz/connectedhomeip that referenced this pull request Mar 31, 2022
…0. (project-chip#16683)

* GroupKeyManagement server: Added validation against groupKeySetID == 0.

* GroupKeyManagement cluster: YAML test added.

* GroupKeyManagement cluster: Review comment applied.
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
…0. (project-chip#16683)

* GroupKeyManagement server: Added validation against groupKeySetID == 0.

* GroupKeyManagement cluster: YAML test added.

* GroupKeyManagement cluster: Review comment applied.
@rcasallas-silabs rcasallas-silabs deleted the group_key_management-keysetid_validation branch October 5, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group Key Mananagement cluster allows invalid group state mapping of IPK
6 participants