-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GroupKeyManagement server: Added validation against groupKeySetID == 0. #16683
Merged
jepenven-silabs
merged 3 commits into
project-chip:master
from
rcasallas-silabs:group_key_management-keysetid_validation
Mar 29, 2022
Merged
GroupKeyManagement server: Added validation against groupKeySetID == 0. #16683
jepenven-silabs
merged 3 commits into
project-chip:master
from
rcasallas-silabs:group_key_management-keysetid_validation
Mar 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
robszewczyk
March 25, 2022 17:45
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
March 25, 2022 17:45
rcasallas-silabs
force-pushed
the
group_key_management-keysetid_validation
branch
from
March 25, 2022 18:12
39f33d1
to
2602f04
Compare
PR #16683: Size comparison from c14faeb to 2602f04 Increases (14 builds for cyw30739, efr32, linux, nrfconnect, p6, telink)
Full report (25 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
rcasallas-silabs
force-pushed
the
group_key_management-keysetid_validation
branch
2 times, most recently
from
March 25, 2022 19:12
027eff3
to
23f04a0
Compare
tcarmelveilleux
approved these changes
Mar 25, 2022
PR #16683: Size comparison from c14faeb to 23f04a0 Increases (16 builds for cyw30739, efr32, esp32, linux, nrfconnect, p6, telink)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
Mar 26, 2022
/rebase |
woody-apple
force-pushed
the
group_key_management-keysetid_validation
branch
from
March 26, 2022 04:23
23f04a0
to
ced0bfb
Compare
PR #16683: Size comparison from e5c39d4 to ced0bfb Increases (16 builds for cyw30739, efr32, esp32, linux, nrfconnect, p6, telink)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Mar 26, 2022
rcasallas-silabs
force-pushed
the
group_key_management-keysetid_validation
branch
from
March 28, 2022 12:23
ced0bfb
to
b9bedb1
Compare
rcasallas-silabs
force-pushed
the
group_key_management-keysetid_validation
branch
from
March 28, 2022 12:57
b9bedb1
to
ea3dcb9
Compare
PR #16683: Size comparison from 125e73c to ea3dcb9 Increases (16 builds for cyw30739, efr32, esp32, linux, nrfconnect, p6, telink)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Mar 31, 2022
…0. (project-chip#16683) * GroupKeyManagement server: Added validation against groupKeySetID == 0. * GroupKeyManagement cluster: YAML test added. * GroupKeyManagement cluster: Review comment applied.
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…0. (project-chip#16683) * GroupKeyManagement server: Added validation against groupKeySetID == 0. * GroupKeyManagement cluster: YAML test added. * GroupKeyManagement cluster: Review comment applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Added missing validation on WriteGroupKeyMap
Testing