Add --fix support to clang-tidy runner
#16646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for required variants for build systems
Replaces the pw_command_runner path we had before and allows independent execution of the checker.
…hould be sufficient for now
…uild/ios. Do not attempt to clang-enable it nor clang-tidy
pullapprove
bot
requested review from
yunhanw-google,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02,
msandstedt,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #16646: Size comparison from b583b57 to f3f5cde Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Mar 25, 2022
msandstedt
approved these changes
Mar 25, 2022
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Mar 31, 2022
* Make clang variant as a requirement for asan/tsan builds, add support for required variants for build systems * Restyle * Also update workflows * Adding a clang-tidy helper script that is outside the build process. Replaces the pw_command_runner path we had before and allows independent execution of the checker. * Remove pw command launcher from darwin as well. clang tidy on linux should be sufficient for now * Use clang builds and validate more compile databases * Adjust test group ordering since we have placed clang as a last variant * More moving of chip tool variants to make the options in yaml file make sense * add missin $ for var specifier * Add clang variant to tsan * Asan/tsan not limited by clang, so updated as such * Restyle * Ensure darwin clang-tidy is also run * Ensure compile commands are exported * Update to use same coverage for tidy for linux as well as before * Undo changes to TestCommand * Remove modernize-nullptr for now: it is still too strict * Select individual OS compilations and do not compile gcc variants on mac * It looks like IOS is always compiled with gcc - see build/toolchain/build/ios. Do not attempt to clang-enable it nor clang-tidy * Tidy gcc/g++ as well * fix typo * Remove PWcommandlauncher from default build as well * Bump up the timeout value for clang validation a lot just in case * Make code easier to read * Fix darwin paths: when using gcc/g++, sysroot is required * More robust gcc finding of sysroot * Typo fix and restyle * Fix support to clangtidy * Add support for specific checks to be run. Tested with modernize-redundant-void-arg (quite a few found) * Disabled optin-osx-cocoa-localizability-emptylocalizationcontextchecker-objc for clang tidy default * Fix optin to be case correct: clang-analyzer-optin.osx.cocoa.localizability.EmptyLocalizationContextChecker * Restyle
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
* Make clang variant as a requirement for asan/tsan builds, add support for required variants for build systems * Restyle * Also update workflows * Adding a clang-tidy helper script that is outside the build process. Replaces the pw_command_runner path we had before and allows independent execution of the checker. * Remove pw command launcher from darwin as well. clang tidy on linux should be sufficient for now * Use clang builds and validate more compile databases * Adjust test group ordering since we have placed clang as a last variant * More moving of chip tool variants to make the options in yaml file make sense * add missin $ for var specifier * Add clang variant to tsan * Asan/tsan not limited by clang, so updated as such * Restyle * Ensure darwin clang-tidy is also run * Ensure compile commands are exported * Update to use same coverage for tidy for linux as well as before * Undo changes to TestCommand * Remove modernize-nullptr for now: it is still too strict * Select individual OS compilations and do not compile gcc variants on mac * It looks like IOS is always compiled with gcc - see build/toolchain/build/ios. Do not attempt to clang-enable it nor clang-tidy * Tidy gcc/g++ as well * fix typo * Remove PWcommandlauncher from default build as well * Bump up the timeout value for clang validation a lot just in case * Make code easier to read * Fix darwin paths: when using gcc/g++, sysroot is required * More robust gcc finding of sysroot * Typo fix and restyle * Fix support to clangtidy * Add support for specific checks to be run. Tested with modernize-redundant-void-arg (quite a few found) * Disabled optin-osx-cocoa-localizability-emptylocalizationcontextchecker-objc for clang tidy default * Fix optin to be case correct: clang-analyzer-optin.osx.cocoa.localizability.EmptyLocalizationContextChecker * Restyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some clang tidy things can be auto-fixed. Support that.
Change overview
Added fix command support
Testing
Manually ran a fix, #16635 is a result of testing this.