-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OTA] Respond with a valid query image response in subsequent requests #16598
Merged
carol-apple
merged 1 commit into
project-chip:master
from
carol-apple:ota_provider_query_status
Mar 24, 2022
Merged
[OTA] Respond with a valid query image response in subsequent requests #16598
carol-apple
merged 1 commit into
project-chip:master
from
carol-apple:ota_provider_query_status
Mar 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #16598: Size comparison from a40104a to 4d350b8 Increases (1 build for linux)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
pullapprove
bot
requested review from
andy31415,
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
lzgrablic02,
mrjerryjohns,
msandstedt and
mspang
March 24, 2022 14:05
pullapprove
bot
requested review from
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
March 24, 2022 14:05
Damian-Nordic
approved these changes
Mar 24, 2022
carol-apple
force-pushed
the
ota_provider_query_status
branch
from
March 24, 2022 16:44
4d350b8
to
4372b4a
Compare
PR #16598: Size comparison from 6c3f648 to 4372b4a Increases (1 build for linux)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
carol-apple
force-pushed
the
ota_provider_query_status
branch
from
March 24, 2022 18:31
4372b4a
to
f43c8c3
Compare
PR #16598: Size comparison from 20f8b95 to f43c8c3 Increases (1 build for linux)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
isiu-apple
approved these changes
Mar 24, 2022
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Mar 31, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After the first QueryImageResponse, the subsequent QueryImage commands received results in invalid responses being sent back. This is due a few combinations:
OTAProviderExample::kRespondWithUnknown
is the default value used if no command line option for queryImageStatus is specifiedOTAProviderExample ::HandleQueryImage
, whenmQueryImageBehavior == OTAProviderExample::kRespondWithUnknown
, it treats it like update is available (setsqueryState = OTAQueryStatus::kUpdateAvailable
) and sets up response fields such as software version, URI, update token, etcOTAProviderExample::kRespondWithUpdateAvailable
OTAProviderExample::kRespondWithUnknown
is skipped, causing an invalid response to be sent back for update availableChange overview
QueryImageBehaviorType
as it is basicallyOTAQueryStatus
plus thekRespondWithUnknown
stateOTAQueryStatus
directly when setting from command line optionHandleQueryImage
andSendQueryImageResponse
Testing
--queryImageStatus
command line options, the first and subsequent query image commands can be handled with the proper responses