-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false potive when the test does not connect to a device. #16568
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
krypton36:FixFalsePositive
Mar 25, 2022
Merged
Fix false potive when the test does not connect to a device. #16568
bzbarsky-apple
merged 1 commit into
project-chip:master
from
krypton36:FixFalsePositive
Mar 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
approved these changes
Mar 24, 2022
andy31415
approved these changes
Mar 24, 2022
pullapprove
bot
requested review from
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
hawk248,
harsha-rajendran,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
msandstedt,
saurabhst,
selissia,
tecimovic,
vijs,
wbschiller and
xylophone21
March 24, 2022 12:32
/rebase |
woody-apple
force-pushed
the
FixFalsePositive
branch
from
March 24, 2022 13:00
38a6402
to
321b20d
Compare
krypton36
force-pushed
the
FixFalsePositive
branch
from
March 24, 2022 16:14
321b20d
to
84b67a4
Compare
PR #16568: Size comparison from 0381869 to 84b67a4 Increases (2 builds for linux)
Decreases (2 builds for linux)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Mar 31, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a test does not connect to a device, a false positive is logged. See issue https://github.com/CHIP-Specifications/chip-certification-tool/issues/297
Change overview
Testing