Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Piggyback darwin attribute cache subscription #16534

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Piggyback darwin attribute cache subscription #16534

merged 1 commit into from
Mar 24, 2022

Conversation

kpark-apple
Copy link
Contributor

Problem

  • Current Darwin attribute cache requires a dedicated subscription, and it is not possible to share a single wildcard subscription for both attribute cache and regular subscription.

Change overview

  • Piggyback CHIPAttributeCacheContainer on CHIPDevice subscription
    instead of using a dedicated subscription.
  • CHIPAttributeCacheContainer API for subscription was removed.
  • CHIPDevice subscription API added optional CHIPAttributeCacheContainer object parameter.

Testing

  • All tests were updated to use the new API.

@boring-cyborg boring-cyborg bot added the darwin label Mar 22, 2022
@github-actions
Copy link

github-actions bot commented Mar 22, 2022 •
edited
Loading

PR #16534: Size comparison from ca56d6b to 4e6f07d

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section ca56d6b 4e6f07d change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604166 604166 0 0.0
.app_xip_area 511264 511264 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561946 561946 0 0.0
.app_xip_area 470572 470572 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571790 571790 0 0.0
.app_xip_area 470768 470768 0 0.0
.bss 83488 83488 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922424 922424 0 0.0
(read/write) 128760 128760 0 0.0
.bss 126768 126768 0 0.0
.data 1988 1988 0 0.0
.text 922416 922416 0 0.0
BRD4161A+rpc (read only) 951236 951236 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142544 142544 0 0.0
.data 2168 2168 0 0.0
.text 951228 951228 0 0.0
window-app BRD4161A (read only) 852800 852800 0 0.0
(read/write) 126720 126720 0 0.0
.bss 124856 124856 0 0.0
.data 1864 1864 0 0.0
.text 852792 852792 0 0.0
esp32 all-clusters-app c3devkit (read only) 964026 964026 0 0.0
(read/write) 1393690 1393690 0 0.0
.dram0.bss 62072 62072 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 198512 198512 0 0.0
.flash.text 964026 964026 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1020579 1020579 0 0.0
(read/write) 461460 461460 0 0.0
.dram0.bss 67592 67592 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 228016 228016 0 0.0
.flash.text 1015195 1015195 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701380 701380 0 0.0
.bss 77656 77656 0 0.0
.data 1868 1868 0 0.0
.text 616056 616056 0 0.0
lock k32w061+release (read/write) 701252 701252 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615920 615920 0 0.0
linux all-clusters-app debug (read only) 2477649 2477649 0 0.0
(read/write) 143152 143152 0 0.0
.bss 57312 57312 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78840 78840 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 211877 211877 0 0.0
.text 2102322 2102322 0 0.0
bridge-app debug+rpc (read only) 1753229 1753229 0 0.0
(read/write) 89424 89424 0 0.0
.bss 44456 44456 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37944 37944 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144588 144588 0 0.0
.text 1493429 1493429 0 0.0
chip-tool debug (read only) 10154061 10154061 0 0.0
(read/write) 354912 354912 0 0.0
.bss 22304 22304 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 325472 325472 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 518197 518197 0 0.0
.text 8853141 8853141 0 0.0
chip-tool-ipv6only arm64 (read only) 9776252 9776252 0 0.0
(read/write) 472801 472801 0 0.0
.bss 40609 40609 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371880 371880 0 0.0
.dynamic 560 560 0 0.0
.got 55384 55384 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493876 493876 0 0.0
.text 8230724 8230724 0 0.0
door-lock-app debug (read only) 2005033 2005033 0 0.0
(read/write) 116832 116832 0 0.0
.bss 47584 47584 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62856 62856 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181052 181052 0 0.0
.text 1674322 1674322 0 0.0
lighting-app debug+rpc (read only) 2178681 2178681 0 0.0
(read/write) 123792 123792 0 0.0
.bss 48864 48864 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175324 175324 0 0.0
.text 1844338 1844338 0 0.0
ota-provider-app debug (read only) 1939425 1939425 0 0.0
(read/write) 112624 112624 0 0.0
.bss 47488 47488 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166475 166475 0 0.0
.text 1621186 1621186 0 0.0
ota-requestor-app debug (read only) 1969593 1969593 0 0.0
(read/write) 115592 115592 0 0.0
.bss 48480 48480 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162884 162884 0 0.0
.text 1654722 1654722 0 0.0
shell debug (read only) 2426993 2426993 0 0.0
(read/write) 147208 147208 0 0.0
.bss 67240 67240 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73472 73472 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209298 209298 0 0.0
.text 2060994 2060994 0 0.0
thermostat-no-ble arm64 (read only) 2262724 2262724 0 0.0
(read/write) 148273 148273 0 0.0
.bss 62753 62753 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4480 4480 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139844 139844 0 0.0
.text 1899568 1899568 0 0.0
tv-app debug (read only) 2678265 2678265 0 0.0
(read/write) 247712 247712 0 0.0
.bss 164384 164384 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74168 74168 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 207285 207285 0 0.0
.text 2296130 2296130 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353708 2353708 0 0.0
.bss 184652 184652 0 0.0
.data 5752 5752 0 0.0
.text 1316308 1316308 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156275 1156275 0 0.0
bss 146716 146716 0 0.0
rodata 145956 145956 0 0.0
text 788432 788432 0 0.0
p6 all-clusters-app default (read/write) 2493408 2493408 0 0.0
.bss 118072 118072 0 0.0
.data 2632 2632 0 0.0
.text 1451672 1451672 0 0.0
light-app default (read/write) 2396808 2396808 0 0.0
.bss 111544 111544 0 0.0
.data 2488 2488 0 0.0
.text 1355072 1355072 0 0.0
lock-app default (read/write) 2360344 2360344 0 0.0
.bss 111288 111288 0 0.0
.data 2448 2448 0 0.0
.text 1318608 1318608 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 896142 896142 0 0.0
bss 87424 87424 0 0.0
noinit 37160 37160 0 0.0
text 633718 633718 0 0.0

@kpark-apple kpark-apple force-pushed the fix/kpark/20220322-single-subscribe branch from 4e6f07d to c6a3972 Compare March 22, 2022 19:51
@github-actions
Copy link

github-actions bot commented Mar 22, 2022 •
edited
Loading

PR #16534: Size comparison from d57c3b3 to c6a3972

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d57c3b3 c6a3972 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 604166 604166 0 0.0
.app_xip_area 511264 511264 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561946 561946 0 0.0
.app_xip_area 470572 470572 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571790 571790 0 0.0
.app_xip_area 470768 470768 0 0.0
.bss 83488 83488 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922424 922424 0 0.0
(read/write) 128760 128760 0 0.0
.bss 126768 126768 0 0.0
.data 1988 1988 0 0.0
.text 922416 922416 0 0.0
BRD4161A+rpc (read only) 951236 951236 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142544 142544 0 0.0
.data 2168 2168 0 0.0
.text 951228 951228 0 0.0
window-app BRD4161A (read only) 852800 852800 0 0.0
(read/write) 126720 126720 0 0.0
.bss 124856 124856 0 0.0
.data 1864 1864 0 0.0
.text 852792 852792 0 0.0
esp32 all-clusters-app c3devkit (read only) 964026 964026 0 0.0
(read/write) 1393690 1393690 0 0.0
.dram0.bss 62072 62072 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 198512 198512 0 0.0
.flash.text 964026 964026 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1020579 1020579 0 0.0
(read/write) 461460 461460 0 0.0
.dram0.bss 67592 67592 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 228016 228016 0 0.0
.flash.text 1015195 1015195 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701380 701380 0 0.0
.bss 77656 77656 0 0.0
.data 1868 1868 0 0.0
.text 616056 616056 0 0.0
lock k32w061+release (read/write) 701252 701252 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615920 615920 0 0.0
linux all-clusters-app debug (read only) 2477649 2477649 0 0.0
(read/write) 143152 143152 0 0.0
.bss 57312 57312 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78840 78840 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 211877 211877 0 0.0
.text 2102322 2102322 0 0.0
bridge-app debug+rpc (read only) 1753229 1753229 0 0.0
(read/write) 89424 89424 0 0.0
.bss 44456 44456 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37944 37944 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144588 144588 0 0.0
.text 1493429 1493429 0 0.0
chip-tool debug (read only) 10154077 10154077 0 0.0
(read/write) 354944 354944 0 0.0
.bss 22336 22336 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 325472 325472 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 518197 518197 0 0.0
.text 8853157 8853157 0 0.0
chip-tool-ipv6only arm64 (read only) 9776284 9776284 0 0.0
(read/write) 472817 472817 0 0.0
.bss 40625 40625 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371880 371880 0 0.0
.dynamic 560 560 0 0.0
.got 55384 55384 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493876 493876 0 0.0
.text 8230756 8230756 0 0.0
door-lock-app debug (read only) 2005033 2005033 0 0.0
(read/write) 116832 116832 0 0.0
.bss 47584 47584 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62856 62856 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181052 181052 0 0.0
.text 1674322 1674322 0 0.0
lighting-app debug+rpc (read only) 2178681 2178681 0 0.0
(read/write) 123792 123792 0 0.0
.bss 48864 48864 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175324 175324 0 0.0
.text 1844338 1844338 0 0.0
ota-provider-app debug (read only) 1939425 1939425 0 0.0
(read/write) 112624 112624 0 0.0
.bss 47488 47488 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166475 166475 0 0.0
.text 1621186 1621186 0 0.0
ota-requestor-app debug (read only) 1969593 1969593 0 0.0
(read/write) 115592 115592 0 0.0
.bss 48480 48480 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162884 162884 0 0.0
.text 1654722 1654722 0 0.0
shell debug (read only) 2426993 2426993 0 0.0
(read/write) 147208 147208 0 0.0
.bss 67240 67240 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73472 73472 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209298 209298 0 0.0
.text 2060994 2060994 0 0.0
thermostat-no-ble arm64 (read only) 2262724 2262724 0 0.0
(read/write) 148273 148273 0 0.0
.bss 62753 62753 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4480 4480 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139844 139844 0 0.0
.text 1899568 1899568 0 0.0
tv-app debug (read only) 2678281 2678281 0 0.0
(read/write) 247744 247744 0 0.0
.bss 164416 164416 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74168 74168 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 207285 207285 0 0.0
.text 2296146 2296146 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353708 2353708 0 0.0
.bss 184652 184652 0 0.0
.data 5752 5752 0 0.0
.text 1316308 1316308 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1156275 1156275 0 0.0
bss 146716 146716 0 0.0
rodata 145956 145956 0 0.0
text 788432 788432 0 0.0
p6 all-clusters-app default (read/write) 2493408 2493408 0 0.0
.bss 118072 118072 0 0.0
.data 2632 2632 0 0.0
.text 1451672 1451672 0 0.0
light-app default (read/write) 2396808 2396808 0 0.0
.bss 111544 111544 0 0.0
.data 2488 2488 0 0.0
.text 1355072 1355072 0 0.0
lock-app default (read/write) 2360344 2360344 0 0.0
.bss 111288 111288 0 0.0
.data 2448 2448 0 0.0
.text 1318608 1318608 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 896142 896142 0 0.0
bss 87424 87424 0 0.0
noinit 37160 37160 0 0.0
text 633718 633718 0 0.0

@kpark-apple kpark-apple mentioned this pull request Mar 23, 2022
Merged
@kpark-apple kpark-apple force-pushed the fix/kpark/20220322-single-subscribe branch from c6a3972 to 56c7b8f Compare March 23, 2022 14:25
@github-actions
Copy link

github-actions bot commented Mar 23, 2022 •
edited
Loading

PR #16534: Size comparison from 4a33c98 to 56c7b8f

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 4a33c98 56c7b8f change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603478 603478 0 0.0
.app_xip_area 510576 510576 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561274 561274 0 0.0
.app_xip_area 469900 469900 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 572806 572806 0 0.0
.app_xip_area 471784 471784 0 0.0
.bss 83488 83488 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922300 922300 0 0.0
(read/write) 128756 128756 0 0.0
.bss 126768 126768 0 0.0
.data 1988 1988 0 0.0
.text 922292 922292 0 0.0
BRD4161A+rpc (read only) 951128 951128 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142544 142544 0 0.0
.data 2168 2168 0 0.0
.text 951120 951120 0 0.0
window-app BRD4161A (read only) 852660 852660 0 0.0
(read/write) 126720 126720 0 0.0
.bss 124856 124856 0 0.0
.data 1864 1864 0 0.0
.text 852652 852652 0 0.0
esp32 all-clusters-app c3devkit (read only) 964156 964156 0 0.0
(read/write) 1393714 1393714 0 0.0
.dram0.bss 62072 62072 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 198536 198536 0 0.0
.flash.text 964156 964156 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1020687 1020687 0 0.0
(read/write) 461492 461492 0 0.0
.dram0.bss 67600 67600 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 228040 228040 0 0.0
.flash.text 1015303 1015303 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701120 701120 0 0.0
.bss 77656 77656 0 0.0
.data 1868 1868 0 0.0
.text 615796 615796 0 0.0
lock k32w061+release (read/write) 701088 701088 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615756 615756 0 0.0
linux all-clusters-app debug (read only) 2478329 2478329 0 0.0
(read/write) 143216 143216 0 0.0
.bss 57312 57312 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78904 78904 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 211941 211941 0 0.0
.text 2102914 2102914 0 0.0
bridge-app debug+rpc (read only) 1753373 1753373 0 0.0
(read/write) 89424 89424 0 0.0
.bss 44456 44456 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37944 37944 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144556 144556 0 0.0
.text 1493605 1493605 0 0.0
chip-tool debug (read only) 10179253 10179253 0 0.0
(read/write) 354976 354976 0 0.0
.bss 22336 22336 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 325520 325520 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 520085 520085 0 0.0
.text 8876325 8876325 0 0.0
chip-tool-ipv6only arm64 (read only) 9798524 9798524 0 0.0
(read/write) 473169 473169 0 0.0
.bss 40625 40625 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371936 371936 0 0.0
.dynamic 560 560 0 0.0
.got 55680 55680 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 495636 495636 0 0.0
.text 8250228 8250228 0 0.0
door-lock-app debug (read only) 2005129 2005129 0 0.0
(read/write) 116832 116832 0 0.0
.bss 47584 47584 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62856 62856 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 180988 180988 0 0.0
.text 1674482 1674482 0 0.0
lighting-app debug+rpc (read only) 2178777 2178777 0 0.0
(read/write) 123792 123792 0 0.0
.bss 48864 48864 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175164 175164 0 0.0
.text 1844594 1844594 0 0.0
ota-provider-app debug (read only) 1946513 1946513 0 0.0
(read/write) 112560 112560 0 0.0
.bss 47456 47456 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166987 166987 0 0.0
.text 1627810 1627810 0 0.0
ota-requestor-app debug (read only) 1969953 1969953 0 0.0
(read/write) 115592 115592 0 0.0
.bss 48480 48480 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162980 162980 0 0.0
.text 1654962 1654962 0 0.0
shell debug (read only) 2427657 2427657 0 0.0
(read/write) 147272 147272 0 0.0
.bss 67240 67240 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73536 73536 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209362 209362 0 0.0
.text 2061570 2061570 0 0.0
thermostat-no-ble arm64 (read only) 2262692 2262692 0 0.0
(read/write) 148273 148273 0 0.0
.bss 62753 62753 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4480 4480 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139780 139780 0 0.0
.text 1899600 1899600 0 0.0
tv-app debug (read only) 2678521 2678521 0 0.0
(read/write) 247744 247744 0 0.0
.bss 164416 164416 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74168 74168 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 207157 207157 0 0.0
.text 2296514 2296514 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353636 2353636 0 0.0
.bss 184652 184652 0 0.0
.data 5752 5752 0 0.0
.text 1316236 1316236 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1138947 1138947 0 0.0
bss 142588 142588 0 0.0
rodata 141516 141516 0 0.0
text 780084 780084 0 0.0
p6 all-clusters-app default (read/write) 2493592 2493592 0 0.0
.bss 118072 118072 0 0.0
.data 2632 2632 0 0.0
.text 1451856 1451856 0 0.0
light-app default (read/write) 2396776 2396776 0 0.0
.bss 111544 111544 0 0.0
.data 2488 2488 0 0.0
.text 1355040 1355040 0 0.0
lock-app default (read/write) 2360312 2360312 0 0.0
.bss 111288 111288 0 0.0
.data 2448 2448 0 0.0
.text 1318576 1318576 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 896954 896954 0 0.0
bss 87444 87444 0 0.0
noinit 37160 37160 0 0.0
text 634304 634304 0 0.0

@kpark-apple kpark-apple force-pushed the fix/kpark/20220322-single-subscribe branch from 56c7b8f to e57daf6 Compare March 23, 2022 19:57
@github-actions
Copy link

github-actions bot commented Mar 23, 2022 •
edited
Loading

PR #16534: Size comparison from 395bb1f to e57daf6

Full report (25 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 395bb1f e57daf6 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603470 603470 0 0.0
.app_xip_area 510560 510560 0 0.0
.bss 75656 75656 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561266 561266 0 0.0
.app_xip_area 469884 469884 0 0.0
.bss 74160 74160 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573350 573350 0 0.0
.app_xip_area 472320 472320 0 0.0
.bss 83488 83488 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922876 922876 0 0.0
(read/write) 128756 128756 0 0.0
.bss 126760 126760 0 0.0
.data 1996 1996 0 0.0
.text 922868 922868 0 0.0
BRD4161A+rpc (read only) 951692 951692 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142536 142536 0 0.0
.data 2176 2176 0 0.0
.text 951684 951684 0 0.0
window-app BRD4161A (read only) 852656 852656 0 0.0
(read/write) 126728 126728 0 0.0
.bss 124856 124856 0 0.0
.data 1872 1872 0 0.0
.text 852648 852648 0 0.0
k32w light k32w061+release (read/write) 701644 701644 0 0.0
.bss 77648 77648 0 0.0
.data 1876 1876 0 0.0
.text 616320 616320 0 0.0
lock k32w061+release (read/write) 701080 701080 0 0.0
.bss 77624 77624 0 0.0
.data 1916 1916 0 0.0
.text 615740 615740 0 0.0
linux all-clusters-app debug (read only) 2478273 2478273 0 0.0
(read/write) 143216 143216 0 0.0
.bss 57312 57312 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78904 78904 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 211941 211941 0 0.0
.text 2102834 2102834 0 0.0
bridge-app debug+rpc (read only) 1753317 1753317 0 0.0
(read/write) 89456 89456 0 0.0
.bss 44456 44456 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37944 37944 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144556 144556 0 0.0
.text 1493525 1493525 0 0.0
chip-tool debug (read only) 10187517 10187517 0 0.0
(read/write) 355136 355136 0 0.0
.bss 22400 22400 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 325560 325560 0 0.0
.dynamic 608 608 0 0.0
.got 4816 4816 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 520725 520725 0 0.0
.text 8883509 8883509 0 0.0
chip-tool-ipv6only arm64 (read only) 9807276 9807276 0 0.0
(read/write) 473313 473313 0 0.0
.bss 40673 40673 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372000 372000 0 0.0
.dynamic 560 560 0 0.0
.got 55696 55696 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 496036 496036 0 0.0
.text 8258340 8258340 0 0.0
door-lock-app debug (read only) 2005073 2005073 0 0.0
(read/write) 116832 116832 0 0.0
.bss 47584 47584 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62856 62856 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 180988 180988 0 0.0
.text 1674402 1674402 0 0.0
lighting-app debug+rpc (read only) 2178721 2178721 0 0.0
(read/write) 123792 123792 0 0.0
.bss 48864 48864 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175164 175164 0 0.0
.text 1844514 1844514 0 0.0
ota-provider-app debug (read only) 1946473 1946473 0 0.0
(read/write) 112560 112560 0 0.0
.bss 47456 47456 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166987 166987 0 0.0
.text 1627746 1627746 0 0.0
ota-requestor-app debug (read only) 1973281 1973281 0 0.0
(read/write) 115816 115816 0 0.0
.bss 48448 48448 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60424 60424 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162980 162980 0 0.0
.text 1657650 1657650 0 0.0
shell debug (read only) 2427617 2427617 0 0.0
(read/write) 147272 147272 0 0.0
.bss 67240 67240 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73536 73536 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209362 209362 0 0.0
.text 2061506 2061506 0 0.0
thermostat-no-ble arm64 (read only) 2262660 2262660 0 0.0
(read/write) 148289 148289 0 0.0
.bss 62753 62753 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4480 4480 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139780 139780 0 0.0
.text 1899536 1899536 0 0.0
tv-app debug (read only) 2679201 2679201 0 0.0
(read/write) 247776 247776 0 0.0
.bss 164416 164416 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74168 74168 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 207157 207157 0 0.0
.text 2297170 2297170 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353636 2353636 0 0.0
.bss 184652 184652 0 0.0
.data 5760 5760 0 0.0
.text 1316236 1316236 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1139459 1139459 0 0.0
bss 142588 142588 0 0.0
rodata 141588 141588 0 0.0
text 780508 780508 0 0.0
p6 all-clusters-app default (read/write) 2493592 2493592 0 0.0
.bss 118072 118072 0 0.0
.data 2640 2640 0 0.0
.text 1451856 1451856 0 0.0
light-app default (read/write) 2396760 2396760 0 0.0
.bss 111544 111544 0 0.0
.data 2496 2496 0 0.0
.text 1355024 1355024 0 0.0
lock-app default (read/write) 2360296 2360296 0 0.0
.bss 111288 111288 0 0.0
.data 2456 2456 0 0.0
.text 1318560 1318560 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 896954 896954 0 0.0
bss 87444 87444 0 0.0
noinit 37160 37160 0 0.0
text 634296 634296 0 0.0

@kpark-apple
Piggyback darwin attribute cache subscription
7b2eea0 
* Piggyback CHIPAttributeCacheContainer on CHIPDevice subscription
  instead of using a dedicated subscription.
@kpark-apple kpark-apple force-pushed the fix/kpark/20220322-single-subscribe branch from e57daf6 to 7b2eea0 Compare March 23, 2022 20:48
@github-actions
Copy link

github-actions bot commented Mar 23, 2022 •
edited
Loading

PR #16534: Size comparison from 395bb1f to 7b2eea0

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 395bb1f 7b2eea0 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603470 603470 0 0.0
.app_xip_area 510560 510560 0 0.0
.bss 75656 75656 0 0.0
.data 604 604 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561266 561266 0 0.0
.app_xip_area 469884 469884 0 0.0
.bss 74160 74160 0 0.0
.data 568 568 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 573350 573350 0 0.0
.app_xip_area 472320 472320 0 0.0
.bss 83488 83488 0 0.0
.data 508 508 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 922876 922876 0 0.0
(read/write) 128756 128756 0 0.0
.bss 126760 126760 0 0.0
.data 1996 1996 0 0.0
.text 922868 922868 0 0.0
BRD4161A+rpc (read only) 951692 951692 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142536 142536 0 0.0
.data 2176 2176 0 0.0
.text 951684 951684 0 0.0
window-app BRD4161A (read only) 852656 852656 0 0.0
(read/write) 126728 126728 0 0.0
.bss 124856 124856 0 0.0
.data 1872 1872 0 0.0
.text 852648 852648 0 0.0
esp32 all-clusters-app c3devkit (read only) 964154 964154 0 0.0
(read/write) 1393730 1393730 0 0.0
.dram0.bss 62072 62072 0 0.0
.dram0.data 14196 14196 0 0.0
.flash.rodata 198536 198536 0 0.0
.flash.text 964154 964154 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1020691 1020691 0 0.0
(read/write) 461500 461500 0 0.0
.dram0.bss 67600 67600 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 228040 228040 0 0.0
.flash.text 1015307 1015307 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701644 701644 0 0.0
.bss 77648 77648 0 0.0
.data 1876 1876 0 0.0
.text 616320 616320 0 0.0
lock k32w061+release (read/write) 701080 701080 0 0.0
.bss 77624 77624 0 0.0
.data 1916 1916 0 0.0
.text 615740 615740 0 0.0
linux all-clusters-app debug (read only) 2478273 2478273 0 0.0
(read/write) 143216 143216 0 0.0
.bss 57312 57312 0 0.0
.data 1280 1280 0 0.0
.data.rel.ro 78904 78904 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 211941 211941 0 0.0
.text 2102834 2102834 0 0.0
bridge-app debug+rpc (read only) 1753317 1753317 0 0.0
(read/write) 89456 89456 0 0.0
.bss 44456 44456 0 0.0
.data 1984 1984 0 0.0
.data.rel.ro 37944 37944 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144556 144556 0 0.0
.text 1493525 1493525 0 0.0
chip-tool debug (read only) 10187517 10187517 0 0.0
(read/write) 355136 355136 0 0.0
.bss 22400 22400 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 325560 325560 0 0.0
.dynamic 608 608 0 0.0
.got 4816 4816 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 520725 520725 0 0.0
.text 8883509 8883509 0 0.0
chip-tool-ipv6only arm64 (read only) 9807276 9807276 0 0.0
(read/write) 473313 473313 0 0.0
.bss 40673 40673 0 0.0
.data 1144 1144 0 0.0
.data.rel.ro 372000 372000 0 0.0
.dynamic 560 560 0 0.0
.got 55696 55696 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 496036 496036 0 0.0
.text 8258340 8258340 0 0.0
door-lock-app debug (read only) 2005073 2005073 0 0.0
(read/write) 116832 116832 0 0.0
.bss 47584 47584 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62856 62856 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 180988 180988 0 0.0
.text 1674402 1674402 0 0.0
lighting-app debug+rpc (read only) 2178721 2178721 0 0.0
(read/write) 123792 123792 0 0.0
.bss 48864 48864 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 67928 67928 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 175164 175164 0 0.0
.text 1844514 1844514 0 0.0
ota-provider-app debug (read only) 1946473 1946473 0 0.0
(read/write) 112560 112560 0 0.0
.bss 47456 47456 0 0.0
.data 1256 1256 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166987 166987 0 0.0
.text 1627746 1627746 0 0.0
ota-requestor-app debug (read only) 1973281 1973281 0 0.0
(read/write) 115816 115816 0 0.0
.bss 48448 48448 0 0.0
.data 1480 1480 0 0.0
.data.rel.ro 60424 60424 0 0.0
.dynamic 592 592 0 0.0
.got 4184 4184 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162980 162980 0 0.0
.text 1657650 1657650 0 0.0
shell debug (read only) 2427617 2427617 0 0.0
(read/write) 147272 147272 0 0.0
.bss 67240 67240 0 0.0
.data 800 800 0 0.0
.data.rel.ro 73536 73536 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209362 209362 0 0.0
.text 2061506 2061506 0 0.0
thermostat-no-ble arm64 (read only) 2262660 2262660 0 0.0
(read/write) 148289 148289 0 0.0
.bss 62753 62753 0 0.0
.data 1040 1040 0 0.0
.data.rel.ro 77000 77000 0 0.0
.dynamic 560 560 0 0.0
.got 4480 4480 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 139780 139780 0 0.0
.text 1899536 1899536 0 0.0
tv-app debug (read only) 2679201 2679201 0 0.0
(read/write) 247776 247776 0 0.0
.bss 164416 164416 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 74168 74168 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 207157 207157 0 0.0
.text 2297170 2297170 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353636 2353636 0 0.0
.bss 184652 184652 0 0.0
.data 5760 5760 0 0.0
.text 1316236 1316236 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1139459 1139459 0 0.0
bss 142588 142588 0 0.0
rodata 141588 141588 0 0.0
text 780508 780508 0 0.0
p6 all-clusters-app default (read/write) 2493592 2493592 0 0.0
.bss 118072 118072 0 0.0
.data 2640 2640 0 0.0
.text 1451856 1451856 0 0.0
light-app default (read/write) 2396760 2396760 0 0.0
.bss 111544 111544 0 0.0
.data 2496 2496 0 0.0
.text 1355024 1355024 0 0.0
lock-app default (read/write) 2360296 2360296 0 0.0
.bss 111288 111288 0 0.0
.data 2456 2456 0 0.0
.text 1318560 1318560 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 896954 896954 0 0.0
bss 87444 87444 0 0.0
noinit 37160 37160 0 0.0
text 634296 634296 0 0.0

@bzbarsky-apple
Copy link
Contributor

Fast-tracking platform change.

@bzbarsky-apple bzbarsky-apple merged commit f34d233 into project-chip:master Mar 24, 2022
@kpark-apple kpark-apple deleted the fix/kpark/20220322-single-subscribe branch March 24, 2022 18:53
@bzbarsky-apple bzbarsky-apple mentioned this pull request Mar 25, 2022
Closed
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@kpark-apple @andrei-menzopol
Piggyback darwin attribute cache subscription (project-chip#16534)
d67dce7 
* Piggyback CHIPAttributeCacheContainer on CHIPDevice subscription
  instead of using a dedicated subscription.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Assignees
No one assigned
Labels
darwin fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpark-apple @bzbarsky-apple