Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix header dependency in CHIPCert #16488

Merged
merged 4 commits into from
Mar 21, 2022
Merged

Fix header dependency in CHIPCert #16488

merged 4 commits into from
Mar 21, 2022

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Mar 21, 2022 •
edited
Loading

Problem

Compile error in https://github.com/project-chip/connectedhomeip/runs/5626855242?check_suite_focus=true :

FAILED: mac_x64_gcc/obj/src/lib/support/tests/libSupportTests.TestTestPersistentStorageDelegate.cpp.o 
`pwd`/../scripts/helpers/clang-tidy-launcher.py g++ -MMD -MF mac_x64_gcc/obj/src/lib/support/tests/libSupportTests.TestTestPersistentStorageDelegate.cpp.o.d -Wconversion -target x86_64-apple-macos10.15 -O0 -g2 -fno-common -ffunction-sections -fdata-sections -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -Wall -Werror -Wextra -Wshadow -Wunreachable-code -Wvla -Wformat -Wformat-nonliteral -Wformat-security -Wno-deprecated-declarations -Wno-unknown-warning-option -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-cast-function-type -fdiagnostics-color -fno-strict-aliasing -fsanitize=address -fno-omit-frame-pointer -Wno-implicit-fallthrough -I/usr/local/Cellar/[email protected]/1.1.1m/include -fobjc-arc -std=gnu++14 -fno-rtti -Wnon-virtual-dtor -DCHIP_HAVE_CONFIG_H=1 -I../src/include -I../src -Imac_x64_gcc/gen/include -I../zzz_generated/app-common -I../config/standalone -I../third_party/nlassert/repo/include -I../third_party/nlio/repo/include -I../third_party/nlfaultinjection/repo/include -I../third_party/jsoncpp/repo/include -I../third_party/nlunit-test/repo/src -c ../src/lib/support/tests/TestTestPersistentStorageDelegate.cpp -o mac_x64_gcc/obj/src/lib/support/tests/libSupportTests.TestTestPersistentStorageDelegate.cpp.o
In file included from ../src/lib/support/tests/TestTestPersistentStorageDelegate.cpp:20:
In file included from ../src/lib/support/TestPersistentStorageDelegate.h:22:
In file included from ../src/credentials/FabricTable.h:27:
In file included from ../src/credentials/CHIPCert.h:34:
../src/lib/asn1/ASN1.h:30:10: fatal error: 'asn1/ASN1OID.h' file not found
#include <asn1/ASN1OID.h>

Change overview

Add dependency on generated header into src/credentials library.

Testing

Compilation will validate this.

Also used ninja -t browse --port 8000 TestTestPersistentStorageDelegate to validate dependency graph that shows in order:

  • tests/TestTestPersistentStorageDelegate
  • obj/src/credentials/lib/libCredentials.a
  • obj/src/lib/asn1/lib/libASN1.a
  • obj/src/lib/asn1/asn1oid_header.stamp

Which seems to indicate that the asn1 header is now a build dependency Also the asn1 header stamp shows as a edge dependecy to include a lot of tests.

@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Mar 21, 2022
@andy31415 andy31415 removed the hotfix urgent fix needed, can bypass review label Mar 21, 2022
@boring-cyborg boring-cyborg bot added the lib label Mar 21, 2022
@andy31415 andy31415 added the hotfix urgent fix needed, can bypass review label Mar 21, 2022
@github-actions
Copy link

github-actions bot commented Mar 21, 2022 •
edited
Loading

PR #16488: Size comparison from 95bcd02 to e34de51

Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 95bcd02 e34de51 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 603854 603854 0 0.0
.app_xip_area 510952 510952 0 0.0
.bss 75656 75656 0 0.0
.data 596 596 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 561642 561642 0 0.0
.app_xip_area 470268 470268 0 0.0
.bss 74160 74160 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 571494 571494 0 0.0
.app_xip_area 470472 470472 0 0.0
.bss 83488 83488 0 0.0
.data 500 500 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 921976 921976 0 0.0
(read/write) 128760 128760 0 0.0
.bss 126768 126768 0 0.0
.data 1988 1988 0 0.0
.text 921968 921968 0 0.0
BRD4161A+rpc (read only) 950788 950788 0 0.0
(read/write) 144712 144712 0 0.0
.bss 142544 142544 0 0.0
.data 2168 2168 0 0.0
.text 950780 950780 0 0.0
window-app BRD4161A (read only) 852304 852304 0 0.0
(read/write) 126712 126712 0 0.0
.bss 124848 124848 0 0.0
.data 1864 1864 0 0.0
.text 852296 852296 0 0.0
esp32 all-clusters-app c3devkit (read only) 961988 961988 0 0.0
(read/write) 1393306 1393306 0 0.0
.dram0.bss 62048 62048 0 0.0
.dram0.data 14188 14188 0 0.0
.flash.rodata 198160 198160 0 0.0
.flash.text 961988 961988 0 0.0
.iram0.text 62016 62016 0 0.0
m5stack (read only) 1018119 1018119 0 0.0
(read/write) 461148 461148 0 0.0
.dram0.bss 67576 67576 0 0.0
.dram0.data 34016 34016 0 0.0
.flash.rodata 227720 227720 0 0.0
.flash.text 1012735 1012735 0 0.0
.iram0.text 123107 123107 0 0.0
k32w light k32w061+release (read/write) 701092 701092 0 0.0
.bss 77656 77656 0 0.0
.data 1868 1868 0 0.0
.text 615768 615768 0 0.0
lock k32w061+release (read/write) 700948 700948 0 0.0
.bss 77624 77624 0 0.0
.data 1908 1908 0 0.0
.text 615616 615616 0 0.0
linux all-clusters-app debug (read only) 2477201 2477201 0 0.0
(read/write) 143152 143152 0 0.0
.bss 57312 57312 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78840 78840 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 212005 212005 0 0.0
.text 2101746 2101746 0 0.0
bridge-app debug+rpc (read only) 1752397 1752397 0 0.0
(read/write) 89424 89424 0 0.0
.bss 44456 44456 0 0.0
.data 1952 1952 0 0.0
.data.rel.ro 37944 37944 0 0.0
.dynamic 592 592 0 0.0
.got 3920 3920 0 0.0
.init 27 27 0 0.0
.init_array 544 544 0 0.0
.rodata 144524 144524 0 0.0
.text 1492661 1492661 0 0.0
chip-tool debug (read only) 1014584 1014584 0 0.0
(read/write) 354848 354848 0 0.0
.bss 22304 22304 0 0.0
.data 1072 1072 0 0.0
.data.rel.ro 325408 325408 0 0.0
.dynamic 608 608 0 0.0
.got 4784 4784 0 0.0
.init 27 27 0 0.0
.init_array 632 632 0 0.0
.rodata 517813 517813 0 0.0
.text 8845429 8845429 0 0.0
chip-tool-ipv6only arm64 (read only) 9769292 9769292 0 0.0
(read/write) 472689 472689 0 0.0
.bss 40609 40609 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 371824 371824 0 0.0
.dynamic 560 560 0 0.0
.got 55328 55328 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 493604 493604 0 0.0
.text 8224324 8224324 0 0.0
door-lock-app debug (read only) 2004473 2004473 0 0.0
(read/write) 116832 116832 0 0.0
.bss 47584 47584 0 0.0
.data 992 992 0 0.0
.data.rel.ro 62856 62856 0 0.0
.dynamic 592 592 0 0.0
.got 4120 4120 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 181180 181180 0 0.0
.text 1673634 1673634 0 0.0
lighting-app debug+rpc (read only) 2135753 2135753 0 0.0
(read/write) 122120 122120 0 0.0
.bss 48352 48352 0 0.0
.data 1472 1472 0 0.0
.data.rel.ro 66792 66792 0 0.0
.dynamic 608 608 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 173436 173436 0 0.0
.text 1805634 1805634 0 0.0
ota-provider-app debug (read only) 1938833 1938833 0 0.0
(read/write) 112624 112624 0 0.0
.bss 47488 47488 0 0.0
.data 1288 1288 0 0.0
.data.rel.ro 58200 58200 0 0.0
.dynamic 608 608 0 0.0
.got 4376 4376 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 166571 166571 0 0.0
.text 1620498 1620498 0 0.0
ota-requestor-app debug (read only) 1969001 1969001 0 0.0
(read/write) 115592 115592 0 0.0
.bss 48480 48480 0 0.0
.data 1416 1416 0 0.0
.data.rel.ro 60264 60264 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 162980 162980 0 0.0
.text 1654034 1654034 0 0.0
shell debug (read only) 2426545 2426545 0 0.0
(read/write) 147208 147208 0 0.0
.bss 67240 67240 0 0.0
.data 784 784 0 0.0
.data.rel.ro 73472 73472 0 0.0
.dynamic 592 592 0 0.0
.got 4152 4152 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 209426 209426 0 0.0
.text 2060418 2060418 0 0.0
thermostat-no-ble arm64 (read only) 2224356 2224356 0 0.0
(read/write) 146385 146385 0 0.0
.bss 62289 62289 0 0.0
.data 1024 1024 0 0.0
.data.rel.ro 75728 75728 0 0.0
.dynamic 560 560 0 0.0
.got 4352 4352 0 0.0
.init 24 24 0 0.0
.init_array 360 360 0 0.0
.rodata 138452 138452 0 0.0
.text 1865840 1865840 0 0.0
tv-app debug (read only) 2677465 2677465 0 0.0
(read/write) 247712 247712 0 0.0
.bss 164384 164384 0 0.0
.data 3104 3104 0 0.0
.data.rel.ro 74168 74168 0 0.0
.dynamic 592 592 0 0.0
.got 4552 4552 0 0.0
.init 27 27 0 0.0
.init_array 888 888 0 0.0
.rodata 207285 207285 0 0.0
.text 2295330 2295330 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2353452 2353452 0 0.0
.bss 184652 184652 0 0.0
.data 5752 5752 0 0.0
.text 1316052 1316052 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1155907 1155907 0 0.0
bss 146716 146716 0 0.0
rodata 145956 145956 0 0.0
text 788072 788072 0 0.0
p6 all-clusters-app default (read/write) 2492960 2492960 0 0.0
.bss 118072 118072 0 0.0
.data 2632 2632 0 0.0
.text 1451224 1451224 0 0.0
light-app default (read/write) 2396360 2396360 0 0.0
.bss 111544 111544 0 0.0
.data 2488 2488 0 0.0
.text 1354624 1354624 0 0.0
lock-app default (read/write) 2359896 2359896 0 0.0
.bss 111288 111288 0 0.0
.data 2448 2448 0 0.0
.text 1318160 1318160 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 895806 895806 0 0.0
bss 87424 87424 0 0.0
noinit 37160 37160 0 0.0
text 633382 633382 0 0.0

@andy31415 andy31415 merged commit 031fe2b into project-chip:master Mar 21, 2022
andrei-menzopol pushed a commit to andrei-menzopol/connectedhomeip that referenced this pull request Apr 14, 2022
@andy31415 @andrei-menzopol
Fix header dependency in CHIPCert (project-chip#16488)
3fac26c 
* Add header dependency since CHIPCert uses the generated header

* Fix typo

* Correct the path for compilation

* Move dependency into tests: they include FabricTable and ChipCert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

Assignees
No one assigned
Labels
hotfix urgent fix needed, can bypass review lib review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy31415 @Damian-Nordic