-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Linux example discriminators to default to 3840 #16477
Merged
tcarmelveilleux
merged 2 commits into
project-chip:master
from
tcarmelveilleux:fix-3840-discriminator
Mar 20, 2022
Merged
Fix Linux example discriminators to default to 3840 #16477
tcarmelveilleux
merged 2 commits into
project-chip:master
from
tcarmelveilleux:fix-3840-discriminator
Mar 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previous change lost the "default" discriminator people were using for a long time (3840) from when all-clusters-app is run without specifying the discriminator argument. - All users should always specify a non-default discriminator, but bringing back the "default" temporarily to avoid issues in test procedures. - Cert tests and proper usage of testing scripts always explicitly set discriminator, so the issue does not arise in CI Testing done: - Running all-clusters-app with no args uses 3840 - Cert tests pass
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
March 19, 2022 13:26
pullapprove
bot
requested review from
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
March 19, 2022 13:26
PR #16477: Size comparison from a3390fd to 14ed213 Increases (1 build for linux)
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Mar 19, 2022
bzbarsky-apple
approved these changes
Mar 20, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
* Fix Linux example discriminators to default to 3840 - Previous change lost the "default" discriminator people were using for a long time (3840) from when all-clusters-app is run without specifying the discriminator argument. - All users should always specify a non-default discriminator, but bringing back the "default" temporarily to avoid issues in test procedures. - Cert tests and proper usage of testing scripts always explicitly set discriminator, so the issue does not arise in CI Testing done: - Running all-clusters-app with no args uses 3840 - Cert tests pass * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
were using for a long time (3840) from when all-clusters-app
is run without specifying the discriminator argument.
but bringing back the "default" temporarily to avoid
issues in test procedures.
set discriminator, so the issue does not arise in CI
Change overview
Testing