Add a helper class for opening commissioning windows. #16474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda and
mrjerryjohns
bzbarsky-apple
force-pushed
the
commissioning-window-opener
branch
from
e86c4b0 to
bb6de8d
Compare
|
PR #16474: Size comparison from ae63451 to bb6de8d Increases above 0.2%:
Increases (2 builds for linux)
Decreases (1 build for linux)
Full report (25 builds for cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
There's a bunch of state involved in this, and trying to hang it all off the controller leads to too many complications, ranging from the inability to be opening more than one commissioning window at a time to crashes. Fixes project-chip#16209
bzbarsky-apple
force-pushed
the
commissioning-window-opener
branch
from
bb6de8d to
46f17b0
Compare
|
PR #16474: Size comparison from a3390fd to 46f17b0 Increases (1 build for linux)
Full report (18 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
reviewed
Mar 21, 2022
bzbarsky-apple
force-pushed
the
commissioning-window-opener
branch
from
3fcb7b5 to
754051c
Compare
|
PR #16474: Size comparison from 2e658fb to 754051c Increases above 0.2%:
Increases (2 builds for linux)
Decreases (1 build for linux)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Mar 22, 2022
|
Is there a way to add a test for the 'dangling OperationalDeviceProxy' case (i.e try to FindOrEstablishSession, and have that fail, and then ensure |
The point is,
|
mrjerryjohns
approved these changes
Mar 23, 2022
jmartinez-silabs
approved these changes
Mar 24, 2022
bzbarsky-apple
force-pushed
the
commissioning-window-opener
branch
from
29a4543 to
a0ddff3
Compare
bzbarsky-apple
force-pushed
the
commissioning-window-opener
branch
from
a0ddff3 to
01fa52c
Compare
|
PR #16474: Size comparison from 20f8b95 to 01fa52c Increases above 0.2%:
Increases (2 builds for linux)
Decreases (1 build for linux)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
rochaferraz
pushed a commit
to rochaferraz/connectedhomeip
that referenced
this pull request
Mar 31, 2022
…6474) * Add a helper class for opening commissioning windows. There's a bunch of state involved in this, and trying to hang it all off the controller leads to too many complications, ranging from the inability to be opening more than one commissioning window at a time to crashes. Fixes project-chip#16209 * Address review comments. * Address review comments.
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
…6474) * Add a helper class for opening commissioning windows. There's a bunch of state involved in this, and trying to hang it all off the controller leads to too many complications, ranging from the inability to be opening more than one commissioning window at a time to crashes. Fixes project-chip#16209 * Address review comments. * Address review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bunch of state involved in this, and trying to hang it all
off the controller leads to too many complications, ranging from the
inability to be opening more than one commissioning window at a time
to crashes.
Fixes #16209
Problem
See above.
Change overview
Adds a helper class for doing the opening of commissioning windows. Uses it in Darwin, python, Android controllers and chip-tool.
Testing
Verified that I can open commissioning windows (basic and enhanced) from chip-tool and commission with the expected codes from the iOS CHIPTool app, and vice versa.